[PATCH v2] staging: android: ion: Align with parenthesis

Align two different lines of arguments with the parenthesis of their respected function definitions. Fix style warnings of matching alignment. Reported by checkpatch. Signed-off-by: John B. Wyatt IV --- v2: Change comment title and summary Suggested-by: Julia Lawall drivers/staging

Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Remove unused code

On Fri, 2020-04-03 at 01:50 +0200, Stefano Brivio wrote: > On Wed, 1 Apr 2020 19:17:06 -0700 > "John B. Wyatt IV" wrote: > > > Remove unused code surrounded by an #if 0 block. > > > > Code has not been altered since 2014 as reported by git b

[PATCH 1/2] staging: gasket: Fix 4 over 80 char warnings

Fix 4 over 80 char warnings by caching long enum values into local variables. All enums are only used once inside each function (and once inside the entire file). Reported by checkpatch. Signed-off-by: John B. Wyatt IV --- drivers/staging/gasket/apex_driver.c | 13 + 1 file

[PATCH 0/2] staging: gasket: Fix style issues in apex_driver.c

Cache long enums as local variables to fit under 80 characters. Fix a comment character limit warning. The goal is to comply with the kernel style guide. All style issues were identified by checkpatch. John B. Wyatt IV (2): staging: gasket: Fix 4 over 80 char warnings staging: gasket: Fix

[PATCH 2/2] staging: gasket: Fix comment 75 character limit warning

Fix 75 character limit warning in comment reported by checkpatch. Reported by checkpatch. Signed-off-by: John B. Wyatt IV --- drivers/staging/gasket/apex_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging

[PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment

Fix 2 parenthesis alignment issues. Reported by checkpatch. Signed-off-by: John B. Wyatt IV --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c

[PATCH] staging: emxx_udc: Remove unused code

Remove unused code surrounded by an #if 0 block. Code has not been altered since 2014 as reported by git blame. Reported by checkpatch. Signed-off-by: John B. Wyatt IV --- drivers/staging/emxx_udc/emxx_udc.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/emxx_udc

[PATCH] staging: android: ion: Fix parenthesis alignment

Fix 2 parenthesis alignment issues. Reported by checkpatch. Signed-off-by: John B. Wyatt IV --- drivers/staging/android/ion/ion_page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion

[PATCH] staging: android: ion: Fix parenthesis alignment

Fix 2 parenthesis alignment issues. Reported by checkpatch. Signed-off-by: John B. Wyatt IV --- drivers/staging/android/ion/ion_page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion

[PATCH v8] staging: vt6656: add error code handling to unused variable

-by: John B. Wyatt IV --- v8: Fix trailing space reported by checkpatch Fix alignment issue suggested by: Stefano Brivio v7: Move an if check. Suggested by Stefano Brivio v6: Forgot to add all the v5 code to commit. v5: Remove Suggested-by: Julia Lawall above seperator line. Remove

Re: [PATCH v7] staging: vt6656: add error code handling to unused variable

On Tue, 2020-03-31 at 00:42 +0200, Stefano Brivio wrote: > On Mon, 30 Mar 2020 15:37:18 -0700 > "John B. Wyatt IV" wrote: > > > Add error code handling to unused 'ret' variable that was never > > used. > > Return an error code from functions called within &

[PATCH v7] staging: vt6656: add error code handling to unused variable

-by: John B. Wyatt IV --- v7: Move an if check. Suggested by Stefano Brivio v6: Forgot to add all the v5 code to commit. v5: Remove Suggested-by: Julia Lawall above seperator line. Remove break; statement in switch block. break; removal checked by both gcc compile and checkpatch

Re: [PATCH v6] staging: vt6656: add error code handling to unused variable

On Tue, 2020-03-31 at 00:01 +0200, Stefano Brivio wrote: > On Mon, 30 Mar 2020 14:46:13 -0700 > "John B. Wyatt IV" wrote: > > > Add error code handling to unused 'ret' variable that was never > > used. > > Return an error code from functions called within &

Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range

On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote: > On Sun, 29 Mar 2020 12:37:18 +0200 (CEST) > Julia Lawall wrote: > > > On Sun, 29 Mar 2020, Soumyajit Deb wrote: > > > > > I had the same doubt the other day about the replacement of > > > udelay() with > > > usleep_range(). The

Re: [Outreachy kernel] [PATCH v5] staging: vt6656: add error code handling to unused variable

On Mon, 2020-03-30 at 23:06 +0200, Stefano Brivio wrote: > On Mon, 30 Mar 2020 11:45:17 -0700 > "John B. Wyatt IV" wrote: > > > Add error code handling to unused 'ret' variable that was never > > used. > > Return an error code from functions called within &

[PATCH v6] staging: vt6656: add error code handling to unused variable

-by: John B. Wyatt IV --- v6: Forgot to add all the v5 code to commit. v5: Remove Suggested-by: Julia Lawall above seperator line. Remove break; statement in switch block. break; removal checked by both gcc compile and checkpatch. Suggested by Stefano Brivio v4: Move Suggested

[PATCH v5] staging: vt6656: add error code handling to unused variable

-by: John B. Wyatt IV --- v5: Remove Suggested-by: Julia Lawall above seperator line. Remove break; statement in switch block. break; removal checked by both gcc compile and checkpatch. Suggested by Stefano Brivio v4: Move Suggested-by: Julia Lawall above seperator line. Add Reviewed

[PATCH v4] staging: vt6656: add error code handling to unused variable

Deslandes Signed-off-by: John B. Wyatt IV --- v4: Move Suggested-by: Julia Lawall above seperator line. Add Reviewed-by tag as requested by Quentin Deslandes. Suggested-by: Quentin Deslandes v3: Forgot to add v2 code changes to commit. v2: Replace goto statements with return. Remove

[PATCH] staging: fbtft: Replace udelay with preferred usleep_range

. Are the docs out of date, or, is this a checkpatch issue? Signed-off-by: John B. Wyatt IV --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c index ec97ad27

[PATCH v3] staging: vt6656: add error code handling to unused variable

Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Signed-off-by: John B. Wyatt IV --- v3: Forgot

[PATCH v2] staging: vt6656: add error code handling to unused variable

Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Signed-off-by: John B. Wyatt IV --- v2: Replace

[PATCH] staging: vt6656: add error code handling to unused variable

Add error code handling to unused 'ret' variable that was never used. Return an error code from functions called within vnt_radio_power_on. Issue reported by coccinelle (coccicheck). Suggested-by: Quentin Deslandes Suggested-by: Stefano Brivio Signed-off-by: John B. Wyatt IV --- drivers

[PATCH 0/2] staging: vt6656: change function from always returning 0 to void

Change vnt_radio_power_on from always returning 0 to void. The first patch in this series was originally submitted as a standalone patch. Greg Kroah-Hartman suggested more changes to be made into a patchset. John B. Wyatt IV (2): staging: vt6656: remove unneeded variable: ret staging

[PATCH 1/2] staging: vt6656: remove unneeded variable: ret

Remove unneeded variable ret; replace with 0 for the return value. Update function documentation (comment) on the return status as suggested by Julia Lawall . Issue reported by coccinelle (coccicheck). Signed-off-by: John B. Wyatt IV --- drivers/staging/vt6656/card.c | 6 ++ 1 file

[PATCH 2/2] staging: vt6656: change unused int return value to void

Change unused int function return value to void from previous patch. Update function documentation to remove mention of return value. Remove if statement check of the only usage of function in the kernel. Replace with calling the function. Suggested-by: Greg Kroah-Hartman Signed-off-by: John B

[PATCH] staging: vt6656: remove unneeded variable: ret

Remove unneeded variable ret; replace with 0 for the return value. Update function documentation (comment) on the return status as suggested by Julia Lawall . Issue reported by coccinelle (coccicheck). Signed-off-by: John B. Wyatt IV --- drivers/staging/vt6656/card.c | 6 ++ 1 file