[PATCH] staging: lustre: fix sparse warnings for undeclared symbols

t be static? Signed-off-by: John Church --- drivers/staging/lustre/lnet/lnet/router.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c index 995f509..87e0c3b 100644 --- a/drivers/stag

Re: [PATCH] staging: lustre: fix sparse warnings for undeclared symbols

On Mon, Jun 02, 2014 at 03:19:18PM +0300, Dan Carpenter wrote: > > Why not just make them static? They don't seem to be used outside of > that file. What am I missing? > Given a 50/50 choice I based my decision on the surrounding functions which were mostly defined in the header file. I shou

[PATCH] staging: lustre: fix sparse warnings for undeclared symbols

t be static? Signed-off-by: John Church --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b/drivers/staging/lustre/include/linux/lnet/lib-lnet.h index 856fcfa..143bb3a 100644 -

Re: [PATCH] staging : android: Fixes a coding style issue in timed_gpio.c

ou are using? I'm doing the Eudyptula Challenge. Task 10 is to fix a coding style issue and submit it the relevant maintainers. > > On Wed, May 07, 2014 at 01:30:02PM +0100, John Church wrote: > > This patch fixes a coding style issue for a line that was over 80 > > char

[PATCH] staging : android: Fixes a coding style issue in timed_gpio.c

This patch fixes a coding style issue for a line that was over 80 characters long. Signed-off-by: John Church --- drivers/staging/android/timed_gpio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android

[PATCH] Staging: android: fix coding style issue in timed_gpio.c

This patch fixes a coding style issue. It modifies a single line that was over 80 characters long. Thanks, John Signed-off-by: John Church --- linux-next/drivers/staging/android/timed_gpio.c.orig2014-05-07 00:20:50.429090320 +0100 +++ linux-next/drivers/staging/android/timed_gpio.c

[PATCH] Staging: android: fix coding style issue for Eudyptula Challenge in timed_gpio.c

Signed-off-by: John Church --- linux-next/drivers/staging/android/timed_gpio.c.orig2014-05-07 00:20:50.429090320 +0100 +++ linux-next/drivers/staging/android/timed_gpio.c 2014-05-07 00:22:09.204795052 +0100 @@ -92,7 +92,7 @@ static int timed_gpio_probe(struct platf