Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
Welp, looks like I didn't test debug configs properly. Allow me 1-2 days to work on fixing it for v2. Thanks in advance. On Thu, Sep 19, 2019 at 6:31 AM kbuild test robot wrote: > > Hi Park, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] >

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
On Thu, Sep 19, 2019 at 5:26 AM Greg KH wrote: > That differs from the original exfat code, so something is odd here. I > need some sort of clarification from Samsung as to when they changed the > license in order to be able to relicense these files. We should probably ask Valdis on what

Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0

2019-09-18 Thread Ju Hyung Park
Hi Greg, On Thu, Sep 19, 2019 at 5:12 AM Greg KH wrote: > That's a lot of rewriting :( > > How about at least keeping the file names the same to make it easier to > see what happened here? > > Then send a follow-on patch that just does the rename? That's still not quite useful tbh, lemme bring

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Ju Hyung Park
On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter wrote: > Use Kconfig. Not just that. There are a lot of non-static functions that's not marked ex/sdfat-specific. (which we would have to clean it up eventually) Even with sdFAT base, there are some non-static functions named as exfat. Figuring out

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Ju Hyung Park
Hi Dan, On Wed, Sep 18, 2019 at 6:27 PM Dan Carpenter wrote: > Put it in drivers/staging/sdfat/. It'll conflict with the current exfat staging drivers. And moreover, I don't think it makes sense to use sdfat naming in mainline. Samsung uses it since it handles all fat filesystems. >From what I

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-18 Thread Ju Hyung Park
On Wed, Sep 18, 2019 at 5:33 PM Greg KH wrote: > He did? I do not see a patch anywhere, what is the message-id of it? I'm just repeating myself at this point, but again, I'm more than willing to work on a patch. I just want to make it clear on how should I. > He took the "best known at the

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-17 Thread Ju Hyung Park
On Tue, Sep 17, 2019 at 2:47 PM Greg KH wrote: > It's the fact that it actually was in a form that could be merged, no > one has done that with the sdfat code :) Well, I'm more than happy to help if you guys are happy with merging the new base. > What fixes? That's what I'm asking here. I

Re: [PATCH] staging: exfat: add exfat filesystem code to

2019-09-15 Thread Ju Hyung Park
Hi Greg, On Sun, Sep 15, 2019 at 10:54 PM Greg KH wrote: > Note, this just showed up publically on August 12, where were you with > all of this new code before then? :) My sdFAT port, exfat-nofuse and the one on the staging tree, were all made by Samsung. And unless you guys had a chance to