Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Juergen Beisert
.                              | Juergen Beisert             | Linux Solutions for Science and Industry      | Phone: +49-5121-206917-5128 | Peiner Str. 6-8, 31137 Hildesheim, Germany    | Fax:   +49-5121-206917- | Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2014-02-24 Thread Juergen Beisert
Hi Dan, On Monday 24 February 2014 14:33:16 Dan Carpenter wrote: On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote: While I don't have much experience with the TS part of the code but I can investigate if you don't have any idea. can you please test the following patch

[PATCH] staging/iio/adc/MXS/LRADC: fix touchscreen statemachine

2014-02-24 Thread Juergen Beisert
-by: Juergen Beisert j...@pengutronix.de diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c index 7fc66a6..514844e 100644 --- a/drivers/staging/iio/adc/mxs-lradc.c +++ b/drivers/staging/iio/adc/mxs-lradc.c @@ -757,6 +757,7 @@ static void mxs_lradc_finish_touch_event

[PATCH 3/9] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits

2013-09-23 Thread Juergen Beisert
In order to support i.MX23 and i.MX28 within one driver we need to separate the register definitions which differ in both SoC variants. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux-in...@vger.kernel.org CC: de...@driverdev.osuosl.org CC

[PATCH 2/9] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC

2013-09-23 Thread Juergen Beisert
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both SoC variants in order to make the touchscreen work on i.MX23 Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux-in...@vger.kernel.org CC: de...@driverdev.osuosl.org CC

[PATCH 9/9] Staging/iio: add TODO reminder

2013-09-23 Thread Juergen Beisert
Some things have still to be done to the LRADC driver. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux-in...@vger.kernel.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC

[PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-23 Thread Juergen Beisert
The following series replaces the current busy loop touchscreen implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation. Since i.MX23 and i.MX28 silicon differs, the existing implementation can be used for the i.MX28 SoC only. The first patch adds proper clock handling.

[PATCH 7/9] Staging/iio/adc/touchscreen/MXS: remove old touchscreen detection implementation

2013-09-23 Thread Juergen Beisert
Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux-in...@vger.kernel.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc

[PATCH 6/9] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-23 Thread Juergen Beisert
-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux-in...@vger.kernel.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk CC: Dmitry Torokhov dmitry.torok

[PATCH 5/9] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC touchscreen driver

2013-09-23 Thread Juergen Beisert
Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Note: support for the remaining LRADC channels is not tested on an i.MX23 yet. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux

[PATCH 8/9] Staging/iio/adc/touchscreen/MXS: provide devicetree adaption

2013-09-23 Thread Juergen Beisert
This is an RFC for the new touchscreen properties. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux-in...@vger.kernel.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan

[PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-23 Thread Juergen Beisert
The delay units inside the LRADC depend on the presence of a 2 kHz clock. This change enables the clock to be able to use the delay unit for the touchscreen part of the driver. Signed-off-by: Juergen Beisert j...@pengutronix.de --- arch/arm/boot/dts/imx23.dtsi| 1 + arch/arm/boot/dts

[PATCH 4/9] Staging/iio/adc/touchscreen/MXS: simplify register access

2013-09-23 Thread Juergen Beisert
Replace the individual register access by a few shared access function to make the code easier to read and in order to add the i.MX23 SoC in the next step. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: linux-in...@vger.kernel.org CC: de

[PATCH 6/7] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation

2013-09-19 Thread Juergen Beisert
Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 163

[PATCH 2/7] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits

2013-09-19 Thread Juergen Beisert
In order to support i.MX23 and i.MX28 within one driver we need to separate the register definitions which differ in both SoC variants. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC

[PATCH 5/7] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-19 Thread Juergen Beisert
-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 532

[PATCH 3/7] Staging/iio/adc/touchscreen/MXS: simplify register access

2013-09-19 Thread Juergen Beisert
Replace the individual register access by a few shared access function to make the code easier to read and in order to add the i.MX23 SoC in the next step. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut

[PATCH 7/7] Staging/iio/adc/touchscreen/MXS: provide devicetree adaption

2013-09-19 Thread Juergen Beisert
This is an RFC for the new touchscreen properties. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk CC

[PATCHv5] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-19 Thread Juergen Beisert
The following series replaces the current busy loop touchscreen implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation. Since i.MX23 and i.MX28 silicon differs, the existing implementation can be used for the i.MX28 SoC only. So, the first two patches of this series

[PATCH 1/6] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC

2013-09-11 Thread Juergen Beisert
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both SoC variants in order to make the touchscreen work on i.MX23 Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC

[PATCH 4/6] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC touchscreen driver

2013-09-11 Thread Juergen Beisert
Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least for the 4 wire touchscreen. Note: support for the remaining LRADC channels is not tested on an i.MX23 yet. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de

[RFCv4] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-11 Thread Juergen Beisert
The following series replaces the current busy loop touchscreen implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation. Since i.MX23 and i.Mx28 silicon differs, the existing implementation can be used for the i.MX28 SoC only. So, the first two patches of this series

[PATCH 6/6] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation

2013-09-11 Thread Juergen Beisert
Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 165

[PATCH 5/5] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation

2013-09-10 Thread Juergen Beisert
Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 165

[PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits

2013-09-10 Thread Juergen Beisert
In order to support i.MX23 and i.MX28 within one driver we need to separate the register definitions which differ in both SoC variants. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC

[RFCv3] staging/iio/adc: change the MXS touchscreen driver implementation

2013-09-10 Thread Juergen Beisert
The following series replaces the current busy loop touchscreen implementation for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation. Since i.MX23 and i.Mx28 silicon differs, the existing implementation can be used for the i.MX28 SoC only. So, the first two patches of this series

[PATCH 1/5] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC

2013-09-10 Thread Juergen Beisert
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both SoC variants in order to make the touchscreen work on i.MX23 Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC

[PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-10 Thread Juergen Beisert
-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 531

[PATCH 1/5] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC

2013-09-06 Thread Juergen Beisert
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both SoC variants in order to make the touchscreen work on i.MX23 Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC

[PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits

2013-09-06 Thread Juergen Beisert
In order to support i.MX23 and i.MX28 within one driver we need to separate the register definitions which differ in both SoC variants. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC

[PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-06 Thread Juergen Beisert
-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 548

[PATCH 5/5] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation

2013-09-06 Thread Juergen Beisert
Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC: Fabio Estevam fabio.este...@freescale.com CC: Jonathan Cameron ji...@cam.ac.uk --- drivers/staging/iio/adc/mxs-lradc.c | 165

[PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits

2013-09-04 Thread Juergen Beisert
In order to support i.MX23 and i.MX28 within one driver we need to separate the register definitions which differ in both SoC variants. Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de CC