Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 08:54:43AM -0800, Joe Perches wrote: > On Mon, 2020-02-24 at 22:17 +0530, Kaaira Gupta wrote: > > On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote: > > > On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote: > > > > Simpl

Re: [greybus-dev] [PATCH] staging: greybus: match parenthesis alignment

2020-02-24 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 01:49:29PM +0200, Laurent Pinchart wrote: > Hi Kaaira, > > Thank you for the patch. > > On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote: > > Fix checkpatch.pl warning of alignment should match open parenthesis in > > audio_

Re: [PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote: > On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote: > > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > > instead of existing functions so that the debug and dump are > > emitted at the sam

[PATCH v2] staging: wfx: data_tx.c: match parentheses alignment

2020-02-24 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote: > On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote: > > Match next line with open parentheses by giving appropriate tabs. Changed the first word to caps. Will keep this in mind from now on. Thanks! > > Thi

[PATCH v4] staging: qlge: emit debug and dump at same level

2020-02-24 Thread Kaaira Gupta
Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() instead of existing functions so that the debug and dump are emitted at the same KERN_ Signed-off-by: Kaaira Gupta --- changes since v1: make code of ql_mpi_core_to_log() simpler. changes since v2: directly call the function

Re: [PATCH] staging: qlge: add braces around macro arguments

2020-02-23 Thread Kaaira Gupta
On Mon, Feb 24, 2020 at 02:32:25PM +0900, Benjamin Poirier wrote: > On 2020/02/22 01:26 +0530, Kaaira Gupta wrote: > > Fix checkpatch.pl warnings of adding braces around macro arguments to > > prevent precedence issues by adding braces in qlge_dbg.c > > > >

[PATCH] staging: wfx: match parentheses alignment

2020-02-23 Thread Kaaira Gupta
match next line with open parentheses by giving appropriate tabs. Signed-off-by: Kaaira Gupta --- drivers/staging/wfx/data_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 20f4740734f2

[PATCH] staging: exfat: remove sync_alloc_bitmap()

2020-02-23 Thread Kaaira Gupta
sync_alloc_bitmap() is not called anywhere, hence remove it from exfat_core.c and exfat.h Signed-off-by: Kaaira Gupta --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 12 2 files changed, 13 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH] staging: exfat: remove exfat_buf_sync()

2020-02-23 Thread Kaaira Gupta
exfat_buf_sync() is not called anywhere, hence remove it from exfat_cache.c and exfat.h Signed-off-by: Kaaira Gupta --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_cache.c | 19 --- 2 files changed, 20 deletions(-) diff --git a/drivers/staging/exfat

[PATCH v3] staging: qlge: emit debug and dump at same level

2020-02-23 Thread Kaaira Gupta
Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() instead of existing functions so that the debug and dump are emitted at the same KERN_ Signed-off-by: Kaaira Gupta --- changes since v1: make code of ql_mpi_core_to_log() simpler. changes since v2: directly call the function

[PATCH v2] staging: qlge: emit debug and dump at same level

2020-02-22 Thread Kaaira Gupta
such as nvec and vc04_services. Signed-off-by: Kaaira Gupta --- changes since v1: make code of ql_mpi_core_to_log() simpler. --- drivers/staging/qlge/qlge_dbg.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers

[PATCH] staging: qlge: add braces on all arms of if-else

2020-02-21 Thread Kaaira Gupta
fix all checkpatch.pl warnings of 'braces {} should be used on all arms of this statement' in the file qlge_ethtool.c by adding the braces. Signed-off-by: Kaaira Gupta --- drivers/staging/qlge/qlge_ethtool.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH] staging: qlge: add braces around macro arguments

2020-02-21 Thread Kaaira Gupta
Fix checkpatch.pl warnings of adding braces around macro arguments to prevent precedence issues by adding braces in qlge_dbg.c Signed-off-by: Kaaira Gupta --- drivers/staging/qlge/qlge_dbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge

[PATCH] staging: qlge: unify multi-line string

2020-02-21 Thread Kaaira Gupta
Fix checkpatch.pl warning of 'quoted string split across lines' in qlge_dbg.c by merging the strings in one line. Fixing this warning is necessary to ease grep-ing the source for printk. Signed-off-by: Kaaira Gupta --- drivers/staging/qlge/qlge_dbg.c | 20 ++-- 1 file changed

[PATCH] staging: octeon: match parentheses alignment

2020-02-20 Thread Kaaira Gupta
match the next line with open parentheses by giving appropriate tabs. Signed-off-by: Kaaira Gupta --- drivers/staging/octeon/octeon-stubs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h index

[PATCH] staging: octeon: add blank line after union

2020-02-20 Thread Kaaira Gupta
add a blank line after union declaration to fix checkpatch.pl warning Signed-off-by: Kaaira Gupta --- drivers/staging/octeon/octeon-stubs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h index d2bd379b1fd9

[PATCH] staging: octeon: add space around '+' and parentheses

2020-02-20 Thread Kaaira Gupta
Fix checkpatch.pl warnings of required spaces around '+' sign in multiple lines in octeon-stubs.h by adding spaces. Also add space before parentheses in the same file to fix checkpatch.pl warning. Signed-off-by: Kaaira Gupta --- drivers/staging/octeon/octeon-stubs.h | 34

[PATCH] staging: greybus: match parenthesis alignment

2020-02-19 Thread Kaaira Gupta
Fix checkpatch.pl warning of alignment should match open parenthesis in audio_codec.c Signed-off-by: Kaaira Gupta --- drivers/staging/greybus/audio_codec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging

Re: [PATCH] staging: comedi: change CamelCase to CAPS

2020-02-19 Thread Kaaira Gupta
On Wed, Feb 19, 2020 at 07:47:41PM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 19, 2020 at 11:16:46PM +0530, Kaaira Gupta wrote: > > fix checkpatch.pl check of 'Avoid CamelCase' by changing NI_CtrSource to > > NI_CTRSOURCE in all the files. Change it to CAPS becaus

[PATCH] staging: exfat: remove exfat_fat_sync()

2020-02-19 Thread Kaaira Gupta
exfat_fat_sync() is not called anywhere, hence remove it from exfat_cache.c and exfat.h Signed-off-by: Kaaira Gupta --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_cache.c | 19 --- 2 files changed, 20 deletions(-) diff --git a/drivers/staging/exfat

[PATCH] staging: bcm2835-camera: call function instead of macro

2020-02-18 Thread Kaaira Gupta
On Tue, Feb 18, 2020 at 09:37:11PM +0300, Dan Carpenter wrote: > On Tue, Feb 18, 2020 at 09:37:28PM +0530, Kaaira Gupta wrote: > > Fix checkpatch.pl warning of 'macro argument reuse' in bcm2835-camera.h > > by removing the macro and calling the function, written in macro in >

[PATCH] staging: bcm2835-camera: call function instead of macro

2020-02-18 Thread Kaaira Gupta
Fix checkpatch.pl warning of 'macro argument reuse' in bcm2835-camera.h by removing the macro and calling the function, written in macro in bcm2835-camera.h, directly in bcm2835-camera.c Signed-off-by: Kaaira Gupta --- .../bcm2835-camera/bcm2835-camera.c | 28

staging: board: disabled driver

2020-02-13 Thread Kaaira Gupta
I made some changes in board.h and other files under board to remove the MACRO using conditions. I did git log --oneline "file path" to get the logs, but turned out the driver was disabled. Hence on seeing it's KConfig file I found STAGING_BOARd and searched it in device drivers in menuconfig.

[PATCH v3] staging: gasket: unify multi-line string

2020-02-12 Thread Kaaira Gupta
Fix three checkpatch.pl warnings of 'quoted string split across lines' in gasket_core.c by merging the strings in one line. Though some strings are over 80 characters long, fixing this warning is necessary to ease grep-ing the source for printk. Signed-off-by: Kaaira Gupta --- drivers/staging

[PATCH v2] staging:gasket:gasket_core.c:unified quoted string split across lines in one line

2020-02-12 Thread Kaaira Gupta
On Tue, Feb 11, 2020 at 09:45:03PM +0100, Julia Lawall wrote: > On Wed, 12 Feb 2020, Kaaira Gupta wrote: > > > Whenever it tries to map a region, but the region has permissions, or it > > attempts to open gasket with tgid, or it releases device node the messages > > a

[PATCH] staging:gasket:gasket_core.c:unified quoted string split across lines in one line

2020-02-12 Thread Kaaira Gupta
for code based on the log messages. So, this patch fixes three warnings of 'quoted string split across lines' in gasket_core.c by merging the strings in one line. Signed-off-by: Kaaira Gupta --- drivers/staging/gasket/gasket_core.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions