[PATCH] staging: gasket: Add descriptions for module parameters

2018-07-08 Thread Kamal Heib
This patch add description for the module parameters and remove the task to do it from the TODO file. Signed-off-by: Kamal Heib --- drivers/staging/gasket/TODO | 1 - drivers/staging/gasket/apex_driver.c | 8 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a

[PATCH] staging: mt7621-eth: Use eth_hw_addr_random()

2018-06-20 Thread Kamal Heib
Use eth_hw_addr_random() to set a random dev_addr and update addr_assign_type. Fixes: e3cbf478f846 ('staging: mt7621-eth: add the drivers core files') Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[PATCH V3] staging: mt7621-eth: Fix memory leak in mtk_add_mac() error path

2018-06-19 Thread Kamal Heib
Fix memory leak in error path of mtk_add_mac() by make sure to free the allocated netdev. Fixes: e3cbf478f846 ('staging: mt7621-eth: add the drivers core files') Signed-off-by: Kamal Heib --- Changes from v2: No need to print error when allocation failed. Changes from v1:

Re: [PATCH V2] staging: mt7621-eth: Fix memory leak in mtk_add_mac() error path

2018-06-19 Thread Kamal Heib
On Mon, Jun 18, 2018 at 10:52:01AM +0200, Greg Kroah-Hartman wrote: > On Sat, Jun 16, 2018 at 01:01:27PM +0300, Kamal Heib wrote: > > Fix memory leak in error path of mtk_add_mac() by make sure to free > > the allocated netdev. > > > > Fixes: e3cbf478f846 ('stag

[PATCH V2] staging: mt7621-eth: Fix memory leak in mtk_add_mac() error path

2018-06-16 Thread Kamal Heib
Fix memory leak in error path of mtk_add_mac() by make sure to free the allocated netdev. Fixes: e3cbf478f846 ('staging: mt7621-eth: add the drivers core files') Signed-off-by: Kamal Heib --- Changes from v1: No need to free the hw_stats. drivers/staging/mt7621-eth/mtk_eth_

Re: [PATCH] staging: mt7621-eth: Fix memory leaks in mtk_add_mac() error path

2018-06-16 Thread Kamal Heib
On Sat, Jun 16, 2018 at 11:54:03AM +0300, Dan Carpenter wrote: > On Fri, Jun 15, 2018 at 01:53:03AM +0300, Kamal Heib wrote: > > @@ -2045,6 +2049,12 @@ static int mtk_add_mac(struct mtk_eth *eth, struct > > device_node *np) > >eth->netdev[id]->base

[PATCH] staging: mt7621-eth: Fix memory leaks in mtk_add_mac() error path

2018-06-14 Thread Kamal Heib
Fix memory leaks in error path of mtk_add_mac() by make sure to free the allocated resources. Fixes: e3cbf478f846 ('staging: mt7621-eth: add the drivers core files') Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 16 +--- 1 file changed, 13 insert

[PATCH] staging: mt7621-eth: Refactor RX ring resource allocation and cleanup

2018-05-18 Thread Kamal Heib
Simplify the code of allocate and cleanup RX ring resources by using helper functions, also make sure to free the allocated resources in cause of allocation failure. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 122 --- 1 file changed, 81

[PATCH] staging: mt7621-eth: Remove unused variable

2018-05-14 Thread Kamal Heib
Remove unused variable 'condition' which was set but not used. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk

[PATCH] staging: mt7621-eth: Refactor ethtool stats

2018-05-12 Thread Kamal Heib
This patch removes the ugly macro hack to make sure hw_stats and ethtool strings are consisten, instead define a new struct which will hold the stat string and his index within the hw_stats struct. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/ethtool.c | 49

[PATCH V2 3/3] staging: mt7621-eth: Fix quoted string split across lines

2018-05-09 Thread Kamal Heib
Quoted strings should not be split to help text grep in the source. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth

[PATCH V2 2/3] staging: mt7621-eth: Fix line over 80 characters

2018-05-09 Thread Kamal Heib
This change fixes all the lines that get over 80 characters. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/ethtool.c| 3 ++- drivers/staging/mt7621-eth/gsw_mt7621.c | 3 ++- drivers/staging/mt7621-eth/mdio.c | 3 ++- drivers/staging/mt7621-eth/soc_mt7621.c | 6 -- 4

[PATCH V2 0/3] staging: Cleanup some checkpatch issue

2018-05-09 Thread Kamal Heib
This patch set fixes multiple issues reported by checkpatch within the mt7621-eth driver. Changes from v1: - [2] move the mdiobus_get_phy() to new line to make the code more clean. - [3] make sure that string is on a line by itself. Kamal Heib (3): staging: mt7621-eth: Prefer unsigned int to

[PATCH V2 1/3] staging: mt7621-eth: Prefer unsigned int to bare use of unsigned

2018-05-09 Thread Kamal Heib
This commit replaces all the unsigned definitions in favour of 'unsigned int' which is preferred. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/gsw_mt7620.h | 4 ++-- drivers/staging/mt7621-eth/gsw_mt7621.c | 4 ++-- drivers/staging/mt7621-eth/mtk_eth_soc.c | 4 ++-

[PATCH 1/3] staging: mt7621-eth: Prefer unsigned int to bare use of unsigned

2018-05-08 Thread Kamal Heib
This commit replaces all the unsigned definitions in favour of 'unsigned int' which is preferred. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/gsw_mt7620.h | 4 ++-- drivers/staging/mt7621-eth/gsw_mt7621.c | 4 ++-- drivers/staging/mt7621-eth/mtk_eth_soc.c | 4 ++-

[PATCH 0/3] staging: Cleanup some checkpatch issue

2018-05-08 Thread Kamal Heib
This patch set fixes multiple issues reported by checkpatch within the mt7621-eth driver. Kamal Heib (3): staging: mt7621-eth: Prefer unsigned int to bare use of unsigned staging: mt7621-eth: Fix line over 80 characters staging: mt7621-eth: Fix quoted string split across lines drivers

[PATCH 2/3] staging: mt7621-eth: Fix line over 80 characters

2018-05-08 Thread Kamal Heib
This change fixes all the lines that get over 80 characters. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/ethtool.c| 3 ++- drivers/staging/mt7621-eth/gsw_mt7621.c | 3 ++- drivers/staging/mt7621-eth/mdio.c | 3 ++- drivers/staging/mt7621-eth/soc_mt7621.c | 6 -- 4

[PATCH 3/3] staging: mt7621-eth: Fix quoted string split across lines

2018-05-08 Thread Kamal Heib
Quoted strings should not be split to help text grep in the source. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth

[PATH V2 0/4] Few fixes for the mt7621-eth driver

2018-05-07 Thread Kamal Heib
This patches fixes an compilation error and cleanup few errors reported by checkpatch.pl script. Cc: NeilBrown Cc: Greg Kroah-Hartman Changes from v1: - patch1: Change phy_ring_{head/tail} to be dma_addr_t. - patch4: Fix aliment based on Neil feedback. Kamal Heib (4): staging: mt7621-eth

[PATH V2 1/4] staging: mt7621-eth: Fix compilation error

2018-05-07 Thread Kamal Heib
Fix the following comilation error by making sure that "phy_ring_head" is defined as "dma_addr_t" and change "phy_ring_tail" to match it as both should be "dma_addr_t". error: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type

[PATH V2 4/4] staging: mt7621-eth: Alignment should match open parenthesis

2018-05-07 Thread Kamal Heib
Fix alignment issues reported by checkpatch.pl. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth

[PATH V2 2/4] staging: mt7621-eth: Remove unnecessary blank lines

2018-05-07 Thread Kamal Heib
Remove un-necessary blank lines to solve errors found by checkpatch.pl. Signed-off-by: Kamal Heib Reviewed-by: NeilBrown --- drivers/staging/mt7621-eth/ethtool.c| 1 - drivers/staging/mt7621-eth/gsw_mt7621.c | 2 -- drivers/staging/mt7621-eth/soc_mt7621.c | 1 - 3 files changed, 4

[PATH V2 3/4] staging: mt7621-eth: Add missing blank lines after declarations

2018-05-07 Thread Kamal Heib
Add missing blank lines after declarations to solve checkpatch.pl errors. Signed-off-by: Kamal Heib Reviewed-by: NeilBrown --- drivers/staging/mt7621-eth/gsw_mt7621.c | 1 + drivers/staging/mt7621-eth/mdio.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/staging/mt7621

[PATCH 0/4] staging: Few fixes for the mt7621-eth driver

2018-05-06 Thread Kamal Heib
This patches fixes an compilation error and cleanup few errors reported by checkpatch.pl script. Cc: NeilBrown Cc: Greg Kroah-Hartman Kamal Heib (4): staging: mt7621-eth: Fix compilation error staging: mt7621-eth: Remove unnecessary blank lines staging: mt7621-eth: Add missing blank

[PATCH 1/4] staging: mt7621-eth: Fix compilation error

2018-05-06 Thread Kamal Heib
Fix the following compilation error: error: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-eth

[PATCH 2/4] staging: mt7621-eth: Remove unnecessary blank lines

2018-05-06 Thread Kamal Heib
Remove un-necessary blank lines to solve errors found by checkpatch.pl. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/ethtool.c| 1 - drivers/staging/mt7621-eth/gsw_mt7621.c | 2 -- drivers/staging/mt7621-eth/soc_mt7621.c | 1 - 3 files changed, 4 deletions(-) diff --git a

[PATCH 3/4] staging: mt7621-eth: Add missing blank lines after declarations

2018-05-06 Thread Kamal Heib
Add missing blank lines after declarations to solve checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/gsw_mt7621.c | 1 + drivers/staging/mt7621-eth/mdio.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/staging/mt7621-eth/gsw_mt7621.c b

[PATCH 4/4] staging: mt7621-eth: Alignment should match open parenthesis

2018-05-06 Thread Kamal Heib
Fix alignment issues reported by checkpatch.pl. Signed-off-by: Kamal Heib --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth

[PATCH] staging: ccree: Fix missing blank line after declaration

2018-01-24 Thread Kamal Heib
Fix the following warning found by checkpatch.pl WARNING: Missing a blank line after declarations + struct cc_cipher_handle *blkcipher_handle = drvdata->blkcipher_handle; + if (blkcipher_handle) { Signed-off-by: Kamal Heib --- drivers/staging/ccree/cc_cipher.c | 1 + 1 file chan

[PATCH v3 5/8] staging: greybus: audio_codec.c: Logical continuations should be on the previous line

2018-01-17 Thread Kamal Heib
Fix the following error found by checkpatch.pl: CHECK: Logical continuations should be on the previous line Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b

[PATCH v3 7/8] staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t'

2018-01-17 Thread Kamal Heib
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/audi

[PATCH v3 1/8] staging: greybus: authentication.c: Fix alignment should match open parenthesis

2018-01-17 Thread Kamal Heib
Fix the following error found by checkpatch.pl: CHECK: Alignment should match open parenthesis +static int cap_ioctl(struct gb_cap *cap, unsigned int cmd, +void __user *buf) Signed-off-by: Kamal Heib --- drivers/staging/greybus/authentication.c | 2 +- 1 file changed, 1

[PATCH v3 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

2018-01-17 Thread Kamal Heib
Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/aud

[PATCH v3 6/8] staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t'

2018-01-17 Thread Kamal Heib
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.

[PATCH v3 0/8] staging: greybus: Fix few issues reported by checkpatch

2018-01-17 Thread Kamal Heib
. - Add greybus-dev mailing list. Kamal Heib (8): staging: greybus: authentication.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c: Cleanup blank lines staging: greybus

[PATCH v3 4/8] staging: greybus: audio_codec.c: Space required around ':'

2018-01-17 Thread Kamal Heib
Space is required when using the question mark operator around ':' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_cod

[PATCH v3 3/8] staging: greybus: audio_codec.c: Cleanup blank lines

2018-01-17 Thread Kamal Heib
Remove the blank lines. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index c4b6584eb1be..98ddb7e5b78b 100644 --- a/drivers/staging/greybus

[PATCH v3 8/8] staging: greybus: audio_codec.h Fix alignment should match open parenthesis

2018-01-17 Thread Kamal Heib
Fix "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_cod

Re: [PATCH v2 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

2018-01-17 Thread kamal heib
On Wed, Jan 17, 2018 at 3:42 PM, Dan Carpenter wrote: > On Wed, Jan 17, 2018 at 03:29:33PM +0200, Kamal Heib wrote: >> Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. >> >> Signed-off-by: Kamal Heib >> --- >>

[PATCH v2 6/8] staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t'

2018-01-17 Thread Kamal Heib
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.

[PATCH v2 7/8] staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t'

2018-01-17 Thread Kamal Heib
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/audi

[PATCH v2 4/8] staging: greybus: audio_codec.c: Space required around ':'

2018-01-17 Thread Kamal Heib
Space is required when using the question mark operator around ':' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_cod

[PATCH v2 1/8] staging: greybus: authentication.c: Fix alignment should match open parenthesis

2018-01-17 Thread Kamal Heib
Fix the following error found by checkpatch.pl: CHECK: Alignment should match open parenthesis +static int cap_ioctl(struct gb_cap *cap, unsigned int cmd, +void __user *buf) Signed-off-by: Kamal Heib --- drivers/staging/greybus/authentication.c | 2 +- 1 file changed, 1

[PATCH v2 8/8] staging: greybus: audio_codec.h Fix alignment should match open parenthesis

2018-01-17 Thread Kamal Heib
Fix "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_cod

[PATCH v2 5/8] staging: greybus: audio_codec.c: Logical continuations should be on the previous line

2018-01-17 Thread Kamal Heib
Fix the following error found by checkpatch.pl: CHECK: Logical continuations should be on the previous line Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b

[PATCH v2 3/8] staging: greybus: audio_codec.c: Cleanup blank lines

2018-01-17 Thread Kamal Heib
Remove the blank lines. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 0dae31f39a2b..3f9088607ea7 100644 --- a/drivers/staging/greybus

[PATCH v2 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

2018-01-17 Thread Kamal Heib
Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/stagi

[PATCH v2 0/8] staging: greybus: Fix few issues reported by checkpatch

2018-01-17 Thread Kamal Heib
This patch set include multiple fixes for the issues reported by checkpatch.pl Cc: greybus-...@lists.linaro.org Cc: Viresh Kumar Cc: Vaibhav Agarwal Cc: Greg Kroah-Hartman Changes from v1: - Rebase the changes on top staging-next. - Add greybus-dev mailing list. Kamal Heib (8): staging

[PATCH 7/8] staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t'

2017-12-22 Thread Kamal Heib
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Cc: Vaibhav Agarwal Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH 8/8] staging: greybus: audio_codec.h Fix alignment should match open parenthesis

2017-12-22 Thread Kamal Heib
Fix "Alignment should match open parenthesis" checkpatch.pl errors. Cc: Vaibhav Agarwal Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/stagi

[PATCH 3/8] staging: greybus: audio_codec.c: Cleanup blank lines

2017-12-22 Thread Kamal Heib
Remove the blank lines. Cc: Vaibhav Agarwal Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 0dae31f39a2b..3f9088607ea7 100644 --- a

[PATCH 6/8] staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t'

2017-12-22 Thread Kamal Heib
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Cc: Vaibhav Agarwal Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH 4/8] staging: greybus: audio_codec.c: Space required around ':'

2017-12-22 Thread Kamal Heib
Space is required when using the question mark operator around ':' Cc: Vaibhav Agarwal Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/stagi

[PATCH 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

2017-12-22 Thread Kamal Heib
Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. Cc: Vaibhav Agarwal Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c

[PATCH 5/8] staging: greybus: audio_codec.c: Logical continuations should be on the previous line

2017-12-22 Thread Kamal Heib
Fix the following error found by checkpatch.pl: CHECK: Logical continuations should be on the previous line Cc: Vaibhav Agarwal Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus

[PATCH 1/8] staging: greybus: authentication.c: Fix alignment should match open parenthesis

2017-12-22 Thread Kamal Heib
Fix the following error found by checkpatch.pl: CHECK: Alignment should match open parenthesis +static int cap_ioctl(struct gb_cap *cap, unsigned int cmd, +void __user *buf) Cc: Viresh Kumar Signed-off-by: Kamal Heib --- drivers/staging/greybus/authentication.c | 2

[PATCH 0/8] staging: greybus: Fix few issues reported by

2017-12-22 Thread Kamal Heib
This patch set include multiple fixes for the issues reported by checkpatch.pl Kamal Heib (8): staging: greybus: authentication.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c: Fix alignment should match open parenthesis staging: greybus: audio_codec.c

[PATCH 1/4] staging: greybus: authentication.c: Fix alignment should match open parenthesis

2017-12-20 Thread Kamal Heib
Fix "Alignment should match open parenthesis" checkpatch.pl error. Signed-off-by: Kamal Heib --- drivers/staging/greybus/authentication.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authen

[PATCH 0/4] staging: greybus: Cleanup checkpatch errors

2017-12-20 Thread Kamal Heib
This patch set fixes multiple error found by checkpatch.pl in the greybus drivers. Kamal Heib (4): staging: greybus: authentication.c: Fix alignment should match open parenthesis staging: greybus: bootrom.c: Fix alignment should match open parenthesis staging: greybus: bundle.c: Fix

[PATCH 2/4] staging: greybus: bootrom.c: Fix alignment should match open parenthesis

2017-12-20 Thread Kamal Heib
Fix "Alignment should match open parenthesis" checkpatch.pl error. Signed-off-by: Kamal Heib --- drivers/staging/greybus/bootrom.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/stagi

[PATCH 3/4] staging: greybus: bundle.c: Fix multiple checkpatch.pl errors

2017-12-20 Thread Kamal Heib
) Signed-off-by: Kamal Heib --- drivers/staging/greybus/bundle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c index 81c018da1248..3f702db9e098 100644 --- a/drivers/staging/greybus/bundle.c +++ b/drivers

[PATCH 4/4] staging: greybus: bundle.h: Use a blank line after struct declarations

2017-12-20 Thread Kamal Heib
Fix the following error found by checkpatch.pl: CHECK: Please use a blank line after function/struct/union/enum declarations +}; +#define to_gb_bundle(d) container_of(d, struct gb_bundle, dev) Signed-off-by: Kamal Heib --- drivers/staging/greybus/bundle.h | 1 + 1 file changed, 1 insertion

[PATCH 2/3] staging: greybus: audio_codec.c: Fix multiple checkpatch errors

2017-12-19 Thread Kamal Heib
This patch fixes the following errors found by checkpatch: 1- Prefer kernel type 'u32' over 'uint32_t'. 2- Space required around that ':'. 3- Alignment should match open parenthesis. 4- Don't use multiple blank lines. Signed-off-by: Kamal Heib --- drivers

[PATCH 3/3] staging: greybus: audio_codec.h: Fix multiple checkpatch errors

2017-12-19 Thread Kamal Heib
This patch fixes the following errors found by checkpatch: 1- Prefer kernel type 'u32' over 'uint32_t'. 2- Alignment should match open parenthesis. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 12 ++-- 1 file changed, 6 insertions(+), 6 dele

[PATCH 1/3] staging: greybus: arche-apb-ctrl.c: Fix multiple blank lines error

2017-12-19 Thread Kamal Heib
Fix "don't use multiple blank lines" error found by checkpatch.pl. Signed-off-by: Kamal Heib --- drivers/staging/greybus/arche-apb-ctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c ind

[PATCH 0/3] staging: greybus: Fix multiple checkpatch errors

2017-12-19 Thread Kamal Heib
This patch set fixes multiple error found by checkpatch.pl in the greybus drivers. Kamal Heib (3): staging: greybus: arche-apb-ctrl.c: Fix multiple blank lines error staging: greybus: audio_codec.c: Fix multiple checkpatch errors staging: greybus: audio_codec.h: Fix multiple checkpatch

[PATCH 2/2] staging: greybus: arche-platform.c: Fix alignment should match open parenthesis

2017-12-17 Thread Kamal Heib
Fix "alignment should match open parenthesis" checkpatch.pl error. Signed-off-by: Kamal Heib --- drivers/staging/greybus/arche-platform.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drive

[PATCH 1/2] staging: greybus: arche-apb-ctrl.c: Fix alignment should match open parenthesis

2017-12-17 Thread Kamal Heib
Fix "alignment should match open parenthesis" checkpatch.pl error. Signed-off-by: Kamal Heib --- drivers/staging/greybus/arche-apb-ctrl.c | 39 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c

[PATCH 0/2] staging: greybus: Fix alignments

2017-12-17 Thread Kamal Heib
This patch set fixes the alignments errors found by checkpatch.pl Kamal Heib (2): staging: greybus: arche-apb-ctrl.c: Fix alignment should match open parenthesis staging: greybus: arche-platform.c: Fix alignment should match open parenthesis drivers/staging/greybus/arche-apb-ctrl.c

[PATCH 1/3] staging: dgnc: dgnc_tty.c: remove unnecessary parentheses

2017-12-16 Thread Kamal Heib
Cleanup the "Unnecessary parentheses around " checkpatch.pl error. Signed-off-by: Kamal Heib --- drivers/staging/dgnc/dgnc_tty.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/st

[PATCH 3/3] staging: dgnc: dgnc_neo.c: remove unnecessary parentheses

2017-12-16 Thread Kamal Heib
Cleanup the "Unnecessary parentheses around " checkpatch.pl error. Signed-off-by: Kamal Heib --- drivers/staging/dgnc/dgnc_neo.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_n

[PATCH 0/3] staging: dgnc: Remove unnecessary parentheses

2017-12-16 Thread Kamal Heib
This patchset cleanup the "Unnecessary parentheses around " checkpatch.pl error from the dgnc driver. Kamal Heib (3): staging: dgnc: dgnc_tty.c: remove unnecessary parentheses staging: dgnc: dgnc_cls.c: remove unnecessary parentheses staging: dgnc: dgnc_neo.c: remove unnecessary p

[PATCH 2/3] staging: dgnc: dgnc_cls.c: remove unnecessary parentheses

2017-12-16 Thread Kamal Heib
Cleanup the "Unnecessary parentheses around " checkpatch.pl error. Signed-off-by: Kamal Heib --- drivers/staging/dgnc/dgnc_cls.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_c

[PATCH] Staging: ccree: Add blank line after declarations

2017-12-15 Thread Kamal Heib
This patch adds a blank line after declarations to improve code readability. Issue find by checkpatch.pl script. WARNING: Missing a blank line after declarations Signed-off-by: Kamal Heib --- drivers/staging/ccree/ssi_cipher.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging

[PATCH] staging: lustre: mgc: Fix incorrect type in assignment

2017-07-01 Thread Kamal Heib
: incorrect type in assignment (different base types) mgc_request.c:82:25:expected unsigned long long [unsigned] [long] [long long] mgc_request.c:82:25:got restricted __le64 [usertype] Cc: Greg Kroah-Hartman Signed-off-by: Kamal Heib --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 4

[PATCH] staging: android: ion: statify __ion_add_cma_heaps

2017-06-30 Thread Kamal Heib
Fix the following sparse warning: symbol '__ion_add_cma_heaps' was not declared. Should it be static? Cc: Greg Kroah-Hartman Signed-off-by: Kamal Heib --- drivers/staging/android/ion/ion_cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/a

[PATCH] staging: wlan-ng: Fix incorrect type in assignment

2017-06-17 Thread Kamal Heib
: incorrect type in assignment (different base types) prism2mgmt.c:200:30:expected unsigned short [unsigned] [addressable] [usertype] channel_list prism2mgmt.c:200:30:got restricted __le16 [usertype] Cc: Greg Kroah-Hartman Signed-off-by: Kamal Heib --- drivers/staging/wlan-ng