HELLO

2020-04-23 Thread Ken
Hello Please can you assist me for a shipment/sales of Raw Gold Bar in your Country. SPECIFICATION.Karat: 22 +,Purity: 96.6%,Raw Gold Bar,Origin:Ghana Price: $35,000 per 1kg Regards. Lucas Duru ___ devel mailing list de...@linuxdriverproject.org http://d

Inquiry for new Order!!!

2020-03-14 Thread Ken Global Enterprise, Inc
· Delivery time · Warranty Your early reply is highly appreciated! Thanks, Alice Louis | Purchasing Manager Ken Global Enterprise, Inc Head office:808, Concord Tower Dubai Media City, p.o.box 37487, Dubai-UAE T: +971 4 33 508 34 F: +971 4 42 5359 61 Dubai U.A.E. * SPAIN *ISRAEL* USA

[PATCH 09/11] staging: unisys: virthba: Fix "else not useful after return" warning

2014-11-18 Thread Ken Depro
This patch fixes a warning generated during the checkpatch script that stated "else not useful after return". I modified the code to return a designated status at the end of the function, and replaced the return statement in the "else if" to set the status accordingly. Sign

[PATCH 08/11] staging: unisys: virthba: Fix a couple checkpatch problems

2014-11-18 Thread Ken Depro
This patch fixes a couple small issues reported by the checkpatch script: Adds a blank line after a struct definition. Removes unnecessary parentheses surrounding a struct member. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c |3 ++- 1 file changed, 2 insertions

[PATCH 06/11] staging: unisys: virthba: Fix missing braces at end of if-else statements

2014-11-18 Thread Ken Depro
This patch fixes checkpatch warnings that resulted from the else portion of if-else statements missing braces, so that it conforms with the rest of the statement. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c |6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH 11/11] staging: unisys: virthba: Fix a couple open parenthesis alignment issues

2014-11-18 Thread Ken Depro
This patch fixes a couple checkpatch checks where alignment of the parameters did not match the open parenthesis of the function. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 10/11] staging: unisys: virthba: Fix warnings regarding lines over 80 characters

2014-11-18 Thread Ken Depro
This patch fixes warnings generated by checkpatch script regarding lines over 80 characters long. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c | 40 -- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 07/11] staging: unisys: virthba: Change alloc calls to use var name instead of type

2014-11-18 Thread Ken Depro
This patch changes a couple of kzalloc calls to pass the variable name to the call, rather than the variable struct type. This is a result of checks generated during the checkpatch script. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c |4 ++-- 1 file changed, 2

[PATCH 00/11] staging: unisys: virthba: Fix checkpatch issues in virthba

2014-11-18 Thread Ken Depro
This series fixes various issues in the virthba.c file that were reported by the checkpatch script. Ken Depro (11): staging: unisys: virthba: Remove unneeded spaces after casts staging: unisys: virthba: Fix CamelCase variables staging: unisys: virthba: Fix open parenthesis alignment checks

[PATCH 03/11] staging: unisys: virthba: Fix open parenthesis alignment checks

2014-11-18 Thread Ken Depro
This patch fixes the "alignment should match open parenthesis" checks from the checkpatch script. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c | 74 +++--- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/stag

[PATCH 04/11] staging: unisys: virthba: Fix logical continuation checks

2014-11-18 Thread Ken Depro
This patch fixes checkpatch checks where the logical operator should be at the end of the line above, not beginning the next line. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff

[PATCH 01/11] staging: unisys: virthba: Remove unneeded spaces after casts

2014-11-18 Thread Ken Depro
This patch removes all unnecessary spaces after casts, as reported by the checkpatch script. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c | 130 +++--- 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 02/11] staging: unisys: virthba: Fix CamelCase variables

2014-11-18 Thread Ken Depro
This patch fixes the improper CamelCase usage for variables, reported by the checkpatch script. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c | 122 +++--- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 05/11] staging: unisys: virthba: Remove blank lines before/after braces

2014-11-18 Thread Ken Depro
This patch removes unnecessary blank lines either before opening braces or after closing braces, as reported by the checkpatch script. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/unisys/virthba

[PATCH] staging: unisys: fix CamelCase methods/variables in virthba.c

2014-11-10 Thread Ken Depro
This patch fixes the CamelCase checks for methods/variables in virthba.c found with the checkpatch script. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthba.c | 122 +++--- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/drivers/staging

[PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c

2014-11-07 Thread Ken Depro
This patch removes all of the unnecessary spaces after casts within the virthba.c file. The checkpatch script was run again after these changes, and no "remove spaces after casts" checks were generated. Signed-off-by: Ken Depro --- drivers/staging/unisys/virthba/virthb

[PATCH] staging: unisys: Remove chanstub files

2014-11-07 Thread Ken Depro
channels Makefile. Signed-off-by: Ken Depro --- drivers/staging/unisys/channels/Makefile |2 +- drivers/staging/unisys/channels/chanstub.c | 75 drivers/staging/unisys/channels/chanstub.h | 23 - drivers/staging/unisys/uislib/uislib.c |1

[PATCH] staging: unisys: Remove chanstub files While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch remov

2014-11-07 Thread Ken Depro
Signed-off-by: Ken Depro --- drivers/staging/unisys/channels/Makefile |2 +- drivers/staging/unisys/channels/chanstub.c | 75 drivers/staging/unisys/channels/chanstub.h | 23 - drivers/staging/unisys/uislib/uislib.c |1 - drivers/staging

Re: [PATCH] staging: unisys: add visorclientbus driver

2014-11-06 Thread Ken Cox
On 11/06/2014 01:05 PM, Greg KH wrote: On Thu, Nov 06, 2014 at 12:53:32PM -0600, Ken Cox wrote: From: Benjamin Romer This patch adds the visorclientbus driver to the Unisys s-Par driver set. This driver is responsible for helping manage virtual devices like keyboards, mice, serial ports

[PATCH] staging: unisys: add visorclientbus driver

2014-11-06 Thread Ken Cox
-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 1 + drivers/staging/unisys/Makefile| 1 + drivers/staging/unisys/visorclientbus/Kconfig | 9 + drivers/staging/unisys/visorclientbus/Makefile | 13 + .../unisys/visorclientbus

[PATCH] staging: unisys: Fix CamelCase params in SignalInsert_withLock

2014-11-06 Thread Ken Depro
From: Ken Depro This patch renames the following SignalInsert_withLock parameters to fix the CamelCase checks: pChannel to pchannel Queue to queue pSignal to psignal Signed-off-by: Ken Depro --- drivers/staging/unisys/channels/chanstub.c |6 +++--- drivers/staging/unisys/channels

[PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c

2014-11-06 Thread Ken Depro
From: Ken Depro This patch removes unneeded spaces after casts within the virthba.c file. The checkpatch script was run after these changes, and no "remove spaces after casts" checks were generated. Later patches will fix the other checkpatch warnings/checks. Conflicts:

[PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c

2014-11-05 Thread Ken Depro
From: Ken Depro This patch removes unneeded spaces after casts within the virthba.c file. The checkpatch script was run after these changes, and no "remove spaces after casts" checks were generated. Later patches will fix the other checkpatch warnings/checks. Signed-off-by:

[PATCH] staging: unisys: Remove extra blank lines from virthba files

2014-11-05 Thread Ken Depro
From: Ken Depro This patch removes extra blank lines from the virthba header and source files. This is the first of a set of patches that will clean up the virthba source file. The only checkpatch issue in the header file was the blank line warnings. Signed-off-by: Ken Depro Signed-off-by

[PATCH] staging: unisys: Remove unneeded spaces from channel.c

2014-11-03 Thread Ken Depro
From: Ken Depro This patch removes some unneeded white space after casts within the channel.c file. The checkpatch script was run after these changes, and no further checks or warnings were seen. Signed-off-by: Ken Depro Signed-off-by: Ben Romer --- drivers/staging/unisys/channels/channel.c

Re: Staging: unisys: base drivers complete

2014-09-15 Thread Ken Cox
hose taken care of. -- Ken Cox ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Staging: unisys: base drivers complete

2014-09-15 Thread Ken Cox
On 09/15/2014 11:04 AM, Greg KH wrote: On Mon, Sep 15, 2014 at 10:56:07AM -0500, Ken Cox wrote: Greg and other reviewers, Ben Romer and I believe that the Unisys drivers in staging-next are now complete. Are there any other changes that you are aware of that we need to make to these drivers

Staging: unisys: base drivers complete

2014-09-15 Thread Ken Cox
. Thanks in advance for your comments, -- Ken Cox ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: linux-next: Tree for Jul 3 (staging/unisys)

2014-07-03 Thread Ken Cox
`channel_mod_init': chanstub.c:(.init.text+0x10a8f): undefined reference to `unisys_spar_platform' because CHANNELSTUB=y and VISORUTIL=m. Hi Randy, I have submitted a patch to fix this. Thanks for the reply. -- Ken ___ devel maili

[PATCH 4/4] Staging: unisys: Fix noderef sparse warnings in vbusdeviceinfo.h

2014-07-03 Thread Ken Cox
vbuschannel_devinfo_to_string() was declared with the devinfo argument as a pointer to __iomem space. No callers of this function need the __iomem space, so I removed that constraint. Same thing goes for vbuschannel_sanitize_buffer(). It doesn't need to operate on I/O space. Signed-off-by

[PATCH 3/4] Staging: unisys: Remove ultra_vbus_init_channel function

2014-07-03 Thread Ken Cox
The function ultra_vbus_init_channel() is never called since previous server code was removed. Remove the dead code. Signed-off-by: Ken Cox --- .../common-spar/include/channels/vbuschannel.h | 36 -- 1 file changed, 36 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 2/4] Staging: unisys: Remove isServer arg from init_vbus_channel()

2014-07-03 Thread Ken Cox
The init_vbus_channel() function is never called with the isServer argument equal to TRUE, so just get rid of the argument altogether. This also means that the code in the function that would be executed in the server case can be removed since it is never executed. Signed-off-by: Ken Cox

[PATCH 0/4] Staging: unisys: Code cleanup

2014-07-03 Thread Ken Cox
This series implements various cleanups for the Unisys drivers, including: -Renaming functions using Linux kernel conventions -Removing dead code -fixing noderef sparse warnings ___ devel mailing list de...@linuxdriverproject.org http://driverdev.

[PATCH 1/4] Staging: unisys: use Linux coding convention for function names

2014-07-03 Thread Ken Cox
NNEL_itoa() --> vbuschannel_itoa() Signed-off-by: Ken Cox --- .../common-spar/include/channels/vbuschannel.h | 4 ++-- .../unisys/common-spar/include/vbusdeviceinfo.h| 28 +++--- drivers/staging/unisys/uislib/uislib.c | 2 +- 3 files changed, 17 insertions(+),

Re: randconfig build error with next-20140630, in drivers/staging/unisys/channels/chanstub.c

2014-06-30 Thread Ken Cox
ubmitted a patch to correct this. The kbuild test robot uncovered it also. Thanks for the report, Ken ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging:unisys: Add Kconfig dependency on UNISYS_VISORUTIL to UNISYS_CHANNELSTUB

2014-06-30 Thread Ken Cox
`channel_mod_init': chanstub.c:(.init.text+0xbe24): undefined reference to `unisys_spar_platform' Reported by: kbuild test robot Signed-off-by: Ken Cox --- drivers/staging/unisys/channels/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/channe

[PATCH v2 1/2] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-26 Thread Ken Cox
elsewhere. In addition, using these macros breaks the build if using gcc 4.9.0 Reported-by: Greg Kroah-Hartman Signed-off-by: Ken Cox --- drivers/staging/unisys/include/vbushelper.h | 8 +++- drivers/staging/unisys/uislib/uisutils.c| 11 --- drivers/staging

[PATCH v2 2/2] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-26 Thread Ken Cox
and the kernel now runs as expected. Reported-by: Fengguang Wu Reported-by: Sasha Levin Tested-by: Ken Cox Signed-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys

[PATCH v2 0/2] Staging: unisys: Remove references to __DATE__ and __TIME__

2014-06-26 Thread Ken Cox
This series removes all references to __DATE__ and __TIME__ from the unisys drivers and also removes BROKEN from the Kconfig so the drivers can be built. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman

Re: [PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-26 Thread Ken Cox
On 06/25/2014 10:57 PM, Greg KH wrote: On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote: --snip-- .id_table = virthba_id_table, .probe = virthba_probe, .remove = virthba_remove, @@ -1413,9 +1413,6 @@ info_proc_read(struct file *file, char __user *buf, size_t

Re: [Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-25 Thread Ken Cox
On 06/17/2014 06:01 PM, Greg KH wrote: On Thu, Jun 05, 2014 at 01:56:16PM -0500, Ken Cox wrote: Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../common-spar/include/channels

[PATCH 4/4] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-25 Thread Ken Cox
and the kernel now runs as expected. Reported-by: Fengguang Wu Reported-by: Sasha Levin Tested-by: Benjamin Romer Tested-by: Ken Cox Signed-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b

[PATCH 1/4] Staging: unisys: remove references to __DATE__ and __TIME__

2014-06-25 Thread Ken Cox
elsewhere. In addition, using these macros breaks the build if using gcc 4.9.0 Reported-by: Greg Kroah-Hartman Signed-off-by: Ken Cox --- drivers/staging/unisys/uislib/uisutils.c| 8 +++- drivers/staging/unisys/virthba/virthba.c| 7 ++- drivers/staging

[PATCH 3/4] Staging: unisys: Remove build_date and build_time from virtpci_driver structure

2014-06-25 Thread Ken Cox
The drivers do not need to keep track of these fields since the same information is present elsewhere in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 2 -- drivers/staging/unisys/virtpci/virtpci.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers

[PATCH 0/4] Staging: unisys: Remove references to __DATE__ and __TIME__

2014-06-25 Thread Ken Cox
This series removes all references to __DATE__ and __TIME__ from the unisys drivers and also removes BROKEN from the Kconfig so the drivers can be built. PATCH 1: Gets rid of references to __DATE__ and __TIME__ PATCH 2: Removes buildDate and buildTime arguments from BusDeviceInfo_Init() PATCH 3: R

[PATCH 2/4] Staging: unisys: remove buildDate and buildTime arguments from BusDeviceInfo_Init

2014-06-25 Thread Ken Cox
The unisys drivers no longer need to record the build date and time since the same info is already in the kernel elsewhere. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/vbushelper.h | 8 +++- drivers/staging/unisys/uislib/uisutils.c| 7

Re: [PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-23 Thread Ken Cox
On 06/17/2014 05:49 PM, Greg KH wrote: On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote: The unisys drivers now properly check to make sure they are running on the s-Par platform before they will initialize. This was fixed in commit fcd0157ece so it is safe to allow the unisys drivers

[PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-07 Thread Ken Helias
From: Ken Helias All other add functions for lists have the new item as first argument and the position where it is added as second argument. This was changed for no good reason in this function and makes using it unnecessary confusing. The name was changed to let old code generate a compile

[PATCH 13/13] staging: tidspbridge: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCHv2 02/13] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-06 Thread Ken Helias
From: Ken Helias All other add functions for lists have the new item as first argument and the position where it is added as second argument. This was changed for no good reason in this function and makes using it unnecessary confusing. Signed-off-by: Ken Helias Cc: Linux NICS Cc: "P

[PATCH] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-06 Thread Ken Helias
changed to use the same names as hlist_add_after_rcu. Signed-off-by: Ken Helias Cc: David Airlie Cc: Jeff Kirsher Cc: Jesse Brandeburg Cc: Bruce Allan Cc: Carolyn Wyborny Cc: Don Skidmore Cc: Greg Rose Cc: Alex Duyck Cc: John Ronciak Cc: Mitch Williams Cc: Linux NICS Cc: Alexander Viro Cc

[Patch v3 4/4] Staging: unisys: Fix noderef sparse warnings in vbusdeviceinfo.h

2014-06-05 Thread Ken Cox
vbuschannel_devinfo_to_string() was declared with the devinfo argument as a pointer to __iomem space. No callers of this function need the __iomem space, so I removed that constraint. Same thing goes for vbuschannel_sanitize_buffer(). It doesn't need to operate on I/O space. Signed-off-by

[Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../common-spar/include/channels/vbuschannel.h | 40 -- drivers/staging/unisys/uislib/uislib.c | 2 +- 2

[Patch v3 1/4] Staging: unisys: use Linux coding convention for function names

2014-06-05 Thread Ken Cox
Changed function declarations for VBUSCHANNEL_devInfoToStringBuffer() and ULTRA_VBUS_init_channel() to conform to Linux kernel coding convention. Signed-off-by: Ken Cox --- drivers/staging/unisys/common-spar/include/channels/vbuschannel.h | 4 ++-- drivers/staging/unisys/common-spar/include

[PATCH v3 0/2] Staging: unisys: uislib: address sparse noderef warnings

2014-06-05 Thread Ken Cox
This series gets rid of some sparse noderef warnings by adding I/O versions of the functions that are producing the warnings and also removing __iomem declarations where they are not needed. While we are at it, we fix up the function names of the functions that we are modifying so that they com

[Patch v3 3/4] Staging: unisys: make function names Linux compliant

2014-06-05 Thread Ken Cox
Changed function declarations in drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h so that the function names follow Linux coding standards. Signed-off-by: Ken Cox --- .../unisys/common-spar/include/vbusdeviceinfo.h| 28 +++--- 1 file changed, 14 insertions

Re: [PATCH v2 2/2] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
On 06/05/2014 11:22 AM, Greg KH wrote: On Thu, Jun 05, 2014 at 11:04:32AM -0500, Ken Cox wrote: Added I/O versions for the functions vbuschannel_devinfo_to_string() and ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox

[PATCH v2 0/2] Staging: unisys: uislib: address sparse noderef warnings

2014-06-05 Thread Ken Cox
This series gets rid of some sparse noderef warnings by adding I/O versions of the functions that are producing the warnings. In the first patch, we clean up the function names so they are acceptable then we add the new functions in the second patch. __

[PATCH v2 1/2] Staging: unisys: use Linux coding convention for function names

2014-06-05 Thread Ken Cox
Changed function declarations for VBUSCHANNEL_devInfoToStringBuffer() and ULTRA_VBUS_init_channel() to conform to Linux kernel coding convention. Signed-off-by: Ken Cox --- drivers/staging/unisys/common-spar/include/channels/vbuschannel.h | 4 ++-- drivers/staging/unisys/common-spar/include

[PATCH v2 2/2] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
Added I/O versions for the functions vbuschannel_devinfo_to_string() and ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../staging/unisys/common-spar/include/channels/vbuschannel.h | 11 ++- drivers/staging/unisys

[PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

2014-06-03 Thread Ken Cox
and the kernel now runs as expected. Reported-by: Fengguang Wu Reported-by: Sasha Levin Tested-by: Benjamin Romer Tested-by: Ken Cox Signed-off-by: Ken Cox --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b

Re: [PATCH 0/6] Staging: unisys: code cleanup patches

2014-05-28 Thread Ken Cox
On 05/28/2014 09:17 AM, Greg KH wrote: On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote: On 05/23/2014 06:18 AM, Greg KH wrote: On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse

Re: [PATCH 0/6] Staging: unisys: code cleanup patches

2014-05-28 Thread Ken Cox
On 05/23/2014 06:18 AM, Greg KH wrote: On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef

[PATCH 4/6] Staging: unisys: Remove unused macros from visorchannel/visorchannel.h

2014-05-22 Thread Ken Cox
. Reported-by: Dan Carpenter Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchannel/visorchannel.h | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/staging/unisys/visorchannel/visorchannel.h b/drivers/staging/unisys/visorchannel/visorchannel.h index 784f03a

[PATCH 6/6] Staging: unisys: visorchipset: Remove filexfer.c

2014-05-22 Thread Ken Cox
There is not any code using the functionality in filexfer.c so I removed it and filexfer.h. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchipset/Makefile | 2 +- drivers/staging/unisys/visorchipset/filexfer.c | 506 - drivers/staging/unisys/visorchipset

[PATCH 5/6] Staging: unisys: Fixup sparse warnings for dereferencing noderef types.

2014-05-22 Thread Ken Cox
Fixed the usage of the following so they don't try to dereference pointers to iomem. CHANNEL_U64_MISMATCH CHANNEL_U32_MISMATCH wait_for_valid_guid Signed-off-by: Ken Cox --- .../unisys/common-spar/include/channels/channel.h | 16 --- drivers/staging/u

[PATCH 2/6] Staging: unisys: Fix sparse warnings in uislib

2014-05-22 Thread Ken Cox
Added ULTRA_VBUS_IOinit_channel() and modified ULTRA_VBUS_init_channel() function so that it can operate on both memory space and IO space without getting sparse warnings. Signed-off-by: Ken Cox --- .../unisys/common-spar/include/channels/vbuschannel.h| 12 ++-- drivers/staging

[PATCH 3/6] Staging: unisys: virthba: declare virthba_queue_command as static

2014-05-22 Thread Ken Cox
virthba_queue_command() is only used inside virthba.c so declare it static. Signed-off-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba

[PATCH 0/6] Staging: unisys: code cleanup patches

2014-05-22 Thread Ken Cox
This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros _

[PATCH 1/6] Staging: unisys: Fix sparse warnings

2014-05-22 Thread Ken Cox
Fix sparse warnings caused by incorrect references to IO space. Signed-off-by: Ken Cox --- drivers/staging/unisys/uislib/uislib.c | 2 +- drivers/staging/unisys/visorchannel/visorchannel.h | 6 +++--- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 4

Re: [Patch V2 0/2] staging: unisys: Fix module loading on non s-Par platform

2014-05-12 Thread Ken Cox
On 04/28/2014 12:23 PM, Ken Cox wrote: Each module now has a check in the init function to ensure that it is being loaded on an s-Par platform and returns an error if it isn't. Also, MODULE_LICENSE("GPL") has been added to visorkmodutils.c. Greg, Have you had a chance to look a

[PATCH V2 2/2] Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")

2014-04-28 Thread Ken Cox
The visorutil module was lacking license info. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/visorkmodutils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c b/drivers/staging/unisys/visorutil/visorkmodutils.c index 7521027

[PATCH V2 1/2] Staging: unisys: detect s-Par firmware

2014-04-28 Thread Ken Cox
if no s-Par firmware is present. This fixes a problem reported from upstream where a panic occurs if the unisys drivers are loaded on a non s-Par system. Reported-by: Fengguang Wu Signed-off-by: Ken Cox Tested by: Ken Cox --- drivers/staging/unisys/channels/chanstub.c | 3 ++ drivers

[Patch V2 0/2] staging: unisys: Fix module loading on non s-Par platform

2014-04-28 Thread Ken Cox
Each module now has a check in the init function to ensure that it is being loaded on an s-Par platform and returns an error if it isn't. Also, MODULE_LICENSE("GPL") has been added to visorkmodutils.c. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 4/4] Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")

2014-04-28 Thread Ken Cox
On 04/25/2014 05:32 PM, Greg KH wrote: On Thu, Apr 24, 2014 at 01:57:12PM -0500, Ken Cox wrote: The visorutil module was lacking license info. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging

[PATCH 3/4] Staging: unisys: virthba: add MODULE_DEVICE_TABLE

2014-04-24 Thread Ken Cox
Add x86_cpu_id struct and call to MODULE_DEVICE_TABLE so this module will be auto loaded on boot. Signed-off-by: Ken Cox Tested-by: Ken Cox --- drivers/staging/unisys/virthba/virthba.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/unisys/virthba/virthba.c b

[Patch 0/4] staging: unisys: Fix module loading on non s-Par platform

2014-04-24 Thread Ken Cox
This series fixes the problem reported by Fengguang Wu where the unisys modules will cause a panic if loaded on a non s-Par platform. Each module now has a check in the init function to ensure that it is being loaded on an s-Par platform and returns an error if it isn't. In addition, a MODULE_D

[PATCH 4/4] Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")

2014-04-24 Thread Ken Cox
The visorutil module was lacking license info. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c b/drivers/staging/unisys/visorutil/visorkmodutils.c index 87ed5bf

[PATCH 2/4] Staging: unisys: Added check for s-Par platform in each init function.

2014-04-24 Thread Ken Cox
This fixes a problem reported from upstream where a panic occurs if the unisys drivers are loaded on a non s-Par system. Reported-by: Fengguang Wu Signed-off-by: Ken Cox Tested by: Ken Cox --- drivers/staging/unisys/channels/chanstub.c| 5 + drivers/staging/unisys/uislib

[PATCH 1/4] staging: unisys: detect s-Par firmware

2014-04-24 Thread Ken Cox
platform and refuse to load if no s-Par firmware is present. This fixes a problem reported from upstream where a panic occurs if the unisys drivers are loaded on a non s-Par system. Reported-by: Fengguang Wu Signed-off-by: Benjamin Romer Tested-by: Benjamin Romer Signed-off-by: Ken Cox Tested-by

Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP

2014-04-07 Thread Ken Cox
On 04/07/2014 09:09 AM, Greg Kroah-Hartman wrote: On Mon, Apr 07, 2014 at 07:17:25PM +0800, Fengguang Wu wrote: Hi Ken, I got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 12e364b9f08aa335dc7716ce74113e834c993765

Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP

2014-04-07 Thread Ken Cox
On 04/07/2014 06:17 AM, Fengguang Wu wrote: Hi Ken, I got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 12e364b9f08aa335dc7716ce74113e834c993765 Author: Ken Cox AuthorDate: Tue Mar 4 07:58:07 2014 -0600 Commit

Re: [PATCH 4/6] Staging: unisys: visorchannel: Clean up sparse warnings in visorchannel code

2014-03-28 Thread Ken Cox
On 03/28/2014 07:53 AM, Dan Carpenter wrote: On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote: Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(), and visorchannel_safesignalinsert

[PATCH 3/8] Staging: unisys: Remove FAIL_WPOSTCODE_1 macro

2014-03-19 Thread Ken Cox
Part of a series to get rid of goto statements embedded in macros. I'm breaking this up into a series of smaller patches for easier review. The later patches in the series will actually remove the goto statements. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timsk

[PATCH 7/8] Staging: unisys: Remove FAIL macro

2014-03-19 Thread Ken Cox
The FAIL macro ultimately includes a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 12 --- .../unisys/visorchannel/visorchannel_funcs.c | 97 ++ drivers/staging/unisys/visorchipset

[PATCH 5/8] Staging: unisys: Remove RETPTR macro

2014-03-19 Thread Ken Cox
The RETPTR macro contained a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 4 --- drivers/staging/unisys/uislib/uislib.c | 11 --- drivers/staging/unisys/uislib/uisqueue.c | 1

[PATCH 2/8] Staging: unisys: Cleanup macros to get rid of goto statements

2014-03-19 Thread Ken Cox
aking this up into a series of smaller patches for easier review. The later patches in the series will actually remove the goto statements. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 83 -- .../unisys/visorchipset/visorchipset_m

[PATCH 8/8] Staging: unisys: Remove RETINT macro

2014-03-19 Thread Ken Cox
The RETINT macro included a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 4 -- drivers/staging/unisys/uislib/uisqueue.c | 9 ++-- .../unisys/visorchannel/visorchannel_funcs.c | 10

[PATCH 6/8] Staging: unisys: Remove RETVOID macro

2014-03-19 Thread Ken Cox
The RETVOID macro contained a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 2 -- drivers/staging/unisys/uislib/uisqueue.c| 1 - drivers/staging/unisys/visorchipset/parser.c

[PATCH 4/8] Staging: unisys: Remove RETBOOL macro

2014-03-19 Thread Ken Cox
The RETBOOL macro contained a goto statement which is not allowed in the kernel. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 4 --- drivers/staging/unisys/uislib/uisqueue.c | 1 - .../unisys/visorchannel/visorchannel_funcs.c | 37

[Patch 0/8] Staging: unisys: Get rid of goto statements in macros

2014-03-19 Thread Ken Cox
This series gets rid of a number of macros that ultimately include a goto statement. The first patches clean up unused macros and macros that reference other macros which eventually contain a goto statement. The latter patches actually remove the goto statements. __

[PATCH 1/8] Staging: unisys: include: Remove unused macros from timskmod.h

2014-03-19 Thread Ken Cox
The following macros were never referenced and have been removed: DEVFROMID DEVFROMFILE DEVFROMINODE DEVFROMIDX TRY_WPOSTCODE_3 Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmod.h | 118 -- 1 file changed, 118

Re: [PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

2014-03-18 Thread Ken Cox
On 03/17/2014 04:43 PM, Mark Einon wrote: Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by: Ken Cox diff --git

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Ken Cox
On 03/17/2014 07:26 PM, DaeSeok Youn wrote: I think vmalloc/kmalloc in uislib_malloc() can be removed and just use vmalloc/kmalloc directly. (UISMALLOC() macro is also removed.) And uislib_malloc() is renamed to "uislib_trace_buffer_status()" which is just tracing buffer status(Malloc_FailuresAl

[Patch V2 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

2014-03-17 Thread Ken Cox
Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack by removing visor_hexDumpToBuffer() and using hex_dump_to_buffer() instead. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmodutils.h | 22 -- .../unisys/visorchannel

Re: [PATCH 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

2014-03-17 Thread Ken Cox
On 03/16/2014 05:13 PM, Mark Einon wrote: On 13/03/14 20:39, Ken Cox wrote: Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/procobjecttree.c | 2 +- drivers/staging/unisys

[PATCH 5/6] Staging: unisys: visorchipset: Clean up sparse warnings in visorchipset code.

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings due to accessing I/O space. Also declared functions and variables as static if they are only used locally. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorchipset/controlvm_direct.c | 1 + drivers/staging/unisys/visorchipset/file.c

[PATCH 6/6] Staging: unisys: visorutil: Clean up sparse warnings in visorutil code

2014-03-13 Thread Ken Cox
Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack. Signed-off-by: Ken Cox --- drivers/staging/unisys/visorutil/procobjecttree.c | 2 +- drivers/staging/unisys/visorutil/visorkmodutils.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions

[PATCH 2/6] Staging: unisys: Clean multiple sparse warnings

2014-03-13 Thread Ken Cox
Cleaned up multiple sparse warnings, mostly due to improper access of I/O space. Also declared functions and variables that were only used locally as static. Removed ULTRA_disp_channel_header(), ULTRA_disp_channel(), ULTRA_disp_vnic_channel() because they were never called. Signed-off-by: Ken

[PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

2014-03-13 Thread Ken Cox
Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by: Ken Cox --- drivers/staging/unisys/channels/channel.c| 166

  1   2   >