[PATCH] staging: greybus: add logging statement when kfifo_alloc fails

Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel --- drivers/staging/greybus/uart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index b3bffe91ae99

Re: [PATCH] staging: greybus: add logging statement when kfifo_alloc fails

On Wed, Jul 10, 2019 at 06:35:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 10, 2019 at 08:20:17AM -0400, Keyur Patel wrote: > > Added missing logging statement when kfifo_alloc fails, to improve > > debugging. > > > > Signed-off-by: Keyur Patel > > --- &g

[PATCH 2/2] staging: most: remove redundant print statement when kfifo_alloc fails

This print statement is redundant as kfifo_alloc just calls kmalloc_array and without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- drivers/staging/most/cdev/cdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most

[PATCH v2] staging: most: remove redundant print statement when

This print statement is redundant as kfifo_alloc just calls kmalloc_array and without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v2: - Edit subject line. --- drivers/staging/most/cdev/cdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH v3] staging: most: remove redundant print statement when kfifo_alloc fails

This print statement is redundant as kfifo_alloc just calls kmalloc_array and without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel Changes in v3: - fix checkpatch warrning --- drivers/staging/most/cdev/cdev.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH v4] staging: most: remove redundant print statement when kfifo_alloc fails

This print statement is redundant as kfifo_alloc just calls kmalloc_array without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v3: - fix checkpatch warning drivers/staging/most/cdev/cdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

Re: [v4] staging: most: remove redundant print statement when kfifo_alloc fails

___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [v4] staging: most: remove redundant print statement when kfifo_alloc fails

I didn't get you. I stiil need to update changelog and send more version or not. If you say so, I can send one more. Thnaks. On Sun, Jul 14, 2019 at 05:23:34PM +0200, Markus Elfring wrote: > > --- > > Changes in v3: > > Thanks for your quick response. > > I find the change log incomplete (even

[PATCH v4] staging: most: Delete an error message for a failed memory allocation

This error message for a failed memory allocation is redundant as kfifo_alloc just calls kmalloc_array without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v4: - change subject line - improve commit description - fix checkpatch warning drivers

Re: [v4] staging: most: Delete an error message for a failed memory allocation

I think commit message is clear enough to understand why this is needed. You can send me what should I include in commit description and I will add and send it again. Otherwise, Greg can comment on this. Thanks. On Sun, Jul 14, 2019 at 06:55:30PM +0200, Markus Elfring wrote: > > --- > > Changes

[PATCH v5] staging: most: Delete an error message for a failed memory allocation

The kfifo_alloc() failure generates enough information and doesn't need to be accompanied by another error statement. Signed-off-by: Keyur Patel --- Changes in v5: - change subject line - simplify commit description - fix checkpatch warning - removed braces around if drivers/staging/most