[PATCH 1/1] staging: fbtft: Removes ";" from very used macro definition.

2018-08-09 Thread Leonardo Brás
All usages of this macro append the ";" at the end of line. It is not recommended nor necessary to append a ";" at the end of this macro definition. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 2/2] staging: fbtft: Adds space around "/"

2018-08-09 Thread Leonardo Brás
Kernel coding style recommends a space char around "/". Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 798a8fe98e95..25302ffc4

[PATCH 1/2] staging: fbtft: Moves "; " from macro definition to macro usage.

2018-08-09 Thread Leonardo Brás
This makes the macro usage more like a function declaration. Also, ending a macro definition with ";" is not recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v3 3/3] staging: fbtft: Corrects long index line - Style

2018-08-09 Thread Leonardo Brás
Reduces the index size to keep the code more readable. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-sysfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 2a5c630dab87

[PATCH v3 0/3] Style changes

2018-08-09 Thread Leonardo Brás
Some style changes to help readability. Leonardo Brás (3): staging: fbtft: Includes description to mutex and spinlock - Style staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style staging: fbtft: Corrects long index line - Style drivers/staging/fbtft/fbtft-sysfs.c | 5 ++- d

[PATCH v3 2/3] staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style

2018-08-09 Thread Leonardo Brás
Use of default macro BIT(n) instead of (1 << n). Helps readability. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging

[PATCH v3 1/3] staging: fbtft: Includes description to mutex and spinlock - Style

2018-08-09 Thread Leonardo Brás
Adds comments explaining what are the spinlock and mutex used for. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 798a8fe98e95

[PATCH v2 14/15] staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style

2018-08-07 Thread Leonardo Brás
Uses default macro BIT(n) instead (1 << n) Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index f77127

[PATCH v2 15/15] staging: fbtft: Replaces custom debug macro with dev_dbg().

2018-08-07 Thread Leonardo Brás
Changes custom macro to dev_dbg to avoid parameter multiple usage and use of typeof(). Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft

[PATCH v2 13/15] staging: fbtft: Corrects long index line - Style

2018-08-07 Thread Leonardo Brás
Avoids a very long line of index, improving readability. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-sysfs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 2a5c630dab87

[PATCH v2 12/15] staging: fbtft: Add spaces around / - Style

2018-08-07 Thread Leonardo Brás
Puts spaces around the /. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 8b79353c722a..83076eca9760 100644 --- a/drivers

[PATCH v2 07/15] staging: fbtft: Removes one nesting level to help readability - Style

2018-08-07 Thread Leonardo Brás
This nesting level was removed to improve readability. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/flexfb.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c index

[PATCH v2 08/15] staging: fbtft: Adjust some empty-line problems - Style

2018-08-07 Thread Leonardo Brás
Erases some blank lines. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_s6d02a1.c | 1 - drivers/staging/fbtft/fb_s6d1121.c | 1 + drivers/staging/fbtft/fb_ssd1289.c | 1 + drivers/staging/fbtft/fbtft_device.c | 2 -- 4 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v2 11/15] staging: fbtft: Includes description to mutex and spinlock - Style

2018-08-07 Thread Leonardo Brás
Includes description to mutex and spinlocks, as recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 6ee9ff320567

[PATCH v2 03/15] staging: fbtft: Fixes some alignment issues - Style

2018-08-07 Thread Leonardo Brás
Fixes (most) alignment issues pointed by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_ssd1289.c | 6 ++--- drivers/staging/fbtft/fb_ssd1351.c | 31 ++ drivers/staging/fbtft/fb_st7735r.c | 13 +++--- drivers/staging/fbtft/fb_st7789v.c

[PATCH v2 05/15] staging: fbtft: A bit more information on dev_err.

2018-08-07 Thread Leonardo Brás
Adds a bit more information on debug. The line break was to avoid obfuscating the parameters on the end of a large line. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_ssd1351.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft

[PATCH v2 09/15] staging: fbtft: Erases some repetitive usage of function name - Style

2018-08-07 Thread Leonardo Brás
Changes this functions to avoid using "blank" on debug twice. Improves log readability. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_sh1106.c | 2 +- drivers/staging/fbtft/fb_ssd1306.c | 2 +- drivers/staging/fbtft/fb_ssd1325.c | 2 +- drivers/staging/fbtft/fb_ssd

[PATCH v2 10/15] staging: fbtft: Fixes some defines styles - Style

2018-08-07 Thread Leonardo Brás
Fixing some styles as recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 10 ++ drivers/staging/fbtft/fbtft-core.c | 6 -- drivers/staging/fbtft/fbtft.h | 4 ++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git

[PATCH v2 06/15] staging: fbtft: Changes gamma table to define.

2018-08-07 Thread Leonardo Brás
Most of other "Gamma Tables" were already boxed on a define, just did the same to PIOLED. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft_device.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c

[PATCH v2 04/15] staging: fbtft: Fixes some lines long lines (>80) - Style

2018-08-07 Thread Leonardo Brás
Trying to keep the code in the 80-char line limit. Signed-off-by: Leonardo Brás diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c index 9276be499303..f5e0ec1c01dc 100644 --- a/drivers/staging/fbtft/fb_ssd1306.c +++ b/drivers/staging/fbtft/fb_ssd1306.c

[PATCH v2 02/15] staging: fbtft: Puts macro arguments in parenthesis to avoid precedence issues - Style

2018-08-07 Thread Leonardo Brás
Puts macro arguments in parenthesis to avoid precedence issues. Some large lines were broken to fit the 80-char limit. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_hx8347d.c | 2 +- drivers/staging/fbtft/fb_ili9163.c | 2 +- drivers/staging/fbtft/fb_ili9320.c | 2

[PATCH v2 01/15] staging: fbtft: Changes udelay(n) to usleep_range(n, n + x). - Style

2018-08-07 Thread Leonardo Brás
Changes some udelay(n) for n >= 10 to usleep_range(n, n+x) as recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- drivers/staging/fbtft/fb_ra8875.c | 4 ++-- drivers/staging/fbtft/fb_tinylcd.c | 2 +- drivers/staging/fb

[PATCH v2 00/15] staging: fbtft: Fixes some issues found with checkpatch.pl

2018-08-07 Thread Leonardo Brás
Fixes some issues found with checkpatch.pl, and other issues found browsing the code. Leonardo Brás (15): staging: fbtft: Changes udelay(n) to usleep_range(n, n + x). - Style staging: fbtft: Puts macro arguments in parenthesis to avoid precedence issues - Style staging: fbtft: Fixes

[PATCH 05/11] staging: fbtft: Erases some repetitive usage of function name - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_sh1106.c | 2 +- drivers/staging/fbtft/fb_ssd1306.c | 2 +- drivers/staging/fbtft/fb_ssd1325.c | 2 +- drivers/staging/fbtft/fb_ssd1331.c | 2 +- drivers/staging/fbtft/fb_uc1611.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions

[PATCH 10/11] staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 3f3dcd96f9a7..41ac00239aa3 100644 --- a/drivers/staging

[PATCH 11/11] staging: fbtft: Includes parenthesis around macro parameters and avoids multiple usage of macro parameter - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 41ac00239aa3..eb2bdc4870be 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b

[PATCH 07/11] staging: fbtft: Includes description to mutex and spinlock - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index d8e7204a8d74..3f3dcd96f9a7 100644 --- a/drivers/staging/fbtft/fbtft.h +++ b/drivers/staging

[PATCH 09/11] staging: fbtft: Corrects long index line - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-sysfs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 8327f8f26ab1..99c8c9a636b5 100644 --- a/drivers/staging/fbtft/fbtft

[PATCH 08/11] staging: fbtft: Add spaces around / - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index a9ee586ee6ba..4c71106d3b71 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b

[PATCH 06/11] staging: fbtft: Fixes some defines styles - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 10 ++ drivers/staging/fbtft/fbtft-core.c | 6 -- drivers/staging/fbtft/fbtft.h | 4 ++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging

[PATCH 04/11] staging: fbtft: Adjust some empty-line problems - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_s6d02a1.c | 1 - drivers/staging/fbtft/fb_s6d1121.c | 1 + drivers/staging/fbtft/fb_ssd1289.c | 1 + drivers/staging/fbtft/fbtft_device.c | 2 -- 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/fbtft

[PATCH 03/11] staging: fbtft: Fixes some alignment and line > 80 char issues - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_ssd1289.c | 6 +-- drivers/staging/fbtft/fb_ssd1306.c | 3 +- drivers/staging/fbtft/fb_ssd1331.c | 9 - drivers/staging/fbtft/fb_ssd1351.c | 43 + drivers/staging/fbtft/fb_st7735r.c | 19

[PATCH 02/11] staging: fbtft: Puts macro arguments in parenthesis to avoid precedence issues - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_hx8347d.c | 2 +- drivers/staging/fbtft/fb_ili9163.c | 2 +- drivers/staging/fbtft/fb_ili9320.c | 2 +- drivers/staging/fbtft/fb_ili9325.c | 2 +- drivers/staging/fbtft/fb_ili9341.c | 2 +- drivers/staging/fbtft/fb_s6d1121

[PATCH 01/11] staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style

2018-08-06 Thread Leonardo Brás
Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- drivers/staging/fbtft/fb_ra8875.c | 4 ++-- drivers/staging/fbtft/fb_tinylcd.c | 2 +- drivers/staging/fbtft/fb_upd161704.c | 19 +-- drivers/staging/fbtft/fb_watterott.c | 4 ++-- 5

[PATCH 00/11] Style Fixes on fbtft

2018-08-06 Thread Leonardo Brás
I did some style fixes on staging/fbtft using scripts/checkpatch.pl. Please feel free to suggest any changes. Leonardo Brás (11): staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style staging: fbtft: Puts macro arguments in parenthesis to avoid precedence issues - Style