All usages of this macro append the ";" at the end of
line. It is not recommended nor necessary to append
a ";" at the end of this macro definition.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Kernel coding style recommends a space char around "/".
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 798a8fe98e95..25302ffc4
This makes the macro usage more like a function declaration.
Also, ending a macro definition with ";" is not
recommended by checkpatch.pl.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-bus.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Reduces the index size to keep the code more readable.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-sysfs.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c
b/drivers/staging/fbtft/fbtft-sysfs.c
index 2a5c630dab87
Some style changes to help readability.
Leonardo Brás (3):
staging: fbtft: Includes description to mutex and spinlock - Style
staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style
staging: fbtft: Corrects long index line - Style
drivers/staging/fbtft/fbtft-sysfs.c | 5 ++-
d
Use of default macro BIT(n) instead of (1 << n). Helps readability.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 56 +--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging
Adds comments explaining what are the spinlock and mutex used for.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 798a8fe98e95
Uses default macro BIT(n) instead (1 << n)
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 56 +--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index f77127
Changes custom macro to dev_dbg to avoid parameter multiple usage and use of
typeof().
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft
Avoids a very long line of index, improving readability.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-sysfs.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c
b/drivers/staging/fbtft/fbtft-sysfs.c
index 2a5c630dab87
Puts spaces around the /.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index 8b79353c722a..83076eca9760 100644
--- a/drivers
This nesting level was removed to improve readability.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/flexfb.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index
Erases some blank lines.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_s6d02a1.c | 1 -
drivers/staging/fbtft/fb_s6d1121.c | 1 +
drivers/staging/fbtft/fb_ssd1289.c | 1 +
drivers/staging/fbtft/fbtft_device.c | 2 --
4 files changed, 2 insertions(+), 3 deletions(-)
diff --git
Includes description to mutex and spinlocks, as recommended by checkpatch.pl.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 6ee9ff320567
Fixes (most) alignment issues pointed by checkpatch.pl.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_ssd1289.c | 6 ++---
drivers/staging/fbtft/fb_ssd1351.c | 31 ++
drivers/staging/fbtft/fb_st7735r.c | 13 +++---
drivers/staging/fbtft/fb_st7789v.c
Adds a bit more information on debug.
The line break was to avoid obfuscating the parameters on the end of a large
line.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_ssd1351.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft
Changes this functions to avoid using "blank" on debug twice. Improves log
readability.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_sh1106.c | 2 +-
drivers/staging/fbtft/fb_ssd1306.c | 2 +-
drivers/staging/fbtft/fb_ssd1325.c | 2 +-
drivers/staging/fbtft/fb_ssd
Fixing some styles as recommended by checkpatch.pl.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-bus.c | 10 ++
drivers/staging/fbtft/fbtft-core.c | 6 --
drivers/staging/fbtft/fbtft.h | 4 ++--
3 files changed, 12 insertions(+), 8 deletions(-)
diff --git
Most of other "Gamma Tables" were already boxed on a define, just did the same
to PIOLED.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft_device.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
Trying to keep the code in the 80-char line limit.
Signed-off-by: Leonardo Brás
diff --git a/drivers/staging/fbtft/fb_ssd1306.c
b/drivers/staging/fbtft/fb_ssd1306.c
index 9276be499303..f5e0ec1c01dc 100644
--- a/drivers/staging/fbtft/fb_ssd1306.c
+++ b/drivers/staging/fbtft/fb_ssd1306.c
Puts macro arguments in parenthesis to avoid precedence issues.
Some large lines were broken to fit the 80-char limit.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_hx8347d.c | 2 +-
drivers/staging/fbtft/fb_ili9163.c | 2 +-
drivers/staging/fbtft/fb_ili9320.c | 2
Changes some udelay(n) for n >= 10 to usleep_range(n, n+x) as recommended by
checkpatch.pl.
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
drivers/staging/fbtft/fb_ra8875.c | 4 ++--
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
drivers/staging/fb
Fixes some issues found with checkpatch.pl, and other issues found browsing the
code.
Leonardo Brás (15):
staging: fbtft: Changes udelay(n) to usleep_range(n, n + x). - Style
staging: fbtft: Puts macro arguments in parenthesis to avoid
precedence issues - Style
staging: fbtft: Fixes
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_sh1106.c | 2 +-
drivers/staging/fbtft/fb_ssd1306.c | 2 +-
drivers/staging/fbtft/fb_ssd1325.c | 2 +-
drivers/staging/fbtft/fb_ssd1331.c | 2 +-
drivers/staging/fbtft/fb_uc1611.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 56 +--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 3f3dcd96f9a7..41ac00239aa3 100644
--- a/drivers/staging
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 41ac00239aa3..eb2bdc4870be 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index d8e7204a8d74..3f3dcd96f9a7 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-sysfs.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c
b/drivers/staging/fbtft/fbtft-sysfs.c
index 8327f8f26ab1..99c8c9a636b5 100644
--- a/drivers/staging/fbtft/fbtft
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
index a9ee586ee6ba..4c71106d3b71 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fbtft-bus.c | 10 ++
drivers/staging/fbtft/fbtft-core.c | 6 --
drivers/staging/fbtft/fbtft.h | 4 ++--
3 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c
b/drivers/staging
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_s6d02a1.c | 1 -
drivers/staging/fbtft/fb_s6d1121.c | 1 +
drivers/staging/fbtft/fb_ssd1289.c | 1 +
drivers/staging/fbtft/fbtft_device.c | 2 --
4 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_ssd1289.c | 6 +--
drivers/staging/fbtft/fb_ssd1306.c | 3 +-
drivers/staging/fbtft/fb_ssd1331.c | 9 -
drivers/staging/fbtft/fb_ssd1351.c | 43 +
drivers/staging/fbtft/fb_st7735r.c | 19
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_hx8347d.c | 2 +-
drivers/staging/fbtft/fb_ili9163.c | 2 +-
drivers/staging/fbtft/fb_ili9320.c | 2 +-
drivers/staging/fbtft/fb_ili9325.c | 2 +-
drivers/staging/fbtft/fb_ili9341.c | 2 +-
drivers/staging/fbtft/fb_s6d1121
Signed-off-by: Leonardo Brás
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
drivers/staging/fbtft/fb_ra8875.c | 4 ++--
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
drivers/staging/fbtft/fb_upd161704.c | 19 +--
drivers/staging/fbtft/fb_watterott.c | 4 ++--
5
I did some style fixes on staging/fbtft using scripts/checkpatch.pl.
Please feel free to suggest any changes.
Leonardo Brás (11):
staging: fbtft: Changes udelay(n) to usleep_range(n, n + 1). - Style
staging: fbtft: Puts macro arguments in parenthesis to avoid
precedence issues - Style
35 matches
Mail list logo