Re: [PATCH] [media] davinci-vpfe: Fix retcode check

econd argument. Did it cause a build warning for you? (Can't really check since I don't have ARM cross compilers close-by) If not, then: Reviewed-by: Levente Kurusa Thanks, Levente Kurusa ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: rtl8821ae: rtl8821ae: hw.c: Cleaning up if statement that always evaluates to false

t; rtl_write_byte(rtlpriv, (MSR), bt_msr); > > rtlpriv->cfg->ops->led_control(hw, ledaction); > > - if ((bt_msr & ~0xfc) == MSR_AP) > > + if ((bt_msr & MSR_AP) == MSR_AP) I changed this line from '0xfc' to '~0xfc', and looking at t

[PATCH] staging: rtl8821ae: fix pointer coding style

Found by checkpatch. Signed-off-by: Levente Kurusa --- drivers/staging/rtl8821ae/pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c index a562aa6..7bbaef7 100644 --- a/drivers/staging/rtl8821ae/pci.c

Re: [PATCH] Staging: octeon-usb: fixed a macro coding style issue

> (0)) > +#define (CVMX_PREFETCH(address, offset) asm volatile ("pref %[type], > %[off](%[rbase])" : : [rbase] "d" (address), [off] "I" (offset), [type] "n" > (0))) Not that way around! :-) The parantheses should be around the code block not the name b

Re: [PATCH] staging: comedi: fix memory leak

On 03/15/2014 04:30 AM, Chase Southwood wrote: >> On Friday, March 14, 2014 11:47 AM, Levente Kurusa wrote: > >> Call kfree() on bdev. The variable is otherwise leaked. >> >> Signed-off-by: Levente Kurusa >> [...] >> > > > Levente, > > Th

[PATCH] staging: comedi: fix memory leak

Call kfree() on bdev. The variable is otherwise leaked. Signed-off-by: Levente Kurusa --- drivers/staging/comedi/drivers/comedi_bond.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/comedi_bond.c b/drivers/staging/comedi/drivers/comedi_bond.c index 51a59e5

[PATCH] staging: davinci_vpfe: fix error check

The check would check the pointer, which is never less than 0. According to the error message, the correct check would be to check the return value of ipipe_mode. Check that instead. Reported-by: David Binderman Signed-off-by: Levente Kurusa --- drivers/staging/media/davinci_vpfe

Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check

On 02/15/2014 11:36 AM, Dan Carpenter wrote: > On Sat, Feb 15, 2014 at 08:53:34AM +0100, Levente Kurusa wrote: >> Thanks Dan, maybe you know some people who could test it? >> RTLXX guys? Or maybe we can take the patch as is? >> I cannot really think of any other solutio

[PATCH] staging: rts5208: fix always true condition

ANDing anything with 0x1E and expecting it to be not 0x03 will always be true. AND instead with 0x03, so that we check the last two bits, which should be what was intended there. Reported-by: David Binderman Signed-off-by: Levente Kurusa --- drivers/staging/rts5208/sd.c | 2 +- 1 file changed

Re: [PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check

se, but since that was written to the file, there must have been some logic behind that. I am slightly disappointed get_maintainer didn't really find anybody for this patch... Greg, can you take it as is or you would need the RFC tag removed? (ie, repost) Maybe you know

[PATCH] [RFC] staging: rtl8821ae: fix invalid bit mask on MSR_AP check

Since MSR_AP is 0x3, ANDing it with 0xFC will never be true. Add a NOT operation to 0xFC so that we will AND with the last three bits which will result in a possibility that the condition will succeed. Signed-off-by: Levente Kurusa --- Hi, This might not be the real solution since it is also

Re: [PATCH V3 1/1] Drivers: hv: Implement the file copy service

on.message; > + copy_size = sizeof(struct hv_start_fcopy); > + if (count < copy_size) > + return 0; > + } else { > + src = fcopy_transaction.fcopy_msg; > + copy_size = sizeof(struct hv_do_fcopy);

Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

D_REALTIME_WAKEUP); > + return type == ANDROID_ALARM_RTC_WAKEUP || > +type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP; > } This is the fourth patch that does the exact same, an other similar patch was already applied, hence this one will not apply. Please base your patches on -nex

Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

gt; -- This is like the third patch in this two week period that does the exact same with more or less success, and I recall one getting applied (I might be wrong). Anyway, this one finally looks good! :-) -- Regards, Levente Kurusa _

Re: [PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments.

0F007094, 0x0104}, -//# Enable start bit within memory controller +/*# Enable start bit within memory controller */ Again, no space and there is that '#' which looks pretty bad. -- Regards, Levente Kurusa ___