: de...@driverdev.osuosl.org
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changes v1 -> v2:
- rebase on current staging/staging-next, fix conflicts
- mention the commit that removed bRxRSSIDisplay since it's now
committed on staging
---
drivers/staging/rtl8188eu/core/rtw_
Not referenced anymore since the removal of field bRxRSSIDisplay in
struct adapter.
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Ivan Safonov <insafo...@gmail.com>
Cc: de...@driverdev.osuosl.org
Signed-off-by
that is being
removed, so remove it as well.
Also fix coding style issues in the touched lines.
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Ivan Safonov <insafo...@gmail.com>
Cc: de...@driverdev.osuosl.org
Signed-off-by: Luca
well.
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Ivan Safonov <insafo...@gmail.com>
Cc: de...@driverdev.osuosl.org
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/staging/rtl8188eu/core/rtw_m
(in a proper way) the mentioned
debugging features, they can still fetch this code from the git
history.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Kyle Kuffermann <kyle.kufferm...@gmail.com>
Cc: Binoy Jayan <binoy.ja...
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
As they are not used anywhere, and also violate the coding style
rules, remove them.
Signed-off-by: Luca Ceresoli &l
These functions have been declared without any implementation since
the first commit (58c434013a22fccfdb14abc2bb8408ca29073b76) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundatio
These functions have been declared without any implementation since
the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net
Since the removal of rtw_proc_init_one() the proc filesystem is not
mentioned in this driver. So this include becomes useless.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Arnd Bergmann <a...@arndb.de>
Cc: Bin
This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartma
Dear Kalle,
thanks for your feedback.
On 02/09/2016 18:18, Kalle Valo wrote:
> Luca Ceresoli <l...@lucaceresoli.net> writes:
>
>> These functions have been declared without any implementation since
>> the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and ther
Since the removal of rtw_proc_init_one() the proc filesystem is not
mentioned in this driver. So this include becomes useless.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Arnd Bergmann <a...@arndb.de>
Cc: Bin
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
As they are not used anywhere, and also violate the coding style
rules, remove them.
Signed-off-by: Luca Ceresoli &l
(in a proper way) the mentioned
debugging features, they can still fetch this code from the git
history.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Kyle Kuffermann <kyle.kufferm...@gmail.com>
Cc: Binoy Jayan <binoy.ja...
These functions have been declared without any implementation since
the first commit (58c434013a22fccfdb14abc2bb8408ca29073b76) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundatio
This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartma
These functions have been declared without any implementation since
the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net
Dear Andy,
thanks for your review.
On 28/08/2016 14:28, Andy Shevchenko wrote:
> On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote:
>
> Put here few words _why_ you are doing this.
I'm doing it because this function is only used inside rtw_recv.c. Which
is quite logical, s
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Cc: Geliang Tang <geliangt...@163.com>
Cc: Jakub Sit
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Kyle Kuffermann <kyle.kufferm...@gmail.com>
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/rtl8188eu/include/recv_osdep.h | 4
1 file changed, 4 deleti
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org&
The proc filesystem is not used in this driver.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Arnd Bergmann <a...@arndb.de>
Cc: Binoy Jayan <binoy.ja...@linaro.org>
Cc: Anish Bhatt <an...@gatech.edu>
Cc:
want to implement (in a proper way) the mentioned
debugging features, they can still fetch these functions from the git
history.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Kyle Kuffermann <kyle.kufferm...@gmail.com&g
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Jes Sorensen <jes.soren...@redhat.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: linux-wirel...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
---
d
Dear Greg,
Greg Kroah-Hartman wrote:
On Wed, Dec 02, 2015 at 10:54:00PM +0100, Luca Ceresoli wrote:
Fix checkpatch issue:
CHECK: spaces preferred around that '*' (ctx:VxV)
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc
The first argument to memset() is (void *), the explicit typecasts are
not needed. They just make code less readable.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>
---
drivers/stag
There is such a field both in struct mlme_ext_info and in struct
registry_priv. Rename both.
Also fix checkpatch issue in the lines touched:
WARNING: line over 80 characters
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg K
Using the ternary operator allows to more concisely write the same
code, and to stay within 80 characters without even increasing the
number of lines.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <g
Fix checkpatch issue:
CHECK: spaces preferred around that '*' (ctx:VxV)
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 4 ++--
This line is connented since the initial import in commit 7b464c9fa5cc
("staging: r8188eu: Add files for new driver - part 4") and there's no
comment stating how it could ever be useful.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwf
field of struct registry_priv.
Raises a new checkpatch issue, which is fixed in a later commit:
CHECK: Avoid CamelCase:
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>
---
drivers
rtw_set_ie() is a memcpy-like function, taking addresses of memory buffers
among its parameters. Similarly to memcpy, change the parameters to be
void*. This will allow to get rid of typecasts whenever it is called.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <
This comment gives pretty much the same information as the name of the
function that it immediately precedes.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>
---
drivers/stag
pmlmeinfo->ADDBA_req is accessed three times in this function, but it
contributes to generating lines above 80 characters that are not easy to
split in a nice way.
Extract a pointer to it to make code slightly more concise and fix some
lines over 80 characters.
Signed-off-by: Luca Ceresoli
Dear Larry,
Larry Finger wrote:
On 09/14/2015 05:34 PM, Luca Ceresoli wrote:
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed from rtw_mlme_ext.h, in a later commit
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
Dear Larry,
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>
Empty commit messages are generally not accepted.
Mean
Even though it is declared in an include file, it is used only in
rtw_cmd.c.
There's even a preprocessor guard to make sure it is not visible in other
modules. It is now useless, so remove it.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg
They are just wrappers to the standard semaphore functions.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg Kroah-Hartman gre...@linux.com
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c| 20 ++--
drivers/staging
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Jes Sorensen jes.soren...@redhat.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8723au/include/rtw_cmd.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging
Even though it is declared in an include file, it is used only in
rtw_cmd.c.
There's even a preprocessor guard to make sure it is not visible in other
modules. It is now useless, so remove it.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg
All usages of this macro have been removed in earlier commits, so get rid
of it.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg Kroah-Hartman gre...@linux.com
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 1 -
1 file changed, 1 deletion
These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg Kroah-Hartman gre...@linux.com
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 11
This macro has no added value, it makes uselessly code more verbose.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg Kroah-Hartman gre...@linux.com
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 31
1 file
they are
referenced, without the need for forward declarations.
Also move near the beginning of the file the collect_bss_info() and
process_80211d(), since they are called from the report_*() functions.
This commit only reorders code, there is no content change.
Signed-off-by: Luca Ceresoli l
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg Kroah-Hartman gre...@linux.com
---
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b
Jes for one patch,
that he also promptly acked -- thanks Jes). You already received these
patches at the first round and you are getting them again. You can safely
delete either this or the other copy, they are identical.
Luca Ceresoli (16):
staging: rtl8188eu: rtw_mlme_ext.c: reorder the report
rtw_init_cmd_priv() is called in one place only, and from another file.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Greg Kroah-Hartman gre...@linux.com
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 13 -
drivers/staging
-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 16
drivers/staging/rtl8188eu/include/hal_intf.h | 5 -
2 files changed, 21 deletions(-)
diff --git
rtw_hal_set_def_var() is never referenced, so remove it.
It used to be the only place where the SetHalDefVarHandler callback was
called, so get rid of the function pointer as well.
Also remove the callback itself, SetHalDefVar8188EUsb(), which was not
called anywhere else.
Signed-off-by: Luca
rtw_hal_write_rfreg() is never referenced, so remove it.
It used to be the only place where the write_rfreg callback was
called, so get rid of the function pointer as well.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin
If CONFIG_88EU_AP_MODE is undefined, issue_asocrsp() is never referenced.
Fixes warning:
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:891:13: warning:
‘issue_asocrsp’ defined but not used [-Wunused-function]
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Fixes: 782eddd748d9 (staging
If CONFIG_88EU_AP_MODE is undefined, OnAuth() is never referenced.
Fixes warning:
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2725:21: warning: ‘OnAuth’
defined but not used [-Wunused-function]
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Fixes: 68345dd7bc26 (staging: rtl8188eu
The is_valid_p2p_probereq is never referenced in the function body.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Jes Sorensen jes.soren...@redhat.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 8
These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 57
These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 60
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers
is_valid_p2p_probereq is initialized to false and never modified. Code
depending on it is dead code. Remove all of it.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core
The is_valid_p2p_probereq is never referenced in the function body.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++---
1 file changed, 2 insertions
/osdep_service.h.
Change rtw_start_drv_threads() to return a proper 0-or-error value.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Dan Carpenter dan.carpen...@oracle.com
---
I think _SUCCESS and _FAIL
step 2 does mean much as there is no step 1 stated anywhere...
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman g...@kroah.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Florian Schilhabel florian.c.schilha...@googlemail.com
---
drivers/staging/rtl8712/os_intfs.c | 1
step 2 does mean much as there is no step 1 stated anywhere...
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 -
1
Even though these are not reported by checkpatch, they are coding style issues.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
Changes since v1:
- Fix a misplaced empty line (reported by Larry Finger
Dear Larry,
Larry Finger wrote:
On 05/13/2015 05:08 PM, Luca Ceresoli wrote:
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
Dear Dan,
Dan Carpenter wrote:
On Thu, May 14, 2015 at 12:08:49AM +0200, Luca Ceresoli wrote:
I think _SUCCESS and _FAIL should be totally eradicated and replaced with
proper error codes and my intent is to do it all over the codebase.
However, since that would be a massive change, I'm sending
Dear Larry,
Larry Finger wrote:
On 05/13/2015 05:08 PM, Luca Ceresoli wrote:
Several functions in this driver return a boolean: _SUCCESS = 1 on
success,
_FAIL = 0 on error, defined in
drivers/staging/rtl8188eu/include/osdep_service.h.
The common practice in the Linux kernel is to return 0
Also remove them from .h files.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/include/osdep_intf.h | 2 --
drivers/staging/rtl8188eu/include/recv_osdep.h | 3 ---
drivers
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman g...@kroah.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Florian Schilhabel florian.c.schilha...@googlemail.com
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++
1 file changed, 3
step 2 does mean much as there is no step 1 stated anywhere...
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman g...@kroah.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Florian Schilhabel florian.c.schilha...@googlemail.com
---
drivers/staging/rtl8712/os_intfs.c | 1
Even though these are not reported by checkpatch, they are coding style issues.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman g...@kroah.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Florian Schilhabel florian.c.schilha...@googlemail.com
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging
step 2 does mean much as there is no step 1 stated anywhere...
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
Cc: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 -
1
value also
describes the kind of error that happened, while a boolean squashes all errors
down a unique value.
Change rtw_start_drv_threads() to return a proper 0-or-error value.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 38 ++---
1 file changed, 29 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index
There are identical comments near the static variable declaration, around
lines 118~120.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 9cd3a84
This code is commented since the initial commit. Probably it is a remnant of
old code.
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index e5e9235..9cd3a84 100644
The comment /* open system */ is repeated verbatim in several places where
dot11AuthAlgrthm_Open is referenced, but not where it is declared.
Move it to be only at its declaration.
This also fixes some line over 80 characters checkpatch warnings.
Signed-off-by: Luca Ceresoli l
step 2 does mean much as there is no step 1 stated anywhere...
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep
Dear Greg,
Greg Kroah-Hartman wrote:
On Tue, Jan 13, 2015 at 11:33:03PM +0100, Luca Ceresoli wrote:
Fixes dozens of sparse warnings like:
warning: symbol 'cfs_tracefile_sem' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: Jinshan Xiong jinshan.xi...@intel.com
Cc: Srikrishan Malik srikrishanma...@gmail.com
Cc: hpdd-disc...@lists.01.org
Cc
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: Jinshan Xiong jinshan.xi...@intel.com
Cc: Srikrishan Malik srikrishanma...@gmail.com
Cc: hpdd-disc...@lists.01.org
Cc
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: Jinshan Xiong jinshan.xi...@intel.com
Cc: Srikrishan Malik srikrishanma...@gmail.com
Cc: hpdd-disc...@lists.01.org
Cc
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: Jinshan Xiong jinshan.xi...@intel.com
Cc: Srikrishan Malik srikrishanma...@gmail.com
Cc: hpdd-disc...@lists.01.org
Cc
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: Jinshan Xiong jinshan.xi...@intel.com
Cc: Srikrishan Malik srikrishanma...@gmail.com
Cc: hpdd-disc...@lists.01.org
Cc
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: Jinshan Xiong jinshan.xi...@intel.com
Cc: Srikrishan Malik srikrishanma...@gmail.com
Cc: hpdd-disc...@lists.01.org
Cc
://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-January/063751.html
Luca Ceresoli (6):
staging: lustre: mdc: declare internal symbols as static
staging: lustre: lmv: declare internal symbols as static
staging: lustre: libcfs: declare internal symbols as static
staging: lustre: llite
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c | 5 -
1 file changed, 5 deletions(-)
diff --git
Fixes dozens of sparse warnings like:
warning: symbol 'cfs_tracefile_sem' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Peng Tao bergw...@gmail.com
Cc: Jinshan Xiong jinshan.xi...@intel.com
Cc: Srikrishan Malik srikrishanma...@gmail.com
Cc: hpdd
Signed-off-by: Luca Ceresoli l...@lucaceresoli.net
Cc: Greg Kroah-Hartman gre...@linux.com
Cc: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging
96 matches
Mail list logo
