Re: [PATCH] staging: et131x: Remove et131x driver from drivers/staging

On Sat, Oct 04, 2014 at 01:37:31AM +0300, Dan Carpenter wrote: > Congrats. :) > > regards, > dan carpenter > And thanks for all the help, both! Cheers, Mark ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/

Re: [PATCH] et131x: Promote staging et131x driver to drivers/net

On Tue, Sep 30, 2014 at 12:32:01PM -0700, Greg KH wrote: > > This is a fine way to make a patch, but it's no way that any of the > netdev developers could ever review it to know what the code happens to > look like in my staging-next branch :( > > How about just sending a patch that adds the driv

[PATCH] et131x: Promote staging et131x driver to drivers/net

This patch moves the et131x gigabit ethernet driver from drivers/staging to drivers/net/ethernet/agere. Signed-off-by: Mark Einon --- This patch appiles to both staging-next and the linux-next tag next-20140930, and takes into account all feedback recieved from the recent RFC for this patch

Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message

On Tue, Sep 30, 2014 at 11:25:43PM +0530, Karthik Nayak wrote: > Removes the 'out of memory' warning issued by checkpatch > > Signed-off-by: Karthik Nayak > --- Hi, I'm not sure which tree you're working agianst, but this change has already been made and is on both staging-next and linux-next.

Re: [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote: > 1. WARNING: else is not generally useful after a break or return > > 2. WARNING: quoted string split across lines > > 3. WARNING: break quoted strings at a space character > > Signed-off-by: Karthik Nayak > --- Hi again, You pro

[PATCH 2/2 resend] staging: et131x: Simplify for loop in et131x_init_send()

The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2 resend] staging: et131x: Audit and update comments

were just plain incorrect. Remove these too. Signed-off-by: Mark Einon --- Resending after refresh against current head of staging-next, as previous patch only applied with fuzz. drivers/staging/et131x/et131x.c | 328 +++ 1 file changed, 21 insertions(+), 307

[PATCH 2/2] staging: et131x: Simplify for loop in et131x_init_send()

The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH 1/2] staging: et131x: Audit and update comments

were just plain incorrect. Remove these too. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 328 +++- 1 file changed, 21 insertions(+), 307 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 0a927d2

Re: [PATCH 5/8] staging: et131x: Reduce split lines by renaming some psr variables

On Wed, Sep 24, 2014 at 03:01:58PM +0300, Dan Carpenter wrote: > > In vim you can just use the '*' key to search for a variable. The extra > "i" really needs to mean somethingi, it shouldn't just be there because > to work around a bad editor. Also there are lots of "mii_" names in > this file s

Re: [PATCH 5/8] staging: et131x: Reduce split lines by renaming some psr variables

On Wed, Sep 24, 2014 at 01:11:42PM +0300, Dan Carpenter wrote: > On Mon, Sep 22, 2014 at 08:58:14PM +0100, Mark Einon wrote: > > static void et131x_rx_dma_memory_free(struct et131x_adapter *adapter) > > { > > u8 id; > > - u32 index; > > + u32 ii

Re: [PATCH v2] et131x: Promote staging et131x driver to drivers/net

On Tue, Sep 23, 2014 at 02:07:17PM -0700, Joe Perches wrote: > On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote: > > This patch moves the et131x gigabit ethernet driver from drivers/staging > > to drivers/net/ethernet/agere. > > checkpatch type modification you might

[PATCH 2/4] staging: et131x: Cat some lines less than 80 columns

Some split lines are less than 80 chars if rejoined, so rejoin them. Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging

[PATCH 3/4] staging: et131x: Remove unnecessary OOM message

Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f5459ec..cd90831 100644 --- a/drivers/staging/et131x/et131x.c

[PATCH 4/4] staging: et131x: Remove unnecessary parentheses

Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index cd90831..0a927d2 100644 --- a/drivers/staging/et131x

[PATCH 1/4] staging: et131x: Use ether_addr_copy when copying ethernet addresses

Reported-by: Joe Perches Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 4b2ae49..b976c75 100644 --- a/drivers/staging/et131x

[PATCH v2] et131x: Promote staging et131x driver to drivers/net

This patch moves the et131x gigabit ethernet driver from drivers/staging to drivers/net/ethernet/agere. Signed-off-by: Mark Einon --- Changes from v1: -modified MAINTAINERS in scope with changes -Fixed typo in Kconfig, Atheros -> Agere -Made review changes from Tobias Klauser, see patch

[PATCH 1/4] staging: et131x: zero allocation of fbr to prevent random address access

br memory on allocation. Subsequent frees of this fbr memory explicitly zeros the ring_virtaddr value. Reported-by: Tobias Klauser Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH 3/4] staging: et131x: Add space after { in pci ID table

Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 6539a8a..10f20b3 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/et131x

[PATCH 4/4] staging: et131x: Remove unnecessary defines to enable driver PM

The Power Management functions can be conditional by assigning pm ops directly to .driver.pm, instead of using #ifdef's, saving some lines of code. Reported-by: Tobias Klauser Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 7 ++- 1 file changed, 2 insertions(

[PATCH 2/4] staging: et131x: don't cast a void* to a struct pointer

Casting a void* popinter to a struct pointer is unnecessary, don't do it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 2889f86..65

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

On Tue, Sep 23, 2014 at 12:01:07PM +0200, Tobias Klauser wrote: > On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote: > > On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote: > > > > Hi Tobias, > > > > Thanks for the d

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

On Tue, Sep 23, 2014 at 09:56:53AM +1000, Angus Gibson wrote: > > +config NET_VENDOR_AGERE > > + bool "Agere devices" > > + default y > > + depends on PCI > > + ---help--- > > + If you have a network (Ethernet) card belonging to this class, say = > > Y > > + and read the Ethernet-HO

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

On Mon, Sep 22, 2014 at 06:57:25PM -0700, Joe Perches wrote: > On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote: > > This patch moves the et131x gigabit ethernet driver from drivers/staging > > to drivers/net/ethernet/agere. > > > > There are no known issues at t

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote: Hi Tobias, Thanks for the details review. I've replied below - [...] > > +/* et131x_rx_dma_memory_alloc > > + * > > + * Allocates Free buffer ring 1 for sure, free buffer ring 0 if required, > > + * and the Packet Status Ring. > > +

[PATCH 4/8] staging: et131x: Reduce split lines in et131x_rx_dma_memory_alloc()

Modify temporary variables so that split lines can be reduced: index -> k fbr_tmp_physaddr -> fbr_physaddr Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et13

[PATCH 7/8] staging: et131x: Reduce split lines by renaming flowcontrol

Rename adapter->flowcontrol to adapter->flow, reducing split lines. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/

[PATCH 3/8] staging: et131x: Remove unused ce_stats struct member

This ce_stats struct member is no longer used. Remove it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index d3615ae..f1bf33b 100644 --- a/drivers/staging/et131x

[PATCH 5/8] staging: et131x: Reduce split lines by renaming some psr variables

Modify some packet status ring associated variables to save a few split lines: pktstat_ringsize -> psr_size psr_num_entries -> psr_entries index -> ii Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 39 +-- 1 file changed, 17 i

[PATCH 8/8] staging: et131x: Remove TODO item regarding split lines

Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 01d9351..13c8168 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -8,7 +8,6 @@ Note

[PATCH 6/8] staging: et131x: Use braces on all arms of if/else in et131x_handle_recv_pkts

The 'if' blocks have braces, so the 'else' blocks should too. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index a00

[PATCH 2/8] staging: et131x: Remove unused MP_TCB defines

These two defines are not used, so remove them. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 358db97..d3615ae 100644 --- a/drivers/staging/et131x

[PATCH 1/8] staging: et131x: Remove unused et131x_adapter struct members

These two adapter struct members are not used, remove them. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index eefa9f1..358db97 100644 --- a/drivers

[PATCH 01/12 v2] staging: et131x: Remove extra blank lines in et131x.h

Remove some blank lines from et131.h, including double blank lines. Signed-off-by: Mark Einon --- Fixing minor typo in commit log. drivers/staging/et131x/et131x.h | 43 - 1 file changed, 43 deletions(-) diff --git a/drivers/staging/et131x/et131x.h b

[PATCH 01/12] staging: et131x: Remove extra blank lines in et131x.h

Remove some blank lines from et131.h, including dounble blank lines. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.h | 43 - 1 file changed, 43 deletions(-) diff --git a/drivers/staging/et131x/et131x.h b/drivers/staging/et131x/et131x.h

[PATCH 09/12] staging: et131x: logical continuations should be on the previous line

Fix two occurrences of the checkpatch check: CHECK: Logical continuations should be on the previous line Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging

[PATCH 11/12] staging: et131x: Use braces on all arms of if/else statements

In some places in et131x.c, one arm of am if/else statement has braces and the other not - put braces on both arms where this happens. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 12/12] staging: et131x: Use variable names instead of types in sizeof

A few calls to sizeof() in et131x.c give the type as a parameter - use the equivalent variable name instead. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging

[PATCH 04/12] staging: et131x: Remove send_hw_lock spinlock

We don't need to use this lock - the tx path is protected by the networking subsystem xmit_lock, so we don't also need it in nic_send_packet(). The other use of this spinlock in et1310_enable_phy_coma() to protect a low power flag makes no sense, so can just be removed. Signed-off-by:

[PATCH 02/12] staging: et131x: Remove blank lines form et131x.c

Remove some unecessary blank lines from et131x.c Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 8da4883..74d5f309 100644 --- a/drivers/staging

[PATCH 10/12] staging: et131x: Remove spaces after casts

In three places in et131x.c, spaces exist after a cast. Remove them. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 17a3a36..c6b5193

[PATCH 08/12] staging: et131x: Fix 'else is not generally useful after a break or return'

Fix this checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c

[PATCH 07/12] staging: et131x: Fix indenting using mixed tabs and spaces

Fix two lines where mixed tabs and spaces were used for indenting. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 8b2f9a9..c158b01

[PATCH 05/12] staging: et131x: Remove useless assignment to NULL

The stack variable skb is no longer used after it's set to NULL. Don't set it to NULL. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131

[PATCH 03/12] staging: et131x: Simplify unlocking tcb_send_qlock in et131x_tx_timeout()

the tx_global_lock, so this shouldn't matter. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 74d5f309..ef3a076 100644 --- a/drivers

[PATCH 06/12] staging: et131x: Add spinlock definition comments

Checkpatch --strict advises that spinlocks should be described when defined, seems a good idea so this change does that. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

On Sat, Sep 13, 2014 at 11:57:51PM +0300, Dan Carpenter wrote: > On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > > I don't think we can make this 100% foolproof without knowing which mbox > &

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > I don't think we can make this 100% foolproof without knowing which mbox > variant the writer used. But dropping the line is probably the worst > possible thing, as it does not match _any_ variants. :) Hi, FYI it was 'git send-email' v2

Re: [PATCH 2/8] staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet

On Sat, Sep 13, 2014 at 12:23:04PM +0300, Dan Carpenter wrote: > On Thu, Sep 11, 2014 at 10:59:40PM +0100, Mark Einon wrote: > > + if (send_packet(skb, adapter)) > > + goto drop_err; > > + > > + return NETDEV_TX_OK; > > + > > +drop_err: >

[PATCH 8/8] staging: et131x: Remove 'reduce number of spinlocks' TODO item

The number of spinlocks has been halved, from 8 to 4 since this comment was made, let's see if this is enough. Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README

[PATCH 7/8] staging: et131x: Simplify code in nic_rx_pkts() for multicast_pkts_rcvd

nding code can be tiedied up a little. Tested somewhat with omping, with no adverse effects seen. Also remove this item from the TODO list. Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - drivers/staging/et131x/et131x.c | 54 ++--- 2 files

[PATCH 1/8] staging: et131x: Remove et131x_send_packets() function

Remove et131x_send_packets() and replace the only use in et131x_tx with the removed function's body. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 76 - 1 file changed, 29 insertions(+), 47 deletions(-) diff --git a/drivers/st

[PATCH 0/8] staging: et131x: Whittle down the remaining TODO items

Tackle the last few major TODO items for this driver. Mark Einon (8): staging: et131x: Remove et131x_send_packets() function staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet staging: et131x: Tidy up rx/tx dropped & bytes stats staging: et131

[PATCH 5/8] staging: et131x: Remove struct tcb->flags

'struct tcb' member 'flags' was only used to collect tx stats, now we are no longer collecting those particular stats, we no longer need tcb->flags or the code used to peek into the skb to set it's value. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.

[PATCH 6/8] staging: et131x: Combine two if statements with same effect

Both these if statements have the same effect when true, so combine them and save a few lines. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x

[PATCH 2/8] staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet

Memory allocation errors do not denote NETDEV_TX_BUSY, simply drop the packet silently with kfree_skb() and return NETDEV_TX_OK. Also remove this item from the TODO list. Signed-off-by: Mark Einon --- drivers/staging/et131x/README | 1 - drivers/staging/et131x/et131x.c | 51

[PATCH 4/8] staging: et131x: Remove ununsed statistics

>From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd are not returned or used for anything meaningful - remove the code that collects them, and the struct members too. Signed-off-by: Mark Einon --- drivers/staging/et1

[PATCH 3/8] staging: et131x: Tidy up rx/tx dropped & bytes stats

Remove some fairly useless comments regarding rx/tx _bytes and _dropped, and use rcvd_pkts_dropped stat value to provide rx_dropped. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH 4/4] staging: et131x: Fix whitespace - alignment matching open parenthesis

Fix occurrences in et131x.c of: CHECK: Alignment should match open parenthesis Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 130 +--- 1 file changed, 67 insertions(+), 63 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers

[PATCH 3/4] staging: et131x: Add auto-negotiation and 1000BT_Half as supported protocols

The driver supports auto-negotiation and 100BaetT_Half but doesn't advertise or list it in it's phydev. Fix that. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/et131

[PATCH 1/4] staging: et131x: Remove dead code in isr

' We don't actually need the dead code, as we're now using NAPI to handle enabling interrupts - but we do need to enable interrupts if NAPI is not scheduled - so enable interrupts if this is the case. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/

[PATCH 2/4] staging: et131x: Remove spinlock fbr_lock

The spinlock fbr_lock is only used in a single call sequence staring from et131x_poll. As this call is already locked by napi->poll_lock, we can remove it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/stag

Re: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero

On Sat, Aug 30, 2014 at 01:32:16PM -0700, Greg KH wrote: > On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote: > > Replace a long list of contiguous writel() calls with a for loop iterating > > over the same values. > > > > Signed-off-by: Mark Einon > >

[PATCH 5/8 v2] staging: et131x: Remove unnecessary i2c_wack variable

i2c_wack is only used to implement a while(1) loop, so let's remove it. Signed-off-by: Mark Einon --- Modified to remove function parameter indenting changes, which are largely unrelated. drivers/staging/et131x/et131x.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote: > Hi Mark, > > On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote: > > > > > Hi Fabio, thanks for the review. > > > > It's a space alignment of parameters to go with the previous change, to

[PATCH 8/8 v2] staging: et131x: Implement NAPI support

et131x_handle_send_pkts() -replacing bottom half workqueue with poll function which handles send & receive of skbs. -adding various other necessary standard napi calls. Also remove this item from the README TODO list. Signed-off-by: Mark Einon --- Updated after Stephen Hemminger commented

Re: [PATCH 4/8] staging: et131x: Use for loop to initialise contiguous macstat registers to zero

On Thu, Aug 21, 2014 at 08:40:20AM +, David Laight wrote: > From: Mark Einon > > Replace a long list of contiguous writel() calls with a for loop iterating > > over the same address values. > > > > Also remove redundant comments on the macstat registers, the variabl

Re: [PATCH 8/8] staging: et131x: Implement NAPI support

On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote: > On Wed, 20 Aug 2014 23:17:58 +0100 > Mark Einon wrote: > > > - bool done = true; > > + int count = 0; > > + int limit = budget; > > + bool not_done = false; > > Don't use neg

Re: [PATCH 8/8] staging: et131x: Implement NAPI support

On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote: > On Wed, 20 Aug 2014 23:17:58 +0100 > Mark Einon wrote: > > > > > + if (budget > MAX_PACKETS_HANDLED) > > + limit = MAX_PACKETS_HANDLED; > > Why this artificial restriction

Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote: > On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon wrote: > > > do { > > pci_read_config_dword(pdev, > > - L

[PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero

Replace a long list of contiguous writel() calls with a for loop iterating over the same values. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b

[PATCH 2/8] staging: et131x: Don't handle rx/tx packets when changing mtu

There's no need to handle any rx/tx interrupts in the middle of an mtu change, so don't. After this change, receive and transmit interrupts are only handled in one place, which paves the way to using NAPI. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 2 -- 1 file

[PATCH 4/8] staging: et131x: Use for loop to initialise contiguous macstat registers to zero

Replace a long list of contiguous writel() calls with a for loop iterating over the same address values. Also remove redundant comments on the macstat registers, the variable names are good enough. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 59

[PATCH 6/8] staging: et131x: Rename NUM_PACKETS_HANDLED to MAX_PACKETS_HANDLED

To better describe it's use as a hard limit. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 551b250..df83ea3 100644 --- a/dr

[PATCH 8/8] staging: et131x: Implement NAPI support

et131x_handle_send_pkts() -replacing bottom half workqueue with poll function which handles send & receive of skbs. -adding various other necessary standard napi calls. Also remove this item from the README TODO list. Signed-off-by: Mark Einon --- drivers/staging/et131x/README |

[PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable

i2c_wack is only used to implement a while(1) loop, so let's remove it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index fc

[PATCH 7/8] staging: et131x: Fix ET_INTR_TXDMA_ISR register name typo

We actually mean to clear the ET_INTR_TXDMA_ISR reg after handling a completed transfer, not the ET_INTR_TXDMA_ERR reg, which should get handled immediately after. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 1/8] staging: et131x: Use eth_mac_addr() instead of duplicating the functionality

There's already working code to set the mac address, so let's use it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 53 + 1 file changed, 1 insertion(+), 52 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drive

[PATCH 0/8] Implement NAPI in et131x

ranch, not staging-next - so won't apply cleanly in it's current state. Please let me know if I need to do anything about this. Cheers, Mark --- Mark Einon (8): staging: et131x: Use eth_mac_addr() instead of duplicating the functionality staging: et131x: Don't handle rx/tx

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

On Mon, Aug 11, 2014 at 01:39:59PM +0800, gre...@linuxfoundation.org wrote: > On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: > > Do you have this hardware ? And did you test this ? > > Mark is the maintainer of this driver, I assume he has the hardware, if > not, I don't care, I tru

Re: [PATCH] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

On Sat, Aug 09, 2014 at 09:39:17PM -0700, Greg KH wrote: > On Tue, Aug 05, 2014 at 11:57:06PM +0100, Mark Einon wrote: > > Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed > > before it is initialised, by: > > > > - letting et131x_

[PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

org/show_bug.cgi?id=77121 Cc: sta...@vger.kernel.org Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 68 - 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c ind

[PATCH] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

org/show_bug.cgi?id=77121 Cc: sta...@vger.kernel.org Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 68 - 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c ind

Re: [PATCH] staging: et131x: remove Module.symvers

On Mon, Jun 02, 2014 at 10:26:42AM +0200, Bjørn Mork wrote: > Removing a build generated file. > > Cc: Mark Einon > Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock") > Signed-off-by: Bjørn Mork Hi Bjørn, Unfortunately this issue has alre

Re: [PATCH 5/8] staging: et131x: Remove useless return variables

only. > > The coccinelle script that find and fixes this issue is: > // > @@ > type T; > constant C; > identifier ret; > @@ > - T ret = C; > ... when != ret > - return ret; > + return C; > // > > Signed-off-by: Peter Senna Tschudin Acked-by: Mark E

Re: [PATCH] staging: et131x: add blank lines after declarations

On Sun, May 04, 2014 at 07:26:51PM +0200, Maarten de Jonge wrote: > Signed-off-by: Maarten de Jonge Acked-by: Mark Einon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: et131x: Remove empty file Module.symvers

On Sun, Apr 27, 2014 at 02:34:48PM +0200, Daniele Forsi wrote: > It was added by commit e0349d5ba (staging: et131x: Remove unused > rcv_pend_lock spinlock) > > Signed-off-by: Daniele Forsi Acked-by: Mark Einon ___ devel mai

[PATCH 6/9] staging: rtl8821ae: Fix checkpatch whitespace issues

Whitespace changes only to appease checkpatch warnings. Signed-off-by: Mark Einon --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 100 ++-- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c b/drivers

[PATCH 2/9] staging: rtl8821ae: Remove unused functions

Remove functions not being called from anywhere: halbtc8192e2ant_set_adc_backoff() halbtc8192e2ant_adc_backoff() Signed-off-by: Mark Einon --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 38 1 file changed, 38 deletions(-) diff --git a/drivers/staging/rtl8821ae

[PATCH 4/9] staging: rtl8821ae: Fix halbtc8192e2ant.c 'defined but not used' sparse warnings

Sparse complains about halbtc8192e2ant_low_penalty_ra() not being used, and subsequently halbtc8192e2ant_set_sw_penalty_tx_rateadaptive() when this is removed. remove both functions. Signed-off-by: Mark Einon --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 48 1

[PATCH 3/9] staging: rtl8821ae: Fix halbtc8192e2ant.c 'should it be static?' sparse warnings

In halbtc8192e2ant.c, fix all instances of the sparse warning: warning: symbol 'xxx' was not declared. Should it be static? Signed-off-by: Mark Einon --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 218 ++-- 1 file changed, 114 insertions(+), 104 deletion

[PATCH 8/9] staging: rtl8821ae: Fix indetentation of switch case statements

-by: Mark Einon --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c b/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c index db48692..244b3c6 100

[PATCH 9/9] staging: rtl8821ae: don't initialise statics to 0 or NULL in halbtc8192e2ant.c

Fixes all checkpatch errors reporting that statics shouldn't be initialised to their defualt values. Signed-off-by: Mark Einon --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8

[PATCH 5/9] staging: rtl8821ae: Remove declaration assignment to zero

We set btrssi to zero and then immediately assign it. Assign it on declaration instead. Signed-off-by: Mark Einon --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8821ae/btcoexist

[PATCH 7/9] staging: rtl8821ae: halbtc8192e2ant.c fix checkpatch leading spaces/tabs issues

Fix checkpatch issues relating to using leading spaces instead of tabs. Whitespace changes only. Signed-off-by: Mark Einon --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 42 ++-- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging

[PATCH 1/9] staging: rtl8821ae: Remove file #if 1

All code in this file is encapsulated in a useless #if 1 declaration, remove it. Signed-off-by: Mark Einon --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c

[PATCH 3/3] staging: rtl8821ae: Fix rtl8821ae/hw.h pointer declaration style

Fix all occurences of the checkpatch error: ERROR: "foo* bar" should be "foo *bar" Signed-off-by: Mark Einon --- drivers/staging/rtl8821ae/rtl8821ae/hw.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.

[PATCH 1/3] staging: rtl8821ae: Fix whitespace in rtl8821ae/hw.h

Fix checkpatch warnings, lines over 80 chars using tabs where possible. Signed-off-by: Mark Einon --- drivers/staging/rtl8821ae/rtl8821ae/hw.h | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.h b/drivers

[PATCH 2/3] staging: rtl8821ae: Remove FSF mailing address from rtl8821ae/hw.h header

Fix checkpatch check: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Mark Einon --- dr

Re: [PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by: Ken Cox diff --git a/drivers/staging/unisys/include/commontype

  1   2   >