>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=4ef8451b332662d004df269d4cdeb7d9f31419b5#n123
>
> The documentation is correct but no one wants you to constantly be
> nagging developers about minor stuff...
Would you interp
>>> Fixes: 14a638ab96c5 ("media: atomisp: use pin_user_pages() for memory
>>> allocation")
>>
>> Please delete a line break for this tag.
>
> Markus, the thing is that we all saw the line break and we just thought
> it didn't matter at all...
Do you disagree to the known documentation then?
https:
> Fixes: 14a638ab96c5 ("media: atomisp: use pin_user_pages() for memory
> allocation")
Please delete a line break for this tag.
Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/
> Fixes: 14a638ab96c5 ("media: atomisp: use pin_user_pages() for memory
> allocation")
Please omit a line break for this tag.
Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/dr
> Call to pm_runtime_get_sync increments counter even in case of
> failure leading to incorrect ref count.
> Call pm_runtime_put_autosuspend if pm_runtime_get_sync fails.
How do you think about a wording variant like the following?
Change description:
The PM runtime reference counter is gen
How do you think about a patch subject like “iio: Increase use of
iio_device_attach_kfifo_buffer()”?
> This change does that.
I suggest to improve also this commit message.
* Would you like to consider a wording like “Convert a specific function call
combination to a better programming inter
> This patchset renames following twenty-two variables declared in exfat.h
Would a subject like “staging: exfat: Renaming of some identifiers”
be more appropriate (than an incomplete one) for this cover letter?
Regards,
Markus
___
devel mailing list
de.
> Change all the occurrences of "Month" to "month" in exfat.
I hope that the final commit will not contain a misplaced quotation character
in the subject.
Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
> Change all the occurrences of "Month" to "month" in exfat.
I hope that the final commit will not contain a misplaced quotation character
in the subject.
Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
> In the implementation of gsc_hpdi_auto_attach(), the allocated dma
> description is leaks in case of alignment error, …
Please avoid a typo in this change message.
…
+++ b/drivers/staging/comedi/drivers/gsc_hpdi.c
…
> @@ -660,6 +661,15 @@ static int gsc_hpdi_auto_attach(struct comedi_device
>
Hello,
I have tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “prism2sta_inf_hostscanresults” contains still
an unchecked call of the function “kmemdup”.
https://git.kernel.org/pub/scm/linux/kernel/git/
>>> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
>>> like other error handling cases. The call to device_free_info() is
>>> added.
>>
>> Please improve this change description.
>
> It is fine as-is, please do not confuse people.
Would you like to clarify a known guideli
> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
> like other error handling cases. The call to device_free_info() is
> added.
Please improve this change description.
Regards,
Markus
___
devel mailing list
de...@linuxdriverproj
> In rtl8192_tx on error handling path allocated urbs and also skb should
> be released.
Can this change description be improved?
How do you think about to add the tag “Fixes” here?
> @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct
> sk_buff *skb)
> RT_TRACE(COMP_
From: Markus Elfring
Date: Wed, 18 Sep 2019 21:01:32 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 10 +-
1
> I'm also curious about that, what is the filesystem or kernel standard about
> likely/unlikely use (since I didn't find some documented standard
> so I used in my personal way,
Such information is helpful.
> I think it is reasonable at least to cover all error handling paths),
I hope so, too.
> +++ b/drivers/staging/exfat/exfat_core.c
> @@ -0,0 +1,3704 @@
…
> +static s32 __load_upcase_table(struct super_block *sb, sector_t sector,
> +u32 num_sectors, u32 utbl_checksum)
> +{
…
> +error:
An other label would be nicer, wouldn't it?
> + if (tmp_bh)
> +
> +++ b/drivers/staging/exfat/exfat.h
> @@ -0,0 +1,973 @@
…
> +/* file types */
> +#define TYPE_UNUSED 0x
> +#define TYPE_DELETED 0x0001
…
> +/* time modes */
> +#define TM_CREATE0
> +#define TM_MODIFY1
Will it be helpful to work with enumerations at su
Your patch remove redundant code, which is fine.
Thanks for your constructive feedback.
> code you changed was simple enough to be understand quickly. I think replacing
> it with a crossed goto (even if it remove redundant code) might not be the
> best
> option.
>
> A solution might be to move
From: Markus Elfring
Date: Fri, 23 Aug 2019 15:15:41 +0200
Adjust jump targets so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/vt6656/main_usb.c
From: Markus Elfring
Date: Wed, 21 Aug 2019 14:30:30 +0200
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng
From: Markus Elfring
Date: Wed, 21 Aug 2019 13:56:35 +0200
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/vt6656
> The kfifo_alloc() failure generates enough information and doesn't need
> to be accompanied by another error statement.
I am curious how the acceptance will evolve for this variant of
another different commit description according to a known software
transformation pattern.
> ---
> Changes in
> I think commit message is clear enough to understand why this is needed.
There are differences to consider between the involved software developers.
> You can send me what should I include in commit description
The clarification should be continued with the number “v5”
in the message subject.
> ---
> Changes in v4:
I find this change log still incomplete.
You have chosen to adjust the commit message once more.
(Some contributors might be also not satisfied with this variant.)
Such a change requires to increase the corresponding patch version number,
doesn't it?
Regards,
Markus
_
> I didn't get you. I stiil need to update changelog
I would appreciate the completion of the listing for V2 till V4.
I guess that a message resend could be sufficient for these adjustments.
> and send more version
This could be another opportunity if you would like to improve
the commit descri
> ---
> Changes in v3:
Thanks for your quick response.
I find the change log incomplete (even if corresponding information
can be determined also from public message archives).
Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
http://
> This print statement is redundant as kfifo_alloc just calls kmalloc_array
> and without the __GFP_NOWARN flag, already does a dump_stack().
I suggest to omit the word “and” from this sentence.
Will any further wording adjustments become helpful for commit descriptions?
> Changes in v3:
> - fix
From: Markus Elfring
Date: Sat, 6 Jul 2019 10:48:23 +0200
Avoid an extra function call by using a ternary operator instead of
a conditional statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/octeon/ethernet.c | 9
From: Markus Elfring
Date: Sat, 6 Jul 2019 10:48:23 +0200
Avoid an extra function call by using a ternary operator instead of
a conditional statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/octeon/ethernet.c | 9
From: Markus Elfring
Date: Sat, 6 Jul 2019 10:03:56 +0200
Avoid an extra function call by using a ternary operator instead of
a conditional statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/speakup/main.c | 7 +++
1
> These messages are not displayed anywhere else:
> "unable to allocate receive buffer of size %u\n"
> "unable to allocate send buffer of size %u\n",
>
> After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation
> failed without the error message.
How do you think about to achi
> These messages are not displayed anywhere else:
> "unable to allocate receive buffer of size %u\n"
> "unable to allocate send buffer of size %u\n",
>
> After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation
> failed without the error message.
Do you notice a Linux allocati
From: Markus Elfring
Date: Sun, 7 Jan 2018 21:03:26 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/net/hyperv/netvsc.c | 5 -
1 file changed, 5 deletions
From: Markus Elfring
Date: Wed, 13 Dec 2017 15:46:07 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 5 +
1
From: Markus Elfring
Date: Wed, 13 Dec 2017 15:15:45 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/vt6656/main_usb.c | 5 +
1 file changed, 1
From: Markus Elfring
Date: Wed, 13 Dec 2017 13:41:41 +0100
Replace two calls of the function "kfree" by a jump to the same statements
at the end of this function so that the generated object code could become
a bit smaller.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/
From: Markus Elfring
Date: Wed, 13 Dec 2017 13:28:15 +0100
Omit an extra message for a memory allocation failure in this function.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/prism2fw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b
From: Markus Elfring
Date: Wed, 13 Dec 2017 13:20:10 +0100
Make a memory allocation failure clearer by using the error code "-ENOMEM"
(instead of the constant "1") in this function.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/prism2fw.c | 2 +-
1 file change
From: Markus Elfring
Date: Wed, 13 Dec 2017 12:57:13 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/prism2fw.c | 5 ++---
1 file changed, 2
From: Markus Elfring
Date: Wed, 13 Dec 2017 14:03:02 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Delete an error message for a failed memory allocation in mkimage()
Use a known error code after a failed kzalloc() in mkimage
From: Markus Elfring
Date: Fri, 3 Nov 2017 20:37:03 +0100
* Add a jump target so that a specific error message is stored only once
at the end of this function implementation.
* Replace four calls of the function "dev_err" by goto statements.
This issue was detected by using the
From: Markus Elfring
Date: Fri, 3 Nov 2017 20:02:22 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace two calls by goto statements.
This issue was detected by using the Coccinelle software.
Sig
> FYI, you are responding to someone who is on my blacklist
I am curious if this communication setting will ever be adjusted.
> and I never accept patches from.
The history shows that our collaboration style changed over time.
I got a few update suggestions integrated (also by you) because
othe
>> @@ -838,6 +834,10 @@ static int usbduxfast_ai_insn_read(struct comedi_device
>> *dev,
>> mutex_unlock(&devpriv->mut);
>> return insn->n;
>
> Minor niggle: You could also remove that call to mutex_unlock() by replacing
> the above three lines with:
>
> ret = insn->n;
>
> wh
From: Markus Elfring
Date: Fri, 3 Nov 2017 10:45:31 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/media/davinci_vpfe
From: Markus Elfring
Date: Fri, 3 Nov 2017 09:26:28 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace two calls by goto statements.
This issue was detected by using the Coccinelle software.
Sig
From: Markus Elfring
Date: Fri, 3 Nov 2017 09:00:25 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace two calls by goto statements.
This issue was detected by using the Coccinelle software.
Sig
From: Markus Elfring
Date: Thu, 2 Nov 2017 22:27:13 +0100
* Add a jump target so that a specific error message is stored only once
at the end of this function implementation.
* Replace two calls of the function "dev_err" by goto statements.
This issue was detected by using the
From: Markus Elfring
Date: Thu, 2 Nov 2017 22:12:58 +0100
* Add a jump target so that a specific error message is stored only once
at the end of this function implementation.
* Replace two calls of the function "dev_err" by goto statements.
This issue was detected by using the
From: Markus Elfring
Date: Thu, 2 Nov 2017 21:16:50 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in these function implementations.
* Replace seven calls by goto statements.
This issue was detected by using the Coccinelle software.
From: Markus Elfring
Date: Thu, 2 Nov 2017 20:30:31 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace five calls by goto statements.
This issue was detected by using the Coccinelle software.
Sig
> Did you read drivers/staging/irda/TODO ?
Yes.
How do recent contributions (by other software developers) fit to information
that is provided in this file?
Regards,
Markus
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdrive
From: Markus Elfring
Date: Thu, 12 Oct 2017 11:08:36 +0200
Strings which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Mark
From: Markus Elfring
Date: Thu, 12 Oct 2017 08:58:38 +0200
Some data were printed into a sequence by separate function calls.
Print the same data by a single function call at each place instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 12 Oct 2017 08:52:53 +0200
Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
Signed-off-by: Markus Elfring
---
drivers/staging/irda/net/irias_object.c | 14 --
1 file changed, 8 insertions(+), 6
From: Markus Elfring
Date: Wed, 11 Oct 2017 22:26:00 +0200
The variable "tx_skb" will eventually be set to an appropriate pointer
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/irda/net/irlap_frame.c | 6 +++--
From: Markus Elfring
Date: Wed, 11 Oct 2017 22:22:13 +0200
The local variable "tx_skb" will only be used in a single if branch
of these functions. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/irda/net/irlap_frame.c | 4 ++
From: Markus Elfring
Date: Wed, 11 Oct 2017 22:20:22 +0200
The variable "discovery" will eventually be set to an appropriate pointer
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/irda/net/irlap_frame.c | 2
From: Markus Elfring
Date: Wed, 11 Oct 2017 22:18:34 +0200
The local variable "discovery" will only be used in a single if branch
of this function. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/irda/net/irlap_frame.c | 2
From: Markus Elfring
Date: Wed, 11 Oct 2017 22:10:26 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code
From: Markus Elfring
Date: Tue, 10 Oct 2017 21:10:43 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/irda/net/irias_object.c | 24
From: Markus Elfring
Date: Tue, 10 Oct 2017 19:35:56 +0200
* Replace the specification of data types by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This
From: Markus Elfring
Date: Thu, 12 Oct 2017 11:25:43 +0200
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (10):
Improve a size determination in 20 functions
Delete ten error messages for a failed memory allocation
Adjust 385 checks for
@@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const
struct pci_device_id *id)
master_num--;
tsi148_device->flush_image =
-kmalloc(sizeof(struct vme_master_resource),
GFP_KERNEL);
+
From: Markus Elfring
Date: Sat, 26 Aug 2017 18:44:12 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/netlogic/xlr_net.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Sat, 26 Aug 2017 18:23:52 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 2 --
1 file changed
>> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const
>> struct pci_device_id *id)
>> master_num--;
>>
>> tsi148_device->flush_image =
>> -kmalloc(sizeof(struct vme_master_resource), GFP_KERNEL);
>> +kmalloc
From: Markus Elfring
Date: Fri, 25 Aug 2017 12:00:17 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code
From: Markus Elfring
Date: Fri, 25 Aug 2017 11:55:03 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Sig
From: Markus Elfring
Date: Fri, 25 Aug 2017 11:10:07 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/vme/bridges/vme_tsi148.c | 18 --
1 file
From: Markus Elfring
Date: Fri, 25 Aug 2017 11:01:29 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code
From: Markus Elfring
Date: Fri, 25 Aug 2017 10:56:41 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Sig
From: Markus Elfring
Date: Fri, 25 Aug 2017 10:20:03 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/vme/bridges/vme_ca91cx42.c | 16
1 file
From: Markus Elfring
Date: Fri, 25 Aug 2017 10:01:16 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code
From: Markus Elfring
Date: Fri, 25 Aug 2017 09:46:13 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This
From: Markus Elfring
Date: Fri, 25 Aug 2017 09:31:46 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/vme/bridges/vme_fake.c | 1 -
1 file changed, 1 deletion
From: Markus Elfring
Date: Thu, 24 Aug 2017 22:32:14 +0200
Return directly without using an intermediate local variable
in these functions.
Signed-off-by: Markus Elfring
---
drivers/vme/vme.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/vme/vme.c b
From: Markus Elfring
Date: Thu, 24 Aug 2017 21:52:00 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This
From: Markus Elfring
Date: Thu, 24 Aug 2017 22:24:38 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code
From: Markus Elfring
Date: Thu, 24 Aug 2017 22:04:45 +0200
Assign a pointer to a data structure member without using an intermediate
local variable.
Signed-off-by: Markus Elfring
---
drivers/vme/vme.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/vme/vme.c
From: Markus Elfring
Date: Thu, 24 Aug 2017 21:38:20 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/vme/vme.c | 51
From: Markus Elfring
Date: Fri, 25 Aug 2017 13:15:43 +0200
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (14):
Delete 11 error messages for a failed memory allocation
Improve 11 size determinations
Move an assignment in
From: Markus Elfring
Date: Wed, 17 May 2017 22:26:07 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
From: Markus Elfring
Date: Wed, 17 May 2017 19:01:10 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> When you make a patch, you are not obliged to eliminate all of the other
> checkpatch warnings on the file.
Your view is generally fine.
> I don't know where you got this idea from.
I got used as a professional software developer to some approaches for
reducing development warnings to some de
> Developer reputation matters for somewhat controversial
> patches being applied as well as non-controversial and
> obviously correct patches being ignored.
I am aware that there are more factors involved.
> Your reputation means most all of your patches fall into
> the latter category.
I hope
>> Just because an automated tool says that this needs to change does not
>> mean it has to.
>
> Checkpatch.pl is correct here. This message is useless. It's during
> init so it's unlikely to fail ever. In current kernels small kmallocs
> are quaranteed to succeed so it can't actually fail curr
> Taking out the message assumes that all callers of this function either log an
> error or pass appropriate error code back to userspace.
Do you like the default error response by Linux memory allocation functions?
Regards,
Markus
___
devel mailing lis
From: Markus Elfring
Date: Thu, 11 May 2017 17:52:38 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code
From: Markus Elfring
Date: Thu, 11 May 2017 17:43:55 +0200
Add a missing character in this description.
Signed-off-by: Markus Elfring
---
drivers/hv/vmbus_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index
From: Markus Elfring
Date: Thu, 11 May 2017 17:33:14 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
From: Markus Elfring
Date: Thu, 11 May 2017 17:30:10 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Sig
From: Markus Elfring
Date: Thu, 11 May 2017 18:00:18 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Improve a size determination in vmbus_device_create()
Delete an error message for a failed memory allocation in
From: Markus Elfring
Date: Sun, 7 May 2017 22:07:16 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/android/bi
> This patch does not apply to Greg's staging-testing branch.
Could the proposed changes be applied with a bit of “fuzz” for the
implementation of the function “ks7010_sdio_probe”?
> Markus a patch was merged the same day you submitted this one that
> refactored this code.
Do you refer to your
From: Markus Elfring
Date: Tue, 11 Apr 2017 14:54:35 +0200
The use of the logging function "dev_err" was introduced here on 2016-09-26.
I find the following implementation details worth for another look.
* Reduce expressions for the first input parameter "dev".
* Omit an ex
From: Markus Elfring
Date: Sun, 1 Jan 2017 16:45:32 +0100
A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts"
so that the data output will be a bit more efficient in these functions.
This issue was d
From: Markus Elfring
Date: Sun, 1 Jan 2017 16:26:36 +0100
Some data were printed into a sequence by two separate function calls.
Print the same data by a single function call instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging
From: Markus Elfring
Date: Sun, 1 Jan 2017 16:12:23 +0100
A few single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/stag
1 - 100 of 286 matches
Mail list logo
