Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

? Best Regards Michał Mirosław ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote: > On 25/07/20 5:31 pm, Michał Mirosław wrote: > > On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: > >> changed usage of slave (which is deprecated) to secondary without breaking > >&

Re: [PATCH v4] staging: nvec: change usage of slave to secondary

reason are the recent coding-style changes, then please note they are about avoiding introducing *NEW* uses of the specific words and not about blindly replacing existing occurrences. Best Regards Michał Mirosław ___ devel mailing l

Re: [PATCH 03/15] staging: wfx: fix double free

On Tue, May 05, 2020 at 02:37:45PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > In case of error in wfx_probe(), wdev->hw is freed. Since an error > occurred, wfx_free_common() is called, then wdev->hw is freed again. > > Cc: Michał Mirosław > Sig

Re: [PATCH v2 1/6] staging: wfx: fix init/remove vs IRQ race

On Tue, Feb 11, 2020 at 11:19:18AM +, Jérôme Pouiller wrote: > On Tuesday 11 February 2020 11:35:01 CET Michał Mirosław wrote: > > Current code races in init/exit with interrupt handlers. This is noticed > > by the warning below. Fix it by using devres for ordering allocations

Re: [[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

On Tue, Feb 11, 2020 at 12:23:54PM +0300, Dan Carpenter wrote: > On Tue, Feb 11, 2020 at 09:46:54AM +0100, Michał Mirosław wrote: > > @@ -234,8 +234,8 @@ static void wfx_sdio_remove(struct sdio_func *func) > > struct wfx_sdio_priv *bus = sdio_get_drvdata(func); > > &g

[PATCH v2 6/6] staging: wfx: use more power-efficient sleep for reset

Replace udelay() with usleep_range() as all uses are in a sleepable context. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/hwio.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH v2 5/6] staging: wfx: use sleeping gpio accessors

Driver calls GPIO get/set only from non-atomic context and so can use any GPIOs. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 6 +++--- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/main.c| 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v2 4/6] staging: wfx: follow compatible = vendor,chip format

As for SPI, follow "vendor,chip" format 'compatible' string also for SDIO bus. Fixes: 0096214a59a7 ("staging: wfx: add support for I/O access") Signed-off-by: Michał Mirosław --- .../devicetree/bindings/net/wireless/siliabs,wfx.txt | 4 ++--

[PATCH v2 3/6] staging: wfx: add proper "compatible" string

Fixes: 0096214a59a7 ("staging: wfx: add support for I/O access") Signed-off-by: Michał Mirosław --- .../bindings/net/wireless/siliabs,wfx.txt | 7 --- drivers/staging/wfx/bus_spi.c | 14 ++ 2 files changed, 14 insertions(+), 7 deletio

[PATCH v2 0/6] staging: WF200 driver fixes

A set of fixes for WF200 WiFi module driver. Three are bug fixes, all the rest: cleanups and optimizations. v2: use devres for fixing init/interrupt race, as suggested by Dan Carpenter add Fixes: tags dropped by accident remove 8-bit SPI fall-back patch Michał Mirosław (6): staging: wfx

[PATCH v2 1/6] staging: wfx: fix init/remove vs IRQ race

/deinit Cc: sta...@vger.kernel.org Fixes: 0096214a59a7 ("staging: wfx: add support for I/O access") Signed-off-by: Michał Mirosław --- v2: use devres to fix the races --- drivers/staging/wfx/bus_sdio.c | 15 ++- drivers/staging/wfx/bus_spi.c | 27 ++

[PATCH v2 2/6] staging: wfx: annotate nested gc_list vs tx queue locking

Cc: sta...@vger.kernel.org Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames") Signed-off-by: Michał Mirosław --- drivers/staging/wfx/queue.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wf

[[PATCH staging] 4/7] staging: wfx: annotate nested gc_list vs tx queue locking

fc/0x198 [wfx] but task is already holding lock: cb7d61f4 (&(&list->lock)->rlock){+...}, at: wfx_tx_queues_clear+0xa0/0x198 [wfx] [...] Possible unsafe locking scenario: CPU0 lock(&(&list->lock)->rlock); lock(&(&list->lock)->rlock

[PATCH staging 0/7] WF200 driver fixes

A set of fixes for WF200 WiFi module driver. Three are bug fixes, all the rest: cleanups and optimizations. Michał Mirosław (7): staging: wfx: add proper "compatible" string staging: wfx: follow compatible = vendor,chip format staging: wfx: fix init/remove vs IRQ race st

[[PATCH staging] 6/7] staging: wfx: use sleeping gpio accessors

Driver calls GPIO get/set only from non-atomic context and so can use any GPIOs. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 6 +++--- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/main.c| 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff

[[PATCH staging] 2/7] staging: wfx: follow compatible = vendor,chip format

As for SPI, follow "vendor,chip" format 'compatible' string also for SDIO bus. Signed-off-by: Michał Mirosław --- .../devicetree/bindings/net/wireless/siliabs,wfx.txt | 4 ++-- drivers/staging/wfx/bus_sdio.c| 1 + 2 files changed

[[PATCH staging] 1/7] staging: wfx: add proper "compatible" string

Add "compatible" string matching "vendor,chip" template and proper GPIO flags handling. Keep support for old name and reset polarity for older devicetrees. Cc: sta...@vger.kernel.org # d3a5bcb4a17f ("gpio: add gpiod_toggle_active_low()") Cc: sta...@vger.ke

[[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

Move interrupt request and free so to avoid following WARN on probe and possible use-after-free on remove. WARNING: CPU: 0 PID: 827 at drivers/staging/wfx/bus_spi.c:142 wfx_spi_irq_handler+0x5c/0x64 [wfx] race condition in driver init/deinit Cc: sta...@vger.kernel.org Signed-off-by: Michał

[[PATCH staging] 7/7] staging: wfx: use more power-efficient sleep for reset

Replace udelay() with usleep_range() as all uses are in a sleepable context. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/bus_spi.c | 4 ++-- drivers/staging/wfx/hwio.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[[PATCH staging] 5/7] staging: wfx: try 16-bit word mode first

WF200 chip works with 16-bit words over SPI, so use that word size if available. This avoids a bounce buffer usage for little-endian hosts. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bus_spi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: wfx: fix reset GPIO polarity

On Thu, Dec 05, 2019 at 03:43:49PM +, Jérôme Pouiller wrote: > On Thursday 5 December 2019 15:49:55 CET Michał Mirosław wrote: > > On Thu, Dec 05, 2019 at 02:08:23PM +, Jérôme Pouiller wrote: > > > On Wednesday 4 December 2019 17:59:46 CET Michał Mirosław wrote: >

Re: [PATCH] staging: wfx: fix reset GPIO polarity

On Thu, Dec 05, 2019 at 02:08:23PM +, Jérôme Pouiller wrote: > On Wednesday 4 December 2019 17:59:46 CET Michał Mirosław wrote: > > Driver inverts meaning of GPIO_ACTIVE_LOW/HIGH. Fix it to prevent > > confusion. > > > > Signed-off-by: Michał Mirosław >

[PATCH] staging: wfx: fix reset GPIO polarity

Driver inverts meaning of GPIO_ACTIVE_LOW/HIGH. Fix it to prevent confusion. Signed-off-by: Michał Mirosław --- drivers/staging/wfx/bus_spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus_spi.c index ab0cda1e124f

[PATCH net-next 1/4] net/vlan: introduce skb_vlan_tag_get_cfi() helper

Abstract CFI/DEI bit access consistently with other VLAN tag fields. Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 7a541eadf78e..4cca4da7a6de 100644 --- a

[PATCH net-next 0/4] VLAN tag handling cleanup

This is a cleanup set after VLAN_TAG_PRESENT removal. The CFI bit handling is made similar to how other tag fields are used. Michał Mirosław (4): net/vlan: introduce skb_vlan_tag_get_cfi() helper net/hyperv: use skb_vlan_tag_*() helpers benet: use skb_vlan_tag_get_prio() mlx5: use

[PATCH net-next 3/4] benet: use skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/emulex/benet/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 80b2bd3747ce..245abf0d19c0 100644 --- a/drivers/net

[PATCH net-next 4/4] mlx5: use skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c index 6dacaeba2fbf..9afdf955f2bc 100644 --- a

[PATCH net-next 2/4] net/hyperv: use skb_vlan_tag_*() helpers

Replace open-coded bitfield manipulation with skb_vlan_tag_*() helpers. This also enables correctly passing of VLAN.CFI bit. Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv

[PATCH net-next] net/hyperv: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv

[PATCH net-next v2 26/27] net/hyperv: enable passing of VLAN.CFI bit

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 1 + drivers/net/hyperv/rndis_filter.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6597d7901929..4e20f4c247fa 100644 --- a/drivers/net/hyperv

[PATCH net-next v2 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv

[PATCH net-next 26/27] net/hyperv: enable passing of VLAN.CFI bit

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 1 + drivers/net/hyperv/rndis_filter.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6597d79..4e20f4c 100644 --- a/drivers/net/hyperv

[PATCH net-next 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv