Re: [PATCH] media: allegro-dvt: Use __packed sentence

2021-02-01 Thread Michael Tretter
On Fri, 29 Jan 2021 23:54:41 +, David Laight wrote: > From: Emmanuel Arias > > Sent: 29 January 2021 20:02 > > > > Fix coding style using __packed sentece instead of > > __attribute__((__packed__)). > > > > Signed-off-by: Emmanuel Arias > > --- > > drivers/staging/media/allegro-dvt/allegro-

Re: [PATCH] media: allegro: Fix use after free on error

2020-12-14 Thread Michael Tretter
x.de/ > > Fixes: cc62c74749a3 ("media: allegro: add missed checks in allegro_open()") > Signed-off-by: Dan Carpenter Reviewed-by: Michael Tretter > --- > From static analysis. Not tested. > > drivers/staging/media/allegro-dvt/allegro-core.c | 3 +-- > 1 fi

Re: [PATCH][next][V2] media: allegro: fix potential null dereference on header

2020-07-22 Thread Michael Tretter
coding") > Signed-off-by: Colin Ian King Reviewed-by: Michael Tretter > --- > > V2: remove need for variable type, as suggested by Michael Tretter > > --- > drivers/staging/media/allegro-dvt/allegro-mail.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions

Re: [PATCH] media: allegro: fix an error pointer vs NULL check

2020-07-22 Thread Michael Tretter
On Wed, 22 Jul 2020 15:38:48 +0300, Dan Carpenter wrote: > The allegro_mbox_init() function returns error pointers, it never > returns NULL. > > Fixes: 94dc76560261 ("media: allegro: rework mbox handling") > Signed-off-by: Dan Carpenter Reviewed-by: Michael Tretter

Re: [PATCH][next] media: allegro: fix potential null dereference on header

2020-07-22 Thread Michael Tretter
On Mon, 20 Jul 2020 17:38:04 +0100, Colin King wrote: > From: Colin Ian King > > The pointer header is an alias to msg and msg is being null checked. > However, if msg is null then header is also null and this can lead to > a null pointer dereference on the assignment type = header->type. Fix > t

Re: [PATCH] media: allegro: Fix some NULL vs IS_ERR() checks in probe

2020-07-01 Thread Michael Tretter
On Fri, 19 Jun 2020 17:30:07 +0300, Dan Carpenter wrote: > The devm_ioremap() function doesn't return error pointers, it returns > NULL on error. > > Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") > Signed-off-by: Dan Carpenter

Re: [PATCH] media: allegro: fix spelling mistake "to" -> "too"

2020-01-24 Thread Michael Tretter
On Thu, 23 Jan 2020 01:06:43 +, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a v4l2_err message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Michael Tretter > --- > drivers/staging/media/allegro-dvt/allegro-core.c | 2 +-

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Michael Tretter
On Tue, 21 Jan 2020 19:59:46 +0800, Chuhong Yuan wrote: > On Tue, Jan 21, 2020 at 4:23 PM Michael Tretter > wrote: > > > > On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > > > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > >

Re: [PATCH v3] media: allegro: add missed checks in allegro_open()

2020-01-21 Thread Michael Tretter
On Mon, 13 Jan 2020 13:59:51 +0800, Chuhong Yuan wrote: > allegro_open() misses checks for v4l2_m2m_ctx_init() and results of > v4l2_ctrl_new* calls. > Add checks and error handlers to fix the problems. > > Signed-off-by: Chuhong Yuan > --- > Changes in v3: > - Make code cleaner. > - Add a ch

Re: [PATCH] media: allegro: add the missed check for v4l2_m2m_ctx_init

2019-12-09 Thread Michael Tretter
On Mon, 09 Dec 2019 16:58:07 +0800, Chuhong Yuan wrote: > allegro_open() misses a check for v4l2_m2m_ctx_init(). > Add a check and error handling code to fix it. > > Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver") > Signed-off-by: Chuhong Yu