Re: [RFC][PATCH 1/2] WIP: Devicetree bindings for Ion

2015-10-20 Thread Mitchel Humpherys
On Tue, Oct 13 2015 at 11:14:23 AM, Andrew wrote: > On 2015-10-12 21:39, Mitchel Humpherys wrote: >> On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring >> wrote: >>> On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott >>> wrote: >> >> [.

Re: [RFC][PATCH 1/2] WIP: Devicetree bindings for Ion

2015-10-12 Thread Mitchel Humpherys
On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring wrote: > On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott > wrote: [...] >> +Example: >> + >> + ion { >> + compatbile = "linux,ion"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> +

Re: [PATCH v2 2/2] staging: ion: chunk_heap: use %pad for printing dma_addr_t's

2015-05-04 Thread Mitchel Humpherys
On Mon, May 04 2015 at 01:05:50 PM, Colin Cross wrote: > On Mon, May 4, 2015 at 1:22 AM, Dan Carpenter > wrote: >> On Thu, Apr 09, 2015 at 06:10:04PM -0700, Mitchel Humpherys wrote: >>> We're currently using %lu and %ld to print some variables of type >>&g

[PATCH] ion: improve ion_phys error message

2015-03-12 Thread Mitchel Humpherys
Clients often get confused when ion_phys errors out due to some heap being used that they didn't expect. Add the heap name and heap type to the error message to make it more obvious. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 4 ++-- 1 file changed, 2 inser

[PATCH] ion: improve ion_phys error message

2015-02-13 Thread Mitchel Humpherys
Clients often get confused when ion_phys errors out due to some heap being used that they didn't expect. Add the heap name and heap type to the error message to make it more obvious. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 4 ++-- 1 file changed, 2 inser

[PATCH] staging: ion: always initialize the free list parameters

2015-01-08 Thread Mitchel Humpherys
ly in ion_device_add_heap, which is always called no matter which heap features are being used. Signed-off-by: Mitchel Humpherys --- drivers/staging/android/ion/ion.c | 3 +++ drivers/staging/android/ion/ion_heap.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/androi

UAPI headers in staging drivers?

2014-06-02 Thread Mitchel Humpherys
What's the protocol for UAPI headers in staging drivers? Specifically, I'm wondering how people usually install those headers. For example, there are a bunch of Android UAPI headers under drivers/staging/android/uapi which currently end up at /drivers with a call to `make headers_install'. All othe

Re: [PATCH v2 0/9] staging: ion: system heap and page pool fixes

2014-05-28 Thread Mitchel Humpherys
learned a new trick with page.lru :). Reviewed-by: Mitchel Humpherys > > Heesub Shin (9): > staging: ion: tidy up a bit > staging: ion: simplify ion_page_pool_total() > staging: ion: remove struct ion_page_pool_item > staging: ion: use compound pages on high order pages for

Re: [PATCH 7/9] staging: ion: remove order argument from free_buffer_page()

2014-05-27 Thread Mitchel Humpherys
On Mon, May 26 2014 at 03:04:59 AM, Heesub Shin wrote: > Not that the pages returned from the pool are compound pages, we do not > need to pass the order information to free_buffer_page(). s/Not/Now/ -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Li

Re: [PATCH 6/9] staging: ion: remove struct page_info

2014-05-27 Thread Mitchel Humpherys
On Mon, May 26 2014 at 03:04:58 AM, Heesub Shin wrote: > ION system heap uses a temporary list holding meta data on pages > allocated to build scatter/gather table. Now that the pages are compound > pages, we do not need to introduce a new data type redundantly. > > Signed-off-by: Heesub Shin > -

[RESEND PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-23 Thread Mitchel Humpherys
akes a long time to complete when kmap_cnt starts at ~0 and can result in a watchdog timeout. WARN and bail when kmap_cnt is about to wrap around from zero. Signed-off-by: Mitchel Humpherys Acked-by: Colin Cross --- Resending since I missed a few folks on the original. Also retaining Colin'

Re: [PATCH] staging: ion: WARN when the handle kmap_cnt is going to wrap around

2014-05-23 Thread Mitchel Humpherys
++greg-kh and de...@driverdev.osuosl.org (my bad for missing you the first time around) On Thu, May 22 2014 at 06:09:11 PM, Colin Cross wrote: > On Thu, May 22, 2014 at 5:51 PM, Mitchel Humpherys > wrote: >> There are certain client bugs (double unmap, for example) that can cause &