[PATCH] staging:fwserial:Fix parentheses alignment in fwserial.c

Fix a checkpatch warning for the file, fwserial.c that warns about alignment between parentheses and the line belows code not being properly aligned with each other. Signed-off-by: Nicholas Krause --- drivers/staging/fwserial/fwserial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] staging:ks7010:Fix warning about coding style spacing issue around asterisk in ks_wlan_net.c

This fixes warning around a asterisk used in ks_wlan_net.c for the define statement used for this driver's transmit queue timeout value as defined by the marco, TX_TIMEOUT. Signed-off-by: Nicholas Krause --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH] rtl8192e:Change calls to printk to the more appropriate pr_debug in rtllib_crypt.c

This changes calls to printk with loglevel of KERN_DEBUG to the more appropriate pr_debug as found by running checkpatch on the file,rtllib_crypt.c. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtllib_crypt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

On April 3, 2015 2:30:01 PM EDT, Greg KH wrote: >On Fri, Apr 03, 2015 at 02:05:11PM -0400, Nicholas Krause wrote: >> >> >> On April 3, 2015 1:05:59 PM EDT, Greg KH >wrote: >> >On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote: >> >>

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

On April 3, 2015 1:05:59 PM EDT, Greg KH wrote: >On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote: >> >> >> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter > wrote: >> > >> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(str

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

On April 3, 2015 5:19:55 AM EDT, Dan Carpenter wrote: > >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct >net_device *dev) >> IEEE_SOFTMAC_TX_QUEUE)) || >> ((!ieee->softmac_data_hard_start_xmit && >> (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)

[PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

This changes the remaining printk statements with the log level of KERN_INFO to use the more appropriate netdev_info for print messages related to code using or part of the networking subsystem. Further more this was found by running checkpatch.pl on the file, rtllib_tx.c. Signed-off-by: Nicholas

Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket

On March 24, 2015 3:08:09 AM EDT, Dan Carpenter wrote: >On Mon, Mar 23, 2015 at 05:08:52PM -0400, Nicholas Krause wrote: >> >> >> On March 23, 2015 9:06:26 AM EDT, Dan Carpenter > wrote: >> >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote

Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket

On March 23, 2015 9:06:26 AM EDT, Dan Carpenter wrote: >On Mon, Mar 23, 2015 at 08:53:19AM -0400, Nicholas Krause wrote: >> >> >> On March 23, 2015 6:40:06 AM EDT, Dan Carpenter > wrote: >> >On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote: &

Re: [PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket

On March 23, 2015 6:40:06 AM EDT, Dan Carpenter wrote: >On Sun, Mar 22, 2015 at 08:04:35PM -0400, Nicholas Krause wrote: >> Fixes the checkpath.pl error where the opening bracket has a unneeded >space between >> it and the function name for a if statement in the >marco

[PATCH 2/2] octeon:Make of_device_id structure const in octeon-hcd.c

This fixes the checkpatch.pl warning about recommending the of_device_id structure,octeon_usb_match to be defined const in octeon-hcd.c Signed-off-by: Nicholas Krause --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 1/2] octeon-usb:Fix coding style issue with space between function name and opening bracket

Fixes the checkpath.pl error where the opening bracket has a unneeded space between it and the function name for a if statement in the marco,VMX_WAIT_FOR_FIELD32. Signed-off-by: Nicholas Krause --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH RESEND] staging:fbtft:Fix build warnings for incorrently using %d for size_t variables in dev_err statements

Fixes the build warnings for using %d for a variable of type size_t in dev_err statements for the functions,fbtft_read_spi and fbtft_write_spi_emulate_9 respectfully by changing both dev_error calls to use the correct format specifier,zu for size_t instead. Signed-off-by: Nicholas Krause

[PATCHv2 2/2] rtl8192u:Remove commented declartions of the structure type, _STA_QOS in ieee80211.h and r8192U_dm.c

This removes the commented declarations of the structure type, _STA_QOS due to us no longer having this structure declartion having now been removed from the header file,rtl819x_Qos.h due to no declartions of this type present anymore. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192u

[PATCHv2 1/2] iee80211:Remove no longer required strutucre defintion, _STA_QOS in rtl819x_Qos.h

Removes the no longer required structure definition,_STA_QOS due to no functions using any structures of this type anymore. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 48 1 file changed, 48 deletions(-) diff --git a/drivers

Re: [PATCH] iee80211:Remove no longer required strutucre defintion, _STA_QOS in rtl819x_Qos.h

# On March 6, 2015 5:13:09 PM EST, "Giedrius Statkevičius" wrote: >On 2015.03.06 23:20, Nicholas Krause wrote: >> Removes the no longer required structure definition,_STA_QOS due to >> no functions using any structures of this type anymore. >> &g

[PATCH] iee80211:Remove no longer required strutucre defintion, _STA_QOS in rtl819x_Qos.h

Removes the no longer required structure definition,_STA_QOS due to no functions using any structures of this type anymore. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 48 1 file changed, 48 deletions(-) diff --git a/drivers

Re: [PATCH] comedi: Change error return code for if statement in the function, cb_pcimdas_ai_rinsn

On February 26, 2015 6:09:56 AM EST, Ian Abbott wrote: >On 25/02/15 21:37, Nicholas Krause wrote: >> >> >> On February 25, 2015 1:03:14 PM EST, Hartley Sweeten > wrote: >>> On Tuesday, February 24, 2015 9:13 PM, Nicholas Krause wrote: >>>> This c

RE: [PATCH] comedi: Change error return code for if statement in the function, cb_pcimdas_ai_rinsn

On February 25, 2015 1:03:14 PM EST, Hartley Sweeten wrote: >On Tuesday, February 24, 2015 9:13 PM, Nicholas Krause wrote: >> This changes us using the incorrect error,-ETIMEOUT when checking if >> the channel we are allocating to on the device structure pointer >passed >

[PATCH] comedi: Change error return code for if statement in the function, cb_pcimdas_ai_rinsn

-by: Nicholas Krause --- drivers/staging/comedi/drivers/cb_pcimdas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b/drivers/staging/comedi/drivers/cb_pcimdas.c index 70dd2c9..d91a6f3 100644 --- a/drivers/staging/comedi/drivers

[PATCH] staging:fbtft:Fix build warnings for incorrently using %d for size_t variables in dev_err statements

Fixes the build warnings for using %d for a variable of type size_t in dev_err statements for the functions,fbtft_read_spi and fbtft_write_spi_emulate_9 respectfully by changing both dev_error calls to use the correct format specifier for size_t instead. Signed-off-by: Nicholas Krause

[PATCH 2/2] drivers:staging:rtl8192u:Fix spacing issues found with checkpatch on the file, rtl819x_Qos.h

This fixes various checkpatch spacing issues found when run on rtl819x_Qos.h. The spacing issues fixed are spacing around brackets and spacing around certain symbols in marco definitions. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 48

[PATCH 1/2] drivers:staging:rtl8192u: Change all C99 comments to standard style C comments in rtl819x_QOS.h

This changes all C99 comments found in rtl819x_QOS.h to standard C style comments as found by running checkpatch on this file. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 352 +++ 1 file changed, 176 insertions(+), 176 deletions

[PATCH] staging wlan-ng: Add missing a blank line after declarations

Fixing trivial checkpatch warnings about missing line after declarations. Signed-off-by: Nicholas Krause --- Tested by compilation only. drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng

[PATCH] staging wlan-ng: Add missing a blank line after declarations

Fixing trivial checkpatch warnings about missing line after declarations. Signed-off-by: Nicholas Krause --- Tested by compilation only. drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng

[PATCHv3] staging: Check for Null allocated skb in fw_download_code

additon I removed the variable, rt_status as it's easier to read this function's return value with just true or false and rt status is a unneeded variable for the bool return of this function. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +++

[PATCHv2] staging: Check against NULL in fw_download_code

I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461. This entry states that we are not checking the skb allocated in fw_download_code and after checking I fixed it to check for the NULL value before using the allocate skb. Signed-off-by: Nicholas Krause --- drivers

[PATCH] staging: Check against NULL in fw_download_code

I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461. This entry states that we are not checking the skb allocated in fw_download_code and after checking I fixed it to check for the NULL value before using the allocate skb. Signed-off-by: Nicholas Krause --- drivers

[PATCH] staging: Remove checkpatch errors in InterfaceMarcos.h

This removes the two errors I get when running checkpatch on this file. The first being not to use C99 comments and the second to remove spacing issues with the define statement on line 7. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/InterfaceMacros.h | 4 ++-- 1 file changed, 2

[PATCH] staging: Join lines in IntefaceIdleMode.c

This joins two lines that need to be joined as this improves the coding style and makes it much easier to read. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/InterfaceIdleMode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/bcm

[PATCH] staging: Fix space issues for header of headers.h

This patch fixes the space errors checkpatch gives on this file for the header of this file. Signed-off-by: Nicholas Krause --- drivers/staging/bcm/headers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/headers.h b/drivers/staging/bcm/headers.h index

[PATCH] staging: Add blank line in sync.c

This patch adds a blank line after line 708 as declared when running checkpatch on this file. Signed-off-by: Nicholas Krause --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index e7b2e02

[PATCH] staging: Add blank lines in sw_sync.c

This adds two blank lines as stated by checkpatch before lines, 100 and 159 respectively. Signed-off-by: Nicholas Krause --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index

[PATCH] staging: Remove checkpatch error from ion.c

This patch removes a checkpatch error by adding a line below the definitions of the character array buf and the pointer path. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers

[PATCH] staging: Change kzalloc to kcalloc

This changes the call to kzalloc to kcalloc in ion_dummy_driver for allocating the heap. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b

[PATCH] staging: Remove checkpatch errors in ion.c for android staging

emory allocated in ion_dma_buf_kmap. Signed-off-by: Nicholas Krause --- drivers/staging/android/ion/ion.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 389b8f6..934d55d 100644 --- a/drivers/staging/android/ion/ion.c

[PATCH] staging: Fix a Fix me in tranzport.c

This patch add a atomic lock in usb_tranzport_usb for preventing a tiny race in this function. Signed-off-by: Nicholas Krause --- drivers/staging/frontier/tranzport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/frontier/tranzport.c b/drivers/staging

[PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

Rewrites the wireless check for legacy checking in function halbtc_legacy to check for both Mode A and B. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/btcoexist

[PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to returning true of false directly. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 --- 1 file changed

[PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to returning true of false directly. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 --- 1 file changed

[PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to returning true of false directly. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7 --- 1 file changed

[PATCH] staging: rtl8192e: check return value of dev_skb_alloc

--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..d8a9427 100644 --- a/drivers/staging/rtl8192e/

[PATCH] Checks if dev_skb_alloc returns Null in function,

--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..d8a9427 100644 --- a/drivers/staging/rtl8192e/

[PATCH] staging: rtl8192e: check return value of dev_skb_alloc

Checks if dev_skb_alloc returns Null in function, fw_download_code. If the return value of dev_skb_alloc is NULL return false and exit this function. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -61,6 +61,10 @@ static bool fw

[PATCH 1/2] Fixes no Null check of dev_skb_alloc in fw_download_code

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -61,6 +61,10 @@ static bool fw

[PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..fde17ff 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -62,12 +62,15 @@ static bool f

[PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers

[PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers

[PATCH] Checks for Null return of skb_alloc in function fw_download_code

Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..fde17ff 100644

[PATCHv2] Fixes function fw_download_code to check for Null return from dev_skb_alloc

Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..e4c8224 100644

[PATCHv2] Check if skb_alloc returns Null in function fw_download_code

Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..11e915e 100644 --- a/drivers

[PATCHv2] Check if skb_alloc returns Null in function fw_download_code

Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..11e915e 100644 --- a/drivers

[PATCH] Check if skb_alloc returns Null in function fw_download_code

Signed-off-by: Nicholas Krause --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..11e915e 100644 --- a/drivers