Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-18 Thread Nicolas Dufresne
Le dimanche 16 mai 2021 à 20:04 -0300, Ezequiel Garcia a écrit : > Hi Hans, > > On Thu, 2021-05-06 at 14:50 +0200, Hans Verkuil wrote: > > On 05/05/2021 17:20, Benjamin Gaignard wrote: > > > > > > Le 05/05/2021 à 16:55, Hans Verkuil a écrit : > > > > On 20/04/2021 14:10, Benjamin Gaignard wrote:

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-06 Thread Nicolas Dufresne
Le jeudi 06 mai 2021 à 14:11 +0100, John Cox a écrit : > > On 05/05/2021 17:20, Benjamin Gaignard wrote: > > > > > > Le 05/05/2021 à 16:55, Hans Verkuil a écrit : > > > > On 20/04/2021 14:10, Benjamin Gaignard wrote: > > > > > The HEVC HANTRO driver needs to know the number of bits to skip at > >

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

2021-05-05 Thread Nicolas Dufresne
Hi Hans, just a partial reply, I'll let Andrzej extend. Le jeudi 29 avril 2021 à 12:20 +0200, Hans Verkuil a écrit : > > +  - ``frame_width_minus_1`` > > +  - Add 1 to get the frame width expressed in pixels. > > +    * - __u16 > > +  - ``frame_height_minus_1`` > > +  - Add 1 to g

Re: [PATCH v10 6/9] media: uapi: Add a control for HANTRO driver

2021-05-05 Thread Nicolas Dufresne
Le mercredi 05 mai 2021 à 16:18 +0100, John Cox a écrit : > > The HEVC HANTRO driver needs to know the number of bits to skip at > > the beginning of the slice header. > > That is a hardware specific requirement so create a dedicated control > > for this purpose. > > > > Signed-off-by: Benjamin Ga

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-29 Thread Nicolas Dufresne
Le jeudi 29 avril 2021 à 11:23 +0200, Hans Verkuil a écrit : > On 27/04/2021 01:34, Ezequiel Garcia wrote: > > On Mon, 26 Apr 2021 at 14:38, Nicolas Dufresne wrote: > > > > > > Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit : > > > > Hi Andrzej,

Re: [RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-26 Thread Nicolas Dufresne
Le lundi 26 avril 2021 à 09:38 +0200, Hans Verkuil a écrit : > Hi Andrzej, > > Thank you for working on this! > > On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote: > > Dear All, > > > > This is an RFC on stateless uapi for vp9 decoding with v4l2. This work is > > based on https://lkml.org/lkml/

Re: [PATCH v2] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-17 Thread Nicolas Dufresne
Le jeudi 17 septembre 2020 à 20:27 -0400, Nicolas Dufresne a écrit : > As per spec, the CAPTURE resolution should be automatically set based on > the OTUPUT resolution. This patch properly propagate width/height to the > capture when the OUTPUT format is set and override the user provide

[PATCH v2] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-17 Thread Nicolas Dufresne
. This also prevents userspace from selecting a CAPTURE resolution that is too small, avoiding kernel oops. Signed-off-by: Nicolas Dufresne Reviewed-by: Ezequiel Garcia Acked-by: Paul Kocialkowski Tested-by: Ondrej Jirman --- .../staging/media/sunxi/cedrus/cedrus_video.c | 29

Re: [PATCH] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-09-17 Thread Nicolas Dufresne
Le jeudi 17 septembre 2020 à 12:39 +0200, Hans Verkuil a écrit : > On 14/05/2020 17:39, Nicolas Dufresne wrote: > > As per spec, the CAPTURE resolution should be automatically set based on > > the OTUPUT resolution. This patch properly propagate width/height to the > > ca

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-26 Thread Nicolas Dufresne
Le mardi 25 août 2020 à 13:30 +0200, Mauro Carvalho Chehab a écrit : > Em Tue, 25 Aug 2020 05:29:29 +1000 > Dave Airlie escreveu: > > > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart > > wrote: > > > Hi Mauro, > > > > > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:

Re: [PATCH 1/3] media: uapi: h264: update reference lists

2020-07-08 Thread Nicolas Dufresne
Le mercredi 08 juillet 2020 à 17:57 +0200, Jernej Škrabec a écrit : > Hi! > > Dne sreda, 08. julij 2020 ob 15:28:52 CEST je Ezequiel Garcia napisal(a): > > Hello Jernej, > > > > I'd like to post a new H264 uAPI cleanup series soon, > > would you mind resending this, or otherwise do you > > mind i

Re: [PATCH 0/3] media: uapi: cedrus: Fix decoding interlaced H264 content

2020-06-07 Thread Nicolas Dufresne
Le dimanche 07 juin 2020 à 16:21 -0400, Nicolas Dufresne a écrit : > Le samedi 06 juin 2020 à 09:46 -0300, Ezequiel Garcia a écrit : > > Hi Jernej, > > > > On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote: > > > Currently H264 interlaced content it's not prop

Re: [PATCH 0/3] media: uapi: cedrus: Fix decoding interlaced H264 content

2020-06-07 Thread Nicolas Dufresne
Le samedi 06 juin 2020 à 09:46 -0300, Ezequiel Garcia a écrit : > Hi Jernej, > > On Thu, 4 Jun 2020 at 15:55, Jernej Skrabec wrote: > > Currently H264 interlaced content it's not properly decoded on Cedrus. > > There are two reasons for this: > > 1. slice parameters control doesn't provide enough

Re: [PATCH 2/3] media: cedrus: h264: Properly configure reference field

2020-06-05 Thread Nicolas Dufresne
ay hold both fields. > > Fix this by checking newly introduced flags in reference lists. > > Signed-off-by: Jernej Skrabec Perhaps an additional patch could cleanup the miss-leading comment in v4l2_h264_dpb_entry definition. Reviewed-by: Nicolas Dufresne > --- > driv

Re: [PATCH 1/3] media: uapi: h264: update reference lists

2020-06-05 Thread Nicolas Dufresne
ill come in > following commit. > > Signed-off-by: Jernej Skrabec This looks like the right approach to me and is extensible if anything else is needed for MVC and SVC special referencing (at least will be enough for what H.264 actually supports in this regard). Reviewed-by: Nicolas Dufr

Re: [PATCH 1/3] media: uapi: h264: update reference lists

2020-06-05 Thread Nicolas Dufresne
Sorry, missed one thing. Le vendredi 05 juin 2020 à 13:08 -0400, Nicolas Dufresne a écrit : > Le jeudi 04 juin 2020 à 20:57 +0200, Jernej Skrabec a écrit : > > When dealing with with interlaced frames, reference lists must tell if > > each particular reference is meant for top

Re: [PATCH] media: cedrus: Add support for VP8 decoding

2020-05-20 Thread Nicolas Dufresne
Le mercredi 20 mai 2020 à 23:01 +0200, Jernej Skrabec a écrit : > VP8 in Cedrus shares same engine as H264. > > Note that it seems necessary to call bitstream parsing functions, > to parse frame header, otherwise decoded image is garbage. This is > contrary to what is driver supposed to do. Howeve

Re: [PATCH] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-05-14 Thread Nicolas Dufresne
Le jeudi 14 mai 2020 à 11:39 -0400, Nicolas Dufresne a écrit : > As per spec, the CAPTURE resolution should be automatically set based on > the OTUPUT resolution. This patch properly propagate width/height to the > capture when the OUTPUT format is set and override the user provided >

[PATCH] media: cedrus: Propagate OUTPUT resolution to CAPTURE

2020-05-14 Thread Nicolas Dufresne
. This also prevents userspace from selecting a CAPTURE resolution that is too small, avoiding unwanted page faults. Signed-off-by: Nicolas Dufresne --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media

Re: [PATCH] media: hantro: Support H264 profile control

2020-01-18 Thread Nicolas Dufresne
Le vendredi 10 janvier 2020 à 13:31 +0100, Hans Verkuil a écrit : > On 11/29/19 1:16 AM, Tomasz Figa wrote: > > On Sat, Nov 23, 2019 at 1:52 AM Nicolas Dufresne > > wrote: > > > Le samedi 23 novembre 2019 à 01:00 +0900, Tomasz Figa a écrit : > > > > On S

Re: [PATCH] media: hantro: Support H264 profile control

2019-11-22 Thread Nicolas Dufresne
Le samedi 23 novembre 2019 à 01:00 +0900, Tomasz Figa a écrit : > On Sat, Nov 23, 2019 at 12:09 AM Nicolas Dufresne > wrote: > > Le vendredi 22 novembre 2019 à 14:16 +0900, Hirokazu Honda a écrit : > > > The Hantro G1 decoder supports H.264 profiles from Baseline to

Re: [PATCH] media: hantro: Support H264 profile control

2019-11-22 Thread Nicolas Dufresne
Le vendredi 22 novembre 2019 à 14:16 +0900, Hirokazu Honda a écrit : > The Hantro G1 decoder supports H.264 profiles from Baseline to High, with > the exception of the Extended profile. > > Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE control, so that the > applications can query the driver for the

Re: [PATCH 5/8] media: cedrus: Detect first slice of a frame

2019-08-30 Thread Nicolas Dufresne
Le vendredi 30 août 2019 à 07:48 +0200, Boris Brezillon a écrit : > On Thu, 29 Aug 2019 21:04:28 +0200 > Jernej Škrabec wrote: > > > Dne ponedeljek, 26. avgust 2019 ob 20:28:31 CEST je Boris Brezillon > > napisal(a): > > > Hi Jernej, > > > > > > On Thu, 22 Aug 2019 21:44:57 +0200 > > > > > > J

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-28 Thread Nicolas Dufresne
Le vendredi 28 juin 2019 à 16:08 +0200, Hans Verkuil a écrit : > On 6/28/19 4:00 PM, Nicolas Dufresne wrote: > > Le vendredi 28 juin 2019 à 11:10 +0100, Dave Stevenson a écrit : > > > Hi Nicolas > > > > > > On Thu, 27 Jun 2019 at 20:55, Nicolas Duf

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-28 Thread Nicolas Dufresne
Le vendredi 28 juin 2019 à 11:10 +0100, Dave Stevenson a écrit : > Hi Nicolas > > On Thu, 27 Jun 2019 at 20:55, Nicolas Dufresne wrote: > > Hi Dave, > > > > Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit : > > > From: Dave Stevenson > >

Re: [PATCH 19/31] staging: bcm2835-camera: Ensure timestamps never go backwards.

2019-06-27 Thread Nicolas Dufresne
Le jeudi 27 juin 2019 à 20:56 +0200, Stefan Wahren a écrit : > From: Dave Stevenson > > There is an awkward situation with H264 header bytes. Currently > they are returned with a PTS of 0 because they aren't associated > with a timestamped frame to encode. These are handled by either > returning

Re: [PATCH 01/31] staging: bcm2835-camera: Ensure H264 header bytes get a sensible timestamp

2019-06-27 Thread Nicolas Dufresne
Hi Dave, Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit : > From: Dave Stevenson > > H264 header come from VC with 0 timestamps, which means they get a > strange timestamp when processed with VC/kernel start times, > particularly if used with the inline header option. > Remember the

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-29 Thread Nicolas Dufresne
Le mardi 29 janvier 2019 à 16:44 +0900, Alexandre Courbot a écrit : > On Fri, Jan 25, 2019 at 10:04 PM Paul Kocialkowski > wrote: > > Hi, > > > > On Thu, 2019-01-24 at 20:23 +0800, Ayaka wrote: > > > Sent from my iPad > > > > > > > On Jan 24, 2019, at 6:27 PM, Paul Kocialkowski > > > > wrote:

Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

2018-03-19 Thread Nicolas Dufresne
Le mardi 20 mars 2018 à 00:46 +, Rohit Athavale a écrit : > Hi Hans, > > Thanks for taking the time to take a look at this. > > > This should definitely use the V4L2 API. I guess it could be added > > to staging/media with a big fat TODO that this should be converted > > to > > the V4L2 mem2m

Re: [PATCH v2 0/3] Initial driver support for Xilinx M2M Video Scaler

2018-02-22 Thread Nicolas Dufresne
Le mercredi 21 février 2018 à 14:43 -0800, Rohit Athavale a écrit : > This patch series has three commits : > - Driver support for the Xilinx M2M Video Scaler IP > - TODO document > - DT binding doc > > Changes in HW register map is expected as the IP undergoes changes. > This is a first attemp

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-10 Thread Nicolas Dufresne
Le dimanche 10 décembre 2017 à 21:56 +0300, Dmitry Osipenko a écrit : > > I've CC-ed Maxime and Giulio as well: they are looking into adding support > > for > > the stateless allwinner codec based on this code as well. There may well be > > opportunities for you to work together, esp. on the users

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-11 Thread Nicolas Dufresne
Le mercredi 11 octobre 2017 à 23:08 +0300, Dmitry Osipenko a écrit : > diff --git a/drivers/staging/tegra-vde/TODO b/drivers/staging/tegra- > vde/TODO > new file mode 100644 > index ..e98bbc7b3c19 > --- /dev/null > +++ b/drivers/staging/tegra-vde/TODO > @@ -0,0 +1,5 @@ > +TODO: > +

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-22 Thread Nicolas Dufresne
Le mardi 21 mars 2017 à 11:36 +, Russell King - ARM Linux a écrit : >     warn: v4l2-test-formats.cpp(1187): S_PARM is > supported for buftype 2, but not ENUM_FRAMEINTERVALS >     warn: v4l2-test-formats.cpp(1194): S_PARM is > supported but doesn't report V4L2_CAP_TIMEPE

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 14:21 +, Russell King - ARM Linux a écrit : > > Can it be a point of failure? > > There's a good reason why I dumped a full debug log using > GST_DEBUG=*:9, > analysed it for the cause of the failure, and tried several different > pipelines, including the standard ba

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 09:55 +, Russell King - ARM Linux a écrit : > 2) would it also make sense to allow gstreamer's v4l2src to try > setting >    a these parameters, and only fail if it's unable to set it?  IOW, > if >    I use: > > gst-launch-1.0 v4l2src device=/dev/video10 ! \ >   

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 00:54 +, Russell King - ARM Linux a écrit : > > > > In practice, I have the impression there is a fair reason why > > framerate > > enumeration isn't implemented (considering there is only 1 valid > > rate). > > That's actually completely incorrect. > > With the ca

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Nicolas Dufresne
Le samedi 18 mars 2017 à 20:43 +, Russell King - ARM Linux a écrit : > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > Can you share your gstreamer pipeline? For now, until > > VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that > > does not attempt to specify a fra

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-15 Thread Nicolas Dufresne
Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs > > with those, it will likely run with any other application. > > > > I would like to add the 'v4l2src' plugin of gstreamer, and on the > imx6 its While i

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-14 Thread Nicolas Dufresne
Le mardi 14 mars 2017 à 15:47 +0100, Benjamin Gaignard a écrit : > Should we use /devi/ion/$heap instead of /dev/ion_$heap ? > I think it would be easier for user to look into one directory rather > then in whole /dev to find the heaps > > > is that we don't have to worry about a limit of 32 possi

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Nicolas Dufresne
Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > The event must be user visible, otherwise the user has no indication > > > the error, and can't correct i