[PATCH] staging: lustre/lnet: Fix wrong type casting warning generated by sparse

2016-02-13 Thread Niranjan Dighe
-by: Niranjan Dighe <niranjan.di...@gmail.com> --- drivers/staging/lustre/lnet/selftest/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c index 366211e..64b6a70

Re: [PATCH] staging: lustre/lnet: Fix wrong type casting warning generated by sparse

2016-02-13 Thread Niranjan Dighe
On Sun, Feb 14, 2016 at 3:19 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Sat, Feb 13, 2016 at 11:34:35PM +0530, Niranjan Dighe wrote: >> diff --git a/drivers/staging/lustre/lnet/selftest/console.c >> b/drivers/staging/lustre/lnet/selftest/console.c >> in

[PATCH] staging: lustre/lnet: Fix wrong typecasting warning generated by sparse

2016-02-13 Thread Niranjan Dighe
this by removing the unnecessary char pointer type cast. Signed-off-by: Niranjan Dighe <niranjan.di...@gmail.com> --- drivers/staging/lustre/lnet/selftest/console.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/d

Re: [PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse

2016-02-07 Thread Niranjan Dighe
On Thu, Feb 4, 2016 at 3:53 AM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Sun, Jan 03, 2016 at 08:27:04AM +0530, Niranjan Dighe wrote: >> Added annotation '__must_hold' to function ksocknal_send_keepalive_locked >> which unlocks the lock ksocknal_

[PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse

2016-01-02 Thread Niranjan Dighe
Added annotation '__must_hold' to function ksocknal_send_keepalive_locked which unlocks the lock ksocknal_data.ksnd_global_lock. As this lock is not acquired in the current function, sparse warns about context imbalance Signed-off-by: Niranjan Dighe <niranjan.di...@gmail.com> --- drivers/s

Re: [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse

2015-12-22 Thread Niranjan Dighe
On Wed, Dec 23, 2015 at 3:34 AM, Dilger, Andreas <andreas.dil...@intel.com> wrote: > On 2015/12/22, 06:05, "Niranjan Dighe" <niranjan.di...@gmail.com> wrote: > >>On Tue, Dec 22, 2015 at 5:14 AM, Greg Kroah-Hartman >><gre...@linuxfoundation.org> wrote

Re: [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse

2015-12-22 Thread Niranjan Dighe
On Tue, Dec 22, 2015 at 5:14 AM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Wed, Dec 09, 2015 at 10:38:13PM +0530, Niranjan Dighe wrote: >> The third argument to function kportal_memhog_alloc is expected to >> be gfp_t whereas the actual argument

[PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse

2015-12-09 Thread Niranjan Dighe
The third argument to function kportal_memhog_alloc is expected to be gfp_t whereas the actual argument was unsigned int. Fix this by explicitly typecasting to gfp_t Signed-off-by: Niranjan Dighe <niranjan.di...@gmail.com> --- drivers/staging/lustre/lustre/libcfs/module.c | 2 +- 1 file c

[PATCH v2 1/2] Staging: slicoss: Remove redundant and disabled code block

2015-03-26 Thread Niranjan Dighe
Removing code guarded by undefined macro SLIC_TRACE_DUMP_ENABLED Signed-off-by: Niranjan Dighe niranjan.di...@gmail.com diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 3104cb0..c2bda1d 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging

[PATCH v2 2/2] Staging: slicoss: Get rid of redundant pointer variable

2015-03-26 Thread Niranjan Dighe
Replace string directly in place of format string and remove pointer variable which was used just once. Signed-off-by: Niranjan Dighe niranjan.di...@gmail.com diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index c2bda1d..f3110f7 100644 --- a/drivers/staging

[PATCH] Staging: rtl8188eu: replace kzalloc and memcpy by kmemdup

2015-03-24 Thread Niranjan Dighe
This was generated by 'make coccicheck' using scripts at scripts/coccinelle/api/memdup.cocci. Signed-off-by: Niranjan Dighe niranjan.di...@gmail.com diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index 86d955f..be9e34a 100644

Staging: slicoss: Fix checkpatch.pl issues

2015-03-24 Thread Niranjan Dighe
The following files had coding style issues that I tried to address. It was mostly about lines spanning more than 80 characters. Signed-off-by: Niranjan Dighe niranjan.di...@gmail.com diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 3104cb0..2161bdb

[PATCH] Staging: slicoss: Fix checkpatch.pl issues

2015-03-24 Thread Niranjan Dighe
Removed unused block of code guarded by #ifdef SLIC_TRACE_DUMP_ENABLED And removed redundant static char *slic_banner and replaced actual string in place of format string. Signed-off-by: Niranjan Dighe niranjan.di...@gmail.com diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging