fbtft: 5 years in staging

Hi, Since I'm the original author of fbtft I thought I'd highlight a couple of issues that's probably not well known. Right after fbtft was added, fbdev was closed for new drivers[1] and the fbdev maintainer wanted to remove fbtft as a consequence of that decision, but Greg KH said he'd keep

Re: fbtft: 5 years in staging

Den 02.02.2020 16.41, skrev Noralf Trønnes: > Hi, > > Since I'm the original author of fbtft I thought I'd highlight a couple > of issues that's probably not well known. > > Right after fbtft was added, fbdev was closed for new drivers[1] and > the fbdev maintainer w

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

Den 20.11.2019 15.43, skrev Noralf Trønnes: > > > Den 20.11.2019 10.57, skrev Andy Shevchenko: >> First of all there is no need to guard GPIO request by CONFIG_OF. >> It works for everybody independently on resource provider. While here, >> rename the fu

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

Den 20.11.2019 10.57, skrev Andy Shevchenko: > First of all there is no need to guard GPIO request by CONFIG_OF. > It works for everybody independently on resource provider. While here, > rename the function to reflect the above. > > Moreover, since we have a global dependency to OF, the rest

[PATCH 3/3] staging/fbtft: Remove flexfb

flexfb was an attempt to write a generic fbtft driver that was abandoned. All the displays it supports are supported by other fbtft drivers. Signed-off-by: Noralf Trønnes --- drivers/staging/fbtft/Kconfig | 6 - drivers/staging/fbtft/Makefile | 1 - drivers/staging/fbtft/flexfb.c | 851

[PATCH 2/3] staging/fbtft: Remove fbtft_device

ust remove the module since it's the responsibility of Device Tree, ACPI or platform code to add devices. Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") Signed-off-by: Noralf Trønnes --- drivers/staging/fbtft/Kconfig|4 - drivers/staging/fbtft/M

[PATCH 1/3] staging/fbtft: Depend on OF

uest_gpios is not set in that case anymore. Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") Cc: stable Signed-off-by: Noralf Trønnes --- drivers/staging/fbtft/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbt

Re: [PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

Den 02.03.2017 14.04, skrev simran singhal: This patch fixes the following sparse warnings: drivers/staging/fbtft/fbtft-bus.c:166:36: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-bus.c:166:36:expected unsigned short [unsigned] [short]

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

Den 26.02.2017 19.11, skrev Stefan Wahren: Eric Anholt hat am 26. Februar 2017 um 18:16 geschrieben: ... For staging, Greg has been taking patches without platform maintainer ack. I think this is great -- the staging code needs *lots* of work, and it generally doesn't need

[PATCH] MAINTAINERS: Remove Noralf Trønnes as fbtft maintainer

Due to personal reasons I'm unable to continue as fbtft maintainer. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- For a long time I have wanted to convert the fbtft drivers to drm. There's now a foundation in place to do so in drivers/gpu/drm/tinydrm. Because of a worsening f

Re: [PATCH v3 0/5] fbtft: make it work with DMA enabled SPI

rkfun for Intel Edison) OLED displays at their maximum speed (25MHz and 10MHz). Noralf, are you okay with this version of series? Yes, Greg applies them without my ack, unless it touches core stuff. Series: Acked-by: Noralf Trønnes <nor...@tronnes.org> Since v2: - fix kbuild bot warni

staging/fbtft: Backward Device Tree compatibility in a drm version

Hi, I'm working on a drivers/gpu/drm version of drivers/staging/fbtft which are drivers for tiny, usually SPI connected, displays. Now I'm wondering if I can be backwards compatible and support Device Trees written for the fbtft drivers. The main obstacle as I understand it, is the init property

Re: [PATCH v2 5/6] staging: fbtft: fb_ssd1306: Support smaller screen sizes

and 6: Acked-by: Noralf Trønnes <nor...@tronnes.org> drivers/staging/fbtft/fb_ssd1306.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c index 80fc57029fee..bede2d5a5571 100644 --- a/drivers/s

Re: [PATCH v2 3/6] staging: fbtft: fallback to usual allocation when DMA fails

Den 03.01.2017 17:12, skrev Andy Shevchenko: On Mon, 2017-01-02 at 13:35 +0200, Andy Shevchenko wrote: Fall back to usual allocation method if DMA coherent allocation fails. SPI framework will map and use DMA mapped memory when possible. Locally I have re-done DMA approach and thus this

Re: [PATCH v2 1/6] staging: fbtft: convert fbtft_reset() to be non-atomic

if (par->gpio.reset == -1) return; + + might_sleep(); gpio_set_value_cansleep() already does might_sleep(). So with that removed: Reviewed-by: Noralf Trønnes <nor...@tronnes.org> + fbtft_par_dbg(DEBUG_RESET, par, "%s()\n", __func__); -

Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask

Den 03.01.2017 14:58, skrev Andy Shevchenko: On Tue, 2017-01-03 at 12:51 +0200, Andy Shevchenko wrote: On Mon, 2017-01-02 at 19:14 +0100, Noralf Trønnes wrote: Den 02.01.2017 12:35, skrev Andy Shevchenko: Usually it's not consumer's business to override resources passed from provider

Re: [PATCH v2 2/6] staging: fbtft: do not override DMA coherent mask

Den 02.01.2017 12:35, skrev Andy Shevchenko: Usually it's not consumer's business to override resources passed from provider, in particularly DMA coherent mask. Signed-off-by: Andy Shevchenko --- drivers/staging/fbtft/fbtft-core.c | 1 - 1 file changed, 1

Re: [PATCH] staging: fbtft: do not allocate huge txbuf

[resending got rejected on the list for html format] Den 09.06.2016 19:18, skrev Michal Suchanek: Hello, On 9 June 2016 at 18:20, Noralf Trønnes <nor...@tronnes.org> wrote: Den 09.06.2016 17:08, skrev Michal Suchanek: txbuflen can be set to arbitrary value by user and it is al

Re: [PATCH] staging: fbtft: do not allocate huge txbuf

Den 09.06.2016 17:08, skrev Michal Suchanek: txbuflen can be set to arbitrary value by user and it is also set automagically to the maximum transfer size of the SPI master controller. AFAICT this is a result of your previous patch. Please make a new version of your previous patch with this

Re: [PATCH] fbtft: limit transfer length by spi device limit

s code of mine looks worse each time I'm confronted with it.) You have even taken care of the special txbuflen == -1 value I see, so I guess this is as good as it gets without any major refactoring, so: Acked-by: Noralf Trønnes <nor...@tronnes.org> And there's no point in doing any refactoring si

Re: [PATCH 1/2] staging: fbtft: add support for ST7789V display controller

Den 11.10.2015 09:31, skrev Dennis Menschel: Am 10.10.2015 um 17:36 schrieb Noralf Trønnes: Den 07.10.2015 22:15, skrev Dennis Menschel: This patch adds support for the Sitronix ST7789V display controller. The controller is intended for small color displays with a resolution of up to 320x240

Re: [PATCH 1/2] staging: fbtft: add support for ST7789V display controller

Den 07.10.2015 22:15, skrev Dennis Menschel: This patch adds support for the Sitronix ST7789V display controller. The controller is intended for small color displays with a resolution of up to 320x240 pixels. Signed-off-by: Dennis Menschel --- The future of fbtft is

Re: [PATCH 3/3] staging: fbtft: use pr_fmt

10.09.2015 06:54, skrev Sudip Mukherjee: On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote: Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: Instead of defining DRVNAME and using it in all calls to pr_* family

Re: [PATCH 3/3] staging: fbtft: use pr_fmt

Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: Instead of defining DRVNAME and using it in all calls to pr_* family of macros lets start using pr_fmt. Signed-off-by: Sudip Mukherjee ---

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

Den 01.09.2015 19:52, skrev Brüns, Stefan: On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote: IMHO, this is a bad idea. A controller supporting more than 32 bpw can not set the bpw mask, as the mask is limited to 32 bits. Thus it has to check the bpw in its own setup function

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

Den 01.09.2015 01:28, skrev Stefan Bruens: On Monday 24 August 2015 01:24:59 Noralf Trønnes wrote: Den 24.08.2015 00:24, skrev Stefan Brüns: Avoid a crash, as master->setup may be NULL (e.g. xilinx controller). Even if master->setup is set, spi_setup does several compatibility/ sanity

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

Den 25.08.2015 19:34, skrev Stefan Wahren: Noralf Trønnes nor...@tronnes.org hat am 25. August 2015 um 00:00 geschrieben: Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan

Re: [PATCH 1/2] staging: fbtft: fix 9-bit SPI support detection

stefan.wah...@i2se.com --- drivers/staging/fbtft/fbtft-core.c | 10 +++--- drivers/staging/fbtft/flexfb.c | 11 --- 2 files changed, 7 insertions(+), 14 deletions(-) Thanks Stefan. Both patches: Acked-by: Noralf Trønnes nor...@tronnes.org

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com --- drivers/staging/fbtft/fbtft-core.c |7 +++ drivers/staging/fbtft/flexfb.c |

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master-setup

Den 24.08.2015 00:24, skrev Stefan Brüns: Avoid a crash, as master-setup may be NULL (e.g. xilinx controller). Even if master-setup is set, spi_setup does several compatibility/ sanity checks which should not be skipped (fixes problems with displays/controllers needing emulation for

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

chip controller simply defining a new flexfb_lcd_controller struct. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Acked-by: Noralf Trønnes nor...@tronnes.org --- Seems I wasn't clear enough, you could use my ack if you put struct flexfb_lcd_controller inside the driver and not in fbtft.h

[PATCH] staging: fbtft: core: Don't set device platform_data

. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/fbtft-core.c | 12 +--- drivers/staging/fbtft/fbtft.h | 5 +++-- drivers/staging/fbtft/flexfb.c | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c

Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller

Den 15.07.2015 11:36, skrev Paul Bolle: On di, 2015-07-14 at 14:59 +0200, Henri Chain wrote: --- /dev/null +++ b/drivers/staging/fbtft/fb_uc1611.c +#define DRVNAMEfb_uc1611 +MODULE_ALIAS(spi: DRVNAME); +MODULE_ALIAS(platform: DRVNAME); +MODULE_ALIAS(spi:uc1611);

Re: [PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op

Den 15.07.2015 04:14, skrev Greg KH: On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote: Use a helper function to choose which set_addr_win implementation to use, based on the value of the setaddrwin module parameter. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com ---

Re: [PATCH 03/10] Staging: fbtft: Use a struct to describe each LCD controller

, + .height = 160, + .init_seq = st7735r_init, + .init_seq_sz = ARRAY_SIZE(st7735r_init), + }, + { Can this be put on one line? }, { With the struct moved: Acked-by: Noralf Trønnes nor...@tronnes.org ___ devel mailing

Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller

Den 14.07.2015 14:59, skrev Henri Chain: This is a driver chip for 240x160 4-bit greyscale LCDs. It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been tested. (It also has a 6800 or 8080-style parallel interface, but I have not included support for it.) Signed-off-by: Henri

[PATCH] staging: fbtft: Add reset to fbtft_init_display_dt()

When an init sequence is present in the Device Tree, fbtft_init_display_dt() is used to initialize the display. Add missing reset function call and activation of chip select for parallel bus. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/fbtft-core.c | 5 + 1

Re: [RFC 0/7] staging: fbtft: minimize coupling to the fbdev subsystem

Den 02.03.2015 11:54, skrev Noralf Trønnes: Hi, This patchset introduces a new API to minimize the coupling to the fbdev graphics subsystem. There have been calls to deprecate fbdev and new fbdev drivers are discouraged. Currently the FBTFT drivers are tightly coupled to fbdev through

Re: [RFC 5/7] staging: fbtft: don't require platform data

Den 02.03.2015 12:31, skrev Dan Carpenter: On Mon, Mar 02, 2015 at 11:54:27AM +0100, Noralf Trønnes wrote: Add dummy platform data when it's not present. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/fbtft-core.c | 6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH] Staging: fbtft: move externs to header file

Den 03.03.2015 11:19, skrev Drew Fustini: Move extern declartions from fbtft-core.c to fbtft header file. This resovles the warning from checkpatch.pl that externs should be avoided in .c files. Signed-off-by: Drew Fustini pdp7p...@gmail.com --- drivers/staging/fbtft/fbtft-core.c | 5 -

Re: [RFC 3/7] staging: fbtft: add lcd controller abstraction

Den 03.03.2015 13:04, skrev Dan Carpenter: On Tue, Mar 03, 2015 at 12:57:29PM +0100, Noralf Trønnes wrote: + ret = ctrl-rotate(ctrl, rotation); + if (!ret) + ctrl-rotation = rotation; + + return ret; Better to check if (ret) consistently (error handling vs

Re: [RFC 3/7] staging: fbtft: add lcd controller abstraction

Den 02.03.2015 12:48, skrev Dan Carpenter: [snip] + if (ctrl-power_supply) { + ret = regulator_enable(ctrl-power_supply); + if (ret) { + dev_err(ctrl-lcdreg-dev, + failed to enable power supply: %d\n, ret);

Re: [RFC 1/7] staging: fbtft: add lcd register abstraction

Den 02.03.2015 13:25, skrev Dan Carpenter: On Mon, Mar 02, 2015 at 11:54:23AM +0100, Noralf Trønnes wrote: diff --git a/drivers/staging/fbtft/lcdreg/lcdreg-debugfs.c b/drivers/staging/fbtft/lcdreg/lcdreg-debugfs.c [snip] +static int lcdreg_userbuf_to_u32(const char __user *user_buf, size_t

[RFC 1/7] staging: fbtft: add lcd register abstraction

Add LCD register abstraction for MIPI DCS like controllers. This hides LCD controller interface implementation details. When built with debugfs, the register is available to userspace. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/Kconfig | 2

[RFC 3/7] staging: fbtft: add lcd controller abstraction

Add abstraction for MIPI DCS/DBI like LCD controllers. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/Kconfig | 1 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/lcdctrl/Kconfig | 3 + drivers/staging/fbtft/lcdctrl/Makefile

[RFC 4/7] staging: fbtft: lcdctrl: add ssd1306 support

Add support for Solomon SSD1306 Monochrome OLED controller. The controller supports up to 128x64 pixles and supports interfaces: Parallel 6800, parallel 8080, SPI (3/4), I2C. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/lcdctrl/Kconfig | 5 + drivers/staging

[RFC 5/7] staging: fbtft: don't require platform data

Add dummy platform data when it's not present. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/fbtft-core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index ac4287f

[RFC 2/7] staging: fbtft: lcdreg: add i2c support

Add I2C bus support to lcdreg. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/lcdreg/Kconfig | 6 ++ drivers/staging/fbtft/lcdreg/Makefile | 2 + drivers/staging/fbtft/lcdreg/lcdreg-i2c.c | 129 ++ drivers/staging/fbtft/lcdreg

[RFC 0/7] staging: fbtft: minimize coupling to the fbdev subsystem

Trønnes Noralf Trønnes (7): staging: fbtft: add lcd register abstraction staging: fbtft: lcdreg: add i2c support staging: fbtft: add lcd controller abstraction staging: fbtft: lcdctrl: add ssd1306 support staging: fbtft: don't require platform data staging: fbtft: extend core to use

[RFC 6/7] staging: fbtft: extend core to use lcdctrl

Add lcdctrl support in core fbtft module. Provide new API for drivers to use. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft/Makefile| 1 + drivers/staging/fbtft/fbtft-lcdctrl.c | 311 ++ drivers/staging/fbtft/fbtft.h

[RFC 7/7] staging: fbtft: add driver for Adafruit ssd1306 based displays

The Adafuit SSD1306 based displays comes in either 128x32 or 128x64 resolutions and uses I2C or SPI interface. This driver has support for the I2C interface. Support for SPI can be added when lcdreg has SPI support. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- drivers/staging/fbtft

Re: [PATCH] Staging: fbtft: fix space errors

Den 02.03.2015 20:21, skrev Andrey Skvortsov: On 02 Mar, Joe Perches wrote: On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote: On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote: If you're really going to change these, please remove the unnecessary \ line continuations indent

[PATCH] MAINTAINERS: add entry for staging/fbtft/

Add MAINTAINERS entry for staging/fbtft/ FBTFT is a framework for writing framebuffer drivers for displays with LCD controllers having onchip RAM. Signed-off-by: Noralf Trønnes nor...@tronnes.org --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH] staging: fbtft: fb_agm1264k-fl: add static keyword

Add missing static keyword to function reset(). This was detected by the kbuild test robot. Signed-off-by: Noralf Trønnes no...@tronnes.org --- drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b

Re: staging: fbtft: CONFIG_ARCH_BCM2708?

Den 20.01.2015 09:46, skrev Paul Bolle: Thomas, Noralf, Your commit c296d5f9957c (staging: fbtft: core support) is included in today's linux-next (ie, next-20150120). I noticed because a script I use to check linux-next spotted a problem in it. See, that commit adds two checks for

Need help setting up git

Hi, I can't get my name: Noralf Trønnes, to come out correctly in From when I format and send a patch. The 'ø' becomes a question mark when received in my email client. This is the head of the patch generated by git format-patch: From b2a4f6abdb097c4dc092b56995a2af8e42fbea79 Mon Sep 17 00:00

[PATCH] staging: fbtft: remove ARCH_BCM2708 optimization

ARCH_BCM2708 is not present in mainline so remove optimization. Signed-off-by: Noralf Trønnes no...@tronnes.org --- drivers/staging/fbtft/fbtft-io.c | 170 --- 1 file changed, 170 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging