Re: [PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string

2020-05-25 Thread Oliver Graute
-24,7 +24,7 @@ > "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \ > "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33" > > -#define HSD20_IPS "true" > +#define HSD20_IPS 1 > > /** > * enum st7789v_command - ST7789V

[PATCH v2] staging: fbtft: fb_st7789v: Initialize the Display

2020-05-13 Thread Oliver Graute
From: Oliver Graute Set Gamma Values and Register Values for the HSD20_IPS Panel Signed-off-by: Oliver Graute --- need information howto set HSD20_IPS Panel at run time and not at compile time Changes for v2: - added define for HSD20_IPS_GAMMA values - check for HSD20_IPS define - enabled

Re: [PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display

2020-04-27 Thread Oliver Graute
On 27/04/20, Dan Carpenter wrote: > On Mon, Apr 27, 2020 at 10:36:42AM +0200, Oliver Graute wrote: > > On 09/04/20, Dan Carpenter wrote: > > > On Thu, Apr 09, 2020 at 11:25:32AM +0200, Oliver Graute wrote: > > > > From: Oliver Graute > > > > &g

Re: [PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display

2020-04-27 Thread Oliver Graute
On 09/04/20, Dan Carpenter wrote: > On Thu, Apr 09, 2020 at 11:25:32AM +0200, Oliver Graute wrote: > > From: Oliver Graute > > > > Set Gamma Values and Register Values for the HSD20_IPS > > > > Signed-off-by: Oliver Graute > > --- >

Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion

2020-04-27 Thread Oliver Graute
On 09/04/20, Dan Carpenter wrote: > On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote: > > From: Oliver Graute > > > > Enable inversion mode > > > > Signed-off-by: Oliver Graute > > --- > > drivers/staging/fbtft/fb_st7789v

Re: [PATCH v1] staging: fbtft: fb_st7789v: enabled inversion

2020-04-27 Thread Oliver Graute
On 09/04/20, Dan Carpenter wrote: > On Thu, Apr 09, 2020 at 11:24:05AM +0200, Oliver Graute wrote: > > From: Oliver Graute > > > > Enable inversion mode > > What the heck is an inversion mode and why would you want it? Should I name it: Enable MIPI_DCS_ENTE

[PATCH v1] staging: fbtft: fb_st7789v: Initialize the Display

2020-04-09 Thread Oliver Graute
From: Oliver Graute Set Gamma Values and Register Values for the HSD20_IPS Signed-off-by: Oliver Graute --- drivers/staging/fbtft/fb_st7789v.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft

[PATCH v1] staging: fbtft: fb_st7789v: enabled inversion

2020-04-09 Thread Oliver Graute
From: Oliver Graute Enable inversion mode Signed-off-by: Oliver Graute --- drivers/staging/fbtft/fb_st7789v.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c index 3c3f387936e8..84c5af2dc9a0 100644 --- a/drivers

[PATCHv2] staging: pi433: pi433_write fixed the return value

2017-12-19 Thread Oliver Graute
The pi433_write function should return the number of processed bytes Reported-by: Marcin Ciupak <marcin.s.ciu...@gmail.com> Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- Changes in v2: - added Reported-By Tag drivers/staging/pi433/pi433_if.c | 2 +- 1 fil

[PATCH] staging: pi433: pi433_write fixed the return value

2017-12-19 Thread Oliver Graute
The pi433_write function should return the number of processed bytes. This fix endless sending if write is invoked from userspace. Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: first try to send data with pi433 on Raspberry Pi

2017-12-19 Thread Oliver Graute
On 12/12/17, Marcin Ciupak wrote: > > this is due to fact that pi433_write returns 0 on successful copy while > it should return 'copied' value. So it is a bug :) > > '0' means nothing was copied so userpsace calls pi433_write again and > again, data is put to fifo and when it is full it goes to

Re: [PATCHv2 0/6] staging: pi433: pi433_if.c various codestyle fixes

2017-12-17 Thread Oliver Graute
On 13/12/17, Oliver Graute wrote: > rearranged the patches and summarized them > > Oliver Graute (6): > staging: pi433: pi433_if.c codestyle space required > staging: pi433: pi433_if.c style fix wrong placed brace > staging: pi433: pi433_if.c style open brace > stagi

[PATCHv2 6/6] staging: pi433: pi433_if.c style fix of space prohibited

2017-12-13 Thread Oliver Graute
rohibited before that close parenthesis ')' + if ( retval != sizeof(instance->tx_cfg) ) Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/pi

[PATCHv2 3/6] staging: pi433: pi433_if.c style open brace

2017-12-13 Thread Oliver Graute
ned-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index b6dbd53..55d284d 100644 --- a/drivers/staging/pi433/p

[PATCHv2 2/6] staging: pi433: pi433_if.c style fix wrong placed brace

2017-12-13 Thread Oliver Graute
This patch fixes this checkpatch.pl error: ERROR: that open brace { should be on the previous line + if (rx_interrupted) + Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

[PATCHv2 4/6] staging: pi433: pi433_if.c space required in for loop

2017-12-13 Thread Oliver Graute
(ctx:VxV) + for (i=0; i<NUM_DIO; i++) ^ Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_

[PATCHv2 1/6] staging: pi433: pi433_if.c codestyle space required

2017-12-13 Thread Oliver Graute
This patch fixes this checkpatch.pl error: ERROR: spaces required around that '+=' (ctx:WxV) + position +=temp; Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCHv2 5/6] staging: pi433: pi433_if.c style fix forbidden spaces

2017-12-13 Thread Oliver Graute
ibited before that close parenthesis ')' + if ( IS_ERR(device->gpiod[i]) ) Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/

[PATCHv2 0/6] staging: pi433: pi433_if.c various codestyle fixes

2017-12-13 Thread Oliver Graute
rearranged the patches and summarized them Oliver Graute (6): staging: pi433: pi433_if.c codestyle space required staging: pi433: pi433_if.c style fix wrong placed brace staging: pi433: pi433_if.c style open brace staging: pi433: pi433_if.c space required in for loop staging: pi433

Re: first try to send data with pi433 on Raspberry Pi

2017-12-12 Thread Oliver Graute
On 11/12/17, Marcus Wolf wrote: > > Am 11.12.2017 um 20:40 schrieb Oliver Graute: > >Hello list, > > > >I just got my pi433 working somehow on Raspberry Pi Model B Rev 2. > > > >Here are my findings: > > > >first I need to enabling spi in

first try to send data with pi433 on Raspberry Pi

2017-12-11 Thread Oliver Graute
Hello list, I just got my pi433 working somehow on Raspberry Pi Model B Rev 2. Here are my findings: first I need to enabling spi in config.txt on boot partition. dtparam=spi=on then adding this node to bcm2835-rpi-b-rev2.dts and compile. _gpio7 { pi433: pi433@0 {

[PATCH 07/10] staging: pi433: pi433_if.c space required in for loop

2017-12-08 Thread Oliver Graute
(ctx:VxV) + for (i=0; i<NUM_DIO; i++) ^ Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_

[PATCH 09/10] staging: pi433: open brace on previous line

2017-12-08 Thread Oliver Graute
This patch fixes this codestyle issue: ERROR: that open brace { should be on the previous line + for (i = 0; i < NUM_DIO; i++) + { Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 01/10] staging: pi433: codestyle space required

2017-12-08 Thread Oliver Graute
ERROR: spaces required around that '+=' (ctx:WxV) + position +=temp; ^ Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 02/10] staging: pi433: space prohibited before closing parenthesis

2017-12-08 Thread Oliver Graute
ERROR: space prohibited before that close parenthesis ')' + (size - position) ); Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/s

[PATCH 08/10] staging: pi433: forbidden space and open brace

2017-12-08 Thread Oliver Graute
ibited before that close parenthesis ')' + if ( IS_ERR(device->gpiod[i]) ) Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/driver

[PATCH 06/10] staging: pi433: space prohibited

2017-12-08 Thread Oliver Graute
This patch fixes this codestyle issues: ERROR: space prohibited after that open parenthesis '(' + if ( retval != sizeof(instance->tx_cfg) ) ERROR: space prohibited before that close parenthesis ')' + if ( retval != sizeof(instance->tx_cfg) ) Signed-off-by: Oliver Graute <o

[PATCH 05/10] staging: pi433: codestyle brace should be on previous line

2017-12-08 Thread Oliver Graute
ned-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 70d2c39..3e79ebf 100644 --- a/drivers/staging/pi433/p

[PATCH 04/10] staging: pi433: pi433_if.c codestyle brace on previous line

2017-12-08 Thread Oliver Graute
ERROR: that open brace { should be on the previous line + if (rx_interrupted) + { Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

[PATCH 03/10] staging: pi433: space prohibted before that close parentesis

2017-12-08 Thread Oliver Graute
ERROR: space prohibited before that close parenthesis ')' +kthread_should_stop() ); Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 10/10] staging: pi433: space prohibited in IS_ERR

2017-12-08 Thread Oliver Graute
This patch fixes this codestyle issue: ERROR: space prohibited after that open parenthesis '(' + if ( IS_ERR(device->gpiod[i]) ) ERROR: space prohibited before that close parenthesis ')' + if ( IS_ERR(device->gpiod[i]) ) Signed-off-by: Oliver Graute <o

[PATCH v2] staging: pi433: pi433_if.c codestyle fix in IRQ_handler

2017-12-05 Thread Oliver Graute
) /* wait was interrupted */ Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 3404cb9..26576bf 100644 --- a/d

[PATCH] staging: pi433: codestyle space required

2017-12-05 Thread Oliver Graute
This patch fixes the following checkpatch.pl error: ERROR: spaces required around that '+=' (ctx:WxV) + position +=temp; ^ Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion

[PATCH] staging: pi433: pi433_if.c codestyle brace on previous line

2017-12-05 Thread Oliver Graute
ace '}' + } + else Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 3404cb9..17be4b6 100644 --- a/driver

[PATCH] staging: pi433: pi433_if.c added a blank in for loop

2017-11-30 Thread Oliver Graute
This patch fixes the following checkpatch.pl error: ERROR: spaces required around that '=' (ctx:VxV) #912: FILE: pi433_if.c:912: + for (i=0; i<NUM_DIO; i++) Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1

[PATCH] staging: pi433: pi433_if.c codestyle fix in IRQ_handler

2017-11-30 Thread Oliver Graute
) /* wait was interrupted */ Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 7632849..1cdff5c

[PATCH] staging: pi433: pi433_if.c codestyle fix missing blank

2017-11-30 Thread Oliver Graute
This patch fixes the following checkpatch.pl error: ERROR: space required after that ',' (ctx:VxV) #342: FILE: pi433_if.c:342: + dev_dbg(dev->dev,"rx: going to wait for any tx to finish"); Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/p

[PATCH] staging: pi433: pi433_if.c codestyle brace on previous line

2017-11-29 Thread Oliver Graute
This patch fixes the following checkpatch.pl error: ERROR: that open brace { should be on the previous line in pi433_if.c as requested by TODO file Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 38 +-

[PATCH] staging: pi433: pi433_if.c codestyle fix space around kthread

2017-11-29 Thread Oliver Graute
: + if ( kthread_should_stop() ) Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 4b8980c..28bb77a 100644 --- a/drivers/s

[PATCH] staging: pi433: pi433_if.c codestyle space prohibited

2017-11-28 Thread Oliver Graute
954: + if ( IS_ERR(device->gpiod[i])) Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 8d51f

[PATCH] staging: pi433: pi433_if.c fix codestyle on two long lines

2017-11-27 Thread Oliver Graute
: + unregister_chrdev(MAJOR(pi433_dev), pi433_spi_driver.driver.name); Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c

[PATCH] staging: pi433: pi433_if.c codestyle fix

2017-11-26 Thread Oliver Graute
) Signed-off-by: Oliver Graute <oliver.gra...@gmail.com> --- drivers/staging/pi433/pi433_if.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 2a205c6..d806523 100644 --- a/drivers/staging/pi433/p