Re: [PATCH] staging: vt6656: Use DIV_ROUND_UP macro instead of specific code

On Mon, Mar 23, 2020 at 11:42:00AM +0100, Greg Kroah-Hartman wrote: > On Sun, Mar 22, 2020 at 12:23:42PM +0100, Oscar Carter wrote: > > Use DIV_ROUND_UP macro instead of specific code with the same purpose. > > Also, remove the unused variables. > > > >

[PATCH] staging: vt6656: Use DIV_ROUND_UP macro instead of specific code

Use DIV_ROUND_UP macro instead of specific code with the same purpose. Also, remove the unused variables. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/baseband.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/staging/vt6656

[PATCH] staging: vt6656: Use BIT() macro in vnt_mac_reg_bits_* functions

The last parameter in the functions vnt_mac_reg_bits_on and vnt_mac_reg_bits_off defines the bits to set or unset. So, it's more clear to use the BIT() macro instead of an hexadecimal value. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/baseband.c | 5 +++-- drivers/staging/v

[PATCH] staging: vt6656: Use BIT() macro instead of hex value

Use the BIT() macro instead of the hexadecimal value to define the different bits in registers. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/desc.h | 35 ++--- drivers/staging/vt6656/device.h | 9 +- drivers/staging/vt6656/mac.h| 263 3 files

[PATCH v2] staging: vt6656: Use ARRAY_SIZE instead of hardcoded size

Use ARRAY_SIZE to replace the hardcoded size so we will never have a mismatch. Signed-off-by: Oscar Carter --- Changelog v1 -> v2 - Use ARRAY_SIZE(priv->cck_pwr_tbl) everywhere instead of introducing a new variable to hold its value. drivers/staging/vt6656/main_usb.c | 7 ---

Re: [PATCH] staging: vt6656: Use ARRAY_SIZE instead of hardcoded size

On Tue, Mar 17, 2020 at 01:45:06PM +0300, Dan Carpenter wrote: > On Sat, Mar 14, 2020 at 05:47:54PM +0100, Oscar Carter wrote: > > Use ARRAY_SIZE to replace the hardcoded size so we will never have a > > mismatch. > > > > Signed-off-by: Oscar Carter > > --- >

[PATCH] staging: vt6656: Use ARRAY_SIZE instead of hardcoded size

Use ARRAY_SIZE to replace the hardcoded size so we will never have a mismatch. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/main_usb.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c

[PATCH v2] staging: vt6656: Use BIT_ULL() macro instead of bit shift operation

is now unnecessary. Signed-off-by: Oscar Carter --- Changelog v1 -> v2 - Add more information to clarify the patch. - Add notes about the legacy provide by Malcolm Priestley. drivers/staging/vt6656/main_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

Re: [PATCH] staging: vt6656: Use BIT_ULL() macro instead of bit shift operation

On Tue, Mar 10, 2020 at 10:50:11AM +0100, Greg Kroah-Hartman wrote: > On Sun, Mar 08, 2020 at 07:22:07PM +, Malcolm Priestley wrote: > > >>> */ > > >>> #undef __NO_VERSION__ > > >>> > > >>> +#include > > >>> #include > > >>> #include > > >>> #include "device.h" > > >>> @@ -802,8 +803,7

Re: [PATCH] staging: vt6656: Use BIT_ULL() macro instead of bit shift operation

On Sun, Mar 08, 2020 at 07:55:38AM +0100, Greg Kroah-Hartman wrote: > On Sat, Mar 07, 2020 at 11:49:29AM +0100, Oscar Carter wrote: > > Replace the bit left shift operation with the BIT_ULL() macro and remove > > the unnecessary "and" operation against the bit_nr variab

[PATCH] staging: vt6656: Use BIT_ULL() macro instead of bit shift operation

Replace the bit left shift operation with the BIT_ULL() macro and remove the unnecessary "and" operation against the bit_nr variable. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/main_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stag

Re: [PATCH] staging: vt6656: Declare a few variables as __read_mostly

On Sun, Mar 01, 2020 at 04:09:13PM +0100, Greg Kroah-Hartman wrote: > On Sun, Mar 01, 2020 at 02:17:01PM +0100, Oscar Carter wrote: > > On Sun, Mar 01, 2020 at 01:25:14PM +0100, Greg Kroah-Hartman wrote: > > > On Sun, Mar 01, 2020 at 12:26:20PM +0100, Oscar Carter wrote: >

[PATCH] staging: vt6656: Remove unnecessary local variables initialization

Don't initialize variables that are then set a few lines later. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/main_usb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c

Re: [PATCH] staging: vt6656: Declare a few variables as __read_mostly

On Sun, Mar 01, 2020 at 01:25:14PM +0100, Greg Kroah-Hartman wrote: > On Sun, Mar 01, 2020 at 12:26:20PM +0100, Oscar Carter wrote: > > These include module parameters. > > > > Signed-off-by: Oscar Carter > > --- > > drivers/staging/vt6656/main_usb.c | 4 ++--

[PATCH] staging: vt6656: Declare a few variables as __read_mostly

These include module parameters. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/main_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 5e48b3ddb94c..701300202b21 100644 --- a/drivers

<    1   2