The deprecated omap2 camera drivers were recently removed. Both the
Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
directory are gone. So the Makefile entry that references both is now
pointless. Remove it too.
Signed-off-by: Paul Bolle
---
Tested by grepping the tree
On Mon, 2014-11-24 at 12:08 +0100, Hans Verkuil wrote:
> I found the same thing and it is already part of my pull request
> to Mauro.
Either way, this trivial issue will be solved.
Thanks,
Paul Bolle
___
devel mailing l
if the cover letter, which it should
see first, still contains these "*** [...] HERE ***" markers. What's the
reason it doesn't do that?
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nd review before it goes out to the
> public.
It's good if people are careful. It's also good if programs help to
avoid silly mistakes.
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
;s no
Kconfig symbol ARCH_BCM2708. (A comment in
drivers/mmc/host/sdhci-bcm2835.c does suggest there's an out of tree
"Main bcm2708 linux port".)
Is the code to add the Kconfig symbol ARCH_BCM2708 queued somewhere?
Thanks,
Paul Bolle
__
? You didn't touch the procinfo method in the other ISDN
drivers, as far as I can see.
(If it was intentional, gigaset_procinfo() can of course be removed.)
> - iif->ctr.proc_fops = &gigaset_proc_fops;
> + iif->ctr.proc_show = gigaset_proc_show,
> I
There are references to four undefined Kconfig macros in the code.
Remove these as the checks for them will always evaluate to false.
There are additional cleanups possible now, but I'll gladly leave those
to people that are actually familiar with the code.
Signed-off-by: Paul
rresponding Makefile line is missing.
Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG
macro. This Kconfig entry can be removed.
Someone familiar with the code might be able to say what to do with the
code depending on the DEBUG and ISS_ISR_DEBUG macros.
Signed-off-by: Paul
e has _never_ been buildable (ever since it got merged
in v2.6.36).
I think TIDSPBRIDGE_DVFS (and everything depending on it) might better
be removed.
Paul Bolle
> help
> DVFS allows DSP Bridge to initiate the operating point change to
> scale the chip voltage
Laurent,
On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote:
> On Sunday 09 February 2014 16:09:37 Paul Bolle wrote:
> > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
> > camera interface - Build system") added a Kconfig entry for
> >
entry is used to set the DEBUG
compiler flag, which enables calls of dev_dbg().
So add a Makefile line to do that for omap4iss too.
Signed-off-by: Paul Bolle
---
0) v1 was called "[media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG". This
versions implements Laurent's alternativ
Two Kconfig entries for this driver default to (uppercase) "Y". But in
Kconfig (lowercase) "y" is a magic symbol. "Y" is an ordinary symbol.
As "Y" is never set these Kconfig symbols will also not be set by
default.
So use "default y" here, a
Mauro,
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 02 Nov 2013 20:20:54 +0100
> Paul Bolle escreveu:
> > On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote:
> > > drivers/media/common/siano/Kconfig:21-26
> > > > config SMS_S
es first. It contains:
Please note that this tag should not be added without the reporter's
permission, especially if the problem was not reported in a public
forum.
Perhaps that should read:
[...], unless the problem was reported in a
On Wed, 2014-02-12 at 01:09 +0100, Martin Walch wrote:
> On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote:
> > This patch also deserves a
> > Reported-by: Martin Walch
> >
> > line, but that apparently requires Martin's permission.
>
> I would
On Wed, 2014-02-12 at 01:25 +0100, Paul Bolle wrote:
> (Greg, is it too late to add this tag in your queue?)
Greg already did! It was "USB: ELAN: Remove useless "default M" lines"
that lacks a Reported-by: tag.
Paul Bolle
__
There are a few lines in this driver that depend on a macro
CONFIG_BT_COEXIST. But there's no Kconfig symbol of that name nor is
there a preprocessor define for that string. So remove these lines.
Signed-off-by: Paul Bolle
---
Entirely untested.
Fun fact: two years ago, code depending o
On Tue, 2014-02-11 at 16:17 +0300, Dan Carpenter wrote:
> On Tue, Feb 11, 2014 at 02:01:08PM +0100, Paul Bolle wrote:
> > I would have done, if I hadn't bothered to check
> > Documentation/SubmittingPatches first. It contains:
> >Please note that this tag shoul
et this flag, if I'm
not misunderstanding Joe.) For what it's worth, I've added the list of
these (for v3.14-rc5) below.
Paul Bolle
v3.14-rc5:arch/powerpc/platforms/pseries/Makefile:ccflags-$(CONFIG_PPC_PSERIES_DEBUG)
+= -DDEBUG
v3.14-rc5:drivers/base/Makefile:ccflags-$(CO
gt; snakes. But I just wanted to point out the lack of consistency here.
A major benefit is that
#if IS_ENABLED(CONFIG_HYPERV)
is shorter than
#if defined(CONFIG_HYPERV) || defined(CONFIG_HYPERV_MODULE)
and less prone to typos.
Paul Bolle
___
cleanups?
How often did a bunch of drivers re-enter the tree after being sent to
staging?
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, 2017-01-03 at 23:25 +0100, Arnd Bergmann wrote:
> As far as I'm concerned, we are totally fine as long as there exists a
> longterm supported kernel that has i4l in drivers/staging.
Or in drivers/isdn, right?
Paul Bolle
___
devel m
k_invalidate);
I couldn't spot any users of these exports. Actually, I couldn't even
spot any users of these three functions. Why were they added?
> +MODULE_LICENSE("GPL");
This states, according to include/linux/module.h, that the license is
GPL v2 or later. So I think eit
up the ippp implementation
> when I move the compat ioctl handler from fs/compat_ioctl.c
> into drivers/net/ppp/ppp_generic.c, but I guess I can do that
> anyway as it seems that i4l never worked properly in compat mode.
Paul Bolle
___
devel
On vr, 2016-03-04 at 17:32 +0100, Arnd Bergmann wrote:
> A third patch moves the capidrv source from drivers/isdn/capi/
> into the i4l directory.
I see. Why exactly?
Thanks,
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.or
On za, 2016-03-05 at 14:08 +0100, Tilman Schmidt wrote:
> As a consequence, owners of HiSAX type adapters are in fact stuck with
> the old hisax driver if they want to continue using i4l userspace
> tools.
Do you know whether or not mISDN tools offer functionality comparable to
i4l tool
mISDN + Asterisk + chan-capi setup? (That's
the closest to mISDN with CAPI support that I could find. Did I miss
something?)
Thanks,
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinf
ple can get out of its way.
(I happen to think that the stuff I currently do is best done with a
human filter applied.)
Thanks,
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
sock_init);
> +module_exit(hvsock_exit);
Any specific reason not to mark these functions __init and __exit?
Thanks,
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
# CONFIG_FOO is not set
will be printed if FOO's dependencies are met and FOO either has a
"prompt" or a default of 'n'.
Hope this helps,
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
.mode = SPI_MODE_3,
> + .platform_data = &(struct fbtft_platform_data) {
> + .display = {
> + .buswidth = 9,
> + },
> + .gpios = (const struct fbtft_gpio []) {
> + {},
> + },
> + }
> + }
> + }, {
Thanks,
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t_hv_pci_drv(void)
{
return vmbus_driver_register(&hv_pci_drv);
}
suffice here? That would also allow to mark exit_hv_pci_drv() with
__exit.
> +module_init(init_hv_pci_drv);
> +module_exit(exit_hv_pci_drv);
Thanks,
Paul Bolle
___
deve
amp; m
Everything below drivers/staging/lustre/Kconfig is only sourced if
STAGING is set. You can drop the dependency on STAGING.
> select LNET
> select CRYPTO
> select CRYPTO_CRC32
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ed and evaluates to n.
> The default values are probably only for convenience, so 88EU_AP_MODE and
> 88EU_P2P are activated together with 8188EU. They still can be turned off.
> Anyway, it should probably say "default y" in both cases.
Ditto.
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 02 Nov 2013 20:20:54 +0100
> Paul Bolle escreveu:
> > Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like
> > to send the trivial patch to fix this?
>
> Yes, it is a typo
The macros CONFIG_SPAR_GUEST, GUESTDRIVERBUILD, and NOAUTOVERSION are
defined in Makefiles for the Unisys SPAR driver. They are never used.
Remove the lines that define these macros.
Signed-off-by: Paul Bolle
---
Compile tested only, on top of next-20140626, by fiddling with BROKEN
and setting
hink TRC_TO_KMEM is defined anywhere. If that's correct, the
proper, well, fix for this checkpatch warning would be to remove all
code currently hidden behind the tests for that macro.
> #if defined(TRC_TO_KMEM)
Paul Bolle
___
devel mai
to remove that
from rtw_efuse.h and make it static in rtw_efuse.c The comment above
that function needs and update too, but maybe it's also OK to drop that
comment.
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
UG):= -DDEBUG
But there's no Kconfig symbol GS_FGPA_DEBUG. On the other hand, the code
involved doesn't seem to use either DEBUG or dev_dbg() so perhaps it
isn't actually needed. (But note that the code does check for
DEBUG_FPGA, which apparently has to be set manually.)
Paul Boll
This Makefile tries to set the DEBUG macro but it uses an unknown
Kconfig macro to do so. Since no code appears to even care about the
DEBUG macro this line can safely be removed.
Signed-off-by: Paul Bolle
---
Completely untested.
By the way, do de...@driverdev.osuosl.org and
de
s_dep/ioctl_cfg80211.c
And why is CONFIG_DEBUG_CFG80211 used? I also couldn't find a Kconfig
symbol DEBUG_CFG80211 nor a preprocessor define for
CONFIG_DEBUG_CFG80211.
The symbols CFG80211_REG_DEBUG and CFG80211_DEBUGFS do exist, but seem
unrelated.
y that
> needs fixing up.
Would you like me to send the trivial patches needed to rip out these
two Kconfig macros? (Note that I can't really test this driver.) Or will
you clean up this stuff when going over this code once again?
Paul Bolle
_
On Mon, 2014-04-07 at 11:38 +0200, Jes Sorensen wrote:
> I'll try to put them on my list - I have ~40-50 (I think) patches
> pending on top of what Larry already submitted. If I forget it, please
> feel free to hollor at me.
If this will ever hit mainline I probably will
cks Greg's staging-next branch, you can find all
> my current changes there (unless I managed to mess it up somehow :):
>
>[...]
>
> I plan to push these to Greg for the next -rc round.
So they'll hit mainline in due cours
n
(and should) be submitted without a commit explanation.
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ic irqreturn_t chd_dec_isr(int irq, void *arg)
> {
> - struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
> + struct crystalhd_adp *adp = (struct crystalhd_adp *)arg;
Shouldn't this cast just be dropped instead?
> int rc = 0;
> if (adp)
>
drivers/staging/crystalhd/crystalhd_lnx.c.
Signed-off-by: Pascal COMBES
Are you and I looking at different patches?
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t are either always true or always
false. Is there a reason not to do that cleaning up?
Paul Bolle
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ill always evaluate to false.
Signed-off-by: Paul Bolle
---
Tested with git grep.
See also the almost identical commit 5212f518ac0f ("rtlwifi: btcoexist:
remove undefined Kconfig macros").
drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.c | 10 --
1 file changed, 10 deleti
ntless anyhow, but that's a different issue.
Signed-off-by: Paul Bolle
---
Untested. Done on top of next-20140526.
drivers/staging/comedi/comedi_fops.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fo
ing up and remove the unused V7() macro too.
Signed-off-by: Paul Bolle
---
Untested. Done op top of next-20140526.
drivers/staging/cxt1e1/functions.c | 18 --
drivers/staging/cxt1e1/linux.c | 17 -
drivers/staging/cxt1e1/musycc
When support for homebrew serial port receivers was added in v2.6.36 its
code contained checks for CONFIG_LIRC_SERIAL_NSLU2. The related Kconfig
symbol didn't exist then. It still doesn't exist now. Remove these checks.
Signed-off-by: Paul Bolle
---
Untested. Done on top of next-20
When the rtl8192u driver was added in v2.6.33 its code contained checks
for CONFIG_RTL8192_PM. The related Kconfig symbol didn't exist then. It
still doesn't exist now. Remove these checks.
Signed-off-by: Paul Bolle
---
Untested. Note that the file r8192_pm.h doesn't exist. And th
l found in
sound/soc/omap/mcbsp.c. And that file is built only if
CONFIG_SND_OMAP_SOC_MCBSP is defined.
Fixes: d0f47ff17f29 ("ASoC: OMAP: Build config cleanup for McBSP")
Signed-off-by: Paul Bolle
---
Untested. Note that commit d0f47ff17f29 shipped in v3.4, so these few
lines of code ha
dated. Use CONFIG_LIB80211_CRYPT_TKIP instead, as was clearly
intended.
Signed-off-by: Paul Bolle
---
Compile tested only. Done on top of next-20140526.
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +-
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletion
on OF && OF_ADDRESS
I have no idea what this is all about, but wouldn't just OF_ADDRESS be
enough here (as OF_ADDRESS depends on OF)?
> help
>Select to enable per-board staging support code.
>
> Actually, there are not many dependenc
r_3addrqos is skb_put() into the sk_buff with which
ieee80211_encrypt_fragment() will be called. So switch from
ieee80211_hdr to ieee80211_hdr_3addrqos here.
Signed-off-by: Paul Bolle
---
v1 was called "staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP".
It managed to break the bu
Two Kconfig entries default to (uppercase) "N". It was clearly intended
to use "default n". But since (lowercase) "n" is the default anyway,
these lines might as well be removed.
Reported-by: Martin Walch
Signed-off-by: Paul Bolle
---
Tested with "make menuc
h this when I first received this patch. One needs to
parse the entire tree to find stuff like this, and there are way too
many patchsets flying by to do treewide searches for all of them. So I
just try to keep up with linux-next, to at least catch things before
they enter mainline.)
Paul Bol
There's a check for CONFIG_MACH_EMGR. But the Kconfig symbol MACH_EMGR
doesn't exist. Remove that check and the single #define it hides. Note
that this macro isn't used by this driver anyway.
Signed-off-by: Paul Bolle
---
Compile tested only (on x86_64).
drivers/staging/emxx_udc
On Wed, 2014-04-02 at 16:08 -0700, Greg KH wrote:
> On Wed, Apr 02, 2014 at 08:52:18PM +, Insop Song wrote:
> > On Wed, April 02, 2014 1:04 PM, Greg KH wrote:
> > > On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote:
> > > > On Tue, 2014-04-01
There are two checks for CONFIG_B4860G100 in this driver. But there's no
Kconfig symbol B4860G100. These checks will always evaluate to false.
Remove them and the code they hide.
Signed-off-by: Paul Bolle
---
Build tested only (by building just drivers/staging/gs_fpgaboot/io.o).
Perhaps
62 matches
Mail list logo
