Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-27 Thread Peter Robinson
> Dave > > PS Is linux-rpi-kernel actually behaving for other people? I didn't > see this patch when it was submitted, and it isn't showing in the list > archive either. No, but it never really has for me, it's always been weird in what it allows through by default and the admin has to approve a

Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-25 Thread Peter Robinson
ra failed with error -3 > > So restore the old behavior and fix this issue. > > Fixes: 52c4dfcead49 ("Staging: vc04_services: Cleanup in ctrl_set_bitrate()") > Signed-off-by: Stefan Wahren Tested-by: Peter Robinson Thanks Stefan, I can confirm this resolves the issue I ha

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-11 Thread Peter Robinson
> > > > > > I get difference results with 5.0-rc1 but neither of the above apps > > > > > > work either, will follow up based on the rest of the thread there. > > > > > > > > > > > > > > > > My first step with Raspbian is to enable the Camera interface which > > > > > results into an appending of

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-10 Thread Peter Robinson
Hi Stefan, > > > > I get difference results with 5.0-rc1 but neither of the above apps > > > > work either, will follow up based on the rest of the thread there. > > > > > > > > > > My first step with Raspbian is to enable the Camera interface which > > > results into an appending of the followin

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
> > I get difference results with 5.0-rc1 but neither of the above apps > > work either, will follow up based on the rest of the thread there. > > > > My first step with Raspbian is to enable the Camera interface which results > into an appending of the following lines to config.txt: > > start_x=1

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
> > Hi Stefan, > > > ... > > > > I get difference results with 5.0-rc1 but neither of the above apps > > work either, will follow up based on the rest of the thread there. > > > > My first step with Raspbian is to enable the Camera interface which results > into an appending of the following lines

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
Hi Dave, > > > This patch series improves the load/unload of bcm2835 camera and audio > > > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > > > > > This series based on current linux-next and Phil Elwell's series > > > ("Improve VCHIQ > > > cache line size handling"

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-09 Thread Peter Robinson
Hi Stefan, > > > But why didn't you applied the series which was actually applied to > > > mainline? > > > Did you apply the rest of Phil's DT series as mentioned in the cover > > > letter? > > > > I'm fairly certain I have Phil's "Improve VCHIQ cache line size > > handling" patch series applied

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-08 Thread Peter Robinson
Hi Stefan, > > > This patch series improves the load/unload of bcm2835 camera and audio > > > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > > > > > This series based on current linux-next and Phil Elwell's series > > > ("Improve VCHIQ > > > cache line size handling

Re: [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload

2019-01-07 Thread Peter Robinson
Hi Stefan, > This patch series improves the load/unload of bcm2835 camera and audio > drivers. It has been tested with Raspberry Pi 3 B and a camera module V1. > > This series based on current linux-next and Phil Elwell's series ("Improve > VCHIQ > cache line size handling"). After Nicolas' serie

Re: [PATCH RFC 01/11] staging: bcm2835-camera: Abort probe if there is no camera

2018-12-19 Thread Peter Robinson
bf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera > driver.") > Signed-off-by: Stefan Wahren Tested-by: Peter Robinson In testing this both with and without a camera module attached it appears to still load the entire v4l stack even if there's no camera attache

Re: [PATCH RFC 02/11] staging: bcm2835-camera: fix module autoloading

2018-12-18 Thread Peter Robinson
by: Stefan Wahren Reviewed-by: Peter Robinson Tested-by: Peter Robinson Tested with a v2 camera module and kernel module loads automatically as expected. > --- > drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH RFC 03/11] staging: bcm2835-camera: Move module info to the end

2018-12-18 Thread Peter Robinson
On Thu, Oct 25, 2018 at 4:30 PM Stefan Wahren wrote: > > In order to have this more consistent between the vc04 services move > the module information to the end of the file. > > Signed-off-by: Stefan Wahren Reviewed-by: Peter Robinson Tested-by: Peter Robinson Tested with a v

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-17 Thread Peter Robinson
> >> > Drop various pieces of dead code from here and there to get rid of > >> > the remaining users of VCHI_CONNECTION_T. After that we get to drop > >> > entire header files worth of unused code. > >> > > >> > I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that > >> > snd-bcm2835 can s

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Peter Robinson
On Thu, Jan 26, 2017 at 1:54 PM, Michael Zoran wrote: > On Thu, 2017-01-26 at 13:21 +0000, Peter Robinson wrote: >> On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran >> wrote: >> > Initial cleanup of bcm2835-audio driver for the >> > bcm2535(Raspberry PI) >

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-26 Thread Peter Robinson
On Thu, Jan 26, 2017 at 12:39 AM, Michael Zoran wrote: > Initial cleanup of bcm2835-audio driver for the > bcm2535(Raspberry PI) > > Driver provides HDMI audio through ALSA and is built > on top of the vc04_services driver. > > Original version of the driver is available at: > http://www.github.co