[PATCH V6] staging: goldfish: Fix pointer cast for 32 bits

. gf_write_dma_addr() was added to handle dma_addr_t values which is used at drivers/staging/goldfish/goldfish_audio.c. Signed-off-by: Dan Carpenter Signed-off-by: Peter Senna Tschudin --- When submiting V5, I havent tested the patch properly. It was my fault. Tested by compilation only for i386 and for

[PATCH V5] staging: goldfish: Fix pointer cast for 32 bits

. gf_write_dma_addr() was added to handle dma_addr_t values which is used at drivers/staging/goldfish/goldfish_audio.c. Signed-off-by: Dan Carpenter Signed-off-by: Peter Senna Tschudin --- Tested by compilation only for x86 and for x86_64. Changes from V4: - Added the function gf_write_dma_addr() - Changed

Re: [PATCH V4] Fix pointer cast for 32 bits arch

On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox wrote: > On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote: >> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote: >> > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote: >> > > Actually, my patch seems like a good idea to me but it's one

Re: [PATCH V4] Fix pointer cast for 32 bits arch

On Thu, Apr 16, 2015 at 7:05 PM, Alan Cox wrote: > On Thu, 2015-04-16 at 20:01 +0300, Dan Carpenter wrote: >> On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote: >> > On Thu, Apr 16, 2015 at 3:39 PM, Peter Senna Tschudin >> > wrote: >> &

[PATCH V4] Fix pointer cast for 32 bits arch

-by: Peter Senna Tschudin --- Tested by compilation only for x86, x86 with CONFIG_X86_PAE=y, and for x86_64. Changes from V3: - Changed type of first argument of gf_write64 - Renamed from gf_write64 to gf_write_ptr - Updated all calls to gf_write_ptr Changes from V2: - Fixed spelling of

Re: [PATCH] Fix pointer cast for 32 bits arch

gt; > On Mon, Apr 13, 2015 at 1:14 PM, Peter Senna Tschudin > wrote: >>> Perhaps checkpatch should complain about casts outside header files? >> Cocinelle found 664 double casts: >> http://pastebin.com/2bi9Dg7k >> >> and 9 triple casts: >> http://paste

Re: [PATCH] Fix pointer cast for 32 bits arch

On Sun, Apr 12, 2015 at 5:38 PM, Geert Uytterhoeven wrote: > On Sun, Apr 12, 2015 at 3:48 PM, Peter Senna Tschudin > wrote: >> On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven >> wrote: >>> On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin >>> wrote:

Re: [PATCH] Fix pointer cast for 32 bits arch

On Mon, Apr 13, 2015 at 11:10 AM, Dan Carpenter wrote: > On Sun, Apr 12, 2015 at 11:26:43AM +0200, Peter Senna Tschudin wrote: >> Sparse compalins about casting void * to u64 on i386. >> Change the cast to resource_size_t. >> >> Signed-off-by: Peter Senna Tschu

Re: [PATCH] Fix pointer cast for 32 bits arch

On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven wrote: > On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin > wrote: >> Sparse compalins about casting void * to u64 on i386. >> Change the cast to resource_size_t. >> >> Signed-off-by: Peter Senna Ts

[PATCH v3] Fix pointer cast for 32 bits arch

Sparse complains about casting void * to u64 on i386. Change the cast to resource_size_t. Also update the type of the first argument of gf_write64() from unsigned long to resource_size_t. Signed-off-by: Peter Senna Tschudin --- Changes from V2: - Fixed spelling of complains - Updated commit

[PATCH v2] Fix pointer cast for 32 bits arch

Sparse compalins about casting void * to u64 on i386. Change the cast to resource_size_t. Also update the gf_write64 function definition changing the first argument type from unsigned long data to resource_size_t. Signed-off-by: Peter Senna Tschudin --- Changes from V1: - Updated commit

[PATCH] Fix pointer cast for 32 bits arch

Sparse compalins about casting void * to u64 on i386. Change the cast to resource_size_t. Signed-off-by: Peter Senna Tschudin --- Tested by compilation only. Tested for x86 and x86_64. drivers/staging/goldfish/goldfish_nand.c | 3 ++- include/linux/goldfish.h | 2 +- 2 files

[PATCH] staging/lustre: Make lstcon_console_{init,fini} static

sparse was complaining that the symbols 'lstcon_console_init' and 'lstcon_console_fini' were not declared. Declaring both as static. Signed-off-by: Peter Senna Tschudin --- drivers/staging/lustre/lnet/selftest/console.c | 6 ++ 1 file changed, 2 insertions(+), 4 deleti

[PATCH] staging/sm7xxfb: Make 'struct vgamode' static

sparse was complaining that symbol 'vgamode' was not declared. Declaring vgamode as static. Signed-off-by: Peter Senna Tschudin --- Tested by compilation only drivers/staging/sm7xxfb/sm7xx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm7xxfb

[PATCH V5 4/6] staging: vt6556: Remove typedefs

= 0, PHY_TYPE_11B, PHY_TYPE_11G, PHY_TYPE_11A } CARD_PHY_TYPE, *PCARD_PHY_TYPE; The following typedefs were removed, but enums were kept at device.h: typedef enum __device_msg_level typedef enum __DEVICE_NDIS_STATUS Tested by compilation only. Signed-off-by: Peter Senna Tschudin

[PATCH V6 6/6] staging: vt6556: Replace printk by dev_warn

This patch fixes a checkpatch warning by replacing printk by dev_warn. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Changes from V5 - Refresh for staging-next of 16/07/2014 drivers/staging/vt6656/main_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH V5 3/4] staging: vt6556: Cleanup coding style: lines over 80 chars

This patch cleanup the follwoing coding style issues: - line over 80 chars - spaces on the beginning of a line - put { and } on the correct places Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Changes from V4: - Splitted [PATCH V4 1/6] in 4 smaller patches drivers

[PATCH V5 4/4] staging: vt6556: Cleanup coding style: indentation

This patch cleanup the follwoing coding style issues: - indentation style - new line after declaration Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Changes from V4: - Splitted [PATCH V4 1/6] in 4 smaller patches drivers/staging/vt6656/main_usb.c | 36

[PATCH V5 2/4] staging: vt6556: Cleanup coding style: comments

This patch cleanup coding style issues on comments. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Changes from V4: - Splitted [PATCH V4 1/6] in 4 smaller patches drivers/staging/vt6656/baseband.c | 15 --- drivers/staging/vt6656/card.c | 4 ++-- drivers

[PATCH V5 1/4] staging: vt6556: Cleanup coding style: #define

This patch cleanup coding style issues on #defines. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Changes from V4: - Splitted [PATCH V4 1/6] in 4 smaller patches drivers/staging/vt6656/card.h | 6 +++--- drivers/staging/vt6656/device.h | 10 +- drivers

[PATCH V5 6/6] staging: vt6556: Replace printk by dev_warn

This patch fixes a checkpatch warning by replacing printk by dev_warn. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Changes from V4: - use dev_warn instead of pr_warn drivers/staging/vt6656/main_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH V5 5/6] staging: vt6556: Cleanup indentation on statements

Use tabs instead of spaces in a set of statements and fix lines over 80 chars. Reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V4: - Fix identation issue found on V4 drivers/staging/vt6656/main_usb.c | 44

Re: [PATCH V4 4/6] staging: vt6556: Remove typedefs

On Tue, Jul 15, 2014 at 5:06 PM, Greg KH wrote: > On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote: >> This patch removes uneeded typedefs reported by chackpatch and removes >> one enum. The removed enum from card.h: >> >> typedef enum _CARD_PHY_TYPE

[PATCH V4 3/6] staging: vt6556: Remove uneeded return statements

This patch remove uneeded return statements reported by checkpatch and fixes the indentation of a multi-line call. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V3: - Splitted the patches by change type drivers/staging/vt6656/card.c | 6 +- drivers

[PATCH V4 4/6] staging: vt6556: Remove typedefs

enums were kept at device.h: typedef enum __device_msg_level typedef enum __DEVICE_NDIS_STATUS Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V3: - Splitted the patches by change type drivers/staging/vt6656/card.h | 7 --- drivers/staging/vt6656/device.h

[PATCH V4 5/6] staging: vt6556: Cleanup indentation on statements

Use tabs instead of spaces in a set of statements and fix lines over 80 chars. Reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V3: - Splitted the patches by change type drivers/staging/vt6656/main_usb.c | 44

[PATCH V4 2/6] staging: vt6556: Remove double parentheses

This patch cleanup a checkpatch warning by removing double parentheses from if condition. Additionally it fixes a line over 80 chars. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V3: - Splitted the patches by change type drivers/staging/vt6656/baseband.c

[PATCH V4 1/6] staging: vt6556: Cleanup trivial coding style issues

declaration Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V3: - Splitted the patches by change type drivers/staging/vt6656/baseband.c | 23 --- drivers/staging/vt6656/card.c | 13 + drivers/staging/vt6656/card.h | 6 ++-- drivers

[PATCH V4 6/6] staging: vt6556: Replace printk by pr_warn

This patch fixes a checkpatch warning by replacing printk by pr_warn. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V3: - Splitted the patches by change type drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

this patch anyway, I may as well give you > the normal feedback for these kinds of patches. > >> >From 69cd87aca39730c0578592d1296b738f7f223f29 Mon Sep 17 00:00:00 2001 >> From: Peter Senna Tschudin >> Date: Mon, 14 Jul 2014 10:28:42 +0200 >> Subject: [PAT

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

On Mon, Jul 14, 2014 at 2:58 PM, Greg KH wrote: > On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote: >> On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote: >> > On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote: >> > > T

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote: > On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote: > > This patch cleanup coding style issues reported by checkpatch. > > > > Tested by compilation only. > > > > Signed-off-by: Peter Se

[PATCH V2 4/4] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. This patch change the following enums: - typedef enum __device_msg_level - typedef enum __DEVICE_NDIS_STATUS Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series

[PATCH V2 3/4] staging: vt6556: Cleanup coding style issues

-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series Made against latest staging-next. drivers/staging/vt6656/card.c | 19 --- drivers/staging/vt6656/card.h | 13 +++-- 2 files changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers

[PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series Made against latest staging-next. drivers/staging/vt6656/baseband.c | 28 1 file

[PATCH V2 2/4] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series Made against latest staging-next. drivers/staging/vt6656/main_usb.c | 118

[PATCH] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. This patch change the following enums: - typedef enum __device_msg_level - typedef enum __DEVICE_NDIS_STATUS Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Made against latest staging-next. drivers/staging

[PATCH] staging: vt6556: Cleanup coding style issues

-by: Peter Senna Tschudin --- Done against latest staging-next. drivers/staging/vt6656/card.c | 19 --- drivers/staging/vt6656/card.h | 13 +++-- 2 files changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c

[PATCH 1/2] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Based on latests staging-next. drivers/staging/vt6656/baseband.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

[PATCH 2/2] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Based on latest staging-next. drivers/staging/vt6656/main_usb.c | 118 +- 1 file changed, 54 insertions(+), 64 deletions

[PATCH] staging: android: Cleanup style issues

This patch fixes the following checkpatch warnings: - Remove else after return - Add space after declaration Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- drivers/staging/android/sync_debug.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH V3] drivers/staging: drivers/staging: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // Signed-off-by: Peter Senna Tschudin --- Changes from V2: - Refreshed for staging/staging-next drivers/staging/bcm/Bcmchar.c |3 +-- drivers/staging/bcm/InterfaceIdleMode.c

[PATCH 3/8 V2] drivers/staging: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // Signed-off-by: Peter Senna Tschudin --- Changes from V1: - Updated semantic patch - Refreshed for next-20140523 drivers/staging/bcm/Bcmchar.c |3 +-- drivers/staging/bcm

[PATCH 3/8] drivers/staging: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/bcm/Bcmchar.c |3 +-- drivers/staging/bcm/InterfaceIdleMode.c |3 +-- drivers/staging/bcm/PHSModule.c

[PATCH 7/8] staging: ozwpan: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/ozwpan/ozhcd.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index

[PATCH 4/8] staging: ft1000: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/ft1000/ft1000-usb/ft1000_download.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b

[PATCH 8/8] staging: vt6655: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/vt6655/hostap.c | 10 -- drivers/staging/vt6655/wpactl.c | 19 ++- 2 files changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH 6/8] USB: as102_usb_drv.c: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/media/as102/as102_usb_drv.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/as102/as102_usb_drv.c b/drivers/staging

[PATCH 5/8] staging: et131x: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/et131x/et131x.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 15e0f4d

[PATCH 1/8] staging: r8712u: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/rtl8712/ieee80211.c|8 ++-- drivers/staging/rtl8712/rtl8712_cmd.c |3 - drivers/staging/rtl8712/rtl8712_recv.c |7 +--- drivers/staging

[PATCH 2/8] staging: wlags49_h2: wl_priv: Remove useless return variables

; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // Signed-off-by: Peter Senna Tschudin --- drivers/staging/wlags49_h2/wl_priv.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_priv.c b/drivers/staging

[PATCH 5/5] Staging: crystalhd: Fix assignment of 0/1 to bool variables

-off-by: Peter Senna Tschudin --- drivers/staging/crystalhd/crystalhd_hw.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff -u -p a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c --- a/drivers/staging/crystalhd/crystalhd_hw.c +++ b/drivers

[PATCH 15/19] staging: Change variable type to bool

-by: Peter Senna Tschudin --- drivers/staging/rtl8187se/r8180_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c index 5947a6f..35412d2 100644 --- a/drivers/staging/rtl8187se/r8180_core.c +++ b

[PATCH 16/19] staging: Change variable type to bool

\|false\) Signed-off-by: Peter Senna Tschudin --- drivers/staging/vt6656/channel.c | 2 +- drivers/staging/vt6656/hostap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/channel.c b/drivers/staging/vt6656/channel.c index 5158ff4..e430b35 100644 --- a

[PATCH 17/19] staging: Change variable type to bool

: Peter Senna Tschudin --- drivers/staging/winbond/wb35tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c index 30a77cc..708c5b0 100644 --- a/drivers/staging/winbond/wb35tx.c +++ b/drivers/staging/winbond

[PATCH 02/19] hv: Change variable type to bool

-off-by: Peter Senna Tschudin --- drivers/hv/hv_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c index cb82233..fa37369 100644 --- a/drivers/hv/hv_util.c +++ b/drivers/hv/hv_util.c @@ -82,7 +82,7 @@ static void