Logical continuations should be on the previous line
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Block comments should align the * on each line
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
WARNING:LEADING_SPACE: please, no spaces at the start of a line
Avoid these errors by writing the function decleration in one line.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Ge
You can sum up the two lines, because the maximum line length of
100 columns is not exceeded.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +--
1 file changed, 1
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
WARNING:LEADING_SPACE: please, no spaces at the start of a line
Avoid these errors by writing the function decleration in one line.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Ge
Logical continuations should be on the previous line
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Block comments should align the * on each line
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
You can sum up the two lines, because the maximum line length of
100 columns is not exceeded.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +--
1 file changed, 1
WARNING:BRACES: braces {} are not necessary for single statement blocks
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a
Line length of 105 exceeds 100 columns.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
Use the automatically defined __func__ macro instead of the function name,
so it stays correct when the function is renamed.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c| 8
Write return_type, function_name and parameters in one line
because lines should not end with a '(' [OPEN_ENDED_LINE]
Write open brace ’{’ on the next line to fix OPEN_BRACE Error
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
--
Remov defines, they don't make sense.
The programmer should know what things need to be static and what not.
Also leave "inline" out and let the compiler decide
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../me
Block comments should use * on subsequent lines and
should use a trailing */ on a separate line.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 5 +++--
1 file changed, 3
Lines should not end with a '('
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/sta
The struct initalizers have been changed as recommended on
https://kernelnewbies.org/KernelJanitors/Todo
Also remove all the false, 0, and NULL members.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../atomisp/pci/runtime/rmgr/src
Hello!
This series fix some codingstyle errors in the files
rmgr_vbuf.c, ia_css_rmgr.h, timer.c, spctrl.c and queue.c
in the drivers/staging/media area.
V2:
[Patch 1/12] Also remove NULL, 0 and false members to make it
C99 standard comform.
[Patch 6/12] Checkpatch throws COMPLEX_MAC
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
WARNING:LEADING_SPACE: please, no spaces at the start of a line
Avoid these errors by writing the function decleration in one line.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Ge
Write return_type, function_name and parameters in one line
because lines should not end with a '(' [OPEN_ENDED_LINE]
Write open brace ’{’ on the next line to fix OPEN_BRACE Error
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
--
Use the automatically defined __func__ macro instead of the function name,
so it stays correct when the function is renamed.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c| 8
Block comments should align the * on each line
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Line length of 105 exceeds 100 columns.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
Logical continuations should be on the previous line
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Lines should not end with a '('
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/sta
Block comments should use * on subsequent lines and
should use a trailing */ on a separate line.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 5 +++--
1 file changed, 3
You can sum up the two lines, because the maximum line length of
100 columns is not exceeded.
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +--
1 file changed, 1
WARNING:BRACES: braces {} are not necessary for single statement blocks
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a
ERROR:COMPLEX_MACRO: Macros with complex values should be
enclosed in parentheses
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h| 4 ++--
1 file changed, 2 insertions(+), 2
Hello!
This series fix some codingstyle errors in the files
rmgr_vbuf.c, ia_css_rmgr.h, timer.c, spctrl.c and queue.c
in the drivers/staging/media area.
Best regards
Philipp
--
media: atomsip: Convert comments to C99 initializ
The struct initalizers have been changed as recommended on
https://kernelnewbies.org/KernelJanitors/Todo
Co-developed-by: Andrey Khlopkov
Signed-off-by: Andrey Khlopkov
Signed-off-by: Philipp Gerlesberger
---
.../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 30 +--
1 file
30 matches
Mail list logo