On Fri, Dec 29, 2017 at 02:19:56AM +0300, Ozgur wrote:
> I think this patch is not good, the code will not work. Please should
> understand in && operator and () why used with C.
hi,
this patch should work, since it compiles and passes checkpatch.
the reason why i removed the () is because of th
Fixed a coding style issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/most/aim-sound/sound.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/aim-sound/sound.c
b/drivers/staging/most/aim-sound/sound.c
index ea1366a44..ab2b0d833
Removed unnecessary parentheses in a if statement.
Signed-off-by: Philippe Loctaux
---
drivers/staging/most/aim-sound/sound.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/aim-sound/sound.c
b/drivers/staging/most/aim-sound/sound.c
index ab2b0d833
Fixes checkpatch coding style issues.
Philippe Loctaux (2):
Staging: most: aim-sound: sound.c: fixed an alignment issue
Staging: most: aim-sound: sound.c: removed unnecessary parentheses
drivers/staging/most/aim-sound/sound.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions
Removed unnecessary parentheses in the if statement.
Signed-off-by: Philippe Loctaux
---
drivers/staging/vme/devices/vme_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_user.c
index 41a5b32e0
Fixed a coding style issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/vme/devices/vme_user.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_user.c
index a3d4610fb..41a5b32e0
'll end up resending another patch without
changing this line, to avoid any bugs or breaking some style rules.
--
Philippe Loctaux
p...@philippeloctaux.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Feb 23, 2016 at 11:07:15AM +, Ian Abbott wrote:
> Even better: just remove the macro, as it isn't used.
How can I do that? I'm asking that because my C knowledge
isn't very good :P
--
Philippe Loctaux
p...@philippeloctaux.com
___
On Tue, Feb 23, 2016 at 10:58:03AM +, Ian Abbott wrote:
> Thanks!
Sweet! Does that means my patch is accepted and maybe will be applied? :)
--
Philippe Loctaux
p...@philippeloctaux.com
___
devel mailing list
de...@linuxdriverproject.org
h
Makes the comment blocks start with /* on separate lines, and end
with */ on separate lines as well,
starting with * for each comment lines.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 47 +
1 file changed, 24 insertions(+), 23
Added spaces around | and *, fixing 2 checkpatch checks.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/mite.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/drivers/staging/comedi/drivers/mite.c
index 8f24702
Sorry I didn't read the doc correctly!
--
Philippe Loctaux
p...@philippeloctaux.com
On Fri, Dec 18, 2015 at 03:00:42PM -0800, Greg KH wrote:
> On Sun, Dec 13, 2015 at 05:40:34PM +0100, Philippe Loctaux wrote:
> > This patch fixes the checkpatch.pl warning:
> >
>
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/comedi_pcmcia.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_pcmcia.h
b/drivers/staging/comedi
Fixed a comment issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c
b/drivers/staging/comedi/drivers/adv_pci_dio.c
Fixed a comment issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/ssv_dnp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c
b/drivers/staging/comedi/drivers/ssv_dnp.c
index acc7f34..c28b6cb 100644
--- a
From 16dae6c28a46ae257dcedd51d973aee7821053f3 Mon Sep 17 00:00:00 2001
From: Philippe Loctaux
Date: Thu, 29 Oct 2015 22:45:16 +0100
Subject: [PATCH] Staging: comedi: fixed comment, added a new line
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/ssv_dnp.c | 3 ++-
1 file
16 matches
Mail list logo