crc32_init is using unnecessary else condition. Cleaningup this function
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/rtl8188eu/core/rtw_security.c | 42 +--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
Function name is hardcoded. replacing with __func__
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/media/cxd2099/cxd2099.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/cxd2099/cxd2099.c
b/drivers/staging/media/cxd2099/cxd2099.c
index
Fixing 'checkpatch.pl' ERROR: code indent should use tabs where possible
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_aead.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c
Fixing coding guideline errors reported by 'checkpatch.pl'
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_cipher.c | 158 +++--
1 file changed, 80 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drive
Fixing 'checkpatch.pl' warnings: Trailing whitespaces
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_cipher.c | 110 ++---
1 file changed, 55 insertions(+), 55 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/sta
Handling checkpatch.pl warning for if block. For single if statement block,
braces are not neccessary. Making code consistent with linux kernel coding
guidelines.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/iio/accel/adis16203.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
((void)sizeof !!(exp)) => I believe it is for compiler to unflag
"unused variable" warning.
On Tue, Apr 4, 2017 at 3:08 PM, Dan Carpenter wrote:
> On Tue, Apr 04, 2017 at 02:45:26PM +0530, Pushkar Jambhlekar wrote:
>> diff --git a/drivers/staging/lustre/lustre/obdclass/c
Replacing 'unsigned' with 'unsigned int'
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
drivers/staging/lustre/lustre/llite/rw26.c | 2 +-
drivers/staging/lustre/lustre/llite/vvp_dev.c | 6 +++
Making references in single line
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 3 +--
drivers/staging/lustre/lustre/llite/llite_lib.c | 6 ++
drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 +--
drivers/staging/lustre/lustre/ptlrpc
Adding a blank line after declaration
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/dcache.c | 1 +
drivers/staging/lustre/lustre/llite/namei.c | 1 +
drivers/staging/lustre/lustre/llite/symlink.c| 1 +
drivers/staging/lustre/lustre/llite/vvp_io.c
ftrace can be used to trace functions. Removing function tracing using
dev_dbg/info
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/wilc1000/wilc_sdio.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
b/drivers/staging/wilc1000/wilc_sdio.c
dev_err: replacing hardcoded function name with '%s' and __func__
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/wilc1000/wilc_sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio.c
b/drivers/staging/wilc1000/wilc_sd
Removing hardcoded function name as code is already using __func__
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
b/drivers
dev_err: replacing function name with '%s' and __func__
dev_dbg: Removing calls which are used for tracing a function.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/wilc1000/wilc_sdio.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/stagin
Current implementation manually traces function using 'dev_dbg'. This way is
not needed because of ftrace, making these calls redundant.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgnc/
Making use of __func__ instead of using function name directly in dev_dbg.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/dgnc/dgnc_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index
Any comment?
On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar
wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> drivers/staging/vc04_services/interface/vchiq_
Fixing 'if' block coding style. '{' should follow 'if' for multiline block
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc0
Thanks. I will rewrite patch according to the suggestions.
On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
>
> No need for that line.
>
>> in file 'vc04_services/int
Description:
in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to
make code according to 'checkpath.pl'.
Also, fixing logical issue, i.e. removing break after goto statement.
Signed-off-by: Pushkar Jambhlekar
---
.../vc04_services/interface/vc
Your concerns were valid. Since 'do' is defined on the new-line, git
did not include it in diff.
On Tue, Mar 14, 2017 at 5:22 PM, Alexander Kapshuk
wrote:
> On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar
> wrote:
>> Hi Alexander,
>>
>> It is not nee
) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; \
} while (0)
On Tue, Mar 14, 2017 at 5:02 PM, Alexander Kapshuk
wrote:
> On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar
> wrote:
>> Description:
>> There should not be ';' after do ... while(0) in macro de
Description:
There should not be ';' after do ... while(0) in macro defination
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
Hi Dan,
I am trying to fix warnings by "checkpatch.pl". Even though it is not
super exciting, no harm to follow correct way.
On Tue, Mar 14, 2017 at 2:43 AM, Dan Carpenter wrote:
> On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wrote:
>> Description:
>>
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis
around macro params.
Also, removing extra line.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
di
Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id.
Checkpath.pl passed.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustr
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c
b/drivers/staging/lustre/lustre/llite/vvp_dev.c
index 12c129f7e..8d78755 100644
--- a
27 matches
Mail list logo