Re: [PATCH] drivers: staging: Mark functions as static and remove unused function in bpctl_mod.c

On Fri, Jan 24, 2014 at 1:34 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Jan 24, 2014 at 04:14:00AM +0530, Rashika Kheria wrote: Mark functions as static in bpctl_mod.c because they are not used outside this file. Remove unused function from bpctl_mod.c. This also eliminates

[PATCH] drivers: sbe-2t3e3: Mark functions as static in ctrl.c

: no previous prototype for ‘t3e3_port_get_stats’ [-Wmissing-prototypes] drivers/staging/sbe-2t3e3/ctrl.c:285:6: warning: no previous prototype for ‘t3e3_port_del_stats’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com --- drivers/staging/sbe-2t3e3/ctrl.c | 14

[PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c

Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not used outside this file. This eliminates the following warning in sm7xxfb.c: drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria

[PATCH 1/2] drivers: dgap: Include appropriate header file in dgap_parse.c

: no previous prototype for ‘dgap_get_config_letters’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com --- drivers/staging/dgap/dgap_parse.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/dgap/dgap_parse.c b/drivers/staging/dgap/dgap_parse.c index ff9d194

[PATCH 2/2] drivers: dgap: Include appropriate header file in dgap_trace.c

for ‘dgap_tracer_free’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com --- drivers/staging/dgap/dgap_trace.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/dgap/dgap_trace.c b/drivers/staging/dgap/dgap_trace.c index 0f9a956..6c8b510 100644 --- a/drivers

[PATCH 2/2] drivers: bcm: Remove unused function in nvm.c

Remove unused function PropagateCalParamsFromEEPROMToMemory() in nvm.c. This eliminates the following warning in nvm.c: drivers/staging/bcm/nvm.c:1369:5: warning: no previous prototype for ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe

[PATCH 1/2] drivers: bcm: Mark functions as static in Qos.c

] drivers/staging/bcm/Qos.c:61:6: warning: no previous prototype for ‘MatchDestIpAddress’ [-Wmissing-prototypes] drivers/staging/bcm/Qos.c:94:6: warning: no previous prototype for ‘MatchTos’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria rashika.khe...@gmail.com --- drivers/staging/bcm/Qos.c

[PATCH] drivers: hv: Mark the function hv_synic_free_cpu() as static in hv.c

This patch marks the function hv_synic_free_cpu() as static in hv.c because it is not used outside this file. Thus, it also eliminates the following warning in hv.c: drivers/hv/hv.c:304:6: warning: no previous prototype for ‘hv_synic_free_cpu’ [-Wmissing-prototypes] Signed-off-by: Rashika

Re: [Suggestion] drivers: staging: dgrp: dgrp_net_ops.c: 'buf' is used without initialized.

() needs re-construction by related maintainers, it is not quite easy to improve these code by other members. Should I attempt to rectify the code in handle_data_in_packet() ? Thanks and regards, -- Rashika Kheria B.Tech CSE IIIT Hyderabad ___ devel

[PATCH v4 1/2] Staging: zram: Fix variable dereferenced before check

) Signed-off-by: Rashika Kheria rashika.khe...@gmail.com --- This revision fixes the following issues of the previous revision: Remove unnecessary checks drivers/staging/zram/zram_drv.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/zram

[PATCH v3] Staging: zram: Fix variable dereferenced before check

) Signed-off-by: Rashika Kheria rashika.khe...@gmail.com --- This revision fixes the following issues of the previous revision- Not included null check drivers/staging/zram/zram_drv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b