Re: [PATCH v2 1/2] media: staging/intel-ipu3: Fix memory leak in imu_fmt

Hi Bingbu Maybe you want to add your Reviewed-by ? ;) Thanks! On Wed, Mar 17, 2021 at 7:48 AM Bingbu Cao wrote: > > > On 3/17/21 1:50 AM, Ricardo Ribalda wrote: > > Hi Bingbu > > > > Thanks for your review > > > > On Tue, Mar 16, 2021 at 12:29 PM Bingbu

Re: [PATCH v2 1/2] media: staging/intel-ipu3: Fix memory leak in imu_fmt

> > On 3/15/21 8:34 PM, Ricardo Ribalda wrote: > > We are losing the reference to an allocated memory if try. Change the > > order of the check to avoid that. > > > > Cc: sta...@vger.kernel.org > > Fixes: 6d5f26f2e045 ("media: staging/intel-ipu3-v4l: red

[PATCH v2 2/2] media: staging/intel-ipu3: Fix set_fmt error handling

fault: [#1] PREEMPT SMP Cc: sta...@vger.kernel.org Fixes: 6d5f26f2e045 ("media: staging/intel-ipu3-v4l: reduce kernel stack usage") Signed-off-by: Ricardo Ribalda --- drivers/staging/media/ipu3/ipu3-v4l2.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletion

[PATCH v2 1/2] media: staging/intel-ipu3: Fix memory leak in imu_fmt

We are losing the reference to an allocated memory if try. Change the order of the check to avoid that. Cc: sta...@vger.kernel.org Fixes: 6d5f26f2e045 ("media: staging/intel-ipu3-v4l: reduce kernel stack usage") Signed-off-by: Ricardo Ribalda --- drivers/staging/media/ipu3/ipu3-v

[PATCH] media: staging/intel-ipu3: Fix set_fmt error handling

: Out of SW-IOMMU space for 4096 bytes at device :00:05.0 [ 38.663010] general protection fault: [#1] PREEMPT SMP Cc: sta...@vger.kernel.org Fixes: 6d5f26f2e045 ("media: staging/intel-ipu3-v4l: reduce kernel stack usage") Signed-off-by: Ricardo Ribalda --- drivers/staging/

Re: [PATCH] hantro: Format IOCTLs compliance fixes

Hi Ezequiel On Mon, Jan 11, 2021 at 12:55 PM Ricardo Ribalda wrote: > > Hi Ezequiel > > On Mon, Jan 11, 2021 at 12:48 PM Ezequiel Garcia > wrote: > > > > Hi Ricardo, > > > > On Mon, 2021-01-11 at 12:35 +0100, Ricardo Ribalda wrote: > > &

Re: [PATCH] hantro: Format IOCTLs compliance fixes

Hi Ezequiel On Mon, Jan 11, 2021 at 12:48 PM Ezequiel Garcia wrote: > > Hi Ricardo, > > On Mon, 2021-01-11 at 12:35 +0100, Ricardo Ribalda wrote: > > Clear the reserved fields. > > > > Fixes: > > fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserve

[PATCH] hantro: Format IOCTLs compliance fixes

Clear the reserved fields. Fixes: fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed test VIDIOC_TRY_FMT: FAIL fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed test VIDIOC_S_FMT: FAIL Signed-off-by: Ricardo Ribalda --- drivers/staging/media

[PATCH] staging/goldfish/goldfish_audio: Fix annotations

spaces) drivers/staging/goldfish/goldfish_audio.c:296:27:expected char [noderef] *buffer_virt drivers/staging/goldfish/goldfish_audio.c:296:27:got void * Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/goldfish/goldfish_audio.c | 10 +- 1 file changed, 5 insertions

Re: [PATCH] staging/sm75fb: Declare static functions as such

; convention is always to use colons in subject lines. About the typo, you are right of course :) Regarding the colon, there is no convention about that, every subsystem has its own preference. I prefer / than : I agree that is your patch that should be pulled, not this one. But I think you s

[PATCH] staging/sm75fb: Declare static functions as such

ivers/staging/sm750fb/ddk750_swi2c.c:361:6: warning: symbol 'swI2CInit_SM750LE' was not declared. Should it be static? Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/sm750fb/ddk750_swi2c.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a

[PATCH v2 2/2] staging/unisys/visorutil/procobjecttree: Replace typedef

Instead of declaring a new type, define a new struct. Signed-off-by: Ricardo Ribalda Delgado --- v2: Suggested by Joe Perches Replace unnecessary casting. drivers/staging/unisys/visorutil/procobjecttree.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[PATCH 0/2] Code Styte

Fix minor code stype problems found by checkpatch.pl Ricardo Ribalda Delgado (2): staging/unisys/visorutil/procobjecttree: Code Style staging/unisys/visorutil/procobjecttree: Replace typedef drivers/staging/unisys/visorutil/procobjecttree.c | 23 +-- 1 file changed, 13

[PATCH 2/2] staging/unisys/visorutil/procobjecttree: Replace typedef

Instead of declaring a new type, define a new struct. Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/unisys/visorutil/procobjecttree.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c b/drivers

[PATCH 1/2] staging/unisys/visorutil/procobjecttree: Code Style

Lines should not be over 80 characters Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/unisys/visorutil/procobjecttree.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c b/drivers/staging/unisys