Re: [PATCH v3 79/79] media: hantro: document the usage of pm_runtime_get_sync()

2021-04-27 Thread Robin Murphy
On 2021-04-27 11:27, Mauro Carvalho Chehab wrote: Despite other *_get()/*_put() functions, where usage count is incremented only if not errors, the pm_runtime_get_sync() has a different behavior, incrementing the counter *even* on errors. That's an error prone behavior, as people often forget to

Re: use of dma_direct_set_offset in (allwinner) drivers

2020-11-04 Thread Robin Murphy
On 2020-11-04 08:14, Maxime Ripard wrote: Hi Christoph, On Tue, Nov 03, 2020 at 10:55:38AM +0100, Christoph Hellwig wrote: Linux 5.10-rc1 switched from having a single dma offset in struct device to a set of DMA ranges, and introduced a new helper to set them, dma_direct_set_offset. This in fa

Re: [PATCH v5 8/9] arm64: dts: rockchip: add isp0 node for rk3399

2020-10-14 Thread Robin Murphy
On 2020-10-14 17:27, Helen Koike wrote: Hi Tomasz, On 9/26/20 10:00 AM, Tomasz Figa wrote: Hi Helen, On Wed, Jul 22, 2020 at 12:55:32PM -0300, Helen Koike wrote: From: Shunqian Zheng RK3399 has two ISPs, but only isp0 was tested. Add isp0 node in rk3399 dtsi Verified with: make ARCH=arm64

Re: [PATCH 00/16] IOMMU driver for Kirin 960/970

2020-08-19 Thread Robin Murphy
On 2020-08-19 11:28, Mauro Carvalho Chehab wrote: Em Tue, 18 Aug 2020 15:02:54 -0700 John Stultz escreveu: On Tue, Aug 18, 2020 at 9:26 AM Robin Murphy wrote: On 2020-08-18 16:29, Mauro Carvalho Chehab wrote: Em Tue, 18 Aug 2020 15:47:55 +0100 Basically, the DT binding has this, for IOMMU

Re: [PATCH 00/16] IOMMU driver for Kirin 960/970

2020-08-19 Thread Robin Murphy
On 2020-08-18 23:02, John Stultz wrote: On Tue, Aug 18, 2020 at 9:26 AM Robin Murphy wrote: On 2020-08-18 16:29, Mauro Carvalho Chehab wrote: Em Tue, 18 Aug 2020 15:47:55 +0100 Basically, the DT binding has this, for IOMMU: smmu_lpae { compatible = "hisilicon,smmu

Re: [PATCH 00/16] IOMMU driver for Kirin 960/970

2020-08-18 Thread Robin Murphy
On 2020-08-18 16:29, Mauro Carvalho Chehab wrote: Hi Robin, Em Tue, 18 Aug 2020 15:47:55 +0100 Robin Murphy escreveu: On 2020-08-17 08:49, Mauro Carvalho Chehab wrote: Add a driver for the Kirin 960/970 iommu. As on the past series, this starts from the original 4.9 driver from the

Re: [PATCH 00/16] IOMMU driver for Kirin 960/970

2020-08-18 Thread Robin Murphy
On 2020-08-17 08:49, Mauro Carvalho Chehab wrote: Add a driver for the Kirin 960/970 iommu. As on the past series, this starts from the original 4.9 driver from the 96boards tree: https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 The remaining patches add SPDX headers and make

Re: [PATCH v5 08/12] device core: Introduce multiple dma pfn offsets

2020-06-17 Thread Robin Murphy
Hi Jim, Thanks for taking this on! On 2020-06-16 21:55, Jim Quinlan wrote: The new field in struct device 'dma_pfn_offset_map' is used to facilitate the use of single or multiple pfn offsets between cpu addrs and dma addrs. It subsumes the role of dev->dma_pfn_offset -- a uniform offset. This

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

2019-07-24 Thread Robin Murphy
On 24/07/2019 15:09, Dmitry Osipenko wrote: 24.07.2019 17:03, Yuehaibing пишет: On 2019/7/24 21:49, Robin Murphy wrote: On 24/07/2019 11:30, Sakari Ailus wrote: Hi Yue, On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

2019-07-24 Thread Robin Murphy
On 24/07/2019 11:30, Sakari Ailus wrote: Hi Yue, On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m. But for many drivers, they use "select IOMMU_IOVA if IOMMU_SUPPORT" in the Kconfig, for example, CONFIG_TEGRA_VDE is

Re: [PATCH 16/16] dma-mapping: use exact allocation in dma_alloc_contiguous

2019-06-14 Thread Robin Murphy
On 14/06/2019 15:50, 'Christoph Hellwig' wrote: On Fri, Jun 14, 2019 at 02:15:44PM +, David Laight wrote: Does this still guarantee that requests for 16k will not cross a 16k boundary? It looks like you are losing the alignment parameter. The DMA API never gave you alignment guarantees to

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Robin Murphy
Hi Roy, On 26/03/18 20:05, Roy Pledge wrote: The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure.

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

2017-07-17 Thread Robin Murphy
On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > Split the 64-bit accesses in 32-bit accesses because there's no real > constrain in MC to do only atomic 64-bit. There's only one place > where ordering is important: when writing the MC command header the > first 32-bi

Re: [PATCH 2/7] staging: fsl-mc: use generic memory barriers

2017-07-17 Thread Robin Murphy
On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > No need to use arch-specific memory barriers; switch to using generic > ones. The rmb()s were useless so drop them. > > Signed-off-by: Laurentiu Tudor > --- > drivers/staging/fsl-mc/bus/mc-sys.c | 6 ++ > 1 file

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Robin Murphy
On 10/03/17 10:31, Brian Starkey wrote: > Hi, > > On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: >> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > > [snip] > >>> >>> For me those patches are going in the right direction. >>> >>> I still have few questions: >>> - since alignmen

Re: [PATCH] staging: vc04_services: setup DMA and coherent mask

2016-11-01 Thread Robin Murphy
Hi Michael, On 31/10/16 19:53, Michael Zoran wrote: > On Mon, 2016-10-31 at 11:40 -0700, Michael Zoran wrote: >> On Mon, 2016-10-31 at 11:36 -0700, Eric Anholt wrote: >>> Michael Zoran writes: >>> Setting the DMA mask is optional on 32 bit but is mandatory on 64 bit. Set the DMA mask a

Re: [PATCHv2] staging: android: ion: use the manged version of DMA memory allocation

2016-02-03 Thread Robin Murphy
On 03/02/16 06:49, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango Use the managed version of the dma_alloc_coherent() i.e. the dmam_alloc_coherent() & accordingly cleanup the error handling part.Also,remove the references to dma_free_coherent That last aspect looks

Re: [PATCH] staging: ion: ion_cma_heap: Don't directly use dma_common_get_sgtable

2015-07-20 Thread Robin Murphy
Hi Laura, On 17/07/15 17:50, Laura Abbott wrote: On 07/17/2015 08:21 AM, Robin Murphy wrote: Hi Tixy, On 17/07/15 12:01, Jon Medhurst (Tixy) wrote: Use dma_get_sgtable rather than dma_common_get_sgtable so a device's dma_ops aren't bypassed. This is essential in situations wher

Re: [PATCH] staging: ion: ion_cma_heap: Don't directly use dma_common_get_sgtable

2015-07-17 Thread Robin Murphy
at least this patch definitely makes things less wrong in that respect. Reviewed-by: Robin Murphy --- This also begs the question as to what happens if the memory region _is_ contiguous but is in highmem or an ioremapped region. Should a device always provide dma_ops for that case? Because I