> > Linux kernel coding style: spaces are never used for
> > indentation.
> >
...
> > struct goldfish_audio {
> > char __iomem *reg_base;
> > int irq;
> > +
>
> That's not a space/tab issue?
Thank you for looking. I separated the new line change into a separate patch.
t take it anyway.
Yes, I saw them.
Regards,
Roman.
On Thu, Jun 28, 2018 at 8:37 AM Greg KH wrote:
>
> On Wed, Jun 27, 2018 at 02:50:52PM -0700, r...@google.com wrote:
> > From: Roman Kiryanov
> >
> > This is kernel driver for controlling the Goldfish sync
> > device
Sure, I will update the patch with you change.
Thank you for reviewing our patches.
On Fri, Jun 15, 2018 at 4:22 AM Greg KH wrote:
>
> On Mon, Jun 04, 2018 at 02:08:20PM -0700, r...@google.com wrote:
> > From: Roman Kiryanov
> >
> > Fix "CHECK: Alignment
I fixed "". They were in the original commit, I thought that was a
reason for this.
On Fri, Jun 1, 2018 at 12:13 PM Greg KH wrote:
>
> On Fri, Jun 01, 2018 at 11:31:23AM -0700, r...@google.com wrote:
> > From: Joshua Lang
> >
> > The buffer_status field is interrupt updated. After every read requ
I remember checkpatch complained about aligning to the first argument.
Somehow I cannot reproduce this now. Feel free to drop this patch.
Thank you.
On Fri, Jun 1, 2018 at 12:11 PM Greg KH wrote:
>
> On Fri, Jun 01, 2018 at 11:31:21AM -0700, r...@google.com wrote:
> > From: Ro
Updated. Thank you.
On Fri, Jun 1, 2018 at 11:40 AM Dan Carpenter wrote:
>
> On Fri, Jun 1, 2018 at 3:22 AM, wrote:
> > From: Joshua Lang
> >
> > The buffer_status field is interrupt updated. After every read request,
> > the buffer_status read field should be reset so that on the next loop
> >
