I will be not able to work on ozwpan driver anymore.
Remove my name & add Tateno as maintainer.
Signed-off-by: Rupesh Gujare
---
MAINTAINERS |2 +-
drivers/staging/ozwpan/TODO |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAI
x_count)
break;
pd = container_of(e, struct oz_pd, link);
- memcpy(&addr[count++], pd->mac_addr, ETH_ALEN);
+ ether_addr_copy(&addr[count++], pd->mac_addr);
}
spin_unlo
py(binding->name, net_dev, OZ_MAX_BINDING_LEN);
Acked-by: Rupesh Gujare
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
56e6fdf..ad5fe7a 100644
--- a/drivers/staging/ozwpan/ozpd.h
+++ b/drivers/staging/ozwpan/ozpd.h
@@ -22,7 +22,7 @@
#define OZ_TIMER_HEARTBEAT2
#define OZ_TIMER_STOP 3
-/*
+/*
*External spinlock variable
*/
extern spinlock_t g_polling_lock;
Acked-by: Rupesh Gujare
void oz_polling_lock_bh(void);
-void oz_polling_unlock_bh(void);
void oz_pd_heartbeat_handler(unsigned long data);
void oz_pd_timeout_handler(unsigned long data);
enum hrtimer_restart oz_pd_heartbeat_event(struct hrtimer *timer);
Acked-by: Rupesh Gujare
--
Regards,
Rupesh Gujare
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 08/01/14 02:53, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
instead of memcmp.
Cc: Rupesh Gujare
Cc: Greg Kroah-Hartman
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Tan Xiaojun
Signed-off-by: Ding Tianhong
---
drivers/staging
Return error if we receive write(), while PD is not connected.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index 50722ea..6ccb64f 100644
--- a/drivers
Incorrect error number was returned here (EPERM), ENXIO is more
appropriate.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index 03b41ee
Buffer depth of 50 units is not sufficient when there is considerable delay
occuring on air due to interference, increase ISOC IN buffer depth to 100 units.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Return error if we receive write(), while PD is not connected.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
index 03b41ee..22cb2ae 100644
--- a/drivers
Reset PORT_ENABLE bit of port status on loosing PD.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index b0398c5..39f5066 100644
--- a/drivers
] hub_port_connect_change: 45 callbacks suppressed
[ 1127.618657] hub 5-0:1.0: connect-debounce failed, port 1 disabled
[ 1127.618668] hub 5-0:1.0: cannot disable port 1 (err = -19)
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |5 +
1 file changed, 5 insertions(+)
diff --git a
Increase ISOC IN buffer depth to 100 units.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 3548860..b0398c5 100644
--- a/drivers/staging
Increase interrupt end point buffer size & convert hard coded
value to macro for better readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/oz
We have icreased interrupt end point buffer size to 512 bytes,
Change variable data type to accomodate it.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging
Max. TX frame size supported is changed to 760 bytes.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozproto.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozproto.h b/drivers/staging/ozwpan/ozproto.h
index e532347..0c49c8a 100644
--- a
Make sure that we return negative value if oz_build_frame()
returns NULL.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
index daaff2a
Use macro instead of hard coded value for readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 83ed64c..89e498b 100644
--- a
Check for valid config number before completing set interface.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index ab93b74..83ed64c 100644
As we are initialising structure, we do not require
memset().
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
index 06004c8..5d24af3 100644
--- a/drivers/staging
schedule_work() returns true if succeeded & false on failure,
error check was doing exactly reverse.
Also removes extra variable.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/oz
On 23/08/13 10:05, Dan Carpenter wrote:
On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote:
+/*--
* Context: softirq-serialized
*/
Don't resend the patch, but these comments are not in kernel
zwpan/ozpd.h
@@ -99,6 +99,7 @@ struct oz_pd {
u8 timeout_type;
struct tasklet_struct heartbeat_tasklet;
struct tasklet_struct timeout_tasklet;
+struct work_struct workitem;
Er, other field names seem aligned, what about this one?
Aft
patch defers deallocation of data structures to work queue.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.c | 28 +++-
drivers/staging/ozwpan/ozpd.h |1 +
2 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ozwpan/ozpd.c b
Check if interface number is correct before creating an end point.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 4682d78..d5a3900 100644
--- a/drivers
Increment PD reference counter, on every timer event so that
we do not loose PD object by mistake.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozproto.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging
Do not allocate a port to new device or process URB when its status is
yet to be read. This avoids race condition when USB core read hub
status a bit late, while new device tries to acquire port.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |5 +++--
1 file changed, 3
We are assigning value to hport before returning, there is
no need to initialize it.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index
We should not use extra variable just to copy pointer value,
renaming parameter name serves pupose & removes extra variable.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd
On 13/08/13 18:35, Sergei Shtylyov wrote:
Hello.
On 08/13/2013 09:29 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging
oject.org/pipermail/driverdev-devel/2013-August/040113.html
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c | 54
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/o
Swap arguments of oz_ep_alloc() to match kmalloc() for better readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 0fd3fea
Remove variable initialization wherever it is not required.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozeltbuf.c |2 +-
drivers/staging/ozwpan/ozhcd.c| 18 +-
drivers/staging/ozwpan/ozpd.c |4 ++--
3 files changed, 12 insertions(+), 12 deletions
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan/ozhcd.h |2 +-
2 files changed, 3 insertions
oz_hcd_pd_arrived returns struct oz_port *, change function
declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan/ozhcd.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff
We are already checking "ep" earlier in function. Do not
need to check again.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drive
Making code simpler for readability.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 5a417c8..4b658d4
Put spaces around math operations.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 4b658d4..2be15f4 100644
This patch adds a blank line between global declarations &
functions for readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c| 17
drivers/staging/ozwpan/ozeltbuf.c | 12 ++
drivers/staging/ozwpan/ozhcd.c |
This patch adds blank line between declaration &
code for readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c|6 ++
drivers/staging/ozwpan/ozeltbuf.c |7 +++
drivers/staging/ozwpan/ozhcd.c |
This patch seriese mostly contains coding style fixes & removes unneeded
variable initialization.
Dan Carpenter (1):
staging: ozwpan: Separate success & failure case for
oz_hcd_pd_arrived()
Rupesh Gujare (9):
staging: ozwpan: Add a blank line between declaraction and code.
On 05/08/13 21:23, Dan Carpenter wrote:
On Mon, Aug 05, 2013 at 07:43:16PM +0100, Rupesh Gujare wrote:
On 05/08/13 18:53, Dan Carpenter wrote:
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote:
This patch fixes crash issue when there is quick cycle of
de-enumeration & enumera
On 05/08/13 19:56, Dan Carpenter wrote:
On Mon, Aug 05, 2013 at 06:40:15PM +0100, Rupesh Gujare wrote:
Fix a bug where we were not returning correct hub status
for 8th port.
What are the user visible effects of this bug?
8 th port is never assigned to new device & we loose one port.
S
On 05/08/13 19:21, Dan Carpenter wrote:
On Mon, Aug 05, 2013 at 06:40:14PM +0100, Rupesh Gujare wrote:
Make sure that we reset port configuration no. when PD departs.
What happens if we don't do this? What is the user visible effect
of this patch?
There is no user visible effect a
On 05/08/13 18:53, Dan Carpenter wrote:
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote:
This patch fixes crash issue when there is quick cycle of
de-enumeration & enumeration due to loss of wireless link.
It is found that sometimes new device (or coming back device)
returns
s in unstable
system & crash.
Above issue is resolved by making sure that we always assign
new port to new device, making sure that USB core reads correct
hub status.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c | 16 +++-
1 file changed, 11 insertions(+), 5 d
This patch series fixes crash issues observed,
& fix a bug in hub status code.
Rupesh Gujare (4):
staging: ozwpan: Fixes crash due to invalid port aceess.
staging: ozwpan: Increment port number for new device.
staging: ozwpan: Reset port configuration number.
staging: ozwpan: Re
Make sure that we reset port configuration no. when PD departs.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index a739986..b060e43 100644
--- a/drivers
This patch fixes kernel crash issue, when we receive URB request
after de-enumerating device.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan
Fix a bug where we were not returning correct hub status
for 8th port.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index b060e43
ngth array with no limit check the remote
attacker can just rewrite it using the memcpy() on the next line.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.h|2 +-
drivers/staging/ozwpan/ozproto.c |2 +-
2 files changed, 2 insertions(+), 2 de
This patch fixes following build warning.
drivers/built-in.o: In function `oz_hcd_heartbeat':
>> (.text+0x30aadd): undefined reference to `__divdi3'
drivers/built-in.o: In function `oz_hcd_heartbeat':
>> (.text+0x30ac85): undefined reference to `__divdi3
->credit += timespec_to_ns(&delta) / NSEC_PER_MSEC;
+ ep->credit += div64_u64(timespec_to_ns(&delta), NSEC_PER_MSEC);
Thank you Anca.
I will resend the patch.
--
Regards,
Rupesh Gujare
___
devel mailing list
de...@linuxdri
This patch fixes following build warning.
drivers/built-in.o: In function `oz_hcd_heartbeat':
>> (.text+0x30aadd): undefined reference to `__divdi3'
drivers/built-in.o: In function `oz_hcd_heartbeat':
>> (.text+0x30ac85): undefined reference to `__divdi3
This patch fixes issues reported by Dan here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-August/040052.html
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.h|2 +-
drivers/staging/ozwpan/ozproto.c |2 +-
2 files
On 02/08/13 11:27, Dan Carpenter wrote:
On Thu, Aug 01, 2013 at 06:45:01PM +0100, Rupesh Gujare wrote:
Farewell report size can be bigger than one byte, increase array
size to accomodate maximum 32 bytes of farewell report.
Gar... No. This is not right.
1) There is no check limiting the
Farewell report size can be bigger than one byte, increase array
size to accomodate maximum 32 bytes of farewell report.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozpd.h b/drivers
Fixes a bug where we were not setting length field causing wrong
report size to be copied.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozproto.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c
index ec60286
Use kernel's strncmp() function instead of defining same within driver.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozproto.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozpr
In case of ISOC transfer, if TX queue is full then we start
dropping latest frame, instead we should drop oldest frame &
add latest frame to TX queue.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozpd.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff -
This patch series removes duplicate code, & replaces it
with kernel library functions, and few bug fixes.
Rupesh Gujare (6):
staging: ozwpan: Use kernel list function for managing interface
list.
staging: ozwpan: Mark string as const
staging: ozwpan: Use kernel strncmp func
Managing interface list, is easier if we use kernel list_* API
than managing it on our own.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozproto.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/ozwpan/ozproto.c b
Make sure that we mark const string so that it does not get modified.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozproto.c |6 +++---
drivers/staging/ozwpan/ozproto.h |4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ozwpan/ozproto.c b
On 30/07/13 14:12, Dan Carpenter wrote:
On Tue, Jul 30, 2013 at 01:31:50PM +0100, Rupesh Gujare wrote:
Current implementation assumes HZ = 1000 for calculating
all internal timer intervals, which creates problem on
platforms where HZ != 1000.
As well we need resolution of less than 10 mSec for
around, which restricts us to timer interval
of 10 mSec. This is particularly found on embedded devices.
This patch moves on to use high resolution timers to calculate
all timer intervals as it allows us to have very small resolution
of timer interval, removing dependency on HZ.
Signed-off-by: Rupesh
On 25/07/13 11:39, Dan Carpenter wrote:
On Thu, Jul 25, 2013 at 10:30:30AM +0100, Rupesh Gujare wrote:
Greg,
Did you missed this patch ? Or did I made another mistake. :( ?
Chillax. It has only been one day. Ask again after two or three
weeks.
All right Dan,
Probably I was getting too
On 24/07/13 15:06, Rupesh Gujare wrote:
This patch fixes coding style issues reported by Dan here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c | 15 ---
1 file changed
This patch fixes coding style issues reported by Dan here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff
From: Joe Perches
Rename Kbuild to usual Makefile, consistent with
Kernel build structure.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/Kbuild | 16
drivers/staging/ozwpan/Makefile | 16
2 files changed, 16
From: Joe Perches
Replace macro with inline function.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozurbparanoia.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozurbparanoia.h
b/drivers/staging/ozwpan
From: Joe Perches
Remove unnecessary debug logs. Most of these logs
print function name at the start of function, which
are not really required.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c |2 --
drivers/staging/ozwpan/ozhcd.c | 28
From: Joe Perches
Remove old oz_trace & oz_trace2 macro & related header files.
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/Kbuild |6 ++
drivers/staging/ozwpan/ozcdev.c|2 --
drivers/staging/ozwpan/ozconfig.h
This is v3 of this original patch series here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-June/039280.html
v3 adds commit log for each patch as suggested by Joe here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-July/039361.html
Joe Perches
-June/039278.html
--
Regards,
Rupesh Gujare
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 04/07/13 13:35, Rupesh Gujare wrote:
From: Joe Perches
Pardon my ignorance, above error occurred while creating patch series.
I should had been careful about it.
--
Regards,
Rupesh Gujare
___
devel mailing list
de...@linuxdriverproject.org
http
From: Joe Perches
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozurbparanoia.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozurbparanoia.h
b/drivers/staging/ozwpan/ozurbparanoia.h
index 00f5a3a
From: Joe Perches
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/Kbuild |6 ++
drivers/staging/ozwpan/ozcdev.c|2 --
drivers/staging/ozwpan/ozconfig.h | 26 ---
drivers/staging/ozwpan/ozeltbuf.c
This patch series splits earlier patch from Joe, into smaller patches.
Joe Perches (5):
staging: ozwpan: Remove extra debug logs.
staging: ozwpan: Replace oz_trace with oz_dbg
staging: ozwpan: Remove old debug macro.
staging: ozwpan: Convert macro to function.
staging: ozwpan: Rename Kbu
From: Joe Perches
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c |2 --
drivers/staging/ozwpan/ozhcd.c | 28
2 files changed, 8 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/ozwpan/ozcdev.c b
From: Joe Perches
Signed-off-by: Joe Perches
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/Kbuild | 16
drivers/staging/ozwpan/Makefile | 16
2 files changed, 16 insertions(+), 16 deletions(-)
delete mode 100644 drivers/staging/ozwpan/Kbuild
eg have objection to define new macros
& he had suggested to use dev_dbg() & pr_debug().
I will leave it to him, if he is all right to accept new macros for
debug logs.
Greg,
Your comments please.
...
+#endif /* _OZCONFIG_H */
Need to change to -
#endi
On 25/06/13 18:02, Greg KH wrote:
On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote:
convert all debug messages from printk to dev_dbg() & add kernel config to
enable/disable these messages during compilation.
No, just use the built-in dynamic debug code in the kernel, no nee
convert all debug messages from printk to dev_dbg() & add kernel config to
enable/disable these messages during compilation.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/Kbuild|2 +-
drivers/staging/ozwpan/Kconfig |9 +
drivers/staging/ozwpan/ozcdev.c |
83 matches
Mail list logo
