Re: [PATCH] staging: fix ignoring return value warning

Hi Dan, On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > Fix the below ignoring return value warning for device_reset. > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > of func

Re: [PATCH] staging: fix ignoring return value warning

On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > Fix the below ignoring return value warning for device_reset. > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > of function declared with 'warn_unused_result' attribute [-Wunused-result] > devi

Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

On Wed, Jun 25, 2014 at 09:43:27AM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote: > > On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote: > > > + > > > /* > > > * Bitfield of

Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote: > Signed-off-by: Denis Carikli > --- > ChangeLog v13->v14: > - Rebased > ChangeLog 12->v13: > - No changes > ChangeLog 11->v12: > - Improved the define names to match the hardware: > ENABLE_POL is not a clock signal but instead an en

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

On Wed, Jan 08, 2014 at 05:39:31PM -0500, Sean Paul wrote: > On Wed, Jan 8, 2014 at 4:36 PM, Russell King - ARM Linux > > Which bits do you think would be useful to move into the core? > > imx_drm_add_components() is rather imx-drm specific, especially for > > the CRTCs - it carries the knowledge t

Re: [PATCH 0/4] Fix some bugs/races in imx-drm

dd_crtc() > imx-drm: imx-drm-core: fix DRM cleanup paths > imx-drm: fix missing symbol exports > imx-drm: ipu-v3: fix potential CRTC device registration race For all (now eight) patches: Acked-by: Sascha Hauer Sascha -- Pengutronix e.K. |

Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3

a > link error as above. To fix this, we adjust the make target with the proper > objs, which will change the name of the resulting .ko. We also add an > EXPORT_SYMBOL_GPL for imx_drm_crtc_id. > > Signed-off-by: Josh Boyer Acked-by: Sascha Hauer Sascha > --- > drive

Re: imx-drm/ipuv3-crtc.ko fails to link

Hi Josh, On Tue, Nov 12, 2013 at 09:32:08AM -0500, Josh Boyer wrote: > On Mon, Nov 11, 2013 at 11:22 AM, Josh Boyer > wrote: > > Hi All, > > > > With v3.12-2839-gedae583 (Linus' tree as of this morning), the > > ipuv3-crtc.ko module fails to link with the following messages: > > > > ERROR: "ipu_

Re: [PATCH -next] staging: drm/imx: fix return value check in ipu_add_subdevice_pdata()

t; Signed-off-by: Wei Yongjun Acked-by: Sascha Hauer > --- > drivers/staging/imx-drm/ipu-v3/ipu-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c > b/drivers/staging/imx-drm/ipu-v3/ipu-common.c > ind

Re: [PATCH] staging: drm/imx: fix return value check in imx_drm_init()

t; Signed-off-by: Wei Yongjun Acked-by: Sascha Hauer Sascha > --- > drivers/staging/imx-drm/imx-drm-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/imx-drm/imx-drm-core.c > b/drivers/staging/imx-drm/imx-drm-core.c > ind

Re: [Patch v2][ 11/37] staging: imx-drm: use of_get_display_timings.

On Thu, Oct 17, 2013 at 05:02:09PM +0200, Denis Carikli wrote: > The comment on top of of_get_drm_display_mode says: > * This function is expensive and should only be used, if only one mode is to > be > * read from DT. To get multiple modes start with of_get_display_timings and > * work with th

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

On Wed, Oct 16, 2013 at 08:02:11PM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 16, 2013 at 11:31:07AM -0700, Greg Kroah-Hartman wrote: > > On Wed, Oct 16, 2013 at 07:07:35PM +0100, Russell King - ARM Linux wrote: > > > Sorry, but I don't think imx-drm is driving the hardware correctly, and

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

On Tue, Oct 15, 2013 at 11:35:00AM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 15, 2013 at 10:18:30AM +0100, Russell King - ARM Linux wrote: > > On Tue, Oct 15, 2013 at 09:46:18AM +0200, Sascha Hauer wrote: > > > This sounds like the wrong clock polarity. Could

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

On Tue, Oct 15, 2013 at 11:00:26AM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 14, 2013 at 11:47:17PM -0300, Fabio Estevam wrote: > > On Mon, Oct 14, 2013 at 2:38 PM, Russell King - ARM Linux > > wrote: > > > > > Shouldn't the above be in patch 1 (or 1.5) rather than patch 2? Patch 2 >

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

On Mon, Oct 14, 2013 at 11:50:29PM +0100, Russell King - ARM Linux wrote: > Answers to these two questions may help stop me wasting a lot of time > chasing what is a really weird bug. > > So, I have X up and running on the Cubox-i carrier-1, using the imx-drm > stuff (I've slightly hacked my xf86-

Re: [patch] staging: drm/imx: ipu-dc: signedness bug in ipu_dc_init_sync()

On Wed, Aug 21, 2013 at 11:30:08AM +0300, Dan Carpenter wrote: > "map" needs to be signed for the error handling to work. In the success > case then it holds a small non-negative value. > > Signed-off-by: Dan Carpenter Acked-by: Sascha Hauer Sascha > > diff --g

Re: [PATCH 1/5] imx-drm: ipu-di: Check the return value from clk_prepare_enable()

On Sun, Aug 18, 2013 at 09:40:02PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > clk_prepare_enable() may fail, so let's check its return value and propagate > it > in the case of error. > > Signed-off-by: Fabio Estevam For the series: Acked