Re: [PATCH] staging: fix ignoring return value warning

2021-02-08 Thread Sascha Hauer
Hi Dan, On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > Fix the below ignoring return value warning for device_reset. > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > of

Re: [PATCH] staging: fix ignoring return value warning

2021-02-08 Thread Sascha Hauer
On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > Fix the below ignoring return value warning for device_reset. > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > of function declared with 'warn_unused_result' attribute [-Wunused-result] >

Re: [PATCH v14 04/10] imx-drm: use defines for clock polarity settings

2014-06-25 Thread Sascha Hauer
On Wed, Jun 25, 2014 at 09:43:27AM +0100, Russell King - ARM Linux wrote: On Wed, Jun 25, 2014 at 06:48:45AM +0200, Sascha Hauer wrote: On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote: + /* * Bitfield of Display Interface signal polarities. */ @@ -37,7 +43,7

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-08 Thread Sascha Hauer
On Wed, Jan 08, 2014 at 05:39:31PM -0500, Sean Paul wrote: On Wed, Jan 8, 2014 at 4:36 PM, Russell King - ARM Linux Which bits do you think would be useful to move into the core? imx_drm_add_components() is rather imx-drm specific, especially for the CRTCs - it carries the knowledge that

Re: [PATCH 0/4] Fix some bugs/races in imx-drm

2013-12-16 Thread Sascha Hauer
: fix DRM cleanup paths imx-drm: fix missing symbol exports imx-drm: ipu-v3: fix potential CRTC device registration race For all (now eight) patches: Acked-by: Sascha Hauer s.ha...@pengutronix.de Sascha -- Pengutronix e.K

Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3

2013-11-18 Thread Sascha Hauer
with the proper objs, which will change the name of the resulting .ko. We also add an EXPORT_SYMBOL_GPL for imx_drm_crtc_id. Signed-off-by: Josh Boyer jwbo...@fedoraproject.org Acked-by: Sascha Hauer s.ha...@pengutronix.de Sascha --- drivers/staging/imx-drm/Makefile | 4

Re: [PATCH -next] staging: drm/imx: fix return value check in ipu_add_subdevice_pdata()

2013-10-31 Thread Sascha Hauer
(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm

Re: [PATCH] staging: drm/imx: fix return value check in imx_drm_init()

2013-10-28 Thread Sascha Hauer
(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Sascha Hauer s.ha...@pengutronix.de Sascha --- drivers/staging/imx-drm/imx-drm-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx

Re: [Patch v2][ 11/37] staging: imx-drm: use of_get_display_timings.

2013-10-18 Thread Sascha Hauer
On Thu, Oct 17, 2013 at 05:02:09PM +0200, Denis Carikli wrote: The comment on top of of_get_drm_display_mode says: * This function is expensive and should only be used, if only one mode is to be * read from DT. To get multiple modes start with of_get_display_timings and * work with that

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-16 Thread Sascha Hauer
On Tue, Oct 15, 2013 at 11:35:00AM +0100, Russell King - ARM Linux wrote: On Tue, Oct 15, 2013 at 10:18:30AM +0100, Russell King - ARM Linux wrote: On Tue, Oct 15, 2013 at 09:46:18AM +0200, Sascha Hauer wrote: This sounds like the wrong clock polarity. Could you try inverting

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 11:50:29PM +0100, Russell King - ARM Linux wrote: Answers to these two questions may help stop me wasting a lot of time chasing what is a really weird bug. So, I have X up and running on the Cubox-i carrier-1, using the imx-drm stuff (I've slightly hacked my

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Sascha Hauer
On Tue, Oct 15, 2013 at 11:00:26AM +0100, Russell King - ARM Linux wrote: On Mon, Oct 14, 2013 at 11:47:17PM -0300, Fabio Estevam wrote: On Mon, Oct 14, 2013 at 2:38 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Shouldn't the above be in patch 1 (or 1.5) rather than patch

Re: [patch] staging: drm/imx: ipu-dc: signedness bug in ipu_dc_init_sync()

2013-08-21 Thread Sascha Hauer
On Wed, Aug 21, 2013 at 11:30:08AM +0300, Dan Carpenter wrote: map needs to be signed for the error handling to work. In the success case then it holds a small non-negative value. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Sascha Hauer s.ha...@pengutronix.de Sascha

Re: [PATCH 1/5] imx-drm: ipu-di: Check the return value from clk_prepare_enable()

2013-08-19 Thread Sascha Hauer
: Acked-by: Sascha Hauer s.ha...@pengutronix.de Sascha --- drivers/staging/imx-drm/ipu-v3/ipu-di.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-di.c b/drivers/staging/imx-drm/ipu-v3/ipu-di.c index 0b6806e..948a49b 100644