Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-12 Thread Saurabh Sengar
On 12 December 2015 at 15:41, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: >> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> > On Mon, Dec 07, 2015 at 06:35:11PM +05

[PATCH v2] Staging: speakup: kobjects: Return the error type to caller

2015-12-07 Thread Saurabh Sengar
Inorder to notify the user that value is not successfuly set in sys entry, error should be returned from store function instead of count Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- v2: Hi Dan, I will look more into this function in my free time. For now just sending you this

Re: [PATCH v2] Staging: speakup: kobjects: Return the error type to caller

2015-12-07 Thread Saurabh Sengar
Please ignore this patch, I will look more in to this function and will send a new patch in order to make this function neat. On 7 December 2015 at 15:29, Saurabh Sengar <saurabh.tr...@gmail.com> wrote: > Inorder to notify the user that value is not successfuly set in sys > entry,

[PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-07 Thread Saurabh Sengar
ternary operator, as it was always returning the status value only, and hence removed the status variable too Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/staging/speakup/varhandlers.c | 50 +-- 1 file changed, 25 insertions(+), 25 del

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-06 Thread Saurabh Sengar
On 7 December 2015 at 12:18, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: >> Inorder to notify the user that value is not successfuly set in sys >> entry, error should be returned from store function instead

[PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-04 Thread Saurabh Sengar
Inorder to notify the user that value is not successfuly set in sys entry, error should be returned from store function instead of count Signed-off-by: Saurabh Sengar <saurabh.tr...@gmail.com> --- drivers/staging/speakup/kobjects.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)