Re: [PATCH] Staging: comedi: driver: Remove condition with no effect

2020-07-18 Thread SAURAV GIREPUNJE
On Mon, Jul 13, 2020 at 02:41:19PM +0100, Ian Abbott wrote: > On 13/07/2020 14:34, Greg KH wrote: > > On Sun, Jul 12, 2020 at 12:36:28PM +0530, Saurav Girepunje wrote: > > > Remove below warning in das1800.c > > > WARNING: possible condition with no effect (if == el

[PATCH] Staging: comedi: driver: Remove condition with no effect

2020-07-12 Thread Saurav Girepunje
Remove below warning in das1800.c WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje --- drivers/staging/comedi/drivers/das1800.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi

[PATCH] staging: greybus: fix fw is NULL but dereferenced.

2020-01-26 Thread Saurav Girepunje
ize. So initialized next_request to NEXT_REQ_GET_FIRMWARE for return in other case. Signed-off-by: Saurav Girepunje --- drivers/staging/greybus/bootrom.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootro

[PATCH] staging: vt6656: fix Unneeded variable: "ret"

2020-01-25 Thread Saurav Girepunje
Remove unneeded variable "ret". Issues reported by coccicheck. Signed-off-by: Saurav Girepunje --- drivers/staging/vt6656/card.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index 7958fc1..654c

[PATCH] staging: rtl8723bs: hal: fix condition with no effect

2020-01-25 Thread Saurav Girepunje
fix warning reorted by coccicheck WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers

[PATCH] staging: rtl8723bs: core: fix condition with no effect

2020-01-25 Thread Saurav Girepunje
fix warning reorted by coccicheck WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c

[PATCH] staging: comedi: drivers: fix condition with no effect

2020-01-25 Thread Saurav Girepunje
fix warning reorted by coccicheck WARNING: possible condition with no effect (if == else) Signed-off-by: Saurav Girepunje --- drivers/staging/comedi/drivers/das1800.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi

Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables

2020-01-25 Thread SAURAV GIREPUNJE
On 25/01/20 11:00 +0100, Johan Hovold wrote: On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: fix uninitialized variables issue found using static code analysis tool Which tool is that? (error) Uninitialized variable: offset (error) Uninitialized variable: size Signed-off

[PATCH] staging: greybus: bootrom: fix uninitialized variables

2020-01-25 Thread Saurav Girepunje
fix uninitialized variables issue found using static code analysis tool (error) Uninitialized variable: offset (error) Uninitialized variable: size Signed-off-by: Saurav Girepunje --- drivers/staging/greybus/bootrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] staging: rtl8723bs: os_dep: Remove return variables

2019-10-02 Thread Saurav Girepunje
Remove return variables, return the values directly, as the functions all return 0 in all cases. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: os_dep: Remove unused variable

2019-09-22 Thread Saurav Girepunje
Remove unused variable ret from functions rtw_mp_ioctl_hdl, rtw_get_ap_info, rtw_mp_efuse_set, rtw_tdls, rtw_tdls_get . Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8723bs: core: Drop condition with no effect

2019-09-21 Thread Saurav Girepunje
As the "else if" and "else" branch body are identical the condition has no effect. So drop the "else if" condition Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/st

[PATCH] staging: rtl8723bs: os_dep: Drop condition with no effect

2019-08-21 Thread Saurav Girepunje
As the "else if" and "else" branch body are identical the condition has no effect. So drop the "else if" condition. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dr

[PATCH] staging: rt;8723bs: os_dep: Drop condition with no effect

2019-08-21 Thread Saurav Girepunje
As the "else if" and "else" branch body are identical the condition has no effect. So drop the "else if" condition. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dr

[PATCH] staging: rtl8723bs: hal: Drop condition with no effect

2019-08-21 Thread Saurav Girepunje
As the "else if" and "else" branch body are identical the condition has no effect. So drop the else if condition. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/s

[PATCH] staging: rtl8723bs: core: add spaces around '-', '+', '&','|' and '?'

2019-08-03 Thread Saurav Girepunje
Add spaces around '-', '+', '&','|' and '?' to improve readability and follow kernel coding style in rtw_ap.c Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/core/rtw_ap.c | 88 - 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/dri

[PATCH] staging: rtl8723bs: core: Remove Unnecessary parentheses

2019-08-03 Thread Saurav Girepunje
Remove Unnecessary parentheses around padapter->mlmepriv, pmlmeext->mlmext_info and pmlmeinfo->network in rtw_ap.c Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/driver

[PATCH] staging: rtl8723bs: core: correct spelling mistake in rtw_ap.c

2019-08-03 Thread Saurav Girepunje
Correct spelling mistake in rtw_ap.c Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 7bd5c61b055c

[PATCH] staging: rtl8188eu: core: add spaces around '-', '+', '>>','<<' and '*' in rtw_efuse.c

2019-08-03 Thread Saurav Girepunje
Add spaces around '-', '+', '>>','<<' and '*' to improve readability and follow kernel coding style. Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 128 ++--- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/dri

[PATCH] staging: rtl8188eu: core: rtw_recv.c: Remove Unnecessary parentheses

2019-08-03 Thread Saurav Girepunje
Remove Unnecessary parentheses around precvframe->list, pmlmeext->mlmext_info and precvpriv->free_recv_queue Signed-off-by: Saurav Girepunje --- drivers/staging/rtl8188eu/core/rtw_recv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl81

[PATCH] staging: rtl8723bs: Remove Unnecessary parentheses

2019-07-28 Thread Saurav-Girepunje
Removed Unnecessary parentheses around "padapter->mlmepriv", "pmlmeext->mlmext_info" and "pmlmeinfo->network" Signed-off-by: Saurav-Girepunje --- drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH] RTWAP:Fixed Coding function and style issues

2019-07-28 Thread Saurav-Girepunje
RTWAP:Fixed Coding function and style issues Removed Unnecessary parentheses Signed-off-by: Saurav-Girepunje --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs