Re: [PATCH] staging: rtl8188eu: Macro should be enclosed

On Sun, Apr 09, 2017 at 02:47:45PM +0100, alfonsolimaas...@gmail.com wrote: > On Sat, Apr 01, 2017 at 09:24:58AM +0200, Sebastian Haas wrote: > > Hi Alfonso, > > > > On Wed, Mar 29, 2017 at 07:50:11PM +0100, alfonsolimaas...@gmail.com wrote: > > > diff --git a/dri

Re: [PATCH] staging: rtl8188eu: Macro should be enclosed

Hi Alfonso, On Wed, Mar 29, 2017 at 07:50:11PM +0100, alfonsolimaas...@gmail.com wrote: > diff --git a/drivers/staging/rtl8188eu/include/odm_debug.h > b/drivers/staging/rtl8188eu/include/odm_debug.h > index 687ff3e..fd92f7e 100644 > --- a/drivers/staging/rtl8188eu/include/odm_debug.h > +++ b/driv

Re: [PATCH 1/3] staging: rtl8188eu: wrap macro parameters in parentheses

On Tue, Mar 07, 2017 at 11:06:48PM +0300, Dan Carpenter wrote: > On Sat, Mar 04, 2017 at 11:05:58PM +0100, Sebastian Haas wrote: > > diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_hal.h > > b/drivers/staging/rtl8188eu/include/rtl8188e_hal.h > > index 9330361..ca9

[PATCH 1/3] staging: rtl8188eu: wrap macro parameters in parentheses

Avoid potential precedences issues by wrapping macro parameters in parentheses. Signed-off-by: Sebastian Haas --- drivers/staging/rtl8188eu/include/Hal8188EPhyReg.h | 2 +- drivers/staging/rtl8188eu/include/Hal8188ERateAdaptive.h | 16 drivers/staging/rtl8188eu/include

[PATCH 3/3] staging: rtl8188eu: fix typos in macros

Rename macro definition and usage to represent correct spelling of DEFAULT: ODM_REG_RX_DEFUALT_A_11N => ODM_REG_RX_DEFAULT_A_11N ODM_REG_RX_DEFUALT_B_11N => ODM_REG_RX_DEFAULT_B_11N Signed-off-by: Sebastian Haas --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 4 ++-- drivers/s

[PATCH 2/3] staging: rtl8188eu: fix typos in comments

Fix typos reported by checkpatch.pl Signed-off-by: Sebastian Haas --- Already existing block-comment warnings on the edited lines are not handled by this patch. drivers/staging/rtl8188eu/include/Hal8188EPhyReg.h| 2 +- drivers/staging/rtl8188eu/include/odm_debug.h | 2 +- drivers

[PATCH 0/3] staging: rtl8188eu: cleanup of checkpatch findings

This patch series fixes typos and prevents potential problems with macro parameters in the rtl8188eu driver. Sebastian Haas (3): staging: rtl8188eu: wrap macro parameters in parentheses staging: rtl8188eu: fix typos in comments staging: rtl8188eu: fix typos in macros drivers/staging

[PATCH] staging: rtl8192u: Fix endianness warnings in ieee80211_rx.c

Fixes the endianness warning "restricted __le16 degrades to integer" by converting __le16 to short before using it in bitmasks or in the macro WLAN_FC_GET_STYPE. Signed-off-by: Sebastian Haas --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 52 +++ 1 file c

[PATCH] staging: most: hdm-usb: fix symbolic permissions warning

Replace symbolic permissions with their octect representation to fix checkpatch warnings. Signed-off-by: Sebastian Haas --- drivers/staging/most/hdm-usb/hdm_usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging