Re: [driver-core:debugfs_lookup_fix] [mm/damon/dbgfs] ff25f87cfc: kernel_BUG_at_lib/list_debug.c

2023-01-05 Thread SeongJae Park
On Thu, 5 Jan 2023 10:53:57 +0100 Greg Kroah-Hartman wrote: > On Wed, Jan 04, 2023 at 06:35:39PM +0000, SeongJae Park wrote: > > Hello, > > > > On Tue, 3 Jan 2023 21:16:09 +0800 kernel test robot > > wrote: > > > > > [-- Attachm

Re: [driver-core:debugfs_lookup_fix] [mm/damon/dbgfs] ff25f87cfc: kernel_BUG_at_lib/list_debug.c

2023-01-04 Thread SeongJae Park
Hello, On Tue, 3 Jan 2023 21:16:09 +0800 kernel test robot wrote: > [-- Attachment #1: Type: text/plain, Size: 7528 bytes --] > > > Greeting, > > FYI, we noticed kernel_BUG_at_lib/list_debug.c due to commit (built with > gcc-11): Thank you for the report! > > commit: ff25f87cfcfc34ebe652

[PATCH v2] staging: silicom: remove BP_PROC_SUPPORT dependant code

2014-03-26 Thread SeongJae Park
but not used [-Wunused-function] static int bp_proc_create(void) ^ Fix the warning and remove code complexity by remove whole code inside #ifdef BP_PROC_SUPPORT. Signed-off-by: SeongJae Park --- drivers/staging/silicom/bpctl_mod.c | 39 - 1 file

Re: [PATCH] staging: silicom: hide conditionally used function in condition

2014-03-26 Thread SeongJae Park
On Wed, Mar 26, 2014 at 9:27 PM, Greg KH wrote: > On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote: >> bp_proc_create() be called only when BP_PROC_SUPPORT defined but its >> definition live outside of #ifdef BP_PROC_SUPPORT and cause following >> trivial buil

[PATCH] staging: silicom: hide conditionally used function in condition

2014-03-25 Thread SeongJae Park
bp_proc_create(void) ^ Fix the warning by hide the definition inside #ifdef BP_PROC_SUPPORT. Signed-off-by: SeongJae Park --- drivers/staging/silicom/bpctl_mod.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c

Re: [PATCH] staging: android: binder: convert commented messages to pr_debug

2014-02-18 Thread SeongJae Park
Add de...@driverdev.osuosl.org as CC. Sorry if this duplicated mail bothered your inbox. On Wed, Feb 19, 2014 at 12:49 PM, SeongJae Park wrote: > 2 debugging messages were just commented out for normal case. Let them > be activated on debug mode without explicit code modification. > >

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread SeongJae Park
On Wed, Feb 19, 2014 at 12:04 PM, Sachin Kamat wrote: > On 19 February 2014 05:58, SeongJae Park wrote: >> On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: >>> On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: >>>> Signed-off-by: SeongJae Park >>

Re: [PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread SeongJae Park
Hello, On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: > On Tue, Feb 18, 2014 at 08:23:26PM +0900, SeongJae Park wrote: >> The variable `binder_debugfs_dir_entry_root` is declared as static >> global variable although it is accessed from init function only. Declare >> it as

Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread SeongJae Park
On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: > On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: >> Signed-off-by: SeongJae Park >> --- >> drivers/staging/android/binder.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers

[PATCH 1/2] staging: android: binder: remove unnecessary comment

2014-02-18 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/android/binder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index eaec1da..b23cbc9 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c

[PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread SeongJae Park
The variable `binder_debugfs_dir_entry_root` is declared as static global variable although it is accessed from init function only. Declare it as init function's local variable because it would be better to read and memory efficiency. Signed-off-by: SeongJae Park --- drivers/staging/an

Re: [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY

2014-02-11 Thread SeongJae Park
On Wed, Feb 12, 2014 at 5:22 AM, Greg KH wrote: > On Sat, Feb 08, 2014 at 11:59:41AM +0900, SeongJae Park wrote: >> Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from >> anywhere. > >> >> Signed-off-by: SeongJae Park >> --- >> drivers/

[PATCH 1/2] staging: android: binder: use whitespace consistently

2014-02-07 Thread SeongJae Park
Whitespace between #define keyword and BINDER_* constants are space in some point and tab in some point. Using space or tab is just writer's choice. But, let's use them more consistently. Signed-off-by: SeongJae Park --- drivers/staging/android/binder.h | 10 +- 1 file

[PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY

2014-02-07 Thread SeongJae Park
Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from anywhere. Signed-off-by: SeongJae Park --- drivers/staging/android/binder.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h index

Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings

2014-02-04 Thread SeongJae Park
On Tue, Feb 4, 2014 at 5:51 PM, Dan Carpenter wrote: > On Tue, Feb 04, 2014 at 05:26:57PM +0900, SeongJae Park wrote: >> Hello, >> >> On Tue, Feb 4, 2014 at 5:21 PM, Dan Carpenter >> wrote: >> > On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote

[PATCH] staging: cxt1e1: remove unnecessary function, VMETRO_TRACE

2014-02-04 Thread SeongJae Park
VMETRO_TRACE isn't called from anywhere. So delete it. Signed-off-by: SeongJae Park --- drivers/staging/cxt1e1/functions.c | 9 - drivers/staging/cxt1e1/pmcc4.h | 1 - 2 files changed, 10 deletions(-) diff --git a/drivers/staging/cxt1e1/functions.c b/drivers/staging/c

Re: [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-04 Thread SeongJae Park
On Tue, Feb 4, 2014 at 5:23 PM, Dan Carpenter wrote: > On Tue, Feb 04, 2014 at 04:01:26PM +0900, SeongJae Park wrote: >> Fix the pointer-integer size mismatch warning below: >> drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’: >> drivers/staging/cxt1

Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings

2014-02-04 Thread SeongJae Park
Hello, On Tue, Feb 4, 2014 at 5:21 PM, Dan Carpenter wrote: > On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote: >> Fix the pointer-integer size mismatch warnings below: >> drivers/staging/bcm/CmHost.c: In function >> ‘StoreCmControlResponseMessage’: >

[PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-03 Thread SeongJae Park
] u_int32_t y = (u_int32_t) x; ^ Signed-off-by: SeongJae Park --- drivers/staging/cxt1e1/functions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/cxt1e1/functions.c b/drivers/staging/cxt1e1/functions.c index 95218e2..8f19a39 100644

[PATCH] staging: bcm: fix pointer-integer size mismatch warnings

2014-02-03 Thread SeongJae Park
pointer from integer of different size [-Wint-to-pointer-cast] pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet); ^ Signed-off-by: SeongJae Park --- drivers/staging/bcm/CmHost.c | 9

[PATCH 2/2] staging: crystalhd: remove unnecessary parenthesis

2014-01-17 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/crystalhd/crystalhd_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index ccfa3b8..4765d52 100644 --- a/drivers/staging/crystalhd

[PATCH 1/2] staging: crystalhd: enclose multi statements macro

2014-01-17 Thread SeongJae Park
Enclose multiple statements macro with do - while block. Signed-off-by: SeongJae Park --- drivers/staging/crystalhd/crystalhd_hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index

[PATCH 2/3] staging: alarm-dev: Remove unnecessary blank lines

2013-11-14 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/android/alarm-dev.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c index ccf74ee..a3b467b 100644 --- a/drivers/staging/android/alarm-dev.c +++ b/drivers/staging

[PATCH 3/3] staging: alarm-dev: Seperate functions with one blank line

2013-11-14 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/android/alarm-dev.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c index a3b467b..2fc7cdd 100644 --- a/drivers/staging/android/alarm-dev.c +++ b/drivers/staging

[PATCH 1/3] staging: alarm-dev: Remove unnecessary parenthesis

2013-11-14 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/android/alarm-dev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c index 647694f..ccf74ee 100644 --- a/drivers/staging/android/alarm-dev.c +++ b

[PATCH 1/3] staging: alarm-dev: Remove unnecessary parenthesis

2013-11-14 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/android/alarm-dev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c index 647694f..ccf74ee 100644 --- a/drivers/staging/android/alarm-dev.c +++ b