Re: [PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay

Hello! On 11.12.2019 21:12, Scott Schafer wrote: chage udelay() to usleep_range() Change? Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c

Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled

Hello! On 21.12.2018 23:57, Florian Westphal wrote: skb->sp doesn't exist anymore in the next-next tree, so mips defconfig It's net-next. :-) no longer builds. Use helper instead to reset the secpath. Not even compile tested. Cc: Greg Kroah-Hartman Reported-by: Guenter Roeck Fixes:

Re: [PATCH 01/25] tty: Change return type to void

Hello! On 9/4/2018 5:44 AM, Jaejoong Kim wrote: Many drivers with tty use the tty_stand_install(). But, there is no need to handle the error, since it always returns 0. So, change the return type of tty_standard_install() and tty_port_install() to void type and remove unnecessary exception

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

le SoCs are still covered by the CONFIG_CPU_SH4 > check. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> [...] Acked-by: Sergei Shtylyov

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is ARCH_RENESAS a more appropriate platform dependency than the legacy "ARCH_RENESAS is", no? > ARCH_SHMOBILE, hence use the former. > > This will allow to drop

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

On 03/09/2018 09:37 PM, Sergei Shtylyov wrote: >> Commit 009f766 intended to filter multicast/broadcast, however > >At least 12 digits needed here, and the summary line too, just like you do > for the Fixes: tag. > >> the NDIS filter wasn't set properly in non-pro

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

Hello! On 03/09/2018 04:25 PM, Mohammed Gamal wrote: > Commit 009f766 intended to filter multicast/broadcast, however At least 12 digits needed here, and the summary line too, just like you do for the Fixes: tag. > the NDIS filter wasn't set properly in non-promiscuous modes, > which

Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message

Hello. On 9/10/2017 11:37 PM, Guenter Roeck wrote: struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h

Re: [PATCH net-next 3/6] netvsc: use typed pointer for internal state

Hello. On 6/9/2017 2:21 AM, Stephen Hemminger wrote: The element netvsc_device:extension is always a point to RNDIS Pointer, maybe? information. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by:

Re: [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors).

Hello! Your subject is too long, mught want to move i(part of) it to the patch description... And you need to provide your Signed-off-by:, the patch can't be applied without it. MBR, Sergei ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

Hello. On 12/16/2015 09:03 PM, Haiyang Zhang wrote: To avoid performance overhead when using skb_flow_dissect_flow_keys(), we switch to the simple parsers to get the IP and port numbers. Performance comparison: throughput (Gbps): Number of connections, before patch, after patch 1

Re: [PATCH v2 42/48] usb: gadget: epautoconf: use 'ep_match' gadget callback

Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: If gadget has set 'ep_match' callback we prefer to call it first to allow UDC driver to find the best matching endpoint basing on chip-specific best usage knowledge. Signed-off-by: Robert Baldyga r.bald...@samsung.com ---

Re: [PATCH v2 47/48] usb: musb: gadget: add musb_match_ep() function

Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching process. Functions does the same that was done by chip-specific code inside of epautoconf. Now this code can be removed from there to separate generic code from

Re: [PATCH v2 45/48] usb: gadget: net2280: add net2280_match_ep() function

Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching process. Functions does the same that was done by chip-specific code inside of epautoconf. Now this code can be removed from there to separate generic code from

Re: [PATCH v2 48/48] usb: gadget: epautoconf: cleanup dead code

Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: Function find_ep() is no longer needed here, so we can remove it. We also don't use anything from gadget_chips.h header any longer. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/epautoconf.c | 14

Re: [PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

Hello. On 7/8/2015 12:05 PM, Robert Baldyga wrote: Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates usb request and increments refcounts. These things needs to be cleaned up by if further steps of initialization fail by calling functionfs_unbind(). Signed-off-by:

Re: [PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()

Hello. On 7/7/2015 5:02 PM, Robert Baldyga wrote: Should use usb_ep_set_maxpacket_limit instead of setting maxpacket value manually. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/staging/emxx_udc/emxx_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

Hello. On 04/28/2015 04:14 AM, K. Y. Srinivasan wrote: Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory One commit is enough. :-) And please also specify that commit's summary in parens. allocation in the packet send path. This commit introduced a bug since it

Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

Hello. On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the So you've first changed the method prototype and follow up with the changes to the actual implementations? That's backward. I'm afraid such changes can't be done

Re: [PATCH 1/3] hyperv: netvsc.c: fixup-of-wait_for_completion_timeout-return-type

Hello. On 1/25/2015 2:03 PM, Nicholas Mc Guire wrote: You probably want to replace hyphens with spaces in the subject of this and other patches. And you're not fixing the return type of wait_for_completion_timeout(), you're fixing the variables to match this type. Signed-off-by:

Re: [PATCH v4 0/4] Correct vendor-prefix and document device isl29028

Hello. On 10/8/2014 1:15 PM, Dan Carpenter wrote: These probably should have been sent to devicet...@vger.kernel.org. Use the maintainer.pl script. You surely meant scripts/get_maintainer.pl. :-) regards, dan carpenter WBR, Sergei ___ devel

Re: [PATCH v2] hyperv: Add netpoll support

Hello. On 07/09/2014 11:58 AM, Richard Weinberger wrote: In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger

Re: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

On 04/09/2014 08:12 PM, Larry Finger wrote: Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparition against eapol_type would always fail. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

Hello. On 03/25/2014 02:12 AM, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 Please also specify that commit's summary line in parens. Also, there's now an established format for such things: Fixes: 12-digit SHA ID (summary line) You can place such line

Re: [PATCH 2/2] coding style: fix line over 80 characters

On 03/21/2014 12:34 AM, Sergei Shtylyov wrote: Signed-off-by: Cédric Cabessa c...@ryick.net --- drivers/staging/usbip/vhci_hcd.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip

Re: [PATCH net-next, v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

Hello. On 03/19/2014 11:40 PM, David Miller wrote: +extern u8 netvsc_hash_key[]; We no longer use extern in header file function declarations. Wait, this is a variable declaration. :-) WBR, Sergei ___ devel mailing list

Re: [PATCH net] hyperv: Fix the carrier status setting

Hello. On 10-02-2014 5:07, Haiyang Zhang wrote: Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com --- drivers/net/hyperv/netvsc_drv.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

Hello. On 01/28/2014 01:29 AM, xypron.g...@gmx.de wrote: From: Heinrich Schuchardt xypron.g...@gmx.de p is freed if NULL. This is not an issue. p is leaked if second calloc fails. Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de ---

Re: [PATCH 1/9 RESENT] staging: r8188eu: Set device type to wlan

Hello. On 10/19/2013 01:32 AM, Larry Finger wrote: The latest version of NetworkManager does not recognize the device as wireless without this change. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 + 1 file changed, 5

Re: [PATCH 4/4] staging: ozwpan: Return error, if PD is not connected.

Hello. On 08/27/2013 07:53 PM, Rupesh Gujare wrote: Return error if we receive write(), while PD is not connected. Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com --- drivers/staging/ozwpan/ozcdev.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

Hello. On 08/22/2013 08:38 PM, Rupesh Gujare wrote: Currently we call oz_pd_destroy() from softirq context, where we try to destroy relevant data structures, as well we kill a tasklet which always result in following kernel warning. [12279.262194] Attempt to kill tasklet from interrupt