[PATCH v5 RESEND 4/8] Staging: rts5208: rtsx_transport.c: Add spaces around -

This patch fixes the following styling issue in rtsx_transport.c as reported by checkpatch.pl: CHECK: spaces preferred around that '-' (ctx:VxV) Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v5 RESEND 7/8] Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses

This patch removes all unnecessary parentheses found by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- Changes since v3 * Fixed patch conflicts due to commit 9a66d05d82db ("Staging: rts5208: fix check for dma mapping error"), and commit b3232842dbef (&

[PATCH v5 RESEND 6/8] Staging: rts5208: rtsx_transport.c: Fix label naming convention

This patch fixes the following naming convention issue in rtsx_transport.c, as reported by checkpatch.pl: CHECK: Avoid CamelCase: Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v5 RESEND 1/8] Staging: rts5208: rtsx_transport.c: Cleanup comments

This patch fixes all multiline comments to conform to the coding style, which states that multiline comments should start with "/*" and end with "*/" on a separate line. Also cleans up some comments to make them more clear and/or reflect what the code is doing. Signed-off-

[PATCH v5 RESEND 0/8] Staging: rts5208: Fix coding style

) as it is already done in change 9a66d05d82db (Staging: rts5208: fix check for dma mapping error) Changes since v2 * Incorporated Joshua Clayton's suggestions regarding the block comments Shaun Ren (8): Staging: rts5208: rtsx_transport.c: Cleanup comments Staging: rts5208

[PATCH v5 RESEND 8/8] Staging: rts5208: rtsx_transport.c: Fix comparisons to NULL

This patch changes all comparsions to NULL with !..., as reported by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transpor

[PATCH v5 RESEND 2/8] Staging: rts5208: rtsx_transport.c: Align to open parenthesis

of rtsx_transfer_data_partial to make the parameters of the rtsx_transfer_sglist_adma_partial call fit in 80 character lines after aligning them to the open parenthesis. Refactor memcpy logic in rtsx_stor_access_xfer_buf to make it more legible. Signed-off-by: Shaun Ren <shaun@linux.com> --- Changes si

[PATCH v5 RESEND 3/8] Staging: rts5208: rtsx_transport.c: Remove spaces after casts

This patch removes all spaces after casts in rtsx_transport.c, as reported by checkpatch.pl: CHECK: No space is necessary after a cast Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v5 RESEND 5/8] Staging: rts5208: rtsx_transport.c: Remove extra newlines

This patch fixes the following issues in rtsx_transport.c as reported by checkpatch.pl: CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please don't use multiple blank lines Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 3

[PATCH v5 2/8] Staging: rts5208: rtsx_transport.c: Align to open parenthesis

of rtsx_transfer_data_partial to make the parameters of the rtsx_transfer_sglist_adma_partial call fit in 80 character lines after aligning them to the open parenthesis. Refactor memcpy logic in rtsx_stor_access_xfer_buf to make it more legible. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/s

[PATCH v4 2/8] Staging: rts5208: rtsx_transport.c: Align to open parenthesis

of rtsx_transfer_data_partial to make the parameters of the rtsx_transfer_sglist_adma_partial call fit in 80 character lines after aligning them to the open parenthesis. Refactor memcpy logic in rtsx_stor_access_xfer_buf to make it more legible. Signed-off-by: Shaun Ren <shaun@linux.com> --- Changes si

[PATCH v4 1/8] Staging: rts5208: rtsx_transport.c: Cleanup comments

This patch fixes all multiline comments to conform to the coding style, which states that multiline comments should start with "/*" and end with "*/" on a separate line. Also cleans up some comments to make them more clear and/or reflect what the code is doing. Signed-off-

[PATCH v4 0/8] Staging: rts5208: Fix coding style

check for dma mapping error) Changes since v2 * Incorporated Joshua Clayton's suggestions regarding the block comments Shaun Ren (8): Staging: rts5208: rtsx_transport.c: Cleanup comments Staging: rts5208: rtsx_transport.c: Align to open parenthesis Staging: rts5208: rtsx_transport.c

[PATCH v4 3/8] Staging: rts5208: rtsx_transport.c: Remove spaces after casts

This patch removes all spaces after casts in rtsx_transport.c, as reported by checkpatch.pl: CHECK: No space is necessary after a cast Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v4 4/8] Staging: rts5208: rtsx_transport.c: Add spaces around -

This patch fixes the following styling issue in rtsx_transport.c as reported by checkpatch.pl: CHECK: spaces preferred around that '-' (ctx:VxV) Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v4 8/8] Staging: rts5208: rtsx_transport.c: Fix comparisons to NULL

This patch changes all comparsions to NULL with !..., as reported by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transpor

[PATCH v4 5/8] Staging: rts5208: rtsx_transport.c: Remove extra newlines

This patch fixes the following issues in rtsx_transport.c as reported by checkpatch.pl: CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please don't use multiple blank lines Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 3

[PATCH v4 6/8] Staging: rts5208: rtsx_transport.c: Fix label naming convention

This patch fixes the following naming convention issue in rtsx_transport.c, as reported by checkpatch.pl: CHECK: Avoid CamelCase: Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v4 7/8] Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses

This patch removes all unnecessary parentheses found by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- Changes since v3 * Fixed patch conflicts due to commit 9a66d05d82db ("Staging: rts5208: fix check for dma mapping error"), and commit b3232842dbef (&

Re: [PATCH v2 7/9] Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses

On Tue 2016-02-09 at 21:26 (-0800), Sudip Mukherjee wrote: > On Mon, Feb 08, 2016 at 05:31:23PM -0800, Shaun Ren wrote: >> This patch removes all unnecessary parentheses found by checkpatch.pl. >> >> Signed-off-by: Shaun Ren <shaun@linux.com> > > This will

[PATCH v3 1/9] Staging: rts5208: rtsx_transport.c: Cleanup comments

This patch fixes all multiline comments to conform to the coding style, which states that multiline comments should start with "/*" and end with "*/" on a separate line. Also cleans up some comments to make them more clear and/or reflect what the code is doing. Signed-off-

[PATCH v3 0/9] Staging: rts5208: Coding style and dma mapping fixes

This set of patches fixes the coding style issues in rtsx_transport.c, and dds a missing call dma_mapping_error() after dma_map_single(). Changes since v2 * Incorporated Joshua Clayton's suggestions regarding the block comments ___ devel mailing list

[PATCH v3 3/9] Staging: rts5208: rtsx_transport.c: Remove spaces after casts

This patch removes all spaces after casts in rtsx_transport.c, as reported by checkpatch.pl: CHECK: No space is necessary after a cast Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v3 5/9] Staging: rts5208: rtsx_transport.c: Remove extra newlines

This patch fixes the following issues in rtsx_transport.c as reported by checkpatch.pl: CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please don't use multiple blank lines Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 3

[PATCH v3 9/9] Staging: rts5208: Add missing dma_mapping_error

This patch adds a dma_mapping_error call to debug potential DMA mapping errors after the dma_map_single call in rtsx_transport.c. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 7/9] Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses

This patch removes all unnecessary parentheses found by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transpor

[PATCH v3 2/9] Staging: rts5208: rtsx_transport.c: Align to open parenthesis

This patch fixes the alignment issue reported by checkpatch.pl: CHECK: Alignment should match open parenthesis Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 61 ++-- 1 file changed, 35 insertions(+), 26 del

[PATCH v3 4/9] Staging: rts5208: rtsx_transport.c: Add spaces around -

This patch fixes the following styling issue in rtsx_transport.c as reported by checkpatch.pl: CHECK: spaces preferred around that '-' (ctx:VxV) Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v3 6/9] Staging: rts5208: rtsx_transport.c: Fix label naming convention

This patch fixes the following naming convention issue in rtsx_transport.c, as reported by checkpatch.pl: CHECK: Avoid CamelCase: Signed-off-by: Shaun Ren <shaun@linux.com> --- Changes since v2 * Update patch to reflect the changes made in PATCH 1/9 (block comments) drivers/s

[PATCH v3 8/9] Staging: rts5208: rtsx_transport.c: Fix comparisons to NULL

This patch changes all comparsions to NULL with !..., as reported by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transpor

[PATCH v2 8/9] Staging: rts5208: rtsx_transport.c: Fix comparisons to NULL

This patch changes all comparsions to NULL with !..., as reported by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transpor

[PATCH v2 6/9] Staging: rts5208: rtsx_transport.c: Fix label naming convention

This patch fixes the following naming convention issue in rtsx_transport.c, as reported by checkpatch.pl: CHECK: Avoid CamelCase: Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v2 7/9] Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses

This patch removes all unnecessary parentheses found by checkpatch.pl. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transpor

[PATCH v2 9/9] Staging: rts5208: Add missing dma_mapping_error

This patch adds a dma_mapping_error call to debug potential DMA mapping errors after the dma_map_single call in rtsx_transport.c. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 0/9] Staging: rts5208: Coding style and dma mapping fixes

This set of patches fixes the coding style issues in rtsx_transport.c, and dds a missing call dma_mapping_error() after dma_map_single(). ___ devel mailing list de...@linuxdriverproject.org

[PATCH v2 1/9] Staging: rts5208: rtsx_transport.c: Fix comment style warnings

This patch fixes all comment style warnings in rtsx_transport.c reported by checkpatch.pl: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 21 ++--- 1 file chang

[PATCH v2 4/9] Staging: rts5208: rtsx_transport.c: Add spaces around -

This patch fixes the following styling issue in rtsx_transport.c as reported by checkpatch.pl: CHECK: spaces preferred around that '-' (ctx:VxV) Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v2 5/9] Staging: rts5208: rtsx_transport.c: Remove extra newlines

This patch fixes the following issues in rtsx_transport.c as reported by checkpatch.pl: CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please don't use multiple blank lines Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 3

[PATCH v2 2/9] Staging: rts5208: rtsx_transport.c: Align to open parenthesis

This patch fixes the alignment issue reported by checkpatch.pl: CHECK: Alignment should match open parenthesis Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 61 ++-- 1 file changed, 35 insertions(+), 26 del

[PATCH v2 3/9] Staging: rts5208: rtsx_transport.c: Remove spaces after casts

This patch removes all spaces after casts in rtsx_transport.c, as reported by checkpatch.pl: CHECK: No space is necessary after a cast Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 2/2] Staging: rts5208: Add missing dma_mapping_error

Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c index eff9a4b621..43787df 100644 --- a/d

[PATCH 1/2] Staging: rts5208: Cleanup rtsx_transport.c

This patch fixes coding style issues in rtsx_transport.c. Signed-off-by: Shaun Ren <shaun@linux.com> --- drivers/staging/rts5208/rtsx_transport.c | 115 +-- 1 file changed, 65 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transpor

[PATCH 0/2] Staging: rts5208: Coding style and dma mapping fixes

This set of patches fixes the coding style issues in rtsx_transport.c, and adds a missing dma_mapping_error check. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel