Re: [Outreachy kernel] Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-31 Thread Shayenne Moura
On 10/30, Sasha Levin wrote: > On Tue, Oct 30, 2018 at 08:17:57PM -0300, Shayenne Moura wrote: > > On 10/30, Greg Kroah-Hartman wrote: > > > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > > > > Remove unneeded parentheses around the

Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-30 Thread Shayenne Moura
On 10/30, Greg Kroah-Hartman wrote: > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > > Remove unneeded parentheses around the arguments of ||. This reduces > > clutter and code behave in the same way. > > Change suggested by checkpatch.pl. > > > > vbox_main.c:119: CHECK:

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
On 10/30, Julia Lawall wrote: > > On Tue, 30 Oct 2018, Shayenne Moura wrote: > > > Hi, > > > > > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > > > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > &g

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
Hi, > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > The "possible alignement issues" in CHECK report is difficult to figure > > > > out by just doing a glance analysis. :) > > > > > > > > Linus also suggested to use bool as