Re: [PATCH v10 8/9] dt-bindings: add documentation of xilinx clocking wizard

2021-05-13 Thread Shubhrajyoti Datta
On Sat, Apr 10, 2021 at 5:02 AM Stephen Boyd wrote: > > Quoting Michal Simek (2021-04-08 03:40:29) > > > > > > On 4/8/21 12:26 PM, Shubhrajyoti Datta wrote: > > > On Sun, Mar 7, 2021 at 1:50 AM Rob Herring wrote: > > >> > > >> On Wed, F

Re: [PATCH v10 8/9] dt-bindings: add documentation of xilinx clocking wizard

2021-04-08 Thread Shubhrajyoti Datta
On Sun, Mar 7, 2021 at 1:50 AM Rob Herring wrote: > > On Wed, Feb 24, 2021 at 06:40:40PM +0530, Shubhrajyoti Datta wrote: > > Add the devicetree binding for the xilinx clocking wizard. > > > > Signed-off-by: Shubhrajyoti Datta > > --- > > v6: > > F

Re: [PATCH v10 5/9] staging: clocking-wizard: Add support for dynamic reconfiguration

2021-03-17 Thread Shubhrajyoti Datta
On Mon, Mar 15, 2021 at 12:37 PM Zhengxun Li wrote: > > Hi Shubhrajyoti, > > My name is Zhengxun and I am the engineer from Macronix. We are > using the platform PicoZed 7015/7030 SOM (System On Module), > which is based on Xilinx Zynq®-7000 All Programmable (AP) SoC to > verify our Flash driver.

Re: [PATCH v10 6/9] staging: clocking-wizard: Add support for fractional support

2021-03-15 Thread Shubhrajyoti Datta
Hi Zhengxun, On Mon, Mar 15, 2021 at 12:55 PM Zhengxun Li wrote: > > Hi Shubhrajyoti, > > +static int clk_wzrd_dynamic_reconfig_f(struct clk_hw *hw, unsigned long rate, > + unsigned long parent_rate) > +{ > + int err; > + u32 value, pre; > + unsigned long rate_div, f, clockout0_div; > +

Re: [PATCH v10 5/9] staging: clocking-wizard: Add support for dynamic reconfiguration

2021-03-15 Thread Shubhrajyoti Datta
Hi Zhengxun, Thanks for the review. On Mon, Mar 15, 2021 at 12:37 PM Zhengxun Li wrote: > > Hi Shubhrajyoti, > > My name is Zhengxun and I am the engineer from Macronix. We are > using the platform PicoZed 7015/7030 SOM (System On Module), > which is based on Xilinx Zynq®-7000 All Programmable

[PATCH v10 5/9] staging: clocking-wizard: Add support for dynamic reconfiguration

2021-02-24 Thread Shubhrajyoti Datta
The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Signed-off-by: Shubhrajyoti Datta Co-developed-by: Chirag Parekh --- v6: Remove the typecast. use min for capping

[PATCH v10 7/9] staging: clocking-wizard: Remove the hardcoding of the clock outputs

2021-02-24 Thread Shubhrajyoti Datta
The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v10: generate the names runtime. drivers/staging/clocking-wizard/clk

[PATCH v10 3/9] staging: clocking-wizard: Update the fixed factor divisors

2021-02-24 Thread Shubhrajyoti Datta
Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock

[PATCH v10 8/9] dt-bindings: add documentation of xilinx clocking wizard

2021-02-24 Thread Shubhrajyoti Datta
Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v6: Fix a yaml warning v7: Add vendor prefix speed-grade v8: Fix the warnings v10: Add nr-outputs .../bindings/clock/xlnx,clocking-wizard.yaml | 72 ++ 1 file

[PATCH v10 4/9] staging: clocking-wizard: Allow changing of parent rate for single output

2021-02-24 Thread Shubhrajyoti Datta
If there is only one output then allow changing of the parent rate. Signed-off-by: Shubhrajyoti Datta --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers

[PATCH v10 2/9] staging: clocking-wizard: Rename speed-grade to xlnx, speed-grade

2021-02-24 Thread Shubhrajyoti Datta
Rename speed-grade to xlnx,speed-grade Signed-off-by: Shubhrajyoti Datta --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk

[PATCH v10 9/9] clk: clock-wizard: Add the clockwizard to clk directory

2021-02-24 Thread Shubhrajyoti Datta
Add clocking wizard driver to clk. And delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig| 9 +++ drivers/clk/Makefile | 1 + .../clk-xlnx-clock-wizard.c

[PATCH v10 6/9] staging: clocking-wizard: Add support for fractional support

2021-02-24 Thread Shubhrajyoti Datta
Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- v7: Remove unnecessary comments use mult_frac use a common divisor function. .../clocking-wizard/clk

[PATCH v10 0/9] clk: clocking-wizard: driver updates

2021-02-24 Thread Shubhrajyoti Datta
the patches Update the speed grade description. [1] https://spinics.net/lists/linux-driver-devel/msg117326.html Shubhrajyoti Datta (9): staging: clocking-wizard: Fix kernel-doc warning staging: clocking-wizard: Rename speed-grade to xlnx,speed-grade staging: clocking-wizard: Update the fixed

[PATCH v10 1/9] staging: clocking-wizard: Fix kernel-doc warning

2021-02-24 Thread Shubhrajyoti Datta
Fix the clocking wizard main structure kernel documentation. Signed-off-by: Shubhrajyoti Datta --- v10: Updated the description drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/clocking-wizard/clk-xlnx

[PATCH v7 3/7] clk: clock-wizard: Fix kernel-doc warning

2020-11-04 Thread Shubhrajyoti Datta
Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index 1bab68e..fb2d555

[PATCH v7 4/7] clk: clock-wizard: Add support for dynamic reconfiguration

2020-11-04 Thread Shubhrajyoti Datta
The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta --- v6

[PATCH v7 5/7] clk: clock-wizard: Add support for fractional support

2020-11-04 Thread Shubhrajyoti Datta
Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- v7: Remove unnecessary comments use mult_frac use a common divisor function. drivers/clk/clk-xlnx

[PATCH v7 6/7] clk: clock-wizard: Remove the hardcoding of the clock outputs

2020-11-04 Thread Shubhrajyoti Datta
The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v7 7/7] clk: clock-wizard: Update the fixed factor divisors

2020-11-04 Thread Shubhrajyoti Datta
Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v7 1/7] dt-bindings: add documentation of xilinx clocking wizard

2020-11-04 Thread Shubhrajyoti Datta
Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v6: Fix a yaml warning v7: Add vendor prefix speed-grade .../bindings/clock/xlnx,clocking-wizard.yaml | 65 ++ 1 file changed, 65 insertions(+) create mode 100644

[PATCH v7 2/7] clk: clock-wizard: Add the clockwizard to clk directory

2020-11-04 Thread Shubhrajyoti Datta
Add clocking wizard driver to clk. And delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta --- v7: Combined the patch for deletion and add of the driver dropping the ack from Greg for the staging as it is a combined patch. Add vendor prefix to speedgrade

[PATCH v7 0/7] clk: clk-wizard: clock-wizard: Driver updates

2020-11-04 Thread Shubhrajyoti Datta
Shubhrajyoti Datta (7): dt-bindings: add documentation of xilinx clocking wizard clk: clock-wizard: Add the clockwizard to clk directory clk: clock-wizard: Fix kernel-doc warning clk: clock-wizard: Add support for dynamic reconfiguration clk: clock-wizard: Add support for fractional support

RE: [PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-11-03 Thread Shubhrajyoti Datta
Hi Stephen, Thanks for the review. > -Original Message- > From: Stephen Boyd > Sent: Tuesday, September 22, 2020 2:52 AM > To: Shubhrajyoti Datta ; linux-...@vger.kernel.org > Cc: devicet...@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@driverdev.osuosl.org;

RE: [PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

2020-09-24 Thread Shubhrajyoti Datta
Hi , Thanks for the review. > -Original Message- > From: Stephen Boyd > Sent: Tuesday, September 22, 2020 2:48 AM > To: Shubhrajyoti Datta ; linux-...@vger.kernel.org > Cc: devicet...@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@driverdev.osuosl.org; robh...

[PATCH v6 7/8] clk: clock-wizard: Update the fixed factor divisors

2020-08-28 Thread Shubhrajyoti Datta
Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v6 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

2020-08-28 Thread Shubhrajyoti Datta
The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta --- v6

[PATCH v6 1/8] dt-bindings: add documentation of xilinx clocking wizard

2020-08-28 Thread Shubhrajyoti Datta
Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v6: Fix a yaml warning .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock

[PATCH v6 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs

2020-08-28 Thread Shubhrajyoti Datta
The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v6 8/8] staging: clocking-wizard: Delete the driver from the staging

2020-08-28 Thread Shubhrajyoti Datta
Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta Acked-by: Greg Kroah-Hartman --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig

[PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

2020-08-28 Thread Shubhrajyoti Datta
Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- v6: remove unnecessary typecast remove unnecessary locks use polled timeout drivers/clk/clk-xlnx

[PATCH v6 3/8] clk: clock-wizard: Fix kernel-doc warning

2020-08-28 Thread Shubhrajyoti Datta
Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index b31524a..d6577c8

[PATCH v6 0/8] clk: clk-wizard: clock-wizard: Driver updates

2020-08-28 Thread Shubhrajyoti Datta
staging as suggested v4: Reorder the patches. Merge the CLK_IS_BASIC patch. Add the yaml form of binding document v5: Fix a mismerge v6: Fix the yaml warning use poll timedout [1] https://spinics.net/lists/linux-driver-devel/msg117326.html Shubhrajyoti Datta (8): dt-bindings: add documentation

[PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

2020-08-28 Thread Shubhrajyoti Datta
Add clocking wizard driver to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 9 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 338 3 files changed, 348 insertions(+) create mode

Re: [PATCH v3 07/10] clk: clock-wizard: Update the fixed factor divisors

2020-01-05 Thread Shubhrajyoti Datta
On Mon, Jan 6, 2020 at 1:30 AM Stephen Boyd wrote: > > Quoting shubhrajyoti.da...@gmail.com (2019-11-27 22:36:14) > > From: Shubhrajyoti Datta > > > > Update the fixed factor clock registration to register the divisors. > > > > Signed-off-by: Shubhrajyoti Datt

Re: [PATCH v3 08/10] clk: clock-wizard: Make the output names unique

2019-11-29 Thread Shubhrajyoti Datta
On Thu, Nov 28, 2019 at 1:15 PM Dan Carpenter wrote: > > On Thu, Nov 28, 2019 at 12:06:15PM +0530, shubhrajyoti.da...@gmail.com wrote: > > From: Shubhrajyoti Datta > > > > Incase there are more than one instance of the clocking wizard. > > And if the output name gi

[PATCH v3 08/10] clk: clock-wizard: Make the output names unique

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta Incase there are more than one instance of the clocking wizard. And if the output name given is the same then the probe fails. Fix the same by appending the device name to the output name to make it unique. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx

[PATCH v3 09/10] staging: clocking-wizard: Delete the driver from the staging

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig

[PATCH v3 07/10] clk: clock-wizard: Update the fixed factor divisors

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b

[PATCH v3 03/10] clk: clock-wizard: Fix kernel-doc warning

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v3 00/10] clk: clk-wizard: clock-wizard: Driver updates

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta In the thread [1] Greg suggested that we move the driver to the clk from the staging. Add patches to address the concerns regarding the fractional and set rate support in the TODO. The patch set does the following - Trivial fixes for kernel doc. - Move the driver

[PATCH v3 06/10] clk: clock-wizard: Remove the hardcoding of the clock outputs

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 5

[PATCH v3 10/10] clk: clock-wizard: Fix the compilation failure

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta After 90b6c5c73 (clk: Remove CLK_IS_BASIC clk flag) The CLK_IS_BASIC is deleted. Adapt the driver for the same. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 05/10] clk: clock-wizard: Add support for fractional support

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 192

[PATCH v3 01/10] dt-bindings: add documentation of xilinx clocking wizard

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- .../bindings/clock/xlnx,clocking-wizard.txt| 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v3 02/10] clk: clock-wizard: Move the clockwizard to clk

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta Move the clocking wizard driver from staging to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 6 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 335 3 files

[PATCH v3 04/10] clk: clock-wizard: Add support for dynamic reconfiguration

2019-11-27 Thread shubhrajyoti . datta
From: Shubhrajyoti Datta The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off

Re: [PATCH] staging: clocking-wizard: Add support for dynamic reconfiguration

2018-09-10 Thread Shubhrajyoti Datta
On Mon, Sep 10, 2018 at 10:36 PM Greg Kroah-Hartman wrote: > > On Mon, Sep 10, 2018 at 10:28:25PM +0530, Shubhrajyoti Datta wrote: > > On Mon, Sep 10, 2018 at 2:41 PM Greg KH wrote: > > > > > > On Mon, Sep 10, 2018 at 10:47:28AM +0530, shubhrajyoti.da...@gmail.

Re: [PATCH] staging: clocking-wizard: Add support for dynamic reconfiguration

2018-09-10 Thread Shubhrajyoti Datta
On Mon, Sep 10, 2018 at 2:41 PM Greg KH wrote: > > On Mon, Sep 10, 2018 at 10:47:28AM +0530, shubhrajyoti.da...@gmail.com wrote: > > From: Shubhrajyoti Datta > > > > The patch adds support for dynamic reconfiguration of clock output rate. > > Output clocks are regis