[PATCH] staging: pi433: add dependency to PA0, 1, 2 setting for output power level

maximum power level is always same regardless of mode. Signed-off-by: Sidong Yang --- drivers/staging/pi433/rf69.c | 45 ++-- 1 file changed, 39 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index

[PATCH] staging: pi433: Return thread immediately when kthread_should_stop() call.

When kthread_stop() called by removing module, running thread should return immediately. Otherwise, It is very dangerous that thread may access any released data like struct pi433_device. Signed-off-by: Sidong Yang --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2] staging: pi433: Fix rf69_set_tx_cfg() logic

Moved code to configure sync to where check enable_sync option before. There is no need to check enable_sync twice. Configuring sync should be executed immediately after enabling sync. Signed-off-by: Sidong Yang --- v2: remove obvious comment. reordered size/value/enable sync functions

[PATCH] staging: pi433: Fix rf69_set_tx_cfg() logic

Moved code to configure sync to where check enable_sync option before. There is no need to check enable_sync twice. Configuring sync should be executed immediately after enabling sync. Signed-off-by: Sidong Yang --- drivers/staging/pi433/pi433_if.c | 17 +++-- 1 file changed, 7

[PATCH] staging: pi433: remove unnecessary calling rf69_set_mode()

Remove unnecessary rf69_set_mode() function call when rx is waiting for a telegram. There is waste to call rf69_set_mode() twice for becoming standby mode. Signed-off-by: Sidong Yang --- drivers/staging/pi433/pi433_if.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff

[PATCH] staging: vboxvideo: fix vbox_dumb_create fail logic

In function vbox_dumb_create() of vbox_main.c, It calls vbox_gem_create() for creating drm_gem_object. and it calls vbox_gem_handle_create() for handle. If handle creation fails only, drm_gem_object should be released by calling drm_gem_object_put_unlocked(). Signed-off-by: Sidong Yang

[PATCH] staging: rtl8192u: Add required spaces before open parenthesis

Fix error reported by checkpatch.pl Signed-off-by: Sidong Yang --- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 22 +++ .../staging/rtl8192u/ieee80211/rtl819x_TSProc.c| 68 +++--- 2 files changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable

On Thu, Jan 10, 2019 at 10:44:08PM +0300, Dan Carpenter wrote: > On Thu, Jan 10, 2019 at 05:00:24PM +0000, Sidong Yang wrote: > > I think you just point out that my code isn't obvious because the > > function returns negative error codes. I agree with you. But what if > &

Re: [PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable

On Thu, Jan 10, 2019 at 03:23:58PM +0300, Dan Carpenter wrote: > On Thu, Jan 10, 2019 at 06:13:47AM +0000, Sidong Yang wrote: > > Removed unnecessary local variable in have_hgsmi_mode_hints. > > The result of hgsmi_query_conf should be directly compared without > > assign

[PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable

Removed unnecessary local variable in have_hgsmi_mode_hints. The result of hgsmi_query_conf should be directly compared without assigning to local variable. Signed-off-by: Sidong Yang --- drivers/staging/vboxvideo/vbox_main.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions

[PATCH v2] staging: erofs: Add identifier for function definition arguments

Add identifier for function definition arguments in xattr_iter_handlers, this change clears the checkpatch.pl issue and make code more explicit. Signed-off-by: Sidong Yang --- drivers/staging/erofs/xattr.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] staging: most: replace function name to __func__

Fix checkpatch.pl warning message about logging code. Previous code contains hard coded function name. Fix this code by using __func__ macro. Signed-off-by: Sidong Yang --- drivers/staging/most/dim2/dim2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most

[PATCH] staging: most: replace function name to __func__

Fix checkpatch.pl warning message about logging code. Previous code contains hard coded function name. Fix this code by using __func__ macro. Signed-off-by: Sidong Yang --- drivers/staging/most/dim2/dim2.c | 2 +- drivers/staging/most/video/video.c | 24 2 files

Re: Re: [PATCH] staging: vc04_services: Fix checkpatch.pl warnings

Hi Stefan, I'm really glad to review my commit! I think that your suggestion that changes subject is good. > i'm okay with the changes, but the subject is too general. We get fixes for > checkpach warning nearly once a week. Suggestion: > > staging: vchiq_version: Use tabs for identation > >

[PATCH] staging: vc04_services: Fix checkpatch.pl warnings

Replace spaces to tabs for indents in beginning of statements. Signed-off-by: Sidong Yang --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm

[PATCH] staging: vc05_services: fix checkpatch.pl errors

Fix some errors for wrong brace position reported by checkpatch. Signed-off-by: Sidong Yang --- .../vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 +-- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 12 2 files changed, 5 insertions(+), 10 deletions