[PATCH v2] staging: comedi: change do_insn*_ioctl to allow more samples

rking around the old limits (256) would complicate the user-space/kernel interaction. The new upper limit is reasonable with current memory available and does not otherwise impact the memory footprint for any current or otherwise typical configuration. Signed-off-by: Spencer E. Olson --- Imple

[PATCH] staging: comedi: change do_insn*_ioctl to allow more samples

rking around the old limits (256) would complicate the user-space/kernel interaction. The new upper limit is reasonable with current memory available and does not otherwise impact the memory footprint for any current or otherwise typical configuration. Signed-off-by: Spencer E. Olson --- dr

[PATCH v2] staging: comedi: ni_mio_common: scale ao INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

ement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS") Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c index 2d

[PATCH] staging: comedi: clarify/unify macros for NI macro-defined terminals

commit 347e244884c3b ("staging: comedi: tio: implement global tio/ctr routing") when setting/reading registers for counter terminals. Fixes: 347e244884c3b ("staging: comedi: tio: implement global tio/ctr routing") Signed-off-by: Spencer E. Olson --- drivers/staging/

[PATCH] staging: comedi: ni_mio_common: scale ao INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

--the analog input cards already similarly scale the timing results based on the number of channels. Signed-off-by: Spencer E. Olson --- This patch is made in reference to the last set of patches adding the timing constraint facility in pci_mio_common (51fd3673838396844f15de0e906be5333bfbbc8d

[PATCH v4 12/13] staging: comedi: ni_660x: clean up pfi routing

Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72 ++-- 1

[PATCH v4 09/13] staging: comedi: tio: implement global tio/ctr routing

rfaces. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 18 +- .../staging/comedi/drivers/ni_mio_common.c| 6 +- drivers/staging/comedi/drivers/ni_tio.c | 457 ++ drivers/staging/comedi/drivers/ni_tio.h | 42 +- .../staging

[PATCH v4 13/13] staging: comedi: ni_660x: add device-global routing

Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 265 +++ 1

[PATCH v4 07/13] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

output selections using the subdevice interfaces--these still require direct register values. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- Patch revisions & Notes: - [PATCH v4 07/13]: Rebased patchset on repa

[PATCH v4 11/13] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v4 08/13] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 ++ drivers/staging/comedi/drivers/ni_stc.h | 6 +- 2 files

[PATCH v4 05/13] staging: comedi: add interface to ni routing table information

Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- Patch revisions: - [PATCH v3 05/13]: Simplify and clean up prototypes of functions for use with besearch. - [PATCH v2 05/13]: Tweak

[PATCH v4 10/13] staging: comedi: ni_mio_common: create device-global access to tio

Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH v4 06/13] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

specifying register-level (or near register-level) values as *_arg options when *_src == TRIG_EXT. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 +++--- 1

[PATCH v4 03/13] staging: comedi: add new device-global config interface

Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 18 drivers/staging/comedi/comedi_fops.c

[PATCH v4 02/13] staging: comedi: add abstracted NI signal/terminal named constants

ll be greatly reduced. Signed-off-by: Spencer E. Olson --- Patch revisions: - [PATCH v2 02/13]: Update signal/terminal names found after adding additional devices to routing list in [PATCH v2 04/13]. drivers/staging/comedi/comedi.h | 151 1 file changed

[PATCH v4 01/13] staging: comedi: tests: add unittest framework for comedi

Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson

[PATCH v4 00/13] device-global identifiers and routes introduced

s are the target of this patch set, including the tio devices (counter/timers) used by these boards. Spencer E. Olson (13): staging: comedi: tests: add unittest framework for comedi staging: comedi: add abstracted NI signal/terminal named constants staging: comedi: add new device-global conf

[PATCH v2] staging: comedi: ni_mio_common: protect register write overflow

ved to the RTSI_Trig_Direction register. (2) Allows all 4 RTSI_BRD lines to be treated as valid sources for RTSI lines. This patch also cleans up the ni_get_rtsi_routing command for readability. Fixes: 03aef4b6dc12 ("Staging: comedi: add ni_mio_common code") Signed-off-

[PATCH v3 09/13] staging: comedi: tio: implement global tio/ctr routing

rfaces. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 18 +- .../staging/comedi/drivers/ni_mio_common.c| 6 +- drivers/staging/comedi/drivers/ni_tio.c | 457 ++ drivers/staging/comedi/drivers/ni_tio.h | 42 +- .../staging

[PATCH v3 12/13] staging: comedi: ni_660x: clean up pfi routing

Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72 ++-- 1

[PATCH v3 03/13] staging: comedi: add new device-global config interface

Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 18 drivers/staging/comedi/comedi_fops.c

[PATCH v3 07/13] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

output selections using the subdevice interfaces--these still require direct register values. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- Notes: - [PATCH 07/13]: This patch must be built upon an earlier patch

[PATCH v3 06/13] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

specifying register-level (or near register-level) values as *_arg options when *_src == TRIG_EXT. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 +++--- 1

[PATCH v3 10/13] staging: comedi: ni_mio_common: create device-global access to tio

Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH v3 05/13] staging: comedi: add interface to ni routing table information

Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- Patch revisions: - [PATCH v3 05/13]: Simplify and clean up prototypes of functions for use with besearch. - [PATCH v2 05/13]: Tweak

[PATCH v3 13/13] staging: comedi: ni_660x: add device-global routing

Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 265 +++ 1

[PATCH v3 08/13] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 ++ drivers/staging/comedi/drivers/ni_stc.h | 6 +- 2 files

[PATCH v3 11/13] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v3 00/13] device-global identifiers and routes introduced

hould be supported--all e/m-series (ni_mio_common.c hardware) boards and 660x boards are the target of this patch set, including the tio devices (counter/timers) used by these boards. Spencer E. Olson (13): staging: comedi: tests: add unittest framework for comedi staging: comedi: add abstracted N

[PATCH v3 02/13] staging: comedi: add abstracted NI signal/terminal named constants

ll be greatly reduced. Signed-off-by: Spencer E. Olson --- Patch revisions: - [PATCH v2 02/13]: Update signal/terminal names found after adding additional devices to routing list in [PATCH v2 04/13]. drivers/staging/comedi/comedi.h | 151 1 file changed

[PATCH v3 01/13] staging: comedi: tests: add unittest framework for comedi

Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson

[PATCH v2 05/13] staging: comedi: add interface to ni routing table information

Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- Changes since last submission: - [PATCH v2 05/13]: Tweak Makefile to build routing info for newly added hardware in updates to [PATCH v2 04

[PATCH v2 12/13] staging: comedi: ni_660x: clean up pfi routing

Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72 ++-- 1

[PATCH v2 02/13] staging: comedi: add abstracted NI signal/terminal named constants

ll be greatly reduced. Signed-off-by: Spencer E. Olson --- Changes since last submission: - [PATCH v2 02/13]: Update signal/terminal names found after adding additional devices to routing list in [PATCH v2 04/13]. drivers/staging/comedi/comedi.h | 151 1

[PATCH v2 09/13] staging: comedi: tio: implement global tio/ctr routing

rfaces. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 18 +- .../staging/comedi/drivers/ni_mio_common.c| 6 +- drivers/staging/comedi/drivers/ni_tio.c | 457 ++ drivers/staging/comedi/drivers/ni_tio.h | 42 +- .../staging

[PATCH v2 00/13] device-global identifiers and routes introduced

re. This patch set is in nowise complete with respect to the various NI hardware options supported by comedi, though a large selection should be supported--all e/m-series (ni_mio_common.c hardware) boards and 660x boards are the target of this patch set, including the tio devices (counter/timers) use

[PATCH v2 01/13] staging: comedi: tests: add unittest framework for comedi

Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson

[PATCH v2 13/13] staging: comedi: ni_660x: add device-global routing

Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 265 +++ 1

[PATCH v2 08/13] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 ++ drivers/staging/comedi/drivers/ni_stc.h | 6 +- 2 files

[PATCH v2 10/13] staging: comedi: ni_mio_common: create device-global access to tio

Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH v2 03/13] staging: comedi: add new device-global config interface

Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 18 drivers/staging/comedi/comedi_fops.c

[PATCH v2 07/13] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

output selections using the subdevice interfaces--these still require direct register values. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- Notes: - [PATCH 07/13]: This patch must be built upon an earlier patch

[PATCH v2 11/13] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v2 06/13] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

specifying register-level (or near register-level) values as *_arg options when *_src == TRIG_EXT. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 +++--- 1

Re: [PATCH 04/13] staging: comedi: ni_routing: Add NI signal routing info

correctly. Because these arrays are sorted (at module load time) by ni_routes, it seemed best to have the symbols for these tables only have static linkage, thus ensuring that _only_ the ni_routes module accesses these. On 09/21/2018 06:09 AM, Ian Abbott wrote: On 19/09/18 17:38, Spencer E. O

[PATCH 3/4] staging: comedi: ni_pcidio: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

Adds implementation of the new INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS instruction. This patch also adds data for this implementation, based on spec sheets from NI. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_pcidio.c | 13 + 1 file changed, 13 insertions

[PATCH 1/4] staging: comedi: add facility to directly query subdevice timing constraints

command_test in order to determine these limits. For other subdevices, this tactic does not work since *_src == TRIG_TIMER might not be valid. There is also the possibility that the timing limits are different between the TRIG_TIMER and TRIG_EXT modes. Signed-off-by: Spencer E. Olson --- drivers

[PATCH 2/4] staging: comedi: ni_mio_common: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

Adds implementation of the new INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS instruction. This patch also adds data for digital subdevices that are streaming capable (within the ni_mio_* family). Mostly, only the m-series devices are capable of digital streaming. Signed-off-by: Spencer E. Olson

[PATCH 4/4] staging: comedi: comedi_test: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

Adds implementation of the new INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS instruction. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/comedi_test.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers

[PATCH 0/4] Add facility to directly query subdevice timing

. This patchset also adds similar information for several digital devices. Spencer E. Olson (4): staging: comedi: add facility to directly query subdevice timing constraints staging: comedi: ni_mio_common: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS staging: comedi: ni_pcidio

[PATCH 09/13] staging: comedi: tio: implement global tio/ctr routing

rfaces. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 18 +- .../staging/comedi/drivers/ni_mio_common.c| 6 +- drivers/staging/comedi/drivers/ni_tio.c | 457 ++ drivers/staging/comedi/drivers/ni_tio.h | 42 +- .../staging

[PATCH 05/13] staging: comedi: add interface to ni routing table information

Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/Kconfig| 4 + drivers/staging/comedi/drivers/Makefile | 1 + drivers/staging/comedi/drivers

[PATCH 07/13] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

output selections using the subdevice interfaces--these still require direct register values. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 687

[PATCH 01/13] staging: comedi: tests: add unittest framework for comedi

Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson

[PATCH] staging: comedi: ni_mio_common: protect register write overflow

ved to the RTSI_Trig_Direction register. (2) Allows all 4 RTSI_BRD lines to be treated as valid sources for RTSI lines. This patch also cleans up the ni_get_rtsi_routing command for readability. Fixes: 03aef4b6dc12 ("Staging: comedi: add ni_mio_common code") Signed-off-by: Spe

[PATCH 03/13] staging: comedi: add new device-global config interface

Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 18 drivers/staging/comedi/comedi_fops.c

[PATCH 10/13] staging: comedi: ni_mio_common: create device-global access to tio

Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH 13/13] staging: comedi: ni_660x: add device-global routing

Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 265 +++ 1

[PATCH 11/13] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 12/13] staging: comedi: ni_660x: clean up pfi routing

Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72 ++-- 1

[PATCH 08/13] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 ++ drivers/staging/comedi/drivers/ni_stc.h | 6 +- 2 files

[PATCH 00/13] device-global identifiers and routes introduced

ies (ni_mio_common.c hardware) boards and 660x boards are the target of this patch set, including the tio devices (counter/timers) used by these boards. Spencer E. Olson (13): staging: comedi: tests: add unittest framework for comedi staging: comedi: add abstracted NI signal/terminal named constan

[PATCH 02/13] staging: comedi: add abstracted NI signal/terminal named constants

ll be greatly reduced. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 130 1 file changed, 130 insertions(+) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index bb961ac79b7e..54cbfb580d15 100644 --- a/dr

[PATCH 06/13] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

specifying register-level (or near register-level) values as *_arg options when *_src == TRIG_EXT. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- .../staging/comedi/drivers/ni_mio_common.c| 106 +++--- 1

Re: [PATCH 03/15] staging: comedi: ni_routing: Add NI signal routing info

On Mon, 2017-10-09 at 12:01 -0600, Spencer E Olson wrote: > On Mon, 2017-10-09 at 10:56 +0100, Ian Abbott wrote: > > On 08/10/17 07:44, Spencer E Olson wrote: > > > On Thu, 2016-11-10 at 18:16 +, Ian Abbott wrote: > > >> On 10/11/16 17:54, Greg Kroah-Hartman wrote

Re: [PATCH 03/15] staging: comedi: ni_routing: Add NI signal routing info

On Mon, 2017-10-09 at 10:56 +0100, Ian Abbott wrote: > On 08/10/17 07:44, Spencer E Olson wrote: > > On Thu, 2016-11-10 at 18:16 +, Ian Abbott wrote: > >> On 10/11/16 17:54, Greg Kroah-Hartman wrote: > >>> On Thu, Nov 10, 2016 at 05:08:36PM +, Ian Abbott w

Re: [PATCH 04/15] staging: comedi: ni_routing: add ni routing tables

On Thu, 2016-11-10 at 11:27 -0700, Spencer E Olson wrote: > On Thu, 2016-11-10 at 18:18 +, Ian Abbott wrote: > > On 10/11/16 17:54, Greg Kroah-Hartman wrote: > > > On Thu, Nov 10, 2016 at 05:17:22PM +, Ian Abbott wrote: > > >> On 12/10/16 12:05, Spencer E. Ol

Re: [PATCH 03/15] staging: comedi: ni_routing: Add NI signal routing info

On Thu, 2016-11-10 at 18:16 +, Ian Abbott wrote: > On 10/11/16 17:54, Greg Kroah-Hartman wrote: > > On Thu, Nov 10, 2016 at 05:08:36PM +, Ian Abbott wrote: > >> On 12/10/16 12:05, Spencer E. Olson wrote: > >>> See README for a thorough discussion of this

Re: [PATCH 02/15] staging: comedi: add abstracted NI signal/terminal named constants

On Thu, 2016-11-10 at 16:29 +, Ian Abbott wrote: > On 12/10/16 12:05, Spencer E. Olson wrote: > > This change adds abstracted constants for National Instruments > > terminal/signal names. > > > > Some background: > > There have been significant confusions o

Re: [PATCH 04/15] staging: comedi: ni_routing: add ni routing tables

On Thu, 2016-11-10 at 18:18 +, Ian Abbott wrote: > On 10/11/16 17:54, Greg Kroah-Hartman wrote: > > On Thu, Nov 10, 2016 at 05:17:22PM +, Ian Abbott wrote: > >> On 12/10/16 12:05, Spencer E. Olson wrote: > >>> Adds tables of all register values for rout

[PATCH 04/15] staging: comedi: ni_routing: add ni routing tables

stored in a spreadsheet so-as to enhance the ability to compare to screenshots obtained of NI-MAX. This commit provides the ability to parse the spreadsheets and generate code following kernel conventions. Signed-off-by: Spencer E. Olson *** PLEASE FIND ACTUAL PATCH AT: http://www.umich.edu/~olsonse

[PATCH 05/15] staging: comedi: add new device-global config interface

Adds interface for configuring options that are global to all sub-devices. For now, only options to configure device-globally identified signal routes have been defined. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 49 + drivers/staging/comedi

[PATCH 14/15] staging: comedi: ni_660x: add device-global routing

Provides the device-global routing interface for ni_660x devices. Using the device-global names in comedi_cmd structures for commands was already supported through the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 260

[PATCH 15/15] staging: comedi: ni_routes: update notes for valid routes

Update references and notes for the routes that have been implemented. This includes a guess as two what might be valid for CtrAux and CtrArmStartTrigger, using mild heuristic evidence from other users. *** PLEASE FIND ACTUAL PATCH AT: http://www.umich.edu/~olsonse/patches/comedi-devglobal-v1/0015

[PATCH 13/15] staging: comedi: ni_660x: clean up pfi routing

Cleans up the pfi routing code to make it easier to follow, read, and also to prepare to use this cleaned up code for enabling the device-global routing interface for ni_660x devices. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 72

[PATCH 12/15] staging: comedi: ni_660x: Add NI PCI-6608 to list of supported devices

Previously, only the PXI version of the NI-6608 board was supported. This change adds support for the PCI version as well. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 06/15] staging: comedi: add interface to ni routing table information

Adds interface and associated unittests for accessing/looking-up/validating the new ni routing table information. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/Kconfig | 4 + drivers/staging/comedi/drivers/Makefile| 1 + drivers/staging/comedi

[PATCH 08/15] staging: comedi: ni_mio_common: implement global pfi, rtsi routing

output selections using the subdevice interfaces--these still require direct register values. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 680

[PATCH 10/15] staging: comedi: tio: implement global tio/ctr routing

rfaces. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_660x.c | 18 +- drivers/staging/comedi/drivers/ni_mio_common.c | 6 +- drivers/staging/comedi/drivers/ni_tio.c | 428 +-- drivers/staging/comedi/drivers/ni_tio.h |

[PATCH 09/15] staging: comedi: ni_mio_common: implement output selection of GPFO_{0, 1}

Implement the ability to route various signals to NI_CtrOut(x) pin. This pin is also known as GPFO_{0,1} in the DAQ STC. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 101 + drivers/staging/comedi/drivers/ni_stc.h| 6

[PATCH 03/15] staging: comedi: ni_routing: Add NI signal routing info

he task of maintaining this knowledge and more quickly enables addition of new NI devices. Signed-off-by: Spencer E. Olson *** PLEASE FIND ACTUAL PATCH AT: http://www.umich.edu/~olsonse/patches/comedi-devglobal-v1/0003-staging-comedi-ni_routing-Add-NI-signal-routing-info.patch (This patch included

[PATCH 11/15] staging: comedi: ni_mio_common: create device-global access to tio

Adds tio sub-devices of ni_mio_common supported hardware to the implementation of test_route, connect_route, disconnect_route. This change delegates the actual functionality to the ni_tio module. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH 07/15] staging: comedi: ni_mio_common: implement new routing for TRIG_EXT

specifying register-level (or near register-level) values as *_arg options when *_src == TRIG_EXT. Annotates and updates tables of register values to reflect this new implementation status. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 106

[PATCH 02/15] staging: comedi: add abstracted NI signal/terminal named constants

ll be greatly reduced. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 128 1 file changed, 128 insertions(+) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index a1c1081..c80d0d6 100644 --- a/dr

[PATCH 01/15] staging: comedi: tests: add unittest framework for comedi

Adds a framework for unittests for comedi drivers. It was certainly possible to write some unit tests before and test various aspects of a particular driver, but this framework makes this a bit easier and hopefully inspires more unittest modules to be written. Signed-off-by: Spencer E. Olson

[PATCH 00/15] device-global identifiers and routes introduced

used by these boards. A copy of these patches can be found at: http://www.umich.edu/~olsonse/patches/comedi-devglobal-v1/ Cc: Eric Piel Spencer E. Olson (15): staging: comedi: tests: add unittest framework for comedi staging: comedi: add abstracted NI signal/terminal named constants staging

[PATCH v2] staging: comedi: ni_mio_common: split out ao arming from ni_ao_inttrig

splits out the arming functionality to allow arming to specifically and separately be done via the CONFIG_INSN_ARM ioctl command. In order to provide backwards compatibility, this patch also provides automatic arming if ni_ao_inttrig is simply called. Signed-off-by: Spencer E. Olson --- Changes in

[PATCH] staging: comedi: porting NI_GPCT constants from comedi.org module

Information pertaining to the NI_GPCT_ARM* registers were added to the comedi.org version of the comedi kernel. This adds this information to the staging-tree version of the comedi kernel. Relevant comments are also copied over. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi

[PATCH] staging: comedi: make constants slightly more consistent

always be the same and also acceptable and correct usage. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/comedi.h | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h

[PATCH] staging: comedi: ni_mio_common: split out ao arming from ni_ao_inttrig

splits out the arming functionality to allow arming to specifically and separately be done via the CONFIG_INSN_ARM ioctl command. In order to provide backwards compatibility, this patch also provides automatic arming if ni_ao_inttrig is simply called. Signed-off-by: Spencer E. Olson --- drivers

Re: [PATCH] staging: comedi: ni_mio_common: fix AO inttrig backwards compatibility

Sorry for the very belated reply on this. I'm assuming that this was already accepted, but I've been working with this patch for a bit. This fixes the problems I raised in any case. Reviewed-by: Spencer E Olson On Wed, 2016-07-20 at 17:07 +0100, Ian Abbott wrote: > On 20/07/16 1

[PATCH v2 2/6] staging: comedi: ni_mio_common: Cleans up/clarifies ni_ao_reset

This patch implements ni_ao_reset much more closely organized like NI MHDDK examples and DAQ-STC pseudo-code. Adds comments with some more specific references to the DAQ-STC. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 70 +- 1

[PATCH v2 0/6] continuous regeneration of finite samples

taging: comedi: ni_mio_comon: adds finite regeneration to AO output) was split into 4 patches (current PATCHES [2-5]/6) that keep the changes a bit more atomic. Spencer E. Olson (6): staging: comedi: mite: enable continuous regeneration of finite samples staging: comedi: ni_mio_common: Cleans u

[PATCH v2 4/6] staging: comedi: ni_mio_common: Cleans up/clarifies ni_ao_cmd

(or with prior behavior in ni_mio_common) actually implement true continuous output. Rather, the output is simply configured to operate as a single buffer output, but where the buffer is as large as is possible with NI-STC hardware. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi

[PATCH v2 1/6] staging: comedi: mite: enable continuous regeneration of finite samples

the user via mmap access to the DMA buffer. If the contents are changed by the user, additional munging is not performed by the driver and only a single call to comedi_mark_buffer_written should be done. Signed-off-by: Spencer E. Olson Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers

[PATCH v2 6/6] staging: comedi: ni_mio_common: add finite regeneration to dio output

accomplish limiting the DMA buffer transfer. Signed-off-by: Spencer E. Olson Reviewed-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_mio_common.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi

[PATCH v2 5/6] staging: comedi: ni_mio_common: adds finite regeneration to AO output

can be left static or changed by the user via mmap access to the DMA buffer. If the contents are changed by the user, additional munging is not performed by the driver and only a single call to comedi_mark_buffer_written should be done. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi

[PATCH v2 3/6] staging: comedi: ni_mio_common: make more bits in ao_cmd1 reg be stateful

]_UPDATE_MODE bits are simple write bits. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c index

[PATCH v2] staging: comedi: ni_mio_common: use CR_CHAN more consistently

the value sufficiently, but using CR_CHAN() here makes the code clearer as it avoids passing some irrelevant bits to NISTC_AI_MODE1_CONVERT_SRC() in the first place. Signed-off-by: Spencer E. Olson --- drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++- 1 file changed, 2 insertions(+), 1

  1   2   >