Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-20 Thread Stefan Agner
On 20.08.2018 10:09, Boris Brezillon wrote: > Hi Stefan, > > On Mon, 20 Aug 2018 09:57:47 +0200 > Stefan Agner wrote: > >> On 19.08.2018 13:26, Boris Brezillon wrote: >> > Hi Stefan, >> > >> > On Sat, 18 Aug 2018 10:30:13 +0200 >> > S

Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-20 Thread Stefan Agner
On 19.08.2018 13:26, Boris Brezillon wrote: > Hi Stefan, > > On Sat, 18 Aug 2018 10:30:13 +0200 > Stefan Agner wrote: > >> > diff --git a/drivers/mtd/nand/raw/tegra_nand.c >> > b/drivers/mtd/nand/raw/tegra_nand.c >> > index 5dcee20e2a8c..bcc3a2888

Re: [PATCH 08/23] mtd: rawnand: Pass a nand_chip object to ecc->read_xxx() hooks

2018-08-18 Thread Stefan Agner
Hi Boris, On 17.08.2018 18:09, Boris Brezillon wrote: > Let's make the raw NAND API consistent by patching all helpers and > hooks to take a nand_chip object instead of an mtd_info one or > remove the mtd_info object when both are passed. > > Let's tackle all ecc->read_xxx() hooks at once. > >

Re: [RFC 02/12] mtd: nand: force drivers to explicitly send READ/PROG commands

2017-10-20 Thread Stefan Agner
Hi Miquel, Thanks for the work on this, happy to see the new interface is moving forward. Some comments below. On 2017-10-18 16:36, Miquel Raynal wrote: > From: Boris Brezillon > > The core currently send the READ0 and SEQIN+PAGEPROG commands in >

Re: [PATCH v5 45/50] mtd: nand: vf610: switch to mtd_ooblayout_ops

2016-04-01 Thread Stefan Agner
On 2016-03-30 09:15, Boris Brezillon wrote: > Implementing the mtd_ooblayout_ops interface is the new way of exposing > ECC/OOB layout to MTD users. I think I sent this already in the last revision: Tested-by: Stefan Agner <ste...@agner.ch> Acked-by: Stefan Agner <ste...@agner

Re: [PATCH v4 48/52] mtd: nand: vf610: switch to mtd_ooblayout_ops

2016-03-07 Thread Stefan Agner
On 2016-03-07 01:47, Boris Brezillon wrote: > Implementing the mtd_ooblayout_ops interface is the new way of exposing > ECC/OOB layout to MTD users. Hi Boris, Tested this revision, works out of the box now! Thanks! Tested-by: Stefan Agner <ste...@agner.ch> Acked-by: Stefa

Re: [PATCH v3 48/52] mtd: nand: vf610: switch to mtd_ooblayout_ops

2016-02-26 Thread Stefan Agner
Hi Boris, On 2016-02-25 16:57, Boris Brezillon wrote: > Implementing the mtd_ooblayout_ops interface is the new way of exposing > ECC/OOB layout to MTD users. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/vf610_nfc.c | 34

Re: [PATCH v3 00/52] mtd: rework ECC layout definition

2016-02-25 Thread Stefan Agner
Hi Boris, On 2016-02-25 16:57, Boris Brezillon wrote: > Hello, > > This patchset aims at getting rid of the nand_ecclayout limitations. > struct nand_ecclayout is defining fixed eccpos and oobfree arrays which > can only be increased by modifying the MTD_MAX_ECCPOS_ENTRIES_LARGE and >

Re: [PATCH 09/23] mtd: nand: vf610: remove useless mtd->ecclayout assignment

2015-12-07 Thread Stefan Agner
On 2015-12-07 14:26, Boris Brezillon wrote: > The NAND core layer is already taking care of ecclayout propagation. Remove > this useless assignment. Thx! I see, nand_scan_tail takes care of that... Acked-by: Stefan Agner <ste...@agner.ch> > > Signed-off-by: Boris Brezi