On Sun, Dec 27, 2015 at 02:44:42AM +0530, shraddha.6...@gmail.com wrote:
> From: Shraddha Barke
>
> Fix checkpatch issue: "CHECK: spinlock_t definition without comment".
>
> Signed-off-by: Shraddha Barke
> ---
This will also not apply because of:
2bc29a1abc5c ("staging: gdm72xx: Replace timeva
On Sun, Dec 27, 2015 at 02:44:41AM +0530, shraddha.6...@gmail.com wrote:
> From: Shraddha Barke
>
> Add missing space around that " " to follow linux kernel coding
> style. Warning detected by checkpatch
>
> Signed-off-by: Shraddha Barke
> ---
This will not apply due to:
2bc29a1abc5c ("staging
On Sun, Dec 27, 2015 at 02:44:40AM +0530, shraddha.6...@gmail.com wrote:
> From: Shraddha Barke
Why are you adding this extra From: line here? You can fix your
gitconfig file so that the From: header of the email will contain this
information.
regards
sudip
__
On Fri, Dec 18, 2015 at 06:35:25PM +0530, Sudip Mukherjee wrote:
> A NULL comparison can be written as if (var) or if (!var).
> Reported by checkpatch.
>
> Signed-off-by: Sudip Mukherjee
> ---
Hi Mauro,
A gentle ping.
Can this series be considered for 4.5?
On Tue, Dec 22, 2015 at 10:53:02AM +0100, Christian Gromm wrote:
> This patch fixes the function channel_has_mbo that delivers the false
> information in case two AIMs are using the same tx channel.
>
> Signed-off-by: Christian Gromm
> ---
>
> diff --git a/drivers/staging/most/mostcore/core.c
On Wed, Dec 23, 2015 at 10:51:11AM +0800, maoma king wrote:
> Dear Greg
> I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to
> linux-next tree.But I never received anything about it.So I sent it
> again. You say "Doesn't apply to my tree :(".but it can be apply to
> least linux-
On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote:
> On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> > From: Bijosh T
> >
> > This patch fixes coding style errors for staging/panel driver.
> >
> > Signed-off-by: Bijosh T
>
> I need a "full" name here, not just "T" as a last n
checkpatch complains about missing space around operators.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/media/lirc/lirc_parallel.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_parallel.c
b/drivers/staging
checkpatch complains about space after type cast.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/media/lirc/lirc_parallel.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_parallel.c
b/drivers/staging/media/lirc/lirc_parallel.c
checkpatch complains about the logical operator, which should be on the
previous line.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/media/lirc/lirc_parallel.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_parallel.c
b
Modify lirc_parallel driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/media/lirc/lirc_parallel.c | 100 +++--
1 file changed, 65 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_parallel.c
b
A NULL comparison can be written as if (var) or if (!var).
Reported by checkpatch.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/media/lirc/lirc_parallel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_parallel.c
b/drivers/staging
On Mon, Dec 14, 2015 at 07:08:08PM -0500, Sanidhya Solanki wrote:
> The original code defined macros in the source code, making it
> harder to read. Moved them to the header file, as per the TODO file.
>
> Updated the TODO file.
I think the TODO file should not be updated now. There are still som
On Tue, Dec 15, 2015 at 04:00:34PM +0100, SF Markus Elfring wrote:
> > If you were a lustre dev then I would accept these renames definitely.
>
> I find this information interesting.
> Would any more contributors like to share their opinion?
>
>
> > I do not think I have been unfair to you.
>
>
On Sat, Dec 12, 2015 at 01:12:21AM -0500, Sanidhya Solanki wrote:
> Thank you everyone for your concern regarding my email client.
>
> Unfortunately, there is a bug in "git send-email" that leads to the gmail
> SMTP server rejecting certain patches sent by the git command.
Is it? I am using git
On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> > > This patch does the following:
> > > * changed the complicated i
On Sat, Dec 12, 2015 at 11:57:45AM +0300, Dan Carpenter wrote:
> On Fri, Dec 11, 2015 at 09:24:16PM -0500, Sanidhya Solanki wrote:
> > On Fri, 11 Dec 2015 16:02:33 +0300
> > Dan Carpenter wrote:
> >
> > > On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> > > > >From 1dbe78ce9803
We were getting build warning about unused variable "tsc_msr" and
"va_tsc" while building for i386 allmodconfig.
Signed-off-by: Sudip Mukherjee
---
build warning with next-20151211 and build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
---
On Fri, Dec 11, 2015 at 01:52:11PM +0800, Jandy Gou wrote:
> drivers/staging/rtl8192u/r8192U_core.c:3212:6: warning: symbol
> 'rtl819x_watchdog_wqcallback' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:3276:6: warning: symbol
> 'watch_dog_timer_callback' was not de
On Thu, Dec 10, 2015 at 06:31:09PM -0500, Benjamin Young wrote:
> From 4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5 Mon Sep 17 00:00:00 2001
> From: Benjamin Young
> Date: Thu, 10 Dec 2015 17:31:00 -0500
> Subject: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around
> that '+'
Rega
On Thu, Dec 10, 2015 at 06:00:14AM -0700, BryanSPaul wrote:
> WARNING: Missing a blank line after declarations lines added
>
> Signed-off-by: Bryan Paul
> ---
Your name in the From: header and Signedoff-by name should match.
> drivers/staging/rtl8188eu/core/rtw_efuse.c | 13 +
> 1 f
On Wed, Dec 09, 2015 at 03:46:02PM -0800, Benjamin Young wrote:
> From f18a3e5f155f5258d2d19ac6b56bfaafa2ad470b Mon Sep 17 00:00:00 2001
> From: Benjamin Young
> Date: Wed, 9 Dec 2015 13:45:00 -0800
> Subject: [PATCH] Fixed coding style problems based on checkpatch.pl for
> goldfish_audio.c
This
On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> This patch does the following:
> * changed the complicated if statements to simple case statements
> * in case of E_DEFAULT, no need to return error as ERESTART,
> because this is the user asked for. Hence function should return succ
On Sat, Dec 05, 2015 at 06:44:10AM -0500, Sanidhya Solanki wrote:
> The patch is included below.
> I would like to apologize for the past few emails. It turns out the
> documentation included in the eMail clients file is woefully out of
> date. I have checked the patches for errors using the script
On Sat, Dec 05, 2015 at 10:25:16PM -0500, Sanidhya Solanki wrote:
> I disagree with the output of the automaton. Included below are my
> compile checks before and after the patch.
Build fails with:
skein_block.c: multiple definition of 'skein_256_process_block'
And you moved skein_256_process_bl
On Fri, Dec 04, 2015 at 08:54:16AM -0800, Kevin Wern wrote:
> ethtool_ops has attributes in sub struct ethool_coalesce that
> correspond to the parameters intagg_delay and dynamic_intagg. It is
> preferable to set these properties with ethtool rather than
> module_param, so create these attributes
On Wed, Dec 02, 2015 at 08:39:10AM +0530, punit vara wrote:
> On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee
> wrote:
> > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote:
> >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote:
> >> >
> >> &
On Tue, Dec 01, 2015 at 06:57:24PM +0300, Dan Carpenter wrote:
> On Tue, Dec 01, 2015 at 09:54:50AM -0500, Ben Romer wrote:
> > On 12/01/2015 03:00 AM, Dan Carpenter wrote:
> > >Doing One Err style error handling is often a mistake but it's ok here.
> >
> > Why is it okay here? I don't understand
On Tue, Dec 01, 2015 at 11:16:16AM -0500, Ben Romer wrote:
> On 12/01/2015 10:57 AM, Dan Carpenter wrote:
> >What I meant was that I'm generally opposed to "common exit paths".
> >Mixing all the exit paths together often makes the code more complicated
> >and leads to errors. That makes sense from
On Tue, Dec 01, 2015 at 07:05:19PM +0300, Dan Carpenter wrote:
> A lot of review is judgement calls. I try very hard to be predictable
> and machine like as possible.
>
> I have sometimes called you out for being too strict.
I usually try to guess what Greg will do if he notices those multiple
c
The success path and the error path both are first doing
spin_unlock_irqrestore() before returning. Use that in the common path
and return the success/error value.
Signed-off-by: Sudip Mukherjee
---
v2: changed label name
It is dependent on the patch series sent by Benjamin (Nov 30th
On Tue, Dec 01, 2015 at 11:06:58AM +0300, Dan Carpenter wrote:
> Also, the main point of course is that you should choose meaningful
> names for labels every time just like you would for functions.
Yes, and while sending I was really thinking that you are going to
complain about the label name. :)
The success path and the error path both are first doing
spin_unlock_irqrestore() before returning. Use that in the common path
and return the success/error value.
Signed-off-by: Sudip Mukherjee
---
It is dependent on the patch series sent by Benjamin (Nov 30th).
drivers/staging/unisys
On Mon, Nov 30, 2015 at 02:46:15PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch fixes the following type of check patch warning:
> Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
This has alrea
On Mon, Nov 30, 2015 at 02:46:06PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch fixes the following checkpatch warning:
> spaces preferred around that ‘*’ or ‘|’
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/visorbus/vis
On error we were returning retval, but retval is not having the error
value. We will get the error value using PTR_ERR.
Signed-off-by: Sudip Mukherjee
---
This series doesnot depend on my earlier pending series.
drivers/staging/most/aim-cdev/cdev.c | 4 ++--
1 file changed, 2 insertions(+), 2
use.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/aim-cdev/cdev.c | 10 +-
drivers/staging/most/aim-network/networking.c | 2 +-
drivers/staging/most/aim-sound/sound.c| 4 ++--
drivers/staging/most/hdm-dim2/dim2_hdm.c | 2 +-
drivers/staging/most
On Fri, Nov 27, 2015 at 05:44:53AM +, 김정배 wrote:
> From 8f6aeb362d9e44f29d46ae7694cdfee4408406ce Mon Sep 17 00:00:00 2001
> From: "KIM JUGNBAE"
> Date: Thu, 26 Nov 2015 16:28:47 +0900
> Subject: [PATCH] bug_fix : access freed memory
This part should not be present in the patch.
>
> sync_fen
On Wed, Nov 25, 2015 at 07:10:30PM +0600, Alexander Kuleshov wrote:
> The dgap driver contains three functions: dgap_cmdb(), dgap_cmdw()
> and dgap_cmdw_exit which are contain duplicated code which waits
> if necessary before updating the pointer to limit outstanding
> commands. This patch introduc
On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote:
> Some error handling paths are checking for success
> instead of error on rtl871x_ioctl_rtl.c.
>
> Signed-off-by: Mauro Dreissig
> ---
> drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239
> ++--
> 1 file ch
On Sat, Nov 21, 2015 at 09:26:32AM +0530, Anjali Menon wrote:
> Moved the comments to the next line to remove the warning
> detected by the checkpatch.pl.
>
> WARNING: line over 80 characters
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/panel/panel.c | 4 +++-
> 1 file changed, 3 ins
device_create() returns ERR_PTR on error, it does not return NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/mostcore/core.c
b/drivers/staging/most/mostcore/core.c
index
If create_most_inst_obj() fails we returned an error pointer but we
missed releasing id.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/mostcore/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/mostcore/core.c
b/drivers/staging/most/mostcore/core.c
index
We were returning ENOMEM on all types of errors. Lets return the actual
error code. At the same time remove the label which became unused as a
result of this patch.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/mostcore/core.c | 22 +++---
1 file changed, 15 insertions
On Wed, Nov 18, 2015 at 01:43:30PM +0100, Christian Gromm wrote:
> This patch fixes a potential MBO leak in case function aim_read()
> exits right after the MBO has been fetched from kfifo and before
> it has been saved to the variable stacked_mbo.
>
> Signed-off-by: Christian Gromm
> ---
> driv
On Wed, Nov 18, 2015 at 09:31:36AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Nov 18, 2015 at 05:25:38PM +, David Binderman wrote:
> > Hello there Greg,
> >
> >
> > > Date: Wed, 18 Nov 2015 09:14:41 -0800
> > > From: gre...@linuxfoundation.org
> > > To:
On Tue, Nov 17, 2015 at 05:44:55PM +0100, Christian Colic wrote:
> Fix checkpatch checks: spaces around + at "reg_base+addr2" and
> rewrite comparisons with NULL to "!data->reg_base"
That becomes multiple changes in a single patch. It should be in
separate patches.
regards
sudip
_
On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote:
> From: Jubin John
>
> Correct the checks on diag.c with the latest checkpatch
>
> Reviewed-by: Dennis Dalessandro
> Reviewed-by: Mike Marciniszyn
> Signed-off-by: Jubin John
> Signed-off-by: Ira Weiny
> ---
Different type
On Mon, Nov 16, 2015 at 10:48:28PM +0530, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel
> ---
In this one I am not seeing any change to BIT.
On Mon, Nov 16, 2015 at 10:48:27PM +0530, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel
> ---
I am not seeing any change related to udelay. C
In case of error we are jumping to err_del_scsipending_ent and always
returning SCSI_MLQUEUE_DEVICE_BUSY from error path. We donot need a
variable to return a fixed error value, it can be returned directly.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorhba/visorhba_main.c | 12
The variables op, sd and zmotion were never being used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorhba/visorhba_main.c | 4
drivers/staging/unisys/visorinput/visorinput.c | 4 +---
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/unisys
On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote:
> On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote:
> > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> > > This patch fixes the checkpatch issue:
> > > CHECK: Prefer using the BIT
On Sat, Nov 14, 2015 at 09:57:10AM +0530, Anjali Menon wrote:
> Used double equal sign instead of equal to sign in the if condition
> to remove the error detected by checkpatch.pl.
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/staging/d
On Fri, Nov 13, 2015 at 11:59:47PM +0200, Panayiotis Tembriotis wrote:
> Remove excess new line characters as suggested by checkpatch.pl:
> ERROR: else should follow close brace '}'
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Panayiotis Tembriotis
> ---
This has
On Fri, Nov 13, 2015 at 09:03:56PM +0530, Nizam Haider wrote:
> Fix Checlpatch warning
> HECK: braces {} should be used on all arms of this statement
>
> Signed-off-by: Nizam Haider
> ---
> drivers/staging/dgnc/dgnc_neo.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --g
On Mon, Nov 09, 2015 at 08:09:36PM +0530, punit vara wrote:
> On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee
> wrote:
> > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote:
> >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote:
> >> >
> >> &
On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> This patch fixes the checkpatch issue:
> CHECK: Prefer using the BIT macro
>
> Reviewed-by: Dean Luick
> Reviewed-by: Ira Weiny
> Reviewed-by: Mike Marciniszyn
> Signed-off-by: Jubin John
> ---
>
> diff --git a/drivers/staging/rd
On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote:
> On Wed, Nov 11, 2015 at 11:01 PM, Greg KH wrote:
> > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote:
> >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot wrote:
> >>
> >> I'm not getting any of these errors
On Fri, Nov 13, 2015 at 04:48:11PM +0530, Nizam Haider wrote:
> This patch fixes several warning during checkpatch
>
> 355: CHECK: Logical continuations should be on the previous line
> : CHECK: braces {} should be used on all arms of this statement
> 1631: CHECK: spaces preferred around that
On Sun, Nov 08, 2015 at 11:34:55AM -0500, James Simmons wrote:
> For UMP and SMP machines the struct cfs_cpt_table are
> defined differently. In the case handled by this patch
> nodemask is defined as a integer for the UMP case and
> as a pointer for the SMP case. This will cause a problem
> for os
On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote:
> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote:
> >
> >
> > On 2015년 11월 09일 18:05, punit vara wrote:
> >>
> >> On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote:
> >>>
> >>> On 2015년 11월 09일 17:18, Dan Carpenter wrote:
>
> On M
On Tue, Nov 03, 2015 at 07:46:07PM -0800, Greg Kroah-Hartman wrote:
> On Mon, Nov 02, 2015 at 12:22:07PM -0500, James Simmons wrote:
> > Cleanup all the unneeded white space in libcfs_hash.h.
> >
> > Signed-off-by: James Simmons
> > ---
> > .../lustre/include/linux/libcfs/libcfs_hash.h | 1
On Sun, Nov 01, 2015 at 10:55:48AM +0200, Mike Rapoport wrote:
> In lynxfb_pci_probe return error immediately in cases no cleanup is
> required.
>
> Signed-off-by: Mike Rapoport
> ---
NACK.
It should be:
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index c78421
On Fri, Oct 30, 2015 at 03:54:03PM +0100, Bogicevic Sasa wrote:
> This fixes all messages from checkpatch.pl about comparison to NULL
> could be written according to coding style preferences
>
> Signed-off-by: Bogicevic Sasa
> ---
For all your next patches, either they have already deen done or
On Fri, Oct 30, 2015 at 03:49:16PM +0100, Bogicevic Sasa wrote:
> This fixes all messages from checkpatch.pl about spaces preffered around
> that +
>
> Signed-off-by: Bogicevic Sasa
> ---
:(
ba7f55b705b9 ("staging: gdm724x: add spaces around binary operators")
regards
sudip
___
On Fri, Oct 30, 2015 at 03:36:37PM +0100, Bogicevic Sasa wrote:
> This fixes the errors about the use of multiple blank lines from
> checkpatch.pl
>
> Signed-off-by: Bogicevic Sasa
> ---
This has already been done.
a487db8b6704 ("staging: gdm724x: remove multiple blank lines")
regards
sudip
___
On Fri, Oct 30, 2015 at 03:30:56PM +0100, Bogicevic Sasa wrote:
> This fixes "Blank lines aren't necessary after an open brace '{'"
> message from checkpatch.pl
>
> Signed-off-by: Bogicevic Sasa
> ---
You are still using some other tree. This will not apply because of some
other change.
regards
On Fri, Oct 30, 2015 at 08:13:48AM -0200, Albino B Neto wrote:
> 2015-10-29 19:12 GMT-02:00 Greg KH :
> >> 0 - https://www.kernel.org/doc/Documentation/CodingStyle
> >
> > I don't understand what you are saying here, what does this email mean?
>
> I have to send private him ? The link for help.
N
On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote:
> With nidstring now having the latest fixes we can
> now clean up all the remaining checkpatch errors
> for nidstring.c.
>
> Signed-off-by: James Simmons
> ---
You are doing different types of changes in this patch. Please split
the
On Thu, Oct 29, 2015 at 12:22:10PM +0300, Dan Carpenter wrote:
> rename_rev.pl is a script to strip away the mechanical changes that we
> often see in staging patches and leave just the interesting changes for
> manual review.
Thanks Dan. This CamelCase feature will be a life saver. I hope you
rem
On Wed, Oct 28, 2015 at 12:44:04PM +0300, Dan Carpenter wrote:
> On Wed, Oct 28, 2015 at 11:54:39AM +0530, Sudip Mukherjee wrote:
> > On Tue, Oct 27, 2015 at 10:26:00PM +0700, Ivan Safonov wrote:
> > > x = x + a and x += a equivalen, but second preferably.
> >
> > e
On Wed, Oct 28, 2015 at 03:59:26PM +0900, Glen Lee wrote:
> From: Leo Kim
>
> This patch removes unused functions at host_interface files.
> - host_int_send_join_leave_info_to_host
> - host_int_send_network_info_to_host
>
> Signed-off-by: Leo Kim
> Signed-off-by: Glen Lee
> ---
> drivers/st
On Tue, Oct 27, 2015 at 07:45:22PM +0200, Aya Mahfouz wrote:
> Replaces IS_PO2 by is_power_of_2. It is more accurate to use
> is_power_of_2 since it returns 1 for numbers that are powers
> of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
> powers of 2.
>
> Signed-off-by: Aya Mahfouz
On Tue, Oct 27, 2015 at 07:43:34PM +0200, Aya Mahfouz wrote:
> Replaces IS_PO2 by is_power_of_2. It is more accurate to use
> is_power_of_2 since it returns 1 for numbers that are powers
> of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
> powers of 2.
>
> Reviewed-by: Andreas Dilger
On Tue, Oct 27, 2015 at 10:26:00PM +0700, Ivan Safonov wrote:
> x = x + a and x += a equivalen, but second preferably.
equivalent?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo
On Tue, Oct 27, 2015 at 10:19:50PM +0700, Ivan Safonov wrote:
> min_t macro better conveys the meaning of the code.
>
> Signed-off-by: Ivan Safonov
> ---
> Changes in v2:
> - min replaced by mit_t.
>
> drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
> drivers/staging/rtl8188eu/core/rtw
On Tue, Oct 27, 2015 at 10:18:10PM +0700, Ivan Safonov wrote:
> min_t macro better conveys the meaning of the code.
>
> Signed-off-by: Ivan Safonov
> ---
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> index 2d88c5a..5808763 100644
On Tue, Oct 27, 2015 at 02:04:54PM +0200, Dzonatans Melgalvis wrote:
> Fixed checkpatch.pl warning about comment block coding style.
>
> Signed-off-by: Dzonatans Melgalvis '.
This change has already been done by:
7e4161747bc6 ("staging: android: Fix checkpatch block comments warnings")
which tre
On Tue, Oct 27, 2015 at 06:20:14PM +0900, Glen Lee wrote:
> wilc_netdev_init function has parameters to pass but no argument is passed
> when bus type SPI is selected. Which causes build error.
> This patch passes argument &wilc to the function wilc_netdev_init.
>
> Signed-off-by: Glen Lee
Fixes:
On Tue, Oct 27, 2015 at 05:33:37PM +0900, Glen Lee wrote:
> From: Leo Kim
>
> This patch removes goto statement and moves the spin lock position.
> If a memory allocation fails, directly returns an error.
> The spin lock actually protects the pHandle. Therefore, call spin lock just
> before pHand
On Mon, Oct 12, 2015 at 08:30:41PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Oct 09, 2015 at 12:32:32PM +0530, Sudip Mukherjee wrote:
> > On Thu, Oct 08, 2015 at 09:11:07PM +0100, Mike Rapoport wrote:
> > > Hi Sudip,
> > >
> > > On Thu, Oct 08, 2015 at 11:
On Mon, Oct 12, 2015 at 01:35:54PM +0200, Tillmann Heidsieck wrote:
>
> I must have rediscovered a problem I already fixed :-(
Which tree are you using? You should be using staging-testing branch of
the staging tree.
regards
sudip
___
devel mailing lis
On Mon, Oct 12, 2015 at 09:48:27AM +0800, Binbin Zhou wrote:
> The PM_EVENT_RESUME state is needed when SM750 resume, otherwise it
> will be failed in the second time of continuous suspend/resume.
>
> Cc: Sudip Mukherjee
> Signed-off-by: Binbin Zhou
> Reviewed-by: Huacai C
On Sat, Oct 10, 2015 at 09:56:16PM +0200, Tillmann Heidsieck wrote:
> This patch fixes a potential buffer overflow detected by smatch.
>
> pda16 has length 512, while processing an element with index < 512 we
> are checking for an end marker in the next element. This poses a
> potential buffer ove
On Sat, Oct 10, 2015 at 04:31:21PM +0700, Ivan Safonov wrote:
> On 10/10/2015 03:35 PM, Sudip Mukherjee wrote:
> >On Thu, Oct 08, 2015 at 10:21:07PM +0700, Ivan Safonov wrote:
> >>This patch inserts ARRAY_SIZE instead of sizeof(type array[])/sizeof(type).
> &g
On Fri, Oct 09, 2015 at 12:11:33PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Static analysis with cppcheck found the following memory leak:
>
> [drivers/staging/wilc1000/linux_mon.c:255]: (error) Memory leak: mgmt_tx
>
> Free mgmt_tx on the error return path when mgmt_tx->buff fails t
On Thu, Oct 08, 2015 at 08:53:18PM +0100, paulmcq...@gmail.com wrote:
> From: Paul McQuade
This line is not required. You can configure your .gitconfig so that
your name will be mentioned correctly in the From: header of the patch.
regards
sudip
___
de
On Thu, Oct 08, 2015 at 10:23:35PM +0700, Ivan Safonov wrote:
> This patch inserts spaces preferred around that '+' found by checkpatch.
> ---
You missed the Signed-off-by:
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
On Thu, Oct 08, 2015 at 10:21:07PM +0700, Ivan Safonov wrote:
> This patch inserts ARRAY_SIZE instead of sizeof(type array[])/sizeof(type).
> ---
> Changes in v2:
> - inserted description to this patch
>
> Signed-off-by: Ivan Safonov
> ---
> drivers/staging/rtl8188eu/hal/bb_cfg.c | 8
On Thu, Oct 08, 2015 at 09:11:07PM +0100, Mike Rapoport wrote:
> Hi Sudip,
>
> On Thu, Oct 08, 2015 at 11:46:28AM +0530, Sudip Mukherjee wrote:
> > On Tue, Oct 06, 2015 at 04:49:13PM +0100, Mike Rapoport wrote:
> > > Currently the sii164 DVI controller support i
On Tue, Oct 06, 2015 at 09:42:15AM +0100, Mike Rapoport wrote:
> The getChipClock function is used only to get MXCLK frequency, which
> makes most of getPllValue function unused and thus. The detection of
> MXCLK frequency may be implemented directly in getChipClock rendering
> getPllValue and calc
On Tue, Oct 06, 2015 at 04:49:13PM +0100, Mike Rapoport wrote:
> Currently the sii164 DVI controller support is unused anywhere in the rest of
> the driver, and, anyway it does not belong to framebuffer device driver.
> These patches remove the sii164 DVI controller support.
I am not sure if we can
On Thu, Oct 08, 2015 at 08:26:40AM +0700, Ivan Safonov wrote:
> Unused macro read_next_pair removed.
>
> Signed-off-by: Ivan Safonov
> ---
Your subject is not clear. It should have been:
[PATCH] staging: rtl8188eu: unused macro read_next_pair removed
same for your next patch also.
regards
sudip
On Mon, Oct 05, 2015 at 12:46:43PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> > The IO configuration was not used to configure the board. It was only
> > read from the configuration file. Stop reading it and also remove the
&g
On Sat, Oct 03, 2015 at 10:47:47AM +0530, Anjali Menon wrote:
> Added a blank line after declaration to fix the coding style
> warning detected by checkpatch.pl
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/i2o/pci.c | 1 +
> 1 file
The IO configuration was not used to configure the board. It was only
read from the configuration file. Stop reading it and also remove the
other related variables defined for it.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 21 -
drivers/staging/dgap
Space is not necessary after typecast.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c| 6 +++---
drivers/staging/dgnc/dgnc_driver.c | 6 +++---
drivers/staging/dgnc/dgnc_mgmt.c | 6 +++---
drivers/staging/dgnc/dgnc_neo.c| 12 ++--
drivers/staging/dgnc
checkpatch was warning us that the alignment should match the open
parenthesis.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c| 14 +++---
drivers/staging/dgnc/dgnc_driver.c | 2 +-
drivers/staging/dgnc/dgnc_neo.c| 2 +-
drivers/staging/dgnc/dgnc_tty.c
Blank lines are not needed after opening braces. checkpatch was giving
us warnings about this.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgnc/dgnc_cls.c| 4
drivers/staging/dgnc/dgnc_driver.c | 3 ---
drivers/staging/dgnc/dgnc_mgmt.c | 1 -
drivers/staging/dgnc/dgnc_neo.c
101 - 200 of 1044 matches
Mail list logo
