On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote:
In cases where visorbus is compiled directly into the kernel, if
visorbus registration fails for any reason, it is still possible for
other drivers to call visorbus_register_visor_driver(), which could
cause an oops. Prevent this
On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote:
On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
According to the kernel coding style the NULL check should not be
written as [variable] == NULL or [variable] != NULL.
It seems
On Tue, Aug 18, 2015 at 02:02:49AM -0400, Raphaël Beamonte wrote:
2015-08-18 1:44 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com:
I think that will be better, since you are sending the patch for
consistent spacing.
Actually, going through the bunch of patches, it seems
On Tue, Aug 18, 2015 at 01:27:31AM -0400, Raphaël Beamonte wrote:
2015-08-18 0:24 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com:
+ netdev_err([Sendconfigpkt]Get Timed out\n);
This will not compile. you can not just replace printk with
netdev_*, you need
sparse was complaining that an integer is used as NULL pointer. Fix it
by using NULL.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/hdm-dim2/dim2_hdm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/hdm-dim2
These functions were only defined but not used anywhere.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/hdm-dim2/dim2_hal.c | 5 -
drivers/staging/most/hdm-dim2/dim2_hal.h | 5 -
drivers/staging/most/hdm-dim2/dim2_hdm.c | 10 --
3 files changed
The Makefile is including drivers/media/video. But there is no such
directory in kernel tree. Since it is aim-v4l2 this might have been
drivers/media/v4l2-core, but the Kconfig already mentions that it
depends on VIDEO_V4L2. So no need to mention that again in the Makefile.
Signed-off-by: Sudip
The variable conf was only assigned the value but was never used.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/hdm-usb/hdm_usb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
b/drivers/staging/most/hdm-usb/hdm_usb.c
If kzalloc fails it will print lots of debugging information in the log,
no need to have another in the code.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/aim-cdev/cdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/most/aim-cdev/cdev.c
b
split_arg_list() and audio_set_pcm_format() are being called from the
same file and is not referenced from outside, so make them as static.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/aim-sound/sound.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
Multiple blank lines are not recommended in the kernel coding style.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/aim-cdev/cdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/most/aim-cdev/cdev.c
b/drivers/staging/most/aim-cdev/cdev.c
index
Mentioning true or false in the if comparison is error prone and also
not according to the coding style.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/aim-cdev/cdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most
According to the kernel coding style the NULL check should not be
written as [variable] == NULL or [variable] != NULL.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/most/aim-cdev/cdev.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
On Sat, Aug 15, 2015 at 09:34:08PM -0400, Raphaël Beamonte wrote:
Externs should be avoided in .c files. These one were not useful and
are thus removed.
These are not externs. These are forward declarations.
regards
sudip
___
devel mailing list
On Sat, Aug 15, 2015 at 09:34:03PM -0400, Raphaël Beamonte wrote:
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
snip
@@ -2182,30 +2182,30 @@ static void rtl8192_init_priv_variable(struct
net_device *dev)
priv-EarlyRxThreshold = 7;
priv-enable_gpio0 = 0;
On Sat, Aug 15, 2015 at 09:34:02PM -0400, Raphaël Beamonte wrote:
A missing struct keyword in variable declaration triggered a
need consistent spacing around '*' code style error.
struct rtl8192_rx_info is typedef as rtl8192_rx_info. This same file is
having few more use of rtl8192_rx_info
On Sat, Aug 15, 2015 at 09:33:58PM -0400, Raphaël Beamonte wrote:
Fix multiple occurences of the need consistent spacing code style error
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/rtl8192u/r8192U_core.c | 28 ++--
1 file changed,
On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote:
Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h |
On Tue, Aug 18, 2015 at 01:38:21AM -0400, Raphaël Beamonte wrote:
2015-08-18 1:02 GMT-04:00 Sudip Mukherjee sudipm.mukher...@gmail.com:
since you are modifying these lines for consistent spacing, it will be
better to have:
(priv-ShortRetryLimit TCR_SRL_OFFSET) | // Short retry limit
On Fri, Aug 14, 2015 at 11:34:07AM -0700, H Hartley Sweeten wrote:
Use the comedi_offset_munge() helper to convert the hardware two's
complement values to the offset binary format expected by comedi.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
On Thu, Aug 13, 2015 at 01:41:20PM +0900, Tony Cho wrote:
From: Johnny Kim johnny@atmel.com
This patch changes the void pointer member of the tstrHostIFmsg to the
real data type because the void pointer type is ambiguous and not
readable.
Signed-off-by: Johnny Kim johnny@atmel.com
dm_odm was being checked for NULL after dereferencing it. Lets check for
NULL first before derefenrencing it.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
On Tue, Aug 11, 2015 at 09:32:30PM +0800, Swee Hua Law wrote:
Add blank line after variable declaration
Signed-off-by: Swee Hua Law sweehu...@gmail.com
---
drivers/staging/lustre/lustre/llite/lloop.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Mon, Aug 10, 2015 at 08:56:02PM +0530, Aparna Karuthodi wrote:
Added a new line to fix a coding style error no space after
declaration detected by checkpatch.
Signed-off-by: Aparna Karuthodi kdasapa...@gmail.com
---
Why are you sending this patch again? You have sent this one long back
On Mon, Aug 10, 2015 at 11:42:27PM -0500, Junsu Shin wrote:
This is a patch to the ion.c that fixes a warning that tells missing a blank
line after declaration
Signed-off-by: Junsu Shin jjun...@gmail.com
---
1) This is a false positive.
2) You need to refresh your tree. This has already
On Sun, Aug 09, 2015 at 08:39:56AM +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: b963e7223cb3278dda35a6550a8df08ff2be2ee5
commit: 1461d66728648540a043ba69ace1081ed5006faf [597/643] staging: sm7xxfb:
merge
On Sun, Aug 09, 2015 at 11:48:34PM +0800, Swee Hua Law wrote:
1) do not initialise globals to NULL
2) improve readability of hlist_for_each_entry_safe()
3) move */ to a separate line
4) change symbol == NULL to !symbol
These were many different changes in a single patch. Please break them
On Sun, Aug 09, 2015 at 09:05:11PM +0530, Chandra S Gorentla wrote:
Removed pointer check with integer; this fixes 'sparse' error -
error: incompatible types for operation ()
left side has type unsigned char [usertype] *[usertype] pu8Tail
right side has type int
Signed-off-by: Chandra
On Sat, Aug 08, 2015 at 01:55:02AM -0500, Junsu Shin wrote:
On 08/06/2015 11:45 PM, Sudip Mukherjee wrote:
On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
snip
Thanks for pointing it out.
Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters
warning
On Fri, Aug 07, 2015 at 09:40:03AM +0200, AdrianRemonda wrote:
On Thu, Aug 06, 2015 at 11:57:28PM +0200, Christian Gromm wrote:
On Thu, 6 Aug 2015 19:34:58 +0200
Adrian Remonda adrianremo...@gmail.com wrote:
snip
Again, please keep the original alignment and start the second line
of
_RECV_OSDEP_C_ was only defined here but never checked anywhere.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c
b/drivers/staging/rtl8188eu
The function rtw_os_recv_resource_alloc() only uses the argument
struct recv_frame *. So remove the other unused argument.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +-
drivers/staging/rtl8188eu/include/recv_osdep.h | 3
Re-arrange the code to directly return success or failure, thus removing
the variable used in the function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Hi Greg,
Resending the patch series as discussed with you. Patch generated
with -M, thought it will be easy for you
Create the documentation for SM712. Mention all the supported modes and
how to use.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Documentation/fb/sm712fb.txt | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/fb/sm712fb.txt
diff
Now since sm712fb has moved out of staging update the maintainers list
accordingly.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9289ecb..ba6c537 100644
Multiple blank lines are not kernel coding style and so checkpatch
complains. Remove them.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm750fb/sm750.c | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b
Lets return the return value directly instead of using a variable to
store the result.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm750fb/sm750.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers
Multiline comments are edited to be in the kernel coding style.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm750fb/sm750.c | 63 +
1 file changed, 39 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c
Kernel coding style says to have a space around the operators.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
This patch will generate checkpatch warning about longline in 2 places,
those were not fixed to keep the readability. Will fix them later.
The warnings were already
Rearrange the code to remove one exit label which also makes the code
less indented and more readable.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm750fb/sm750.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git
On Fri, Aug 07, 2015 at 11:45:03AM -0700, H Hartley Sweeten wrote:
Define the bits in this register. Remove the old defines in hwdrv_apci1564.c.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
This is a patch to the dm365_ipipe.c that fixes over 80 characters warning
detected by checkpatch.pl.
Signed-off-by: Junsu Shin jjun...@gmail.com
please do not use whitespace before Signed-off-by: line.
---
On Mon, Aug 03, 2015 at 11:22:35PM +0200, Adrian Remonda wrote:
This patch fixes the warning generated by sparse: Using plain integer
as NULL pointer by replacing the offending 0 with NULL.
Signed-off-by: Adrian Remonda adrianremo...@gmail.com
---
This patch will not apply because of
On Tue, Aug 04, 2015 at 08:44:51PM +0200, Adrian Remonda wrote:
This is a patch to the mostcore/core.c file. It makes
several local functions and structures static to prevent global
visibility.
Signed-off-by: Adrian Remonda adrianremo...@gmail.com
---
snip
@@ -1255,7 +1255,7 @@ static void
On Tue, Aug 04, 2015 at 08:44:52PM +0200, Adrian Remonda wrote:
This patch fixes the warning generated by sparse: Using plain integer
as NULL pointer by replacing the offending 0 with NULL.
Signed-off-by: Adrian Remonda adrianremo...@gmail.com
---
drivers/staging/most/mostcore/core.c | 2
On Wed, Aug 05, 2015 at 12:08:16AM +0200, Daniel Machon wrote:
Fixed brace coding styles issues
Signed-off-by: Daniel Machon dmachon@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
On Wed, Aug 05, 2015 at 12:14:55AM -0500, Pradheep Shrinivasan wrote:
From: pradheep pradheep...@gmail.com
Dan had previously told you that it is wrong.
Here From: line is only required if you are not able to configure the
email From: header while using some corporate server. But your email
From:
On Mon, Aug 03, 2015 at 11:48:59AM +0530, Shraddha Barke wrote:
From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001
From: Shraddha Barke shraddha.6...@gmail.com
Date: Mon, 3 Aug 2015 11:34:19 +0530
Subject: [PATCH] Staging : lustre : Use -EINVAL instead of -ENOSYS
You do
On Mon, Aug 03, 2015 at 11:17:06AM +0530, Shraddha Barke wrote:
Declare the file_operations structure ll_file_operations as const, as done
elsewhere in the kernel, as there are no modifications to its fields.
Problem found using checkpatch:
WARNING: struct file_operations should normally
On Sun, Aug 02, 2015 at 11:04:22PM +0530, Shraddha Barke wrote:
Your subject says 'Revert Staging : lustre: Struct file_operations
should be const'. This patch reverts which commit?
Declare the file_operations structure ll_file_operations as const, as done
elsewhere in the kernel, as there are
On Sat, Aug 01, 2015 at 01:04:48PM +0200, Christian Gromm wrote:
On Fri, 31 Jul 2015 17:14:32 +0530
Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
On Thu, Jul 30, 2015 at 06:19:41PM +0200, Christian Gromm wrote:
This patch replaces pr_*() functions with dev_*().
Reported
On Fri, Jul 31, 2015 at 01:52:13PM -0700, Greg Kroah-Hartman wrote:
On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
This patch fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
Signed-off-by: Shraddha Barke shraddha.6...@gmail.com
---
snip
On Fri, Jul 31, 2015 at 03:12:23AM -0600, Alex Wilson wrote:
Fixed two coding style warnings concerning multiline comments.
Signed-off-by: Alex Wilson alex.david.wil...@gmail.com
---
drivers/staging/panel/panel.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
On Fri, Jul 31, 2015 at 04:38:08PM +0900, Tony Cho wrote:
Hi Greg,
This patch focuses on removing the compile warnings for 64bit incompatability.
Most warnings are due to senseless type castings from driver handler to u32
and
also to void pointers. They are removed by using the same handler
On Thu, Jul 30, 2015 at 06:19:41PM +0200, Christian Gromm wrote:
This patch replaces pr_*() functions with dev_*().
Reported-by: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off-by: Christian Gromm christian.gr...@microchip.com
---
snip
+ dev_notice(dev,
+
On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote:
This patch lets preprocessor conditionals (#ifdef) related to
WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out
the entire functions is preferred rather than portions of functions or
expressions becausue doing so
On Thu, Jul 30, 2015 at 06:10:12PM +0900, Tony Cho wrote:
This patch removes the warnings reported by checkpatch.pl on missing
a blank line after declarations.
Signed-off-by: Tony Cho tony@atmel.com
---
V2: This patch doesn't have a difference with the first one. However,
it's resent
On Tue, Jul 28, 2015 at 05:16:09PM +0200, Christian Gromm wrote:
This patch prevents snprintf from exceeding a given buffer size.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Christian Gromm christian.gr...@microchip.com
---
snip
- snprintf(devnod_buf,
On Mon, Jul 27, 2015 at 07:35:15PM +0530, Shraddha Barke wrote:
This patch compresses two lines into a single line if immediate return
is found. Variable rc is dropped as it is no longer needed.
same patch again?
regards
sudip
___
devel mailing list
On Mon, Jul 27, 2015 at 07:29:36PM +0530, Shraddha Barke wrote:
This patch compresses two lines into a single line if immediate return
is found. Variable rc is dropped as it is no longer needed.
snip
- return rc;
+ return wait_event_interruptible(un-un_flags_wait, ((un-un_flags
On Mon, Jul 27, 2015 at 09:20:23PM +0200, Mario Bambagini wrote:
This patch fixes 8 bad alignments. When a line is split on
more than one line, the other lines must be aligned with
paranthesis.
Signed-off-by: Mario Bambagini mario.bambag...@gmail.com
---
On Mon, Jul 27, 2015 at 04:10:29PM +0800, Navy Cheng wrote:
The work flow of dgnc_init_module() is base on if statment. Here is a
nest if in the function.
To avoid the nest if statment, make the code easier to understand and
make the codingstyle to be identical with others, add end label to
On Sun, Jul 26, 2015 at 11:04:54PM +0530, Shraddha Barke wrote:
This patch compresses two lines into a single line if immediate return
statement
is found. Also,remove variable rc as it is no longer needed.
It is done using tool Coccinelle. And semantic patch used for this is as
follows:
On Sat, Jul 18, 2015 at 09:38:57AM +0530, Sudip Mukherjee wrote:
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
Hi Tomi,
A gentle ping
regards
sudip
___
devel mailing list
de
On Sun, Jul 26, 2015 at 11:03:40PM +0530, Shraddha Barke wrote:
This patch compresses two lines into a single line if immediate return
statement
is found. Also,remove variable rc as it is no longer needed.
It is done using tool Coccinelle. And semantic patch used for this is as
follows:
On Sat, Jul 25, 2015 at 09:49:19AM +0800, Incarnation P. Lee wrote:
From: Pan Li incarnation.p@outlook.com
Add one space after ',' in function call parameters list.
Signed-off-by: Pan Li incarnation.p@outlook.com
---
This has already been done by 574150f0d275 (staging:lustre: fix
On Tue, Jul 21, 2015 at 03:17:06PM +0530, Vinay Simha wrote:
Joe,
Just want to confirm, shall i delete this code in sm750_help.h, even the
FIELD_START and FIELD_END is not required.
If they are not used anywhere feel free to send a patch to delete them.
regards
sudip
On Thu, Jul 23, 2015 at 01:24:50PM +0300, Dan Carpenter wrote:
On Thu, Jul 23, 2015 at 01:10:57PM +0300, Dan Carpenter wrote:
In this specific case, writing it as if (ret != 0) caused the bug. If
we had written it as if (ret) return ret; then there are no zeroes so
wouldn't have been any
On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote:
struct ndis_wlan_bssid_ex is a dopelganger of
struct wlan_bssid_ex, and is used about a third as often
Switch all instances to wlan_bssid_ex
This also gets rid of a use of typedef NDIS_802_11_RATES_EX
Signed-off-by: Joshua
On Tue, Jul 21, 2015 at 12:14:43PM +0530, Vinay Simha BN wrote:
WARNING: line over 80 characters
comment block , odd statement fixes
This is not applying. I think you have done the changes on top of your
previous patch.
regards
sudip
___
devel mailing
On Mon, Jul 20, 2015 at 08:55:43AM +0200, Guillaume Bienkowski wrote:
Signed-off-by: Guillaume Bienkowski guitre...@gmail.com
---
you have not given anything in the commit message. Please mention which
type of space style issue you have corrected in the commit message. Same
for your next 2/2
On Mon, Jul 20, 2015 at 02:15:35PM +0300, Cihangir Akturk wrote:
obd_device_list_sops and obd_device_list_fops are not
referenced outside of linux-module.c, so make them static.
And they are not modified also, so const ?
regards
sudip
___
devel
On Mon, Jul 20, 2015 at 06:10:04PM +0200, Maciek Borzecki wrote:
Remove unnecessary braces where appropriate. Fix non-tab
indentation.
This removes the following checkpatch warnings:
WARNING: braces {} are not necessary for single statement blocks
ERROR: code indent should use tabs where
On Tue, Jul 21, 2015 at 11:39:49AM +0530, Sudip Mukherjee wrote:
On Mon, Jul 20, 2015 at 02:15:35PM +0300, Cihangir Akturk wrote:
obd_device_list_sops and obd_device_list_fops are not
referenced outside of linux-module.c, so make them static.
And they are not modified also, so const ?
You
On Tue, Jul 21, 2015 at 08:28:06AM +0200, Maciek Borzecki wrote:
On Tue, Jul 21, 2015 at 8:19 AM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On Mon, Jul 20, 2015 at 06:10:04PM +0200, Maciek Borzecki wrote:
Remove unnecessary braces where appropriate. Fix non-tab
indentation
Directly return NULL instead of using another label and goto.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers
Check for kzalloc failure and directly return from the error patch thus
simplifying the success path.
Suggested-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 7 +++
1 file changed, 3
Success and error path was mixed. Separate them by directly returning 0
from the success path. In the process remove the variable which became
unused.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 8 +++-
1 file changed, 3 insertions
_HCI_INTF_C_ was only defined here but not being used anywhere.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep
Multiple blank lines should be avoided.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index
On Fri, Jul 17, 2015 at 10:57:44PM +0200, Maciek Borzecki wrote:
Remove unnecessary brakes where appropriate.
brakes or braces?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
On Sat, Jul 18, 2015 at 07:57:44AM +0300, Adi Ratiu wrote:
Signed-off-by: Adi Ratiu a...@adirat.com
---
Your patch seems to be corrupted (line wrapped?). And you have not
mentioned any commit message.
regards
sudip
___
devel mailing list
On Sat, Jul 18, 2015 at 08:03:27PM +0200, Jakub Sitnicki wrote:
On Sat, Jul 18, 2015 at 06:46 AM CEST, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On Fri, Jul 17, 2015 at 05:33:55PM +0200, Jakub Sitnicki wrote:
On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee
sudipm.mukher
On Fri, Jul 17, 2015 at 02:47:55PM +0300, Dan Carpenter wrote:
On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote:
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote:
By checking for the success
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/Kconfig| 2 --
drivers/staging/Makefile
Create the documentation for SM712. Mention all the supported modes and
how to use.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Documentation/fb/sm712fb.txt | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/fb/sm712fb.txt
diff
Now since sm712fb has moved out of staging update the maintainers list
accordingly.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8133cef..2c77c30 100644
On Fri, Jul 17, 2015 at 01:05:55PM +0300, Dan Carpenter wrote:
On Fri, Jul 17, 2015 at 03:21:28PM +0530, Sudip Mukherjee wrote:
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
I don't think I like these at all. remove_one has always been buggy in
that it removes everything
On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote:
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote:
By checking for the success of kzalloc we were able to remove the goto
label thus making the code more readable.
No... You've just changed error handling
On Fri, Jul 17, 2015 at 12:30:03PM +0300, Dan Carpenter wrote:
I don't think I like these at all. remove_one has always been buggy in
that it removes everything. We should fix it to only remove one instead
of formalizing the currect terrible behavior.
Its already applied.
I thought after the
On Fri, Jul 17, 2015 at 05:33:55PM +0200, Jakub Sitnicki wrote:
On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
Stop using DBG_88E which is a custom macro for printing debugging
messages. Instead start using pr_debug and in the process define
Create the documentation for SM712. Mention all the supported modes and
how to use.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Documentation/fb/sm712fb.txt | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/fb/sm712fb.txt
diff
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/Kconfig |2 -
drivers/staging/Makefile |1 -
drivers/staging/sm7xxfb/Kconfig
Now since sm712fb has moved out of staging update the maintainers list
accordingly.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8133cef..2c77c30 100644
On Fri, Jul 17, 2015 at 09:52:35AM -0700, Greg Kroah-Hartman wrote:
On Fri, Jul 17, 2015 at 06:51:18PM +0530, Sudip Mukherjee wrote:
Now since all cleanups are done and the code is ready to be merged lets
move it out of staging into fbdev location.
This is really hard for the fbdev
Relocate the function dgap_stop() so that in a later patch we can remove
the duplicate codes between dgap_stop() and dgap_remove_one().
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/dgap/dgap.c | 30 +++---
1 file changed, 15 insertions(+), 15
Remove the duplicate code of dgap_remove_one() and dgap_stop().
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/dgap/dgap.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
In a later patch we will remove the duplicate codes. But the code also
needs to execute dgap_remove_driver_sysfiles() if it is being called
from dgap_remove_one() but if being called fron the error path of the
dgap_init_module() then the sysfiles should not be removed.
Signed-off-by: Sudip
On Thu, Jul 16, 2015 at 06:47:40AM -0400, Sreenath Madasu wrote:
Fixed the unused variable warning for the driver.
oops. no. You have done it on top of your previous patch. Please combine
these two patches and send a single patch which will remove the code
related to channel14 and this unused
301 - 400 of 962 matches
Mail list logo
