[PATCH 2/5] staging: exfat: separate and move exFAT-mount core processing.

2020-03-11 Thread Tetsuhiro Kohada
() to exfat_mount.c as exfat_umount(). - Change some functions to static. This also fixes the exfat_bdev_close() leak. :-) Reviewed-by: Takahiro Mori Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 11 +--- drivers/staging/exfat/exfat_core.c | 82

[PATCH 1/5] staging: exfat: conform 'pbr_sector_t' definition to exFAT specification

2020-03-11 Thread Tetsuhiro Kohada
definitions. Reviewed-by: Takahiro Mori Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 139 +++- drivers/staging/exfat/exfat_core.c | 62 ++--- drivers/staging/exfat/exfat_super.c | 14 ++- 3 files changed, 65 insertions(+), 150

[PATCH 4/5] staging: exfat: add boot region verification

2020-03-11 Thread Tetsuhiro Kohada
Add Boot-Regions verification specified in exFAT specification. Reviewed-by: Takahiro Mori Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat_core.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/drivers/staging/exfat/exfat_core.c b/drivers

[PATCH 3/5] staging: exfat: consolidate boot sector analysis

2020-03-11 Thread Tetsuhiro Kohada
led in fs_set_vol_flags(), and tmp_bh leak in exfat_mount(). :-) Reviewed-by: Takahiro Mori Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat_core.c | 106 - 1 file changed, 45 insertions(+), 61 deletions(-) diff --git a/drivers/staging/exfat/exfat_core.c

[PATCH 5/5] staging: exfat: standardize checksum calculation

2020-03-11 Thread Tetsuhiro Kohada
- Remove redundant code of calc_checksum_2byte() and rename to calc_checksum16. - Replace checksum calculation in __load_upcase_table() with calc_checksum32(). Reviewed-by: Takahiro Mori Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 3 ++- drivers/staging/exfat

[PATCH 1/2] staging: exfat: clean up d_entry rebuilding.

2020-03-02 Thread Tetsuhiro Kohada
Clean up d_entry rebuilding in exfat_rename_file() and move_file(). -Replace memcpy of d_entry with structure copy. -Change to use the value already stored in fid. Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat_core.c | 25 ++--- 1 file changed, 10

[PATCH 2/2] staging: exfat: remove redundant if statements

2020-03-02 Thread Tetsuhiro Kohada
If statement does not affect results when updating directory entry in ffsMapCluster(). Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat_super.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat

[PATCH] staging: exfat: remove 'file creation modes'

2020-02-28 Thread Tetsuhiro Kohada
The mode parameter in ffsCreateFile() and create_file() is redundant. Remove it and definition. Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 5 + drivers/staging/exfat/exfat_core.c | 6 +++--- drivers/staging/exfat/exfat_super.c | 7 +++ 3 files changed, 7

[PATCH] staging: exfat: rename buf_cache_t's 'flag' to 'locked'

2020-02-27 Thread Tetsuhiro Kohada
buf_cache_t.flag is used only for lock. Change the variable name from 'flag' to 'locked' and remove unused definitions. Reviewed-by: Takahiro Mori Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_cache.c | 27

[PATCH v3] staging: exfat: remove symlink feature

2020-02-26 Thread Tetsuhiro Kohada
Completely remove symlink codes and definitions. In the previous patch, it was not completely removed. Reviewed-by: Takahiro Mori Signed-off-by: Tetsuhiro Kohada --- Changes in v3: - fixed subject line Changes in v2: - previous patch didn't completely remove it drivers/staging/exfat/exfat.h

[PATCH] staging: exfat: remove symlink feature : Additional patch

2020-02-25 Thread Tetsuhiro Kohada
Completely remove symlink codes and definitions. In the previous patch, it was not completely removed. Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 3 --- drivers/staging/exfat/exfat_core.c | 3 --- drivers/staging/exfat/exfat_super.c | 27

[RFC PATCH] staging: exfat: remove symlink feature.

2020-02-18 Thread Tetsuhiro Kohada
-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat_super.c | 450 1 file changed, 450 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index b398114c2604..c7bc07e91c45 100644 --- a/drivers/staging/exfat

[PATCH v3 1/2] staging: exfat: remove DOSNAMEs.

2020-02-16 Thread Tetsuhiro Kohada
remove 'dos_name','short_name' and related definitions. 'dos_name' and 'short_name' are definitions before VFAT. These are never used in exFAT. Signed-off-by: Tetsuhiro Kohada --- Changes in v3: - Rebase to staging-next. Changes in v2: - Rebase to linux-next-next-20200213. drivers/staging

[PATCH v3 2/2] staging: exfat: dedicate count_entries() to sub-dir counting.

2020-02-16 Thread Tetsuhiro Kohada
count_entries() function is only used to count sub-dirs. Clarify the role and rename to count_dir_entries(). Signed-off-by: Tetsuhiro Kohada --- Changes in v3: - Rebase to staging-next. Changes in v2: - Rebase to linux-next-next-20200213. drivers/staging/exfat/exfat.h | 2 +- drivers

[PATCH v2 2/2] staging: exfat: dedicate count_entries() to sub-dir counting.

2020-02-13 Thread Tetsuhiro Kohada
count_entries() function is only used to count sub-dirs. Clarify the role and rename to count_dir_entries(). Signed-off-by: Tetsuhiro Kohada --- Changes in v2: - Rebase to linux-next-next-20200213. drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_core.c | 8

[PATCH v2 1/2] staging: exfat: remove DOSNAMEs.

2020-02-13 Thread Tetsuhiro Kohada
remove 'dos_name','ShortName' and related definitions. 'dos_name' and 'ShortName' are definitions before VFAT. These are never used in exFAT. Signed-off-by: Tetsuhiro Kohada --- Changes in v2: - Rebase to linux-next-next-20200213. drivers/staging/exfat/exfat.h | 52

[PATCH 2/2] staging: exfat: dedicate count_entries() to sub-dir counting.

2020-02-03 Thread Tetsuhiro Kohada
count_entries() function is only used to count sub-dirs. Clarify the role and rename to count_dir_entries(). Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_core.c | 8 ++-- drivers/staging/exfat/exfat_super.c | 4 ++-- 3 files

[PATCH 1/2] staging: exfat: remove DOSNAMEs.

2020-02-03 Thread Tetsuhiro Kohada
remove 'dos_name','ShortName' and related definitions. 'dos_name' and 'ShortName' are definitions before VFAT. These are never used in exFAT. Signed-off-by: Tetsuhiro Kohada --- drivers/staging/exfat/exfat.h | 52 +++-- drivers/staging/exfat/exfat_core.c | 47

[PATCH v2] staging: exfat: remove 'vol_type' variable.

2020-01-29 Thread Tetsuhiro Kohada
lways set to 'EXFAT'. The variable checks are unnessesary, so remove unused code. Signed-off-by: Tetsuhiro Kohada Reviewed-by: Mori Takahiro Suggested-by: Dan Carpenter --- Changes in v2: - Remove wrong check in exfat_readdir(), as suggested by Dan Carpenter. - Update comment in exfat_readdir().

[PATCH] staging: exfat: remove 'vol_type' variable.

2020-01-29 Thread Tetsuhiro Kohada
lways set to 'EXFAT'. The variable checks are unnessesary, so remove unused code. Signed-off-by: Tetsuhiro Kohada Reviewed-by: Mori Takahiro --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 26 ++--- drivers/staging/exfat/exfat_sup

[PATCH v3] staging: exfat: remove fs_func struct.

2020-01-23 Thread Tetsuhiro Kohada
From: "Tetsuhiro Kohada" Remove 'fs_func struct' and change indirect calls to direct calls. The following issues are described in exfat's TODO. > Create helper function for exfat_set_entry_time () and > exfat_set_entry_type () because it's sort of ugly to be calling the s

[PATCH v2] staging: exfat: remove fs_func struct.

2020-01-23 Thread Tetsuhiro Kohada
From: "Tetsuhiro Kohada" Remove 'fs_func struct' and change indirect calls to direct calls. The following issues are described in exfat's TODO. > Create helper function for exfat_set_entry_time () and > exfat_set_entry_type () because it's sort of ugly to be calling the s