Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-18 Thread Tillmann Heidsieck
On Sun, Oct 18, 2015 at 08:54:57PM +0200, Tillmann Heidsieck wrote: > Hi, [...] > Greg is probably trying to apply this series to the staging-next branch of > his staging tree[0] > so you need to clone that one, or add it as an additional remote[1] to your > clone of the kernel tr

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-18 Thread Tillmann Heidsieck
Hi, On 2015-10-18 08:32, punit vara wrote: On Sat, Oct 17, 2015 at 10:46 AM, Greg KH wrote: On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: Put constant on the right side of a test.Problem found using checkpatch: Warning:Comparisons should place the constant on the right side of

Re: [RESEND PATCH v2] staging/wlan-ng: Fix potential buffer overflow in firmware handling

2015-10-13 Thread Tillmann Heidsieck
On Mon, Oct 12, 2015 at 05:11:08PM +0530, Sudip Mukherjee wrote: > On Mon, Oct 12, 2015 at 01:35:54PM +0200, Tillmann Heidsieck wrote: > > > > I must have rediscovered a problem I already fixed :-( > > Which tree are you using? You should be using staging-testing branch

Re: [RESEND PATCH v2] staging/wlan-ng: Fix potential buffer overflow in firmware handling

2015-10-12 Thread Tillmann Heidsieck
Oh sorry for the noise ... I officially suck and will try to better myself. I must have rediscovered a problem I already fixed :-( Again sorry for the noise Tillmann On Mon, Oct 12, 2015 at 04:32:17PM +0530, Sudip Mukherjee wrote: > On Sat, Oct 10, 2015 at 09:56:16PM +0200, Tillmann Heidsi

[RESEND PATCH v2] staging/wlan-ng: Fix potential buffer overflow in firmware handling

2015-10-10 Thread Tillmann Heidsieck
This patch fixes a potential buffer overflow detected by smatch. pda16 has length 512, while processing an element with index < 512 we are checking for an end marker in the next element. This poses a potential buffer overflow if no end marker is present. Signed-off-by: Tillmann Heidsieck ---

[PATCH v2] staging/wlan-ng: Fix potential buffer overflow in firmware handling

2015-09-30 Thread Tillmann Heidsieck
This patch fixes a potential buffer overflow detected by smatch. pda16 has length 512, while processing an element with index < 512 we are checking for an end marker in the next element. This poses a potential buffer overflow if no end marker is present. Signed-off-by: Tillmann Heidsieck ---

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-09-29 Thread Tillmann Heidsieck
On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > The primary requirement for moving a driver out of staging is that it use > mac80211. No amount of cosmetic fixing will ever make that change for > rtl8712u! As I am pretty sure someone has done something like this before, is there a

[PATCH] staging/wlan-ng: Fix potential buffer overflow in firmware handling

2015-09-29 Thread Tillmann Heidsieck
This patch fixes a potential buffer overflow detected by smatch. pda16 has length 512, while processing an element with index < 512 we are checking for an end marker in the next element. This poses a potential buffer overflow if no end marker is present. --- drivers/staging/wlan-ng/prism2fw.c | 4

[PATCH 3/3] staging: wlan-ng remove unnessecary variable

2015-09-23 Thread Tillmann Heidsieck
The result variable is not set anywhere beyond its initialization, therefore it can be remove. Signed-off-by: Tillmann Heidsieck --- drivers/staging/wlan-ng/prism2fw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging

[PATCH 1/3] staging: wlan-ng fix buffer overflow in firmware handling

2015-09-23 Thread Tillmann Heidsieck
We test for an END marker in the element beyond the current one, this effectively limits the size of the array to be HFA384x_PDA_LEN_MAX/2 - 1 not HFA384x_PDR_END_OF_PDA/2. This patch fixes a possible buffer overflow in case there was no END marker. Signed-off-by: Tillmann Heidsieck --- drivers

[PATCH 0/3] staging/wlan-ng: fix buffer overflow and clean up redundant code

2015-09-23 Thread Tillmann Heidsieck
Hi, smatch found a possible buffer overflow in staging/wlan-ng, the first patch of this series fixes this issue. The remaining two patches clean up redundant code. Cheers Tillmann Tillmann Heidsieck (3): staging: wlan-ng fix buffer overflow in firmware handling staging: wlan-ng remove

[PATCH 2/3] staging: wlan-ng remove redundant conditional

2015-09-23 Thread Tillmann Heidsieck
We exit the above loop either if curroff >= (HFA384x_PDA_LEN_MAX / 2 - 1) or if we found the END marker in the element beyond the current one. The first case is checked for in the preceding if statement, therefore the second if statement is redundant and can be removed. Signed-off-by: Tillm

Re: [PATCH v2] staging: fsl-mc: add DPAA2 overview readme

2015-08-11 Thread Tillmann Heidsieck
Hi Stuart, I am by no means a native speaker, but I have proof-read my fair share of articles and theses, so here are a bunch of suggestions which might or might not help improve you document. On 07.08.2015 03:09, Stuart Yoder wrote: > add README file providing an overview of the DPAA2 architec