[PATCH] Improve code style in drivers/staging/rts5208

2019-06-03 Thread Tobias Nießen
These changes to sd.c and xd.c slightly improve the code style and reduce the overall line length. Signed-off-by: Tobias Nießen Signed-off-by: Sabrina Gaube --- drivers/staging/rts5208/sd.c | 23 +++ drivers/staging/rts5208/xd.c | 8 2 files changed, 15 insertions

staging: rts5208: Two patches to improve code style

2019-06-26 Thread Tobias Nießen
The following two patches improve the code style in the rts5208 staging driver. Many other style issues cannot be resolved without much more extensive refactoring. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.o

[PATCH 1/2] staging: rts5208: Rewrite redundant if statement to improve code style

2019-06-26 Thread Tobias Nießen
cing the average line length. Signed-off-by: Tobias Nießen Signed-off-by: Sabrina Gaube --- drivers/staging/rts5208/sd.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c index b3f8

[PATCH 2/2] staging: rts5208: Simplify boolean expression to improve code style

2019-06-26 Thread Tobias Nießen
elatively long names, using the second form makes the code much more readable and shorter. Signed-off-by: Tobias Nießen Signed-off-by: Sabrina Gaube --- drivers/staging/rts5208/xd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/

Re: [PATCH 1/2] staging: rts5208: Rewrite redundant if statement to improve code style

2019-06-30 Thread Tobias Nießen
Am 26.06.2019 um 16:56 schrieb Dan Carpenter: > Both these patches seem fine. > > On Wed, Jun 26, 2019 at 04:28:56PM +0200, Tobias Nießen wrote: >> This commit uses the fact that >> >> if (a) { >> if (b) { >> ... >>